The base theme stable is not operated correctly

Reviewed and looks good to me.

Can be moved to RTBC

Reviewed the "merge request !23". Working fine. Please check the below images:

Before:

After:

So, my understanding is that this change switches to using core's stable9, rather than the contrib stable theme. I'm fine with this (especially if the contrib stable theme wasn't installing correctly anyway). Essentially using option 2 rather than option 1 from this page https://www.drupal.org/node/3309392 → .

In your testing, did it seem like this switch introduced any issues related to the differences between stable and stable9 that that documentation mentions?

@sim_1 When we install Drupal "10.0.x", the "stable9" theme exists on the "core/themes" path. So there is no need to add an additional contributed project theme "stable".

The contributed project theme "stable" will effectively work the same but it's now dependent on something outside of Drupal core.

I have checked with the Option 2 approach and the site is working fine with that. I have not found any issues from the UI side.

Great, thanks for checking. I think it's most important that we having a working install so hopefully we can just patch any visual issues that come up if we do end up encountering any. Thanks!

Great, thanks for this MR and testing! Merged.

Since we aren't using the contributed theme stable anymore, and are using stable9 from core, I created a MR to remove stable from zurb_foundation's composer.json.
https://git.drupalcode.org/project/zurb-foundation/-/merge_requests/32/d...

I can't reopen the issue, but if a maintainer (@sim_1?) could please review this that would be great. Thanks!

I tested the MR by making a patch file of it and install in locally. But that don't fix the problem for me. I still get the message:

Drupal\Core\Theme\MissingThemeDependencyException: Base theme stable9 has not been installed. in Drupal\Core\Theme\ThemeInitialization->getActiveThemeByName() (line 115 of core/lib/Drupal/Core/Theme/ThemeInitialization.php).

I'm having the same problem as #16, although I have just updated from beta1 to beta2. It makes a little sense, since I'm seeing that stable9 is disabled for my application

drush pml | grep stable
  Core           Stable 9 (stable9)                  Disabled   10.5.1          
  Core           Stable (stable)                     Enabled    2.1.0 

but attempting to enable it returns

Unable to install modules stable9 due to missing modules stable9.