- Issue created by @bandanasharma
- @bandanasharma opened merge request.
- Status changed to Needs review
almost 2 years ago 7:49am 20 April 2023 - Status changed to RTBC
almost 2 years ago 7:59am 20 April 2023 - 🇮🇳India Manoj Raj.R Chennai
Reviewed and looks good to me.
Can be moved to RTBC
- 🇮🇳India shyam_bhatt Gujarat
Reviewed the "merge request !23". Working fine. Please check the below images:
Before:
After:
- 🇺🇸United States sim_1
So, my understanding is that this change switches to using core's stable9, rather than the contrib stable theme. I'm fine with this (especially if the contrib stable theme wasn't installing correctly anyway). Essentially using option 2 rather than option 1 from this page https://www.drupal.org/node/3309392 → .
In your testing, did it seem like this switch introduced any issues related to the differences between stable and stable9 that that documentation mentions?
- 🇮🇳India shyam_bhatt Gujarat
@sim_1 When we install Drupal "10.0.x", the "stable9" theme exists on the "core/themes" path. So there is no need to add an additional contributed project theme "stable".
The contributed project theme "stable" will effectively work the same but it's now dependent on something outside of Drupal core.
I have checked with the Option 2 approach and the site is working fine with that. I have not found any issues from the UI side.
- 🇺🇸United States sim_1
Great, thanks for checking. I think it's most important that we having a working install so hopefully we can just patch any visual issues that come up if we do end up encountering any. Thanks!
-
sim_1 →
committed 35ce2527 on 9.x authored by
bandanasharma →
Issue #3355260 by bandanasharma, Shyam_Bhatt, Manoj Raj.R: The base...
-
sim_1 →
committed 35ce2527 on 9.x authored by
bandanasharma →
- Status changed to Fixed
over 1 year ago 4:57pm 13 June 2023 - Status changed to Fixed
over 1 year ago 1:13pm 16 June 2023