The readme file is still not fully updated as per the standard see this
Readme Standard →
.
The project details are still missing, Table of contents, and other sections are not updated properly.
Add the contents of the file and create the patch. Please review.
bandanasharma → created an issue.
@radhe_shyam I saw your commit and you used the form ID “#contact-message-feedback-form” which makes this fix for this page only. I fixed this generic issue throughout the form.
@nilesh.k The screenshot you attached is from the /admin/content page. However, this issue occurs when you see that the content view in the admin/structure/views/view/content path is not top-aligned due to the top margin.
I created the patch for it. Make text lighter on hover by using opacity. Keep the hover style color white for the banner section text "LOOK HERE". Please review.
bandanasharma → created an issue.
I tried to check the "MR !5" but I can't get the updated code.
Also tried with curl command and got this error
bandana@developmentvm:~/projects/drupal/themes/contrib/potent_allure$ curl https://git.drupalcode.org/project/potent_allure/-/merge_requests/5/diffs | git apply -v
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 73765 0 73765 0 0 75734 0 --:--:-- --:--:-- --:--:-- 75656
error: unrecognized input
Maybe this is because the branch is not updated. In the created MR it is displayed, MR is locked.
I created the patch for it. Please check this. Attached is also the screenshot for the issue fix.
bandanasharma → created an issue.
I applied patch #2 and it works fine. Attached you will find the before and after screenshots.
However, if you click on the icon, you will be redirected to the linked page and will not be able to see the menu items. Because the symbol is called after the 'a' tag. Just showing the icon is not a solution, it should work properly.
I am not switching to RTBC and will wait for the mentor to respond to his opinion.
I created the patch for it. Please review. Attached is also the after-fix screenshot.
bandanasharma → created an issue.
#6 patch applied successfully. Readme looks fine to me.
Moving to RTBC ++
#3 patch is applied successfully but the characters exceed more than 80 for these lines.
3 | Line exceeds 80 characters; contains 412 characters
22 | Line exceeds 80 characters; contains 101 characters
@alok_singh It would be great if you added a proper issuer summary and a step to reproduce the issue. Only attaching a screenshot is not enough for everyone to work on it. Please create the issue properly.
@alok_singh It would be great if you added a proper issuer summary and a step to reproduce the issue. Only attaching a screenshot is not enough for everyone to work on it.
I tried applying patch #3 and it works for me. I didn't get an error message, see the following lines.
bandana@developmentvm:~/projects/drupal/themes/contrib/harmony_haven$ git apply -v harmonyhaven-readme-3381362-3.patch
Checking patch README.md...
Applied patch README.md cleanly.
I have created the patch for the same. Please review.
I have fixed the issue and created a patch for this. Attached after issue fix screenshot. Please review.
bandanasharma → created an issue.
@bunty Oberoi Add the summary for this. Try to create issue as per this https://www.drupal.org/community/contributor-guide/reference-information... →
bandanasharma → created an issue.
#2 patch is applied successfully. The menu looks like a dropdown style but still, it does not look good as a menu. Parent and child items vision is still confusing. Also on the hover menu item is increasing spacing for the right side. Attached recording for more clarity and a screenshot of how it is looking after applying the patch.
The user interface should look more reliable.
bandanasharma → created an issue.
I have fixed the #8 warning issued. Please review.
bandanasharma → made their first commit to this issue’s fork.
This issue exists due to the drupal_get_path() function in the theme.theme file and it is deprecated. I have created a patch for this and attached the screenshot after fixing this issue.
I also faced the installation issue and was able to resolve it. This issue exists due to this line core: 8.x, it is valid for Drupal 8. We don't need this code simply remove this line and it solves the installation issue.
See this for info standard [
https://www.drupal.org/docs/develop/theming-drupal/defining-a-theme-with... →
I don't think the previous patch changes required in the theme. Please review anyone and suggest.
This is not related to the Spaceless tag, please create a separate issue for this.
MR !3 is working fine. After applying the MR this issue is resolved. This issue was coming due to the slider arrow.
Moving to RTBC.
#10 patch applied successfully. After applying the patch I ran the phpcs command again and not the drupal coding standard issue found in the files mentioned.
Moving this to RTBC.
I have created the patch for the same. Attached is the after-fix screenshot. Please review.
#2 Thanks for the cross-review. You verified one level and added an item under "PM kissan "then you can see that.
bandanasharma → created an issue.
#3 patch failed to apply.
#2 patch apply cleanly but it is not complete.
@keshav.k This issue is related to version 10.x.x. So yes it will not work with 8.x-1.x.
@AaronBauman thanks for the work.
I have tested your patch with D10 and the 8.x-4.x-dev of the Redix. It applies cleanly and fixes the issue. Changes reflect in the select.html.twig file.
Moving to RTBC.
bandanasharma → created an issue.
@Gurdev93
Thanks For the Patch
I checked and tested #MR! 5 on Drupal 10.1.0-dev. Fixed the checkbox and text alignment issue on the contact page. I've attached the screenshot for reference. Please review it.
Fix the issue and commit the updated file. Please review.
The content of the MR !1 readme.md file looks fine, but the characters for the following line exceed the standard.
[Installing Drupal Modules](https://www.drupal.org/docs/extending-drupal/installing-drupal-modules).
Need to fix.
bandanasharma → made their first commit to this issue’s fork.
I created MR for the README.md file and updated the file content according to the Drupal readme standard.
@prachi6824 I tried to apply the patch but I get this error message.
This is the error message:
Checking patch README.md...
error: README.md: No such file or directoryThis issue occurs for me in chrome on windows.
@Vinayak.Ambig The same problem also occurs with other input fields i.e. Button color, Button hover, Dark background color, Secondary background color, and Dropdown active background color.
The proposed solution needs to check the existing code and set the condition if the input value is #fff then the text color for that input will change to black.
I also encountered the same issue with the About Us page banner. Fix that and create an MR.
bandanasharma → created an issue.
The Readme.md file has been updated according to the drupal standard.
bandanasharma → made their first commit to this issue’s fork.
bandanasharma → created an issue.