- Issue created by @jay jangid
- @jay-jangid opened merge request.
- Issue was unassigned.
- Status changed to Needs review
almost 3 years ago 9:33am 24 January 2023 - ๐ฎ๐ณIndia jay jangid Jaipur
Created MR , please review.
Thank you.
- First commit to issue fork.
- ๐ฎ๐ณIndia nayana_mvr
Reviewed MR!4. There were some minor corrections which I have done. Otherwise it looks good and it follows the README.md template โ .
- Status changed to RTBC
over 2 years ago 5:05pm 1 June 2023 - ๐ฎ๐ณIndia kavitha@specbee.com
The patch works fine. Moving it to RTBC
- Status changed to Needs review
over 2 years ago 8:26pm 13 July 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
Since the last reviewer does not pay much attention to details, it would be better somebody else reviews the MR.
- ๐ฎ๐ณIndia Nupur Badola
Reviewed MR!4, The patch is not cleanly applied.
git.drupalcode.org_project_tweetext_-_merge_requests_4.diff.txt:59: new blank line at EOF. + warning: 1 line adds whitespace errors. - Status changed to Needs work
about 2 years ago 12:48pm 13 September 2023 - Assigned to Tshewang Gyaltshen
- Issue was unassigned.
- Status changed to Needs review
about 2 years ago 8:52am 14 September 2023 - ๐ง๐นBhutan Tshewang Gyaltshen
Reviewed MR! 4 and updated the content inside the README.md. Its working fine and its follow standard README.md template
- Status changed to Needs work
about 2 years ago 6:43am 15 September 2023 - ๐ฎ๐ณIndia bandanasharma
The readme file is still not fully updated as per the standard see this Readme Standard โ .
The project details are still missing, Table of contents, and other sections are not updated properly. - ๐ฎ๐ณIndia anjali mehta
Anjali Mehta โ made their first commit to this issueโs fork.
- Status changed to Needs review
about 2 years ago 10:41am 15 September 2023 - Status changed to Needs work
about 2 years ago 1:48pm 15 September 2023 - Status changed to Needs review
about 2 years ago 4:30am 18 September 2023 - Status changed to Needs work
about 2 years ago 4:36am 19 September 2023 - ๐ต๐ญPhilippines kenyoOwen
Hi Anjali Mehta
I reviewed and applied your MR!4. As per Apaderno "If the library is included with the module, it is not necessary to list it as requirement. A requirement is something that needs to be downloaded or installed before installing this module.", I think the requirements text should be replaced with
This module requires no modules outside of Drupal core., since it doesn't have any modules need to install before the module. Please see the screenshots attached.For your review.
Thank you. - Status changed to Needs review
about 2 years ago 12:11pm 19 September 2023 - Status changed to Needs work
about 2 years ago 8:22pm 19 September 2023 - Status changed to Needs review
about 2 years ago 11:26am 20 September 2023 - Status changed to RTBC
about 2 years ago 5:18am 28 September 2023 - ๐ต๐ญPhilippines kenyoOwen
Hi Anjali Mehta
I reviewed your MR!4 and confirmed that it follows the README.md template with the added changes as per comment #18. Please see the screenshots attached.
Thank you.