🇮🇳India @Shyam_Bhatt

I think the maintainer can use phpcbf and resolve similar issues. Hence, I am closing this issue.

I think the maintainer can use phpcbf and resolve similar issues. Hence, I am closing this issue.

I think the maintainer can use phpcbf and resolve similar issues. Hence, I am closing this issue.

Here I am adding a solution patch to fix the above issue.

After applying the patch, run the below code:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml "module_path"

It will resolve all the issues from phpcs.

A new sniff added to Coder 8.3.19 →

Shyam_Bhatt → created an issue.

@Utkarsh_33 @xjm I have checked the "MR !5290" and patch #6 🐛 Long words overflow out of modals Needs work both are working fine.

Please check the below images. The above change is working fine in every device layout.

Before:

After:

+ Moving to RTBC

Here I am adding a solution patch to fix the above issue.

After applying the patch, run the below code:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml "module_path"

It will resolve all the issues from phpcs.

Shyam_Bhatt → created an issue.

Here I am adding a solution patch to fix the above issue.

After applying the patch, run the below code:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml "theme_path"

It will resolve all the issues from phpcs.

@sunlix Can you please add more detail to reproduce this issue?

Here I am adding a solution patch to fix the above issue.

After applying the patch, run the below code:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml "module_path"

It will resolve all the issues from phpcs. + Needs review.

Shyam_Bhatt → created an issue.

Here I am adding a solution patch to fix the above issue.

After applying the patch, run the below code:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml "module_path"

It will resolve all the issues from phpcs.

Shyam_Bhatt → created an issue.

Added a new patch, to fix all warnings/errors reported by PHP_CodeSniffer. Please check and review.

+ Needs Review.

@hudri I have checked the "MR !39", documentation updated on the "cheat-sheet.md" file.

Before:

After:

+ Moving to RTBC

Here I am adding a solution patch to fix the above issue.

After applying the patch, run the below code:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml "theme_path"

Result:

FILE                                                                                                                   FIXED  REMAINING
---------------------------------------------------------------------------------------------------------------------------------------
...s/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/hayya_zymphonies_theme/hayya_zymphonies_theme.theme  66     11
...uments/Internal/Projects/d10contrib/web/themes/contrib/hayya_zymphonies_theme/hayya_zymphonies_theme.libraries.yml  1      0
/Users/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/hayya_zymphonies_theme/css/global.css              671    7
/Users/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/hayya_zymphonies_theme/css/media.css               21     1
...l/Projects/d10contrib/web/themes/contrib/hayya_zymphonies_theme/config/install/hayya_zymphonies_theme.settings.yml  1      0
...ontrib/web/themes/contrib/hayya_zymphonies_theme/config/optional/block.block.hayya_zymphonies_theme_page_title.yml  1      0
...nternal/Projects/d10contrib/web/themes/contrib/hayya_zymphonies_theme/includes/fontawesome/css/fontawesome-all.css  878    0
...cuments/Internal/Projects/d10contrib/web/themes/contrib/hayya_zymphonies_theme/includes/smartmenus/sm-core-css.css  109    3
...uments/Internal/Projects/d10contrib/web/themes/contrib/hayya_zymphonies_theme/includes/owl/assets/owl.carousel.css  5      0
---------------------------------------------------------------------------------------------------------------------------------------
A TOTAL OF 1753 ERRORS WERE FIXED IN 9 FILES
---------------------------------------------------------------------------------------------------------------------------------------

Time: 1.05 secs; Memory: 32MB

Needs review.

Shyam_Bhatt → created an issue.

Here I am adding a solution patch to fix the above issue.

After applying the patch, run the below code:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml "module_path"

Result:

--------------------------------------------------------------------------------------------------------------------------------------
FILE                                                                                                                  FIXED  REMAINING
--------------------------------------------------------------------------------------------------------------------------------------
/Users/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/mediteran/css/layout/layout.css                   2      0
/Users/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/mediteran/css/ckeditor/ckeditor.css               54     0
/Users/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/mediteran/css/admin_toolbar/admin.toolbar.css     1      0
/Users/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/mediteran/css/components/tour.theme.css           2      0
/Users/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/mediteran/css/components/form.css                 476    1
/Users/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/mediteran/css/components/jquery.ui/theme.css      578    0
/Users/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/mediteran/css/components/dialog.css               248    0
/Users/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/mediteran/css/theme/gutenberg.css                 3      0
/Users/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/mediteran/css/theme/module_filter.css             71     0
/Users/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/mediteran/css/theme/webform.css                   62     0
/Users/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/mediteran/css/theme/page_manager.css              1      0
/Users/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/mediteran/css/theme/token.css                     5      0
/Users/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/mediteran/css/tour/tour.module.css                2      0
/Users/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/mediteran/mediteran.theme                         17     1
--------------------------------------------------------------------------------------------------------------------------------------
A TOTAL OF 1522 ERRORS WERE FIXED IN 14 FILES
--------------------------------------------------------------------------------------------------------------------------------------

Time: 1.11 secs; Memory: 18MB

Needs review.

Shyam_Bhatt → created an issue.

Adding a patch to fix that issue.

Shyam_Bhatt → created an issue.

@alok_singh I have checked the "MR !13", Working fine. After adding the MR the pagination links visible with new style.

Before:

After:

+ Moving this to RTBC

@Nitin Shrivastava I have checked the "MR !3" working fine. Please check the images below:

Before:

After:

+ Moving to RTBC

@Murz I have checked the patch #5 🐛 No indication that a table has a quite wide width and horisontal scrolling RTBC working fine in desktop as well in responsive layout.

Now if the table has a quite wide width and horizontal scrolling, the shadow effect is visible and indicates some hidden columns present on respective sides. Please check the images below:

Before:

After:

+ Moving to RTBC

@viren18febS I have checked the #2 🐛 Route 'entity.taxonomy_term.revision' does not exist. Needs review patch. Working fine.

Installed and enabled the module, and navigated to any taxonomy revisions page: /taxonomy/{nid}/revisions, after adding the patch there are no error messages visible.

+ Moving to RTBC

@el7cosmos I have checked with Drupal version "10.1.6" same issue on that version as well please merge the working MR to Drupal version "10.1.6" as well.

"MR !5199" looks good the automated testing file was added and working fine.

+ Moving to RTBC

@Wouter Waeytens It's like a similar issue https://www.drupal.org/project/webform/issues/3392954 💬 Deprecated function: preg_split(): Passing null to parameter #2 ($subject) of type string is deprecated Fixed

@el7cosmos As per the steps to reproduce, I have followed the same for Drupal Version: 11.x-dev

Steps to reproduce

1. Create a new standard Drupal site with "11.x-dev"
2. Enable the Media and Media Library modules
3. Visit /admin/content/media
4. Create pieces of media until a paginator appears in the Grid tab (currently, you must create at least 25 pieces of media)
5. Navigate to the Grid tab
6. Notice the Select all media checkbox, Navigate to the second page of results, Notice that the Select all media checkbox does not appear
7. Navigate back to the first page of results, Notice that the Select all media checkbox does not appear

Before patch #20 🐛 "Select all media" checkbox disappears after using paginator in Media Library Grid view RTBC :

After patch #20 🐛 "Select all media" checkbox disappears after using paginator in Media Library Grid view RTBC :

After checking with Drupal Version 11.x-dev
+ Moving to RTBC

I have checked the "MR !311", working fine. The CI pipeline checks are also passed for the same.

Please check the below image:

After MR:

+ Moving to RTBC

@alok_singh I have checked the 'MR !24', and it works fine with the '1.0.x' the latest development branch.

Steps to reproduce this issue:

Go to the "/user/register" link, on the User register page, the 'Create new account' button is much bigger.

Before:

After:

+ Moving to RTBC

@alok_singh I have checked the 'MR !23', and it works fine with the '1.0.x' the latest development branch.

Steps to reproduce this issue:

1. Go to the "/user/register" link, on the User register page, the 'Personal contact form' and checkbox are not aligned.

Before:

After:

+ Moving to RTBC

@alok_singh I have checked the 'MR !25', Working fine with the '1.0.x' the latest development branch.

As the latest development branch is "1.0.x", the "MR !25" is working fine.

After 'MR !25':

+ Moving to RTBC

@alok_singh I have checked the 'MR !25', getting an error while applying it.

Steps to reproduce this issue:

1. Go to the "/user/register" link and try to upload the Image.

I have created a new patch file, to resolve the issue. Please check the below files.

After patch:

+ Needs Review

Hi @sdhruvi5142
If testing is passed, please change status from Needs Review to RTBC.

Thanks

@Jaroslav Červený I have checked the #11 🐛 None of the checkboxes are aligned to their label RTBC patch, updated with the scss file. Working fine.

Moving to +RTBC.

@chetan I have checked patch #7 🐛 None of the checkboxes are aligned to their label RTBC , working fine.
After applying the patch the checkbox and label position are fixed.

Please check the images below.

Before:

After:

Moving to +RTBC

@kksandr I have checked the "MR !313", looks good. After adding the "color-scheme: dark" property to ".gin--dark-mode" class, we can see a stylized scrollbar for dark themes in modern browsers.

For reference please check the "color-scheme" property https://developer.mozilla.org/en-US/docs/Web/CSS/color-scheme

After MR:

Moving to +RTBC.

@andy_w I have checked the #2 🐛 Back to site link for custom blocks RTBC , with Drupal 10.0.1 and gin as admin theme.

Steps to reproduce the issue:

1. After user logged in, go to Structure > Block layout > Custom block library
2. Add/Edit any custom block, Try to click on the "Back to site" link from the top, it will not redirect to the front page of the site.

After the patch, when you Add/Edit any custom block, Try to click on the "Back to site" link from the top, it will redirect to the front page of the site. The patch is working fine.

After patch:

@simonbaese I have checked the "MR !9", the accordion module icon on the CKEditor 5, visible in white with the GIN as admin them and visible in black with the GIN light theme.

Please check the images below:

Before MR:

After MR:

Moving to +RTBC.

A new file "composer.json" was added after testing the "MR !10". For every custom module need to add a composer json file as per the drupal standards https://www.drupal.org/docs/develop/using-composer/add-a-composerjson-file →

After MR:

"MR !10" working fine. Moving this to +RTBC.

@kavbiswa I have checked the "CKEditor Accordion" module with Drupal 10.0.1, Claro as the admin theme, and Olivero as the Frontend theme but I cannot reproduce the issue. By seeing the image on #2 🐛 Accordion Title becomes white in color on hover making it invisible to see Needs review , maybe you are using some other theme from the frontend side.

Please see the attached screenshot, with the above configuration.

@quietone I have checked the #5 📌 Cleanup cspell directives RTBC patch working fine with the 11.x branch.

In ckeditor5 *.js files cspell:words replaced with cspell:ignore and a space after cspell was removed from d7_block.yml file.

Before:

After:

Moving to + RTBC

@Tanuja Bohra check with Drupal 10.1 version.

To fix the above issue, Please check and review the patch.

After patch:

Shyam_Bhatt → created an issue.

@akoe @rmixter I have checked the #12 patch, but the alignment does not look good for the layout builder fields.
Please check the following steps to test it:

1. Install Drupal 9.5.x
2. Enable Layout builder and Layout builder modules
3. Enable Layout builder on the article content type
4. Go to Manage display
5. Select a block and click 'Move'
6. See that the drag-and-drop icon alignment is not look good

Please check the provided patch, I have fixed the layout alignment issue.

After patch:

@sonam_sharma The patch #3 🐛 Unknown "spaceless" tag RTBC was already updated and working fine. There is no need to add a new patch file like #3.

Code updated as per Twig and Drupal coding standards in patch file #3. Moving to +RTBC

@nitesh624 I have checked this issue with the steps provided in the description. Please check the below patch to fix the issue for the stable theme only.

After patch:

@philip_stier I have checked the "MR !66", the "prototype.breakpoints.yml" file added to the theme directory.

Before the MR:

After the MR:

Shyam_Bhatt → made their first commit to this issue’s fork.

@gg24 I have checked the "MR !26" with Drupal 10.0.1 and Theme version "8.x-6.x", getting some error. Please check the images attached.

After "MR !26":

The latest version "9.x", working fine with the Drupal 10.0.1. Instead of adding a patch, we can update the theme version.

Moving to + Needs work.

I have updated the code with the gin variable for the multiple date range fields as per the suggestion.
Please check the patch. I have attached the image after adding the patch.

Update the code in the _table.scss file:

tr .form-items-inline > .form-item {
    margin-top: var(--gin-spacing-l);
    margin-bottom: var(--gin-spacing-l);
  }

Adding a patch to resolve this issue. Please check and verify. Moving to + Needs review.

After patch:

Shyam_Bhatt → created an issue.

@mandclu I have checked the "MR !294" working fine.

After installing the smart date module, I created a field on the Basic content type page and the date range alignment works fine.
Please check the below image for the same.

Moving to + RTBC.

@alok_singh I have checked and reviewed the "MR !7" working fine.
The remove button looks good from the front end side.

Before:

After:

Moving to +RTBC

This issue is related to Drupal 10.
Please check the below steps to reproduce this issue

1. Install Drupal 10.
2. Add "Adminimal" as an administration theme.
3. Now click on "Structure", for the active menu items, the icons of the toolbar aren't displaying.

It's because there is no stable theme existing in the core folder.

So we need to update the background image path instead of "/core/themes/stable/images/core/icons/787878/file.svg" need to update "/core/misc/icons/787878/file.svg".

Please check the below code with the updated path.

/* Main menu icons. */
.adminimal .toolbar-icon-system-admin-content:active:before,
.adminimal .toolbar-icon-system-admin-content.is-active:before {
  background-image: url(/core/misc/icons/787878/file.svg);
}

.adminimal .toolbar-icon-system-admin-structure:active:before,
.adminimal .toolbar-icon-system-admin-structure.is-active:before {
  background-image: url(/core/misc/icons/787878/orgchart.svg);
}

.adminimal .toolbar-icon-system-themes-page:active:before,
.adminimal .toolbar-icon-system-themes-page.is-active:before {
  background-image: url(/core/misc/icons/787878/paintbrush.svg);
}

.adminimal .toolbar-icon-entity-user-collection:active:before,
.adminimal .toolbar-icon-entity-user-collection.is-active:before {
  background-image: url(/core/misc/icons/787878/people.svg);
}

.adminimal .toolbar-icon-system-modules-list:active:before,
.adminimal .toolbar-icon-system-modules-list.is-active:before {
  background-image: url(/core/misc/icons/787878/puzzlepiece.svg);
}

.adminimal .toolbar-icon-system-admin-config:active:before,
.adminimal .toolbar-icon-system-admin-config.is-active:before {
  background-image: url(/core/misc/icons/787878/wrench.svg);
}

.adminimal .toolbar-icon-system-admin-reports:active:before,
.adminimal .toolbar-icon-system-admin-reports.is-active:before {
  background-image: url(/core/misc/icons/787878/barchart.svg);
}

.adminimal .toolbar-icon-help-main:active:before,
.adminimal .toolbar-icon-help-main.is-active:before {
  background-image: url(/core/misc/icons/787878/questionmark-disc.svg);
}

Please check the updated patch. I have added interdiff file to compare #9 patch.

+Needs review

Hello
I checked this issue and followed all the steps mentioned.
The "Add Paragraph" button does not look like other buttons in the Adminimal theme after applying the #4 🐛 Add New Paragraphs is not themed. Needs review patch.

Adding a new patch to fix the issue. Please check and review. + Needs review

Before:

After applying the new patch:

@paucala I have checked the "MR !62" working fine. After applying MR changes the esoteric mark is visible for the required fields. Please check the below image for the same.

Before:

After:

+ Adding patch file same as in the MR for quick fixes.

@sim_1 I have checked and reviewed the "MR !64" working fine. By adding this MR we can able to see the additional configuration regarding "System Messages" and "Tables". Please check the below images for the same.

Before:

After:

+ Adding patch file same as in the MR for quick fixes.

Adding a patch to fix the issue.

After patch:

Needs review.

Shyam_Bhatt → created an issue.

I have checked the "MR !30" is working fine. When we update the module to 4.0.0 the warning related to jquery_ui_autocomplete appears.
After applying "MR !30", the jquery_ui_autocomplete library warning was removed.

I am moving to +RTBC.

For #6 🐛 Toolbar is-active link causes layout shift Needs work All checks pass. Needs review.

I have checked the "MR !11" working fine with the field type "managed_file".

Please check the below steps:

1. Install and enable the Menu Link Attributes module.
2. Go to the configuration page "/admin/config/menu_link_attributes/config".
3. Add the "managed_file" field as per the below code:
   

   icon-attr:
       label: 'icon label'
       type: managed_file
       upload_location: 'public://module-images/menu-link-images/'
       file_validate_extensions: 'gif png'

The "file_validate_extensions" key was added to the patch. so we can restrict the file with different extensions.
Please check the after image.

It will not allow a jpg file.

It will allow only png and gif files.

After creating SUB_THEME, Go to theme path "cd /path/to/SUBTHEME_NAME" and then run npm install.

When running npm run watch the following error message appears which stops the SCSS to CSS compilation.
After updating the @import '~bootstrap/scss/variables-dark'; instead of @import "~bootstrap/scss/_variables-dark.scss"; found some errors as below:

To fix this I have updated the new patch. Please check the patch and the after image for the same.

Needs review.

The "stylesheets-remove" key is deprecated and will be removed in Drupal 9. In most cases, libraries-override should be used. Please check the link: https://www.drupal.org/node/2349827#stylesheets_remove →

I have checked patch #2 🐛 The theme info key stylesheets-remove is removed from Drupal 10 Fixed . Working fine. Please check the below images:

Before:

After:

Updated the @import '~bootstrap/scss/variables-dark'; instead of @import "~bootstrap/scss/_variables-dark.scss"; on the same file for better code practice and creating a new patch.

I have checked the patch and added the after and before screenshots.

Please refer #5 🐛 Radix sub theme npm compilation issue Fixed steps for the testing. Needs review

I have checked the #2 🐛 span_classes missing schema Fixed working fine. Please check the after and before images for the issue.

Configuration schema is a YAML based declarative. The format in Drupal describes the structure of configuration files. It is then applied to Typecast configuration values to ensure the type. Please refer to the link: https://www.drupal.org/docs/drupal-apis/configuration-api/configuration-... →

Verified and tested patch#52 on the Drupal 11.x-dev version and Claro. Patch was applied successfully and looks good to me for DESKTOP and MOBILE.

Testing Steps:

1. Install Drupal 11.x-dev version.
2. Go to Appearance -> Set Claro theme as admin and default theme
3. Add content and click on "PREVIEW"
4. Observe broken content displayed on the preview page, please check the before-preview image.
5. Now apply the patch and clear the cache.
6. Again go to previe

w and verify after the patch proper content displayed on the preview page for desktop and mobile.

Testing Results:
After applying the patch proper content preview is displayed on the desktop view.
After applying the patch proper content preview is displayed on the mobile view.
Working as expected, We can move this ticket to RTBC.

@paucala There are multiple MR's created for the issue. I have check the Latest "MR 53" and it is working fine. To avoid confusion of multiple Mr's I have created patch and the after and before images for the same.

Needs Review.

I have created the patch to fix the above issue.
After patch:

Needs review

Shyam_Bhatt → created an issue.

@sim_1 When we install Drupal "10.0.x", the "stable9" theme exists on the "core/themes" path. So there is no need to add an additional contributed project theme "stable".

The contributed project theme "stable" will effectively work the same but it's now dependent on something outside of Drupal core.

I have checked with the Option 2 approach and the site is working fine with that. I have not found any issues from the UI side.

I have created the patch to fix the above issue. Needs review

Shyam_Bhatt → created an issue.

The overwritten variable background is detected as a bug.
I have created the patch to fix the same.
Please check the patch and image after the fix.

I have created a new patch to address the above issue. I am attaching a screenshot for reference, showing the state before and after applying the patch.

Before:

After:

I have reviewed your patch & Implemented it on my website having Drupal version 10.0.9 And PHP version 8.1
The patch #16 📌 Fix the issues reported by phpcs Needs review is working fine.

Please check the below screenshot:

I have run the vendor /bin/phpcs --standard=DrupalPractice,Drupal --extensions=php,module,info,txt,md,yml web/modules/contrib/fontawesome/ command with the " 8.x-2.x" branch latest code and with PHP 8.2.6.
Showing no errors in the code.

Please check the below image:

@Daniel I have reviewed the changes update on the "MR !24". Please check the below patch for the same. I have checked working fine with the branch "8.x-2.x".

I have checked the "Merge request !24", working fine.

Please follow the below steps to fix the issue.
Create a Font Awesome Icon field
Set the widget to Font Awesome Iconpicker Widget in the form display
A custom field description is not shown to the user in the edit UI for the field.

Before patch:

After patch:

I have checked with the "2.0.x" branch the README.txt was replaced with the README.md
The documentation looks fine. Please check below image:

I have checked the patch #2 📌 Update module description and install message RTBC .
The updated text for the module description and install message looks good. Please check the below images.

Before:

After:

Reviewed the "merge request !23". Working fine. Please check the below images:

Before:

After:

I have checked the patch "gin-toolbar-hover-fix-3362460-2", working fine.
Go to appearance and gin theme settings and select the Navigation to "Legacy, Classic Drupal Toolbar"

Please check the below images:

Before:

After:

@DieterHolvoet I have checked the MR !247 is working fine when we added the checkboxes with the better expose filter.
Please check below image:

Before:

After:

@DieterHolvoet I have added the "Taxonomy Term Reference Tree Widget" module and created Taxonomy Term Reference Tree on content type. The look and feel look good after the patch.

Before:

After:

@volkerk I have installed the "Length Indicator" module and checked the "MR ! 219", we can override our custom CSS with the patch for the Length Indicator. Please check the below images.

@volkerk Working fine. Please check below image:

@volkerk I have checked the "MR !218". Working fine. Please check the below images.

Before:

After: