shyam_bhatt → created an issue.
yes @balintbrews, I will try once as per your latest comment.
@balintbrews The issue is already listed on the StackOverflow.
This is a known issue since (at the time of writing) typescript 5.1.3 is not supported. We can either downgrade your version of typescript to match the required version, or wait until support for typescript 5.1.3 is released by the eslint team
shyam_bhatt → changed the visibility of the branch 3485440-update-ui-for to active.
shyam_bhatt → changed the visibility of the branch 3485440-update-ui-for to hidden.
@jessebaker can we get credit for the issue creation? or a different issue MR is fixing this issue.
The field image does not yet support updating the preview on change. We need to create/update the "data-media-file" attribute with a default value, Also we have to store the new image value in the form state variable. Need to check the "inputBehaviors.tsx" file.
@kristen pol, We can include the below components to the organisms:
- Gallery: An image or media gallery with thumbnails and a lightbox feature for viewing full-sized images.
- Pricing Table: A table that compares different pricing plans with features and call-to-action buttons.
- Modal Dialog: A dialog that overlays the main content and contains text, forms, buttons, and sometimes images.
@kristen pol Thanks for the suggesstion. I have checked the other components as well and it's working fine.
Thanks for sharing
https://www.drupal.org/project/experience_builder/issues/3473666
📌
Create MR with SDDS Sections so XB demo can use MR patch
Needs review
by this, I can now enable the other demo components as well.
After merging the above link MR on the "0.x", we can close this issue.
shyam_bhatt → created an issue.
shyam_bhatt → created an issue.
@wim leers I have tried it after taking the latest pull and with Standard profile setup. And it's working fine, we can close this issue.
I have checked the code after rebasing the latest code. The #13 🐛 Zoom Behaviour Issue: Clicking Plus Button Resets Zoom Level Before Gradually Increasing Needs review scenario is fixed on the MR !257.
shyam_bhatt → created an issue.
shyam_bhatt → changed the visibility of the branch 3470647-zoom-behaviour-issue to hidden.
@jessebaker issues 2) and 5) from the above list, were resolved in the MR257. Please check the image below.
Looks like a duplicate issue. https://www.drupal.org/project/experience_builder/issues/3473761 🐛 After deleting all the components from the canvas, "Add section" button should be visible on the canvas Active
shyam_bhatt → created an issue.
shyam_bhatt → created an issue.
yes, Kristen pol. Thanks for the comment. I added the code for better visibility.
We can add the prop with type integer as per the below code. It will generate a new filter level with no error.
level:
type: integer
title: Level
description: 'Semantic level: 1, 2, 3, 4.'
default: 2
enum:
- 1
- 2
- 3
- 4
examples:
- 2
shyam_bhatt → created an issue.
@omkar-pd I have checked the "MR !218" in my local, and the issue still exists. Clicking the plus button after setting the zoom level to more than 25% causes the zoom level to reset to 25% before gradually increasing and the same with the minus button.
I have added the patch to fix the issue, after adding this patch the viewport will gradually increase and decrease by clicking plus and minus buttons.
I think the maintainer can use phpcbf and resolve similar issues. Hence, I am closing this issue.
I think the maintainer can use phpcbf and resolve similar issues. Hence, I am closing this issue.
I think the maintainer can use phpcbf and resolve similar issues. Hence, I am closing this issue.
Here I am adding a solution patch to fix the above issue.
After applying the patch, run the below code:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml "module_path"
It will resolve all the issues from phpcs.
A new sniff added to Coder 8.3.19 →
Shyam_Bhatt → created an issue.
@Utkarsh_33 @xjm I have checked the "MR !5290" and patch #6 🐛 Long words overflow out of modals Needs work both are working fine.
Please check the below images. The above change is working fine in every device layout.
Before:
After:
+ Moving to RTBC
Here I am adding a solution patch to fix the above issue.
After applying the patch, run the below code:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml "module_path"
It will resolve all the issues from phpcs.
Shyam_Bhatt → created an issue.
Here I am adding a solution patch to fix the above issue.
After applying the patch, run the below code:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml "theme_path"
It will resolve all the issues from phpcs.
@sunlix Can you please add more detail to reproduce this issue?
Here I am adding a solution patch to fix the above issue.
After applying the patch, run the below code:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml "module_path"
It will resolve all the issues from phpcs. + Needs review.
Shyam_Bhatt → created an issue.
Here I am adding a solution patch to fix the above issue.
After applying the patch, run the below code:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml "module_path"
It will resolve all the issues from phpcs.
Shyam_Bhatt → created an issue.
Added a new patch, to fix all warnings/errors reported by PHP_CodeSniffer. Please check and review.
+ Needs Review.
@hudri I have checked the "MR !39", documentation updated on the "cheat-sheet.md" file.
Before:
After:
+ Moving to RTBC
Here I am adding a solution patch to fix the above issue.
After applying the patch, run the below code:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml "theme_path"
Result:
FILE FIXED REMAINING
---------------------------------------------------------------------------------------------------------------------------------------
...s/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/hayya_zymphonies_theme/hayya_zymphonies_theme.theme 66 11
...uments/Internal/Projects/d10contrib/web/themes/contrib/hayya_zymphonies_theme/hayya_zymphonies_theme.libraries.yml 1 0
/Users/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/hayya_zymphonies_theme/css/global.css 671 7
/Users/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/hayya_zymphonies_theme/css/media.css 21 1
...l/Projects/d10contrib/web/themes/contrib/hayya_zymphonies_theme/config/install/hayya_zymphonies_theme.settings.yml 1 0
...ontrib/web/themes/contrib/hayya_zymphonies_theme/config/optional/block.block.hayya_zymphonies_theme_page_title.yml 1 0
...nternal/Projects/d10contrib/web/themes/contrib/hayya_zymphonies_theme/includes/fontawesome/css/fontawesome-all.css 878 0
...cuments/Internal/Projects/d10contrib/web/themes/contrib/hayya_zymphonies_theme/includes/smartmenus/sm-core-css.css 109 3
...uments/Internal/Projects/d10contrib/web/themes/contrib/hayya_zymphonies_theme/includes/owl/assets/owl.carousel.css 5 0
---------------------------------------------------------------------------------------------------------------------------------------
A TOTAL OF 1753 ERRORS WERE FIXED IN 9 FILES
---------------------------------------------------------------------------------------------------------------------------------------
Time: 1.05 secs; Memory: 32MBNeeds review.
Shyam_Bhatt → created an issue.
Here I am adding a solution patch to fix the above issue.
After applying the patch, run the below code:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml "module_path"
Result:
--------------------------------------------------------------------------------------------------------------------------------------
FILE FIXED REMAINING
--------------------------------------------------------------------------------------------------------------------------------------
/Users/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/mediteran/css/layout/layout.css 2 0
/Users/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/mediteran/css/ckeditor/ckeditor.css 54 0
/Users/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/mediteran/css/admin_toolbar/admin.toolbar.css 1 0
/Users/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/mediteran/css/components/tour.theme.css 2 0
/Users/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/mediteran/css/components/form.css 476 1
/Users/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/mediteran/css/components/jquery.ui/theme.css 578 0
/Users/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/mediteran/css/components/dialog.css 248 0
/Users/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/mediteran/css/theme/gutenberg.css 3 0
/Users/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/mediteran/css/theme/module_filter.css 71 0
/Users/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/mediteran/css/theme/webform.css 62 0
/Users/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/mediteran/css/theme/page_manager.css 1 0
/Users/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/mediteran/css/theme/token.css 5 0
/Users/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/mediteran/css/tour/tour.module.css 2 0
/Users/a./Documents/Internal/Projects/d10contrib/web/themes/contrib/mediteran/mediteran.theme 17 1
--------------------------------------------------------------------------------------------------------------------------------------
A TOTAL OF 1522 ERRORS WERE FIXED IN 14 FILES
--------------------------------------------------------------------------------------------------------------------------------------
Time: 1.11 secs; Memory: 18MBNeeds review.
Shyam_Bhatt → created an issue.
Adding a patch to fix that issue.
Shyam_Bhatt → created an issue.
@alok_singh I have checked the "MR !13", Working fine. After adding the MR the pagination links visible with new style.
Before:
After:
+ Moving this to RTBC
@Nitin Shrivastava I have checked the "MR !3" working fine. Please check the images below:
Before:
After:
+ Moving to RTBC
@Murz I have checked the patch #5 🐛 No indication that a table has a quite wide width and horisontal scrolling RTBC working fine in desktop as well in responsive layout.
Now if the table has a quite wide width and horizontal scrolling, the shadow effect is visible and indicates some hidden columns present on respective sides. Please check the images below:
Before:
After:
+ Moving to RTBC
@viren18febS I have checked the #2 🐛 Route 'entity.taxonomy_term.revision' does not exist. Needs review patch. Working fine.
Installed and enabled the module, and navigated to any taxonomy revisions page: /taxonomy/{nid}/revisions, after adding the patch there are no error messages visible.
+ Moving to RTBC
@el7cosmos I have checked with Drupal version "10.1.6" same issue on that version as well please merge the working MR to Drupal version "10.1.6" as well.
"MR !5199" looks good the automated testing file was added and working fine.
+ Moving to RTBC
@Wouter Waeytens It's like a similar issue https://www.drupal.org/project/webform/issues/3392954 💬 Deprecated function: preg_split(): Passing null to parameter #2 ($subject) of type string is deprecated Fixed
@el7cosmos As per the steps to reproduce, I have followed the same for Drupal Version: 11.x-dev
Steps to reproduce
- Create a new standard Drupal site with "11.x-dev"
- Enable the Media and Media Library modules
- Visit /admin/content/media
- Create pieces of media until a paginator appears in the Grid tab (currently, you must create at least 25 pieces of media)
- Navigate to the Grid tab
- Notice the Select all media checkbox, Navigate to the second page of results, Notice that the Select all media checkbox does not appear
- Navigate back to the first page of results, Notice that the Select all media checkbox does not appear
Before patch
#20
🐛
"Select all media" checkbox disappears after using paginator in Media Library Grid view
RTBC
:
After patch
#20
🐛
"Select all media" checkbox disappears after using paginator in Media Library Grid view
RTBC
:
After checking with Drupal Version 11.x-dev
+ Moving to RTBC
I have checked the "MR !311", working fine. The CI pipeline checks are also passed for the same.
Please check the below image:
After MR:
+ Moving to RTBC
@alok_singh I have checked the 'MR !24', and it works fine with the '1.0.x' the latest development branch.
Steps to reproduce this issue:
Go to the "/user/register" link, on the User register page, the 'Create new account' button is much bigger.
Before:
After:
+ Moving to RTBC
@alok_singh I have checked the 'MR !23', and it works fine with the '1.0.x' the latest development branch.
Steps to reproduce this issue:
- Go to the "/user/register" link, on the User register page, the 'Personal contact form' and checkbox are not aligned.
Before:
After:
+ Moving to RTBC
@alok_singh I have checked the 'MR !25', Working fine with the '1.0.x' the latest development branch.
As the latest development branch is "1.0.x", the "MR !25" is working fine.
After 'MR !25':
+ Moving to RTBC
@alok_singh I have checked the 'MR !25', getting an error while applying it.
Steps to reproduce this issue:
- Go to the "/user/register" link and try to upload the Image.
I have created a new patch file, to resolve the issue. Please check the below files.
After patch:
+ Needs Review
Hi @sdhruvi5142
If testing is passed, please change status from Needs Review to RTBC.
Thanks
@Jaroslav Červený I have checked the #11 🐛 None of the checkboxes are aligned to their label RTBC patch, updated with the scss file. Working fine.
Moving to +RTBC.
@chetan I have checked patch
#7
🐛
None of the checkboxes are aligned to their label
RTBC
, working fine.
After applying the patch the checkbox and label position are fixed.
Please check the images below.
Before:
After:
Moving to +RTBC
@kksandr I have checked the "MR !313", looks good. After adding the "color-scheme: dark" property to ".gin--dark-mode" class, we can see a stylized scrollbar for dark themes in modern browsers.
For reference please check the "color-scheme" property https://developer.mozilla.org/en-US/docs/Web/CSS/color-scheme
After MR:
Moving to +RTBC.
@andy_w I have checked the #2 🐛 Back to site link for custom blocks RTBC , with Drupal 10.0.1 and gin as admin theme.
Steps to reproduce the issue:
- After user logged in, go to Structure > Block layout > Custom block library
- Add/Edit any custom block, Try to click on the "Back to site" link from the top, it will not redirect to the front page of the site.
After the patch, when you Add/Edit any custom block, Try to click on the "Back to site" link from the top, it will redirect to the front page of the site. The patch is working fine.
After patch: