- Issue created by @murz
- @murz opened merge request.
- Status changed to Needs review
about 1 year ago 3:07pm 8 November 2023 - 🇦🇲Armenia murz Yerevan, Armenia
I created a merge request with implementing the shadow, please review.
Attaching a static patch file with those changes, to make it possible to use in composer until 🐛 GitLab Merge Requests Unable to Generate Incremental Patch Files Active is resolved.
- Status changed to RTBC
about 1 year ago 5:50am 9 November 2023 - 🇮🇳India shyam_bhatt Gujarat
@Murz I have checked the patch #5 🐛 No indication that a table has a quite wide width and horisontal scrolling RTBC working fine in desktop as well in responsive layout.
Now if the table has a quite wide width and horizontal scrolling, the shadow effect is visible and indicates some hidden columns present on respective sides. Please check the images below:
Before:
After:
+ Moving to RTBC
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 2:27pm 9 November 2023 - 🇦🇲Armenia murz Yerevan, Armenia
Caught a strange issue with tables on other pages that they got a white background on the footer, here are the screenshots:
So, the class "gin-table-scroll-wrapper" has some strange rules:
padding-bottom: 240px; margin-bottom: -240px;
Removing them resolves the issue. Updated MR and attaching a patch.
but we need to check if this will affect other pages, so moving to "Need Review".
- Status changed to RTBC
11 months ago 10:10pm 18 January 2024 - 🇺🇸United States DamienMcKenna NH, USA
This patch helps a lot with it not being clear that tables have a horizontal area to scroll, thank you.
I'm sure there may be other or better ways of improving it, but IMHO this is a good start.
- Status changed to Needs work
9 months ago 10:19pm 20 March 2024 - 🇨🇭Switzerland saschaeggi Zurich
The 240px should not be included here as it will break menus being able to overflow.
- 🇺🇸United States j.young
I tried the patches in both #5 and #9 and they don't seem to have any effect on dark mode. Is that expected?
- Status changed to Closed: duplicate
8 months ago 1:01pm 4 May 2024 - 🇨🇭Switzerland saschaeggi Zurich
This will be fixed with 🐛 Table header overflow issue for multiple user role on permissions page. Fixed
Closing this issue in favor of the other one and moving credits over.