core/once is missing for library gin/edit_form

Created on 14 November 2023, 7 months ago
Updated 7 January 2024, 6 months ago

Problem/Motivation

I am getting the error that once is missing in my compiled javascript with Drupal 10.1.6
I think the dependency core/once is missing here.

https://git.drupalcode.org/project/gin/-/blob/8.x-3.x/gin.libraries.yml?...

Steps to reproduce

Add core/once dependency to `gin/edit_form`

🐛 Bug report
Status

Fixed

Version

3.0

Component

Code

Created by

🇩🇪Germany sunlix Wesel

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @sunlix
  • @sunlix opened merge request.
  • Status changed to Needs review 7 months ago
  • 🇮🇳India Shyam_Bhatt Gujarat

    @sunlix Can you please add more detail to reproduce this issue?

  • 🇩🇪Germany sunlix Wesel

    Hey sure,

    I dived a little bit deeper into it.
    I cant allocate the source of the dependency tree. By any reason edit_form.js is in my depedency tree.
    But I am logged out on my default frontpage. The edit_form.js should not have in.

  • 🇩🇪Germany sunlix Wesel

    I found the issue in our distribution. :-)
    We have a library which depends on the gin/edit_form library.
    Due to that, we load the js.

    But I think the question remains. Should the gin libraries declare its dependencies (correctly/explicity)?
    The edit_form.js depends on the core/once library but do not declare it as a dependency explicity.

  • Status changed to Fixed 6 months ago
  • 🇩🇪Germany sunlix Wesel

    Hey,

    I close this issue, because it is already merged by Sascha. :-) Thanks for that!

  • 🇨🇭Switzerland saschaeggi Zurich

    @dunliz ah thanks forgot to close it!

  • Status changed to Fixed 6 months ago
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024