- Issue created by @omkar-pd
- Assigned to shyam_bhatt
- Merge request !268#3472535 Fixed the scrollbar visibility issue on opening and closing the contextual menu. → (Merged) created by shyam_bhatt
- Issue was unassigned.
- Status changed to Needs review
4 months ago 1:04pm 6 September 2024 - 🇮🇳India omkar-pd
Testest the changes. If we move the cursor away a bit from the menu the menu closes.
- Status changed to Needs work
4 months ago 2:02pm 6 September 2024 - Assigned to shyam_bhatt
- 🇬🇧United Kingdom jessebaker
@omkar-pd I don't think that scrollbar on the right should be there at all! Is the screenshot taken on Windows?
- 🇬🇧United Kingdom jessebaker
Updated the Proposed resolution in the issue summary.
- Issue was unassigned.
- Assigned to bnjmnm
- 🇬🇧United Kingdom jessebaker
@shyam_bhatt You're code change does seem to resolve the issue, but I fear it is just treating a symptom and not addressing the cause.
This issue seems to have been introduced in https://www.drupal.org/project/experience_builder/issues/3454173 📌 Media Library integration (includes introducing a new main content renderer/`_wrapper_format`) Fixed
The addition of
- system/base
in experience_builder.libraries.yml means the /xb page is now loading extra JS libraries. One of which is announce.js. The code in announce.js add a new div to the page at the bottom of the body with a height/width of 1px that sits below the experience builder div and is what is causing the scrollbar.Assigning to @bnjmnm to take a look.
- Assigned to jessebaker
- Status changed to Active
4 months ago 1:12pm 9 September 2024 - 🇬🇧United Kingdom jessebaker
Discussed with @bnjmnm - the announce div is included as part of a longer term plan to improve a11y so it's correct that we are loading it on the page. For now I'm going to just set the body to have overflow: hidden and be done with it.
- 🇬🇧United Kingdom jessebaker
Thanks all. I've merged a fix. I also verified that (at least on MacOS) the fix does not prevent a11y screen readers from working with the announce.js functionality
-
jessebaker →
committed b99d3f02 on 0.x authored by
shyam_bhatt →
Issue #3472535 by shyam_bhatt, jessebaker, omkar-pd: Scrollbar...
-
jessebaker →
committed b99d3f02 on 0.x authored by
shyam_bhatt →
- Issue was unassigned.
- Status changed to Fixed
4 months ago 1:48pm 9 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.