@jsacksick I see this patch is committed but not included in the current release. Will you please create a new release ?
Thanks
@jsacksick I see this patch is committed but not included in the current release. Will you please create a new release ?
Thanks
Solved conflicts.
omkar-pd → made their first commit to this issue’s fork.
omkar-pd → changed the visibility of the branch 3240103-refactored-deferred to hidden.
@shubh511,
No need to create a new PR. There is already a PR created for this.
Check if you can address the given feedback in #17 and #18 and make changes in the existing PR.
https://git.drupalcode.org/project/drupal/-/merge_requests/5792
Addressed Feedback.
Will work on the feedback.
All the threads are resolved.
Refactored the class function. Please review.
@ahsannazir, The target branch should be 11.x.
Resolved Conflicts.
Still, many eslint errors needs to be fixed.
Made all the changes. Please Review.
Addressed feedback.
omkar-pd → made their first commit to this issue’s fork.
Refactored jQuery toggle to JS. Tests are passed. Moving this to Needs Review.
omkar-pd → made their first commit to this issue’s fork.
Addressed feedback.
Needs Review.
omkar-pd → made their first commit to this issue’s fork.
Made remaining changes and Fixed tests for MR 4337.
omkar-pd → made their first commit to this issue’s fork.
Not sure why the Compilation check is failing at yarn run -s check:ckeditor5 Can't see any error just ERROR: Job failed: command terminated with exit code 1
omkar-pd → made their first commit to this issue’s fork.
Changes done.
Yes, the toolbar functionality working fine. The rule is added and tests are green. Moving this to Needs review.
@saschaeggi, I've included the vertical-tabs library in media-form. Please review.
omkar-pd → made their first commit to this issue’s fork.
omkar-pd → created an issue.
Fixed tests. Moving this to Needs Review.
Still, in ajax.js there is one$.Deferred().reject() that needs to be replaced. But looking for review before moving forward.
Replaced deferred in toolbar.js with promise. Some tests are failing I'll try to fix those.
omkar-pd → made their first commit to this issue’s fork.
All tests are passed for MR 5777.
Changing this to Needs Review.
Updates:-
Made some changes in fetch calls.
- Used
application/x-www-form-urlencodedinstead ofapplication/json - Used
new URLSearchParams()to pass data in body. - Tested editor.js and contextual.js files functionality and it's working fine.
- Number of test failures is reduced, And trying to fix other failures as well.
@sijumpk, Target branch should be 8.x-4.x as it D10 support branch.
Yes, Because there are still some Ajax calls remaining to replace.
Replaced some Ajax calls with fetch. Still, there are some calls left to replace. Waiting for review on these changes, Setting this to Needs Work.
omkar-pd → made their first commit to this issue’s fork.
Yes, I was not able to change the target branch and also was not able to create a new branch. so added a patch.
MR created from #12.
omkar-pd → made their first commit to this issue’s fork.
Attaching a patch as well.
Removed uses of serialize(). The target branch needs to be changed from 9.3.x to 11.x.
omkar-pd → made their first commit to this issue’s fork.
Created MR from the patch #6.
omkar-pd → made their first commit to this issue’s fork.
omkar-pd → created an issue.
Made changes as per the Proposed resolution.
omkar-pd → made their first commit to this issue’s fork.
The patch will solve the issue. Replaced jquery/once with core/once.
omkar-pd → created an issue.
@kenyoOwen please apply this patch https://git.drupalcode.org/project/audio_embed_field/-/merge_requests/8/... and check.
MR looks good.
@sarwan the core_version_requirment key will not work in version < 8.7
Check here:-
https://www.drupal.org/node/3070687 →
On hover showed a list of more categories. I think styling can be improved or we can show categories on click. Ready for review.
omkar-pd → made their first commit to this issue’s fork.
It's changing due to the inspector. If we dock the inspector to the right or in a new window we can see it's 512 x 512. Check screenshots.
We should remove the core key and add core_version_requirement: ^8.9 || ^9 || ^10
Removed default search (x) icon. PR still needs a rebase.
omkar-pd → made their first commit to this issue’s fork.
I can reproduce this issue, We should decide if we want to remove the route or Add the form, and if we want to add the form then what type of settings we should provide?
Omkar Deshpande - Session/Speaker Volunteer.
I applied the patch and it worked for me. Attaching a screenshot for reference.
Moved Config page from System Menu to Content Authoring.
omkar-pd → made their first commit to this issue’s fork.
Made all the changes. Changing status back to Needs review.
@cosmicdreams
I have addressed the given feedback. Please have a look.
Used localStorage to remember the last scroll position and scroll back to the same position refresh.
Please review and suggest if we can use a better approach.
omkar-pd → made their first commit to this issue’s fork.
Yes @geek-merlin, it fixes the issue for me. Raised an MR.
After some RnD. I found out that hook_field_widget_form_alter is removed in Drupal 10. Check out the below link for change records.
Installed the module on Drupal 10. Was able to reproduce the issue. It seems that value $element['#datetimehideseconds']['hide'] Is getting Null even if the hide seconds field is checked in the widget. So the code inside if (!empty($element['#datetimehideseconds']['hide'])) is not excuted.