Account created on 13 August 2021, over 3 years ago
  • Engineer - Full Stack at QED42 
#

Merge Requests

More

Recent comments

🇮🇳India omkar-pd

omkar-pd made their first commit to this issue’s fork.

🇮🇳India omkar-pd

It looks like the "Create new revision" checkbox value (revision = true) isn't returned in the entity_form_fields data because of the way we filter form values here:

return Query::parse(http_build_query(array_intersect_key($values, $entity->toArray())));

However, revision is not part of $entity->toArray(), so it gets stripped out by array_intersect_key(), even though it exists in $values

🇮🇳India omkar-pd

Tested this and it's working as expected. 🎉

🇮🇳India omkar-pd

Yes, @hooroomoo, I'm using chrome.

Let me test this in Firefox.

🇮🇳India omkar-pd

Currently, it scrolls while dragging in the layers menu.

🇮🇳India omkar-pd

Code Looks good. But need approval from code owner. so keeping this in Needs Review.

🇮🇳India omkar-pd

+1 #13 🐛 The context menu is not accessible for JS components from library Active

I tried debugging this a couple of days ago and came to the same conclusion. I attempted to reattach the event listeners, but it didn’t work. I also tried replacing the cloned element with the original one, but the item in the event is different from the original element—it is the rendered output of that component.

🇮🇳India omkar-pd

Also, the preview is not working for existing components (eg- Heading, Hero) once dragged to Canvas.

🇮🇳India omkar-pd

This will not solve the issue for slots (one col, two col). Changes should be made in SlotOverlay.tsx to also solve that issue.

🇮🇳India omkar-pd

I have rebased with the latest changes. All tests are passing except for one, which remains unaffected by the code changes.img[src*="/experience_builder/components/image/600x400.png"]' was found in iframe '[data-xb-preview="lg"][data-test-xb-content-initialized="true"][data-xb-swap-active="true"]': expected **false** to equal **true**

🇮🇳India omkar-pd

I think the work on default_markup for code components is still pending.

default_markup: "@todo Make something 🆒 in https://www.drupal.org/project/experience_builder/issues/3498889" - Which appears to be fixed issue.

🇮🇳India omkar-pd

The component preview is now loading, but it appears empty. Debugging the issue.

🇮🇳India omkar-pd

Raised PR with Proposed resolution.

🇮🇳India omkar-pd

omkar-pd made their first commit to this issue’s fork.

🇮🇳India omkar-pd

I've implemented the changes as mentioned in #5. Keeping this in "Needs Review" since tests are still required, allowing someone else to pick it up and continue

🇮🇳India omkar-pd

In AutoSaveManager.php there is a @todo Update label from incoming entity data once it exists for label.
https://git.drupalcode.org/project/experience_builder/-/blob/0.x/src/Aut...

Is it the right change?

🇮🇳India omkar-pd

omkar-pd made their first commit to this issue’s fork.

🇮🇳India omkar-pd

omkar-pd made their first commit to this issue’s fork.

🇮🇳India omkar-pd

Thank you for the fix @atul_ghate and @a.dmitriiev

🇮🇳India omkar-pd

omkar-pd made their first commit to this issue’s fork.

🇮🇳India omkar-pd

Started implementing the logApi service.
Currently, I’ve set up basic logging functionality with a hardcoded level: 'error'. However, I need further guidance on determining the appropriate error level dynamically.

🇮🇳India omkar-pd

omkar-pd made their first commit to this issue’s fork.

🇮🇳India omkar-pd

I was able to reproduce with the given steps.

Warning: Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()?

Check the render method of `SlotClone`.
    at Panel (http://localhost:5173/src/components/Panel.tsx:22:11)
    at 
🇮🇳India omkar-pd

omkar-pd made their first commit to this issue’s fork.

🇮🇳India omkar-pd

@chrisfromredfin,
I just found that this issue reintroduces Remove Modals after They're Closed 🐛 Remove Modals after They're Closed Fixed .

🇮🇳India omkar-pd

omkar-pd made their first commit to this issue’s fork.

Production build 0.71.5 2024