- Issue created by @larowlan
- First commit to issue fork.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Lots of failing tests though: https://git.drupalcode.org/issue/experience_builder-3517029/-/pipelines/... — could you take a look at those? 🙏
- 🇺🇸United States bnjmnm Ann Arbor, MI
Everything in the MR is adding
xb-to the beginning of attributes, so there are attributes that begin withxb-data-. That is not what is being requested. Reiterating the issue summary might cause additional confusion, so just review the summary again and follow it as stated. - First commit to issue fork.
- 🇮🇳India koustav_mondal Kolkata
Hello @bnjmnm, I have made the changes. Please review the changes.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
This is on the right track now! But it's also modifying SDC-owned things, and that needs to be reverted — see MR review :)
- 🇮🇳India koustav_mondal Kolkata
Hello @wim leers, I have reverted SDC-owned things. Please have a look and let me know if we require any other changes.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Thanks! :)
In the mean time, 📌 Get Options as buttons in Page Data form working Active landed, this now needs a rebase — that issue added a bunch of
@todos pointing to this issue!
