Hello @bbrala, Thank you for your guidance. I have fixed the issue that you mentioned over here. Please let me know if we require any other changes.
Hello @bbrala, Now PHPStan and PHPCS errors are fixed.
Sorry for the typos. Make those corrected. Please review now.
Please review and let me know if we require any other changes.
Working on it.
koustav_mondal → made their first commit to this issue’s fork.
Hello @tr, I just removed /8 at the end, but the link is still redirecting to a broken page. I found that the link is only available with Drupal 7.x. So I added /7 at the end. But I don't know how to host the image. I'll appreciate it if anyone comes to fix that portion. Thanks in advance.
Working on it.
Hello @quietone, I have the required changes. Please have a look and let me know if we require any other changes.
Hello @wim leers, I have reverted SDC-owned things. Please have a look and let me know if we require any other changes.
Hello @bramdriesen, I have made the changes, please look into.
Working on it.
Hello @bnjmnm, I have made the changes. Please review the changes.
koustav_mondal → made their first commit to this issue’s fork.
Working on this.
Installed the module and tested. Looks good. Attaching screenshot for reference.
Changes looks good to me. Protected const is also declared. Moving to RTBC.
Hello @avpaderno, yes it'll be better to create a separate issue for adding a README.md file. Now this MR looks good.
Changes are looks good to me.Hence moving to RTBC.
Hello @wouters_f, if the changes are good then please fix the issue.
Hello @mradcliffe, as the issue is created to fix PHP 8.4 deprecations, I've removed the Gitlab CI template. If needed then it can be added later.
Made the changes and added .gitlab-ci.yml file to test the pipeline, Please review.
Hello @adamps, I've made the changes according to #14 . Please have a look and tell me if any other changes are required.
Hello @adwivedi008 there was some pieline issue in your code, I fixed it and also the issue was assigned to me already.
koustav_mondal → changed the visibility of the branch 3350992-display-names-containing to hidden.
@quietone I have made the changes in core/lib. Please have a look.
Thank you @quietone, I'll move the changes in the new issue.
Working on it.
Hello @kalash-j, I think this specific issue was created to fix only \Drupal calls in classes.
Installed the module and checked in local. After editing the Dashboard layout it is now redirected back to the Dashboard page( admin/dashboard) , not in structure(admin/structure/dashboard). Attaching a video for referance. LGTM+
@quietone I didn't write any script, used the search function of an IDE. Do I revert back the changes in test? Or you can create an issue for not non-test changes.
Replaced http://example.com. Please have a look.
Working on it.
Please Review changes in new MR.
koustav_mondal → made their first commit to this issue’s fork.
Added 2nd parameter to parseAddress().
@adamps Added comment, please chcek.
@adamps Made the changes. Previous MR was forked form 1.4.0 and LegacyMailer class was not present in that specific version. So, pull the latest 2.x-dev and raised new MR-139 and made the changes in that MR. Kindly review it.
@adamps I have made the cahnges. Please review.
@ufku The issue is fixed but you forgot to provide credit. Being new to Drupal community, credit motivates to contribute more. Thank you.
@adamps I made the changes according to #5 . Please have a look.
@rckstr_rohan As the MR is already given, the issue should be in Needs Review State. All the changes looks good to me. Moving it to RTBC.
Working on it.
Working on it.
Working on it.
Made the changes. Please review it.
Checked in my local setup before and after changes. Attaching screenshots. LGTM+
@sorina.hriban I am also not able to reproduce the error. Could you elaborate the steps to reproduce the error?
Sorry for the confusion. Chceked again. Attaching videos for this. LGTB+
Installed the module. I tried to place the Admin Feedback Block but got some Js error. Moving it to Needs Work.
Installed the specific version and tested the module before and after the changes. Looks good to me. Moving it to RTBC. Here I'm attaching two videos for the reference.
@darvanen I also tried to reproduce the error. Got the following error but not able to reproduce the error that you mentioned.
------ -----------------------------------------------------------------------------------------------------
Line tests/src/Kernel/TokenFilterKernelTest.php
------ -----------------------------------------------------------------------------------------------------
:47 \Drupal calls should be avoided in classes, use dependency injection instead
:identification_card: globalDrupalDependencyInjection.useDependencyInjection
:55 Call to an undefined method Drupal\Tests\token_filter\Kernel\TokenFilterKernelTest::assertEquals().
:identification_card: method.notFound
Working on it.
Working on it.
@liam morland Now the Yellow triangle is not coming, please have look if any other changes is required.
@anybody if the MR looks good then please merge and close the issue.
Make the changes and provided the MR.
Made all changes. Please review it.
Working on it.
@liam morland I have made the change according to comment #7 .
Review the MR.
@liam morland I have made the changes. Please Review it.
Working on it.
koustav_mondal → changed the visibility of the branch 5.0.x to hidden.
koustav_mondal → changed the visibility of the branch 3498310-fix-php-8.4 to hidden.
@solideogloria Made the changes , please review it.
Working on it.
@bramdriesen I have raised MR. Please review it.
working on it.
Working on it.
@nikolay shapovalov I have Fixed all the PHPStan issues except these two.
------ --------------------------------------------------------------------------------------------------------------------
Line src/Form/ContactFormCloneForm.php
------ --------------------------------------------------------------------------------------------------------------------
20 Class Drupal\contact_storage\Form\ContactFormCloneForm extends @internal class Drupal\contact\ContactFormEditForm.
------ --------------------------------------------------------------------------------------------------------------------
------ -------------------------------------------------------------------------------------------
Line src/Plugin/Validation/Constraint/ConstactStorageMaximumSubmissionsConstraintValidator.php
------ -------------------------------------------------------------------------------------------
23 Access to an undefined property Symfony\Component\Validator\Constraint::$limitReached.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
------ -------------------------------------------------------------------------------------------
I am not able to fix the second issue and the first issue is not supposed to be fixed
🐛
Upgrade Status reports warning for ContactFormCloneForm
Closed: won't fix