🇮🇳India @koustav_mondal

Kolkata
Account created on 6 December 2024, 4 months ago
#

Recent comments

🇮🇳India koustav_mondal Kolkata

Installed the module and tested. Looks good. Attaching screenshot for reference.

🇮🇳India koustav_mondal Kolkata

Changes looks good to me. Protected const is also declared. Moving to RTBC.

🇮🇳India koustav_mondal Kolkata

Hello @avpaderno, yes it'll be better to create a separate issue for adding a README.md file. Now this MR looks good.

🇮🇳India koustav_mondal Kolkata

Changes are looks good to me.Hence moving to RTBC.

🇮🇳India koustav_mondal Kolkata

Hello @wouters_f, if the changes are good then please fix the issue.

🇮🇳India koustav_mondal Kolkata

Hello @mradcliffe, as the issue is created to fix PHP 8.4 deprecations, I've removed the Gitlab CI template. If needed then it can be added later.

🇮🇳India koustav_mondal Kolkata

Made the changes and added .gitlab-ci.yml file to test the pipeline, Please review.

🇮🇳India koustav_mondal Kolkata

Hello @adamps, I've made the changes according to #14 . Please have a look and tell me if any other changes are required.

🇮🇳India koustav_mondal Kolkata

Hello @adwivedi008 there was some pieline issue in your code, I fixed it and also the issue was assigned to me already.

🇮🇳India koustav_mondal Kolkata

koustav_mondal changed the visibility of the branch 3350992-display-names-containing to hidden.

🇮🇳India koustav_mondal Kolkata

@quietone I have made the changes in core/lib. Please have a look.

🇮🇳India koustav_mondal Kolkata

Thank you @quietone, I'll move the changes in the new issue.

🇮🇳India koustav_mondal Kolkata

Hello @kalash-j, I think this specific issue was created to fix only \Drupal calls in classes.

🇮🇳India koustav_mondal Kolkata

Installed the module and checked in local. After editing the Dashboard layout it is now redirected back to the Dashboard page( admin/dashboard) , not in structure(admin/structure/dashboard). Attaching a video for referance. LGTM+

🇮🇳India koustav_mondal Kolkata

@quietone I didn't write any script, used the search function of an IDE. Do I revert back the changes in test? Or you can create an issue for not non-test changes.

🇮🇳India koustav_mondal Kolkata

Added 2nd parameter to parseAddress().

🇮🇳India koustav_mondal Kolkata

@adamps Made the changes. Previous MR was forked form 1.4.0 and LegacyMailer class was not present in that specific version. So, pull the latest 2.x-dev and raised new MR-139 and made the changes in that MR. Kindly review it.

🇮🇳India koustav_mondal Kolkata

@ufku The issue is fixed but you forgot to provide credit. Being new to Drupal community, credit motivates to contribute more. Thank you.

🇮🇳India koustav_mondal Kolkata

@adamps I made the changes according to #5 . Please have a look.

🇮🇳India koustav_mondal Kolkata

@rckstr_rohan As the MR is already given, the issue should be in Needs Review State. All the changes looks good to me. Moving it to RTBC.

🇮🇳India koustav_mondal Kolkata

Checked in my local setup before and after changes. Attaching screenshots. LGTM+

🇮🇳India koustav_mondal Kolkata

@sorina.hriban I am also not able to reproduce the error. Could you elaborate the steps to reproduce the error?

🇮🇳India koustav_mondal Kolkata

Sorry for the confusion. Chceked again. Attaching videos for this. LGTB+

🇮🇳India koustav_mondal Kolkata

Installed the module. I tried to place the Admin Feedback Block but got some Js error. Moving it to Needs Work.

🇮🇳India koustav_mondal Kolkata

Installed the specific version and tested the module before and after the changes. Looks good to me. Moving it to RTBC. Here I'm attaching two videos for the reference.

🇮🇳India koustav_mondal Kolkata

@darvanen I also tried to reproduce the error. Got the following error but not able to reproduce the error that you mentioned.

 ------ -----------------------------------------------------------------------------------------------------
  Line   tests/src/Kernel/TokenFilterKernelTest.php
 ------ -----------------------------------------------------------------------------------------------------
  :47    \Drupal calls should be avoided in classes, use dependency injection instead
         :identification_card:  globalDrupalDependencyInjection.useDependencyInjection
  :55    Call to an undefined method Drupal\Tests\token_filter\Kernel\TokenFilterKernelTest::assertEquals().
         :identification_card:  method.notFound
🇮🇳India koustav_mondal Kolkata

@liam morland Now the Yellow triangle is not coming, please have look if any other changes is required.

🇮🇳India koustav_mondal Kolkata

@anybody if the MR looks good then please merge and close the issue.

🇮🇳India koustav_mondal Kolkata

Made all changes. Please review it.

🇮🇳India koustav_mondal Kolkata

@liam morland I have made the change according to comment #7 .

🇮🇳India koustav_mondal Kolkata

@liam morland I have made the changes. Please Review it.

🇮🇳India koustav_mondal Kolkata

koustav_mondal changed the visibility of the branch 5.0.x to hidden.

🇮🇳India koustav_mondal Kolkata

koustav_mondal changed the visibility of the branch 3498310-fix-php-8.4 to hidden.

🇮🇳India koustav_mondal Kolkata

@solideogloria Made the changes , please review it.

🇮🇳India koustav_mondal Kolkata

@bramdriesen I have raised MR. Please review it.

🇮🇳India koustav_mondal Kolkata

@nikolay shapovalov I have Fixed all the PHPStan issues except these two.

------ -------------------------------------------------------------------------------------------------------------------- 
  Line   src/Form/ContactFormCloneForm.php                                                                                   
 ------ -------------------------------------------------------------------------------------------------------------------- 
  20     Class Drupal\contact_storage\Form\ContactFormCloneForm extends @internal class Drupal\contact\ContactFormEditForm.  
 ------ -------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------- 
  Line   src/Plugin/Validation/Constraint/ConstactStorageMaximumSubmissionsConstraintValidator.php  
 ------ ------------------------------------------------------------------------------------------- 
  23     Access to an undefined property Symfony\Component\Validator\Constraint::$limitReached.     
         💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property        
 ------ -------------------------------------------------------------------------------------------

I am not able to fix the second issue and the first issue is not supposed to be fixed
🐛 Upgrade Status reports warning for ContactFormCloneForm Closed: won't fix

🇮🇳India koustav_mondal Kolkata

Working on it.

🇮🇳India koustav_mondal Kolkata

@dieterholvoet I replaced all final methods and self/static keyword, pipeline for PHPStan, eslint and phpcs is green now.

🇮🇳India koustav_mondal Kolkata

@DieterHolvoet I have made the changes that are told by you. Have a look.

🇮🇳India koustav_mondal Kolkata

Fixed the issues reported by PHP_CodeSniffer. Pipeline is green now.

🇮🇳India koustav_mondal Kolkata

koustav_mondal made their first commit to this issue’s fork.

🇮🇳India koustav_mondal Kolkata

@anybody I have updated the Readme.md file.

Production build 0.71.5 2024