\Drupal calls should be avoided in classes, use dependency injection instead

Created on 7 June 2023, almost 2 years ago

FILE: D:\xampp\htdocs\my_site_name_dir\web\modules\contrib\ckeditor\tests\modules\src\Form\AjaxCssForm.php
----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------
110 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------------------

📌 Task
Status

Active

Version

1.0

Component

Code

Created by

🇮🇳India arti_parmar

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @arti_parmar
  • Issue was unassigned.
  • Status changed to Needs review almost 2 years ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7
    last update almost 2 years ago
    37 pass, 2 fail
  • 🇮🇳India arti_parmar

    Kindly review patch.

  • The last submitted patch, 2: 3365251-2.patch, failed testing. View results
    - codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • Status changed to Needs work almost 2 years ago
  • 🇮🇳India arpitk Indore

    Hi I reviewed the patch it applies cleanly no more error regarding \Drupal calls are reported. However 2 test cases are failing those need to be fixed.

    Thanks!

  • First commit to issue fork.
  • Assigned to koustav_mondal
  • 🇮🇳India koustav_mondal Kolkata

    Working on it.

  • Issue was unassigned.
  • 🇮🇳India kalash-j jaipur

    Hey @koustav_mondal i have reviewed your MR!19 , it does eleminate the error of dependency injection, but there still many PHPCS errors are present.

    ghostman-zibbi@Zibbi:~/Desktop/test site/web/modules/custom/ckeditor-3365251 (3365251--drupal-calls)$ lando phpcs .
    
    FILE: /app/web/modules/custom/ckeditor-3365251/src/Plugin/Editor/CKEditor.php
    --------------------------------------------------------------------------------------------------------
    FOUND 7 ERRORS AFFECTING 6 LINES
    --------------------------------------------------------------------------------------------------------
     109 | ERROR | [x] Parameter $file_url_generator has null default value, but is not marked as nullable.
     109 | ERROR | [x] Parameter $module_list has null default value, but is not marked as nullable.
     322 | ERROR | [ ] Public method name "CKEditor::getJSSettings" is not in lowerCamel format
     450 | ERROR | [ ] Parameter tags must be defined first in a doc comment
     456 | ERROR | [ ] Public method name "CKEditor::buildToolbarJSSetting" is not in lowerCamel format
     474 | ERROR | [ ] Parameter tags must be defined first in a doc comment
     480 | ERROR | [ ] Public method name "CKEditor::buildContentsCssJSSetting" is not in lowerCamel format
    --------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/src/Plugin/CKEditorPlugin/StylesCombo.php
    ----------------------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    ----------------------------------------------------------------------------------------
      96 | ERROR | Doc comment short description must start with a capital letter
     118 | ERROR | Parameter tags must be defined first in a doc comment
    ----------------------------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/src/Plugin/CKEditorPlugin/DrupalImage.php
    ----------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ----------------------------------------------------------------------------------------
     74 | ERROR | Doc comment short description must start with a capital letter
    ----------------------------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/src/Plugin/CKEditorPlugin/Internal.php
    ---------------------------------------------------------------------------------------------------
    FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES
    ---------------------------------------------------------------------------------------------------
     344 | ERROR   | Parameter tags must be defined first in a doc comment
     369 | WARNING | Line exceeds 80 characters; contains 81 characters
     399 | ERROR   | Parameter tags must be defined first in a doc comment
     409 | ERROR   | Protected method name "Internal::generateACFSettings" is not in lowerCamel format
    ---------------------------------------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/src/CKEditorPluginContextualInterface.php
    ----------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ----------------------------------------------------------------------------------------
     38 | ERROR | Description for the @return value is missing
    ----------------------------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/src/CKEditorPluginInterface.php
    ----------------------------------------------------------------------------------------
    FOUND 3 ERRORS AFFECTING 3 LINES
    ----------------------------------------------------------------------------------------
     39 | ERROR | [ ] Description for the @return value is missing
     74 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment
     88 | ERROR | [x] Doc comment long description must end with a full stop
    ----------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ----------------------------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/src/Annotation/CKEditorPlugin.php
    ----------------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    ----------------------------------------------------------------------------------
     10 | ERROR | [x] Doc comment long description must end with a full stop
     40 | ERROR | [ ] The @var tag must be the first tag in a member variable comment
    ----------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ----------------------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/ckeditor.module
    ---------------------------------------------------------------------------------------------------------------------------------------
    FOUND 3 ERRORS AFFECTING 3 LINES
    ---------------------------------------------------------------------------------------------------------------------------------------
     27 | ERROR | The array declaration extends to column 730 (the limit is 120). The array content should be split up over multiple lines
     31 | ERROR | The array declaration extends to column 588 (the limit is 120). The array content should be split up over multiple lines
     41 | ERROR | The array declaration extends to column 413 (the limit is 120). The array content should be split up over multiple lines
    ---------------------------------------------------------------------------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/vendor/plugins/dialog/styles/dialog.css
    --------------------------------------------------------------------------------------
    FOUND 20 ERRORS AFFECTING 10 LINES
    --------------------------------------------------------------------------------------
      2 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
      2 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
      6 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
      6 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
      7 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
      7 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
      8 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
      8 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
      9 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
      9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
     10 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
     10 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
     11 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
     11 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
     12 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
     12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
     13 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
     13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
     17 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
     17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
    --------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 20 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/vendor/LICENSE.md
    ----------------------------------------------------------------------
    FOUND 0 ERRORS AND 21 WARNINGS AFFECTING 21 LINES
    ----------------------------------------------------------------------
       38 | WARNING | Line exceeds 80 characters; contains 88 characters
       40 | WARNING | Line exceeds 80 characters; contains 109 characters
       42 | WARNING | Line exceeds 80 characters; contains 111 characters
       43 | WARNING | Line exceeds 80 characters; contains 88 characters
       44 | WARNING | Line exceeds 80 characters; contains 129 characters
       46 | WARNING | Line exceeds 80 characters; contains 113 characters
       48 | WARNING | Line exceeds 80 characters; contains 112 characters
       50 | WARNING | Line exceeds 80 characters; contains 111 characters
       52 | WARNING | Line exceeds 80 characters; contains 89 characters
       54 | WARNING | Line exceeds 80 characters; contains 90 characters
       56 | WARNING | Line exceeds 80 characters; contains 90 characters
       57 | WARNING | Line exceeds 80 characters; contains 82 characters
     1412 | WARNING | Line exceeds 80 characters; contains 142 characters
     1414 | WARNING | Line exceeds 80 characters; contains 127 characters
     1416 | WARNING | Line exceeds 80 characters; contains 205 characters
     1418 | WARNING | Line exceeds 80 characters; contains 190 characters
     1420 | WARNING | Line exceeds 80 characters; contains 755 characters
     1428 | WARNING | Line exceeds 80 characters; contains 142 characters
     1430 | WARNING | Line exceeds 80 characters; contains 127 characters
     1431 | WARNING | Line exceeds 80 characters; contains 205 characters
     1433 | WARNING | Line exceeds 80 characters; contains 755 characters
    ----------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/vendor/SECURITY.md
    ----------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    ----------------------------------------------------------------------
      3 | WARNING | Line exceeds 80 characters; contains 105 characters
      8 | WARNING | Line exceeds 80 characters; contains 104 characters
     10 | WARNING | Line exceeds 80 characters; contains 173 characters
    ----------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/vendor/skins/moono-lisa/editor_iequirks.css
    ------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ------------------------------------------------------------------------------------------
     1 | WARNING | File appears to be minified and cannot be processed
    ------------------------------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/vendor/skins/moono-lisa/editor_gecko.css
    ---------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ---------------------------------------------------------------------------------------
     1 | WARNING | File appears to be minified and cannot be processed
    ---------------------------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/vendor/skins/moono-lisa/dialog_ie8.css
    -------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    -------------------------------------------------------------------------------------
     1 | WARNING | File appears to be minified and cannot be processed
    -------------------------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/vendor/skins/moono-lisa/editor_ie8.css
    -------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    -------------------------------------------------------------------------------------
     1 | WARNING | File appears to be minified and cannot be processed
    -------------------------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/vendor/skins/moono-lisa/dialog_iequirks.css
    ------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ------------------------------------------------------------------------------------------
     1 | WARNING | File appears to be minified and cannot be processed
    ------------------------------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/vendor/skins/moono-lisa/dialog.css
    ---------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ---------------------------------------------------------------------------------
     1 | WARNING | File appears to be minified and cannot be processed
    ---------------------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/vendor/skins/moono-lisa/editor_ie.css
    ------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ------------------------------------------------------------------------------------
     1 | WARNING | File appears to be minified and cannot be processed
    ------------------------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/vendor/skins/moono-lisa/editor.css
    ---------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ---------------------------------------------------------------------------------
     1 | WARNING | File appears to be minified and cannot be processed
    ---------------------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/vendor/skins/moono-lisa/dialog_ie.css
    ------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ------------------------------------------------------------------------------------
     1 | WARNING | File appears to be minified and cannot be processed
    ------------------------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/vendor/CHANGES.md
    ----------------------------------------------------------------------
    FOUND 0 ERRORS AND 47 WARNINGS AFFECTING 47 LINES
    ----------------------------------------------------------------------
       12 | WARNING | Line exceeds 80 characters; contains 154 characters
       67 | WARNING | Line exceeds 80 characters; contains 243 characters
       69 | WARNING | Line exceeds 80 characters; contains 188 characters
      194 | WARNING | Line exceeds 80 characters; contains 210 characters
      198 | WARNING | Line exceeds 80 characters; contains 161 characters
      313 | WARNING | Line exceeds 80 characters; contains 398 characters
      317 | WARNING | Line exceeds 80 characters; contains 346 characters
      497 | WARNING | Line exceeds 80 characters; contains 85 characters
      498 | WARNING | Line exceeds 80 characters; contains 86 characters
      499 | WARNING | Line exceeds 80 characters; contains 114 characters
      500 | WARNING | Line exceeds 80 characters; contains 96 characters
      504 | WARNING | Line exceeds 80 characters; contains 96 characters
      506 | WARNING | Line exceeds 80 characters; contains 92 characters
      560 | WARNING | Line exceeds 80 characters; contains 280 characters
      684 | WARNING | Line exceeds 80 characters; contains 113 characters
      685 | WARNING | Line exceeds 80 characters; contains 162 characters
      690 | WARNING | Line exceeds 80 characters; contains 108 characters
      691 | WARNING | Line exceeds 80 characters; contains 133 characters
      695 | WARNING | Line exceeds 80 characters; contains 191 characters
      696 | WARNING | Line exceeds 80 characters; contains 104 characters
      698 | WARNING | Line exceeds 80 characters; contains 95 characters
      706 | WARNING | Line exceeds 80 characters; contains 275 characters
      764 | WARNING | Line exceeds 80 characters; contains 138 characters
      766 | WARNING | Line exceeds 80 characters; contains 98 characters
      767 | WARNING | Line exceeds 80 characters; contains 88 characters
      768 | WARNING | Line exceeds 80 characters; contains 81 characters
     1011 | WARNING | Line exceeds 80 characters; contains 117 characters
     1012 | WARNING | Line exceeds 80 characters; contains 124 characters
     1073 | WARNING | Line exceeds 80 characters; contains 88 characters
     1075 | WARNING | Line exceeds 80 characters; contains 345 characters
     1354 | WARNING | Line exceeds 80 characters; contains 188 characters
     1359 | WARNING | Line exceeds 80 characters; contains 335 characters
     1360 | WARNING | Line exceeds 80 characters; contains 233 characters
     1374 | WARNING | Line exceeds 80 characters; contains 117 characters
     1375 | WARNING | Line exceeds 80 characters; contains 100 characters
     1376 | WARNING | Line exceeds 80 characters; contains 275 characters
     1377 | WARNING | Line exceeds 80 characters; contains 282 characters
     1378 | WARNING | Line exceeds 80 characters; contains 157 characters
     1382 | WARNING | Line exceeds 80 characters; contains 164 characters
     1431 | WARNING | Line exceeds 80 characters; contains 280 characters
     1487 | WARNING | Line exceeds 80 characters; contains 280 characters
     1692 | WARNING | Line exceeds 80 characters; contains 102 characters
     1693 | WARNING | Line exceeds 80 characters; contains 113 characters
     2076 | WARNING | Line exceeds 80 characters; contains 117 characters
     2079 | WARNING | Line exceeds 80 characters; contains 117 characters
     2128 | WARNING | Line exceeds 80 characters; contains 102 characters
     2182 | WARNING | Line exceeds 80 characters; contains 88 characters
    ----------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/ckeditor.api.php
    ----------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    ----------------------------------------------------------------------
     21 | ERROR | Missing parameter type
     48 | ERROR | Missing parameter type
    ----------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/tests/src/Unit/CKEditorPluginManagerTest.php
    -------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    -------------------------------------------------------------------------------------------
     70 | ERROR | [x] Array closing indentation error, expected 10 spaces but found 8
    -------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    -------------------------------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/tests/src/Kernel/CKEditorPluginManagerTest.php
    ------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 4 ERRORS AND 2 WARNINGS AFFECTING 5 LINES
    ------------------------------------------------------------------------------------------------------------------------------------------
      36 | ERROR   | [x] Missing function doc comment
      39 | WARNING | [x] There must be no blank line following an inline comment
      39 | WARNING | [ ] There must be no blank line following an inline comment
      84 | ERROR   | [ ] The array declaration extends to column 201 (the limit is 120). The array content should be split up over multiple
         |         |     lines
     127 | ERROR   | [ ] The array declaration extends to column 145 (the limit is 120). The array content should be split up over multiple
         |         |     lines
     133 | ERROR   | [ ] The array declaration extends to column 174 (the limit is 120). The array content should be split up over multiple
         |         |     lines
    ------------------------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ------------------------------------------------------------------------------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/tests/src/Kernel/CKEditorTest.php
    ------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 12 ERRORS AND 3 WARNINGS AFFECTING 14 LINES
    ------------------------------------------------------------------------------------------------------------------------------------------
      52 | ERROR   | [x] Missing function doc comment
      56 | WARNING | [x] There must be no blank line following an inline comment
      56 | WARNING | [ ] There must be no blank line following an inline comment
      86 | ERROR   | [ ] Public method name "CKEditorTest::testGetJSSettings" is not in lowerCamel format
     140 | ERROR   | [ ] The array declaration extends to column 122 (the limit is 120). The array content should be split up over multiple
         |         |     lines
     228 | ERROR   | [ ] Public method name "CKEditorTest::testBuildToolbarJSSetting" is not in lowerCamel format
     259 | ERROR   | [ ] Public method name "CKEditorTest::testBuildContentsCssJSSetting" is not in lowerCamel format
     267 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
     425 | ERROR   | [ ] Public method name "CKEditorTest::testJSTranslation" is not in lowerCamel format
     495 | ERROR   | [ ] Protected method name "CKEditorTest::assertCKEditorLanguage" is not in lowerCamel format
     511 | ERROR   | [x] Missing function doc comment
     522 | ERROR   | [x] Missing function doc comment
     537 | ERROR   | [x] Missing function doc comment
     543 | ERROR   | [x] Missing function doc comment
     569 | ERROR   | [x] Missing function doc comment
    ------------------------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ------------------------------------------------------------------------------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/tests/src/Functional/CKEditorLoadingTest.php
    -------------------------------------------------------------------------------------------------------------------------------
    FOUND 3 ERRORS AND 2 WARNINGS AFFECTING 5 LINES
    -------------------------------------------------------------------------------------------------------------------------------
      42 | ERROR   | [x] Missing function doc comment
      93 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
     187 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
     208 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
     219 | ERROR   | [x] Missing function doc comment
    -------------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    -------------------------------------------------------------------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/tests/src/Functional/CKEditorAdminTest.php
    ----------------------------------------------------------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    ----------------------------------------------------------------------------------------------------------------------------
     37 | ERROR | [x] Missing function doc comment
     86 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
    ----------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ----------------------------------------------------------------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/tests/src/Functional/Update/CKEditorUpdateOmitDisabledPluginSettings.php
    ------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ------------------------------------------------------------------------------------------------------------------------------------------
     47 | ERROR | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes
        |       | option.
    ------------------------------------------------------------------------------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/tests/src/FunctionalJavascript/BigPipeRegressionTest.php
    -----------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
    -----------------------------------------------------------------------------------------------------------------
      55 | ERROR   | Public method name "BigPipeRegressionTest::testCommentForm_2698811" is not in lowerCamel format
     100 | WARNING | Unused variable $i.
    -----------------------------------------------------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/tests/src/FunctionalJavascript/MediaLibraryTest.php
    --------------------------------------------------------------------------------------------------
    FOUND 3 ERRORS AFFECTING 3 LINES
    --------------------------------------------------------------------------------------------------
     293 | ERROR | [x] Array indentation error, expected 10 spaces but found 8
     294 | ERROR | [x] Array indentation error, expected 10 spaces but found 8
     302 | ERROR | [x] Array closing indentation error, expected 8 spaces but found 6
    --------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/tests/modules/src/Plugin/CKEditorPlugin/LlamaContextualAndButton.php
    -----------------------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
    -----------------------------------------------------------------------------------------------------------------------------------------
     13 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
     44 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
     68 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    -----------------------------------------------------------------------------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/tests/modules/src/Plugin/CKEditorPlugin/LlamaButton.php
    -----------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    -----------------------------------------------------------------------------------------------------------------------------------------
      8 | WARNING | Line exceeds 80 characters; contains 82 characters
     23 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    -----------------------------------------------------------------------------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/tests/modules/src/Plugin/CKEditorPlugin/LlamaCss.php
    -----------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    -----------------------------------------------------------------------------------------------------------------------------------------
     25 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    -----------------------------------------------------------------------------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/tests/modules/src/Form/AjaxCssForm.php
    -------------------------------------------------------------------------------------
    FOUND 3 ERRORS AFFECTING 3 LINES
    -------------------------------------------------------------------------------------
     39 | ERROR | [x] Whitespace found at end of line
     40 | ERROR | [ ] Parameter tags must be grouped together in a doc comment
     49 | ERROR | [x] @inheritDoc found. Did you mean {@inheritDoc}?
    -------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    -------------------------------------------------------------------------------------
    
    
    FILE: /app/web/modules/custom/ckeditor-3365251/tests/modules/ckeditor_test.routing.yml
    ------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    ------------------------------------------------------------------------------------------------------------------
      7 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
     14 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
    ------------------------------------------------------------------------------------------------------------------
    
    Time: 1.09 secs; Memory: 24MB
  • 🇮🇳India koustav_mondal Kolkata

    Hello @kalash-j, I think this specific issue was created to fix only \Drupal calls in classes.

Production build 0.71.5 2024