Added git lab and solved some phpcs error too and created the !MR9
kalash-j → created an issue.
@deepak5423 !MR43 is following all the README.md standards.
kalash-j → changed the visibility of the branch 3452227- to hidden.
kalash-j → made their first commit to this issue’s fork.
i have raised the MR!11 for this issue
i have checked it on D11 and its working fine
kalash-j → made their first commit to this issue’s fork.
This module is compatible with Drupal 10 checked in my system no issues found. Moving to RTBC.
I have fixed the issues of PHPCS
kalash-j → made their first commit to this issue’s fork.
@apaderno i have done the changes on the feedback you have provided
Added gitlab CI for the module
kalash-j → made their first commit to this issue’s fork.
kalash-j → made their first commit to this issue’s fork.
hello , i have solved all the issues that PHPCS has shown.
MR!2 have 0 PHPCS error please check.
kalash-j → made their first commit to this issue’s fork.
@gpietrzak i have added the LICENSE.txt please look into it
kalash-j → made their first commit to this issue’s fork.
@kriboogh worked on your feedbacks
kalash-j → made their first commit to this issue’s fork.
Sorry @smustgrave i have miss read the other ticket , i have done those changes as asked it TODO. and Added the TODO comment back to the theme file as changes of that file is already done the that ticket
Removed the todo task from the both files. As the function is not deprecated.
kalash-j → made their first commit to this issue’s fork.
@cmlara created update hook for MR!37
Pipeline is working fine now
had some issue with composer which are solved now
Added git lab to the project so that is run pipeline
Created the MR!4 for the patch i have provided earlier Since, patches are going to be removed from drupal.org issue workflow
kalash-j → created an issue.
kalash-j → made their first commit to this issue’s fork.
i have added a commit to MR!18
did solved all the solvable PHPCS problems
kalash-j → made their first commit to this issue’s fork.
Added a commit to MR!3
tried to solved the issue and i didnt faced any warning
kalash-j → made their first commit to this issue’s fork.
The MR has conflict have been solved
Please check!!
kalash-j → made their first commit to this issue’s fork.
i Have added the info in readme.md too
kalash-j → made their first commit to this issue’s fork.
kalash-j → created an issue.
Added the required changes in !MR 4
kalash-j → made their first commit to this issue’s fork.
.gitlab-ci.yml is alreday added in the codebase , theres no need og this issue
kalash-j → made their first commit to this issue’s fork.
Created the !MR 9 with solution.
kalash-j → made their first commit to this issue’s fork.
kalash-j → made their first commit to this issue’s fork.
Here's a Patch that will work the the current and other PHP versions
kalash-j → created an issue.
kalash-j → made their first commit to this issue’s fork.
kalash-j → made their first commit to this issue’s fork.
kalash-j → made their first commit to this issue’s fork.
This code has used old method for connection which works fine with Drupal 8 , but that method is deprecated in drupal 9.4 , when drupal 8 comes to end of life at that we can use this patch to update it and use the module for drupal 9 or grater
kalash-j → created an issue.
kalash-j → created an issue.
i have done required changes that were mention in MR !2 comments
I have created the MR !2 with the required changes please check
kalash-j → made their first commit to this issue’s fork.
The MR !5 have solved the issues and there is no class is created and error is solved which is given by phpcs
kalash-j → made their first commit to this issue’s fork.
kalash-j → made their first commit to this issue’s fork.
I have tried this MR !66 in drupal 10.1.4 and its working perfectly fine but when trying to apply #8 patch getting this error
error: modules/private_message_notify/private_message_notify.info.yml: No such file or directory
Maintaners Alredy port the module to drupal 10 , so there is no need for this issue
@jjgw Can you specify how you are getting this error i have tried this module in drupal 10.1 and php 8.2 .I did added the content and check for the error but i am not getting any error .Please share more details on this issue
The Patch first-error-message-not-appear-3076054-17.patch by joaopauloc.dev is working fine. After applying patch error message is showing on field when no value is entred. Everything is working fine as required.
There's an issue with this patch it dose solve the problem of multiple commenting but when user comment for 1 time , user cant able to comment again
I have installed 'drupal/scheduled_transitions:^2.3' this version of the module and i tried to reproduce the issue but i am not facing any problem as mentioned above its working fine
The patch 3057250-65.patch is working fine , i have tried and tested it .
kalash-j → made their first commit to this issue’s fork.
The patch redirect-redirect_on_exception-3363110-3.patch by huzooka is working fine .Its redirecting user to a different page who have explicit admin language.