- Issue created by @smustgrave
- 🇮🇳India pradhumanjainOSL
@smustgrave This issue is closed in this thread. Would you please review.
- 🇮🇳India pradhumanjainOSL
I think we can remove this @todo from these file too
core/includes/theme.inc. - First commit to issue fork.
- Status changed to Needs review
8 months ago 5:13am 7 May 2024 - 🇮🇳India kalash-j jaipur
Removed the todo task from the both files. As the function is not deprecated.
- Status changed to Active
8 months ago 12:10pm 7 May 2024 - 🇺🇸United States smustgrave
If the other ticket was read would see removing the todos isn’t the solution but to do what the todos said.
- Status changed to Needs review
7 months ago 11:43pm 15 May 2024 - 🇮🇳India kalash-j jaipur
Sorry @smustgrave i have miss read the other ticket , i have done those changes as asked it TODO. and Added the TODO comment back to the theme file as changes of that file is already done the that ticket
- Status changed to Needs work
7 months ago 2:46pm 16 May 2024 - 🇺🇸United States smustgrave
MR appears to have failures.
How come we are leaving " see https://www.drupal.org/project/drupal/issues/3443759 📌 LinkGenerator.php "System path is deprecated - use the route name and parameters" Needs review ." ? shouldn't that be removed.
- Status changed to Needs review
5 months ago 7:13am 9 July 2024 - Status changed to Needs work
5 months ago 7:47am 9 July 2024 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.