- Issue created by @quietone
- Status changed to Needs review
7 months ago 3:49am 17 April 2024 - Status changed to Needs work
7 months ago 1:12pm 17 April 2024 - 🇺🇸United States smustgrave
Searching for deprecated and 11.0 found a missing instance in
Token.phpAlso a comment in LinkGenerator // @todo System path is deprecated - use the route name and parameters.
- 🇮🇳India pradhumanjainOSL
pradhumanjain2311 → made their first commit to this issue’s fork.
- Status changed to Needs review
7 months ago 11:23am 23 April 2024 - 🇺🇸United States smustgrave
Quick glance but link generator is removing a comment. Does the code need to be tweaked at all?
- Status changed to RTBC
7 months ago 2:45pm 23 April 2024 - 🇺🇸United States smustgrave
Believe the comment in linkGenerator was left over.
https://git.drupalcode.org/project/drupal/-/commit/bf4a582850e66bc28cfd0... was the commit it was added.
- Status changed to Needs work
7 months ago 3:44pm 23 April 2024 - 🇬🇧United Kingdom catch
That @todo wasn't a leftover, it's not been worked on since it was added. I think we can remove the @todo, but let's open an issue for what it was trying to do so the thought is still tracked - left a comment on the MR and marking needs work for the follow-up to be opened.
- Status changed to RTBC
7 months ago 1:56pm 26 April 2024 - 🇺🇸United States smustgrave
Opened up follow ups for both threads
Added comment back and since that was the only change I did think good to self RTBC.
- Status changed to Needs work
7 months ago 2:12pm 26 April 2024 - 🇬🇧United Kingdom catch
I think we should probably add the type hints that were moved to a follow-up in this issue - gave reasons in the MR.
- Status changed to RTBC
7 months ago 2:34pm 26 April 2024 - Status changed to Fixed
7 months ago 2:40pm 26 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.