- Issue created by @sidharth_soman
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 10:53am 7 July 2023 - š®š³India sidharth_soman Bangalore
All issues fixed except for unused variables and warnings involving lines exceeding 80 characters. I'm leaving that up to the discretion of the maintainers.
Please review the MR made against the 2.0.x branch.
- Status changed to Needs work
6 months ago 12:52pm 31 May 2024 Hi,
Applied MR!10 #2 against the 2.0.x branch, confirmed remaining issues are unused variables and lines exceeding 80 characters.
taxonomy_machine_name git:(2.0.x) curl https://git.drupalcode.org/project/taxonomy_machine_name/-/merge_requests/10.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 4275 0 4275 0 0 10773 0 --:--:-- --:--:-- --:--:-- 10989 patching file modules/search_api_taxonomy_machine_name/src/Plugin/views/filter/SearchApiTaxonomyMachineName.php patching file src/Plugin/views/filter/TaxonomyIndexMachineName.php patching file taxonomy_machine_name.module ā taxonomy_machine_name git:(2.0.x) ā cd .. ā contrib git:(main) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig taxonomy_machine_name FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/taxonomy_machine_name/taxonomy_machine_name.module --------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------- 80 | WARNING | Line exceeds 80 characters; contains 100 characters --------------------------------------------------------------------------------------------------------------------------- FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/taxonomy_machine_name/modules/search_api_taxonomy_machine_name/search_api_taxonomy_machine_name.views.inc ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 21 | WARNING | Unused variable $field_alias. ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: ...etInterns/Demo-site/drupal-orgissue/web/modules/contrib/taxonomy_machine_name/modules/search_api_taxonomy_machine_name/src/Plugin/views/filter/SearchApiTaxonomyMachineName.php ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 79 | WARNING | Line exceeds 80 characters; contains 111 characters ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/taxonomy_machine_name/src/Plugin/views/argument_validator/TermMachineName.php ------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------ 74 | WARNING | Unused variable $operator. 78 | WARNING | Unused variable $operator. ------------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/taxonomy_machine_name/src/Plugin/views/filter/TaxonomyIndexMachineName.php --------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------------------- 12 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\views\Plugin\views\display\DisplayPluginBase. --------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------------- Time: 669ms; Memory: 12MBThank you.
- First commit to issue fork.
- Status changed to Needs review
5 months ago 11:44am 3 June 2024 - š®š³India atul_ghate
Added a merge request (MR) to fix PHPCS issues, but one still remains. See the image below.
- Status changed to Needs work
4 months ago 6:17am 9 July 2024 - š®š³India kalash-j jaipur
@atul_ghate I have reviewed MR!10, there is only 1 phpcs error in the issue , as you already mentioned .
what we can do here is , comment that line , if the maintainer required that variable later they can uncomment it and can use it . - Status changed to Needs review
4 months ago 6:39am 9 July 2024 - š®š³India atul_ghate
Hello @kalash-j, i have made the suggested change please review.
- š®š³India kalash-j jaipur
hello @atul_ghate i have reviewd your MR and there is no error present in it
RTBC +1 - Status changed to RTBC
4 months ago 6:54am 10 July 2024