Hi @reveen.thakur51,
I have reviewed the MR and confirmed the configuration of GitLab CI is added and the pipeline is working properly.
Will now move this to RTBC since it is noted that the jobs can be checked on separate issues.
Thanks,
Jake
Hi @torfj,
I have confirmed the commits you made on MR!4 and confirmed the README.md follows the standard template. I have added an image for reference.
Will now move this to RTBC
Thanks,
Jake
Hi @ankitv18,
I have reviewed your commits and confirmed the gitlab template was added to the MR!3, also confirmed can run the pipeline.
Will now move this to RTBC
Thanks,
Jake
Hi @gremy,
I have confirmed that a GitLab CI configuration was added to the MR and that the pipeline may run without error, however, some jobs resulted an error. Kindly advise whether to create another issue for the failed jobs or should it be fixed in this issue.
Thanks,
Jake
Hi @gremy,
I confirm that a GitLab CI configuration is added to the MR, confirmed pipeline can run without errors, however, the jobs needs to be fixed. Should another issue be created for the failed jobs or should it be fixed in this issue?
Kindly advise on the best solution there is.
Thanks,
Jake
Hi @kul.pratap,
I have reviewed the pipeline and confirmed the cspell job succeeded. For the phpcs errors, I think it is fine since there is another ticket for it, you can check it here 🐛 phpcs: 12 failed, 12 total tests Active if you'd like.
Will move this to RTBC now.
Thanks,
Jake
Hi @chhavi.sharma,
I have reviewed your changes on MR!5 and confirmed the suggestion of sir @avpaderno was followed and the phpcs job passed.
Will now move this to RTBC
Thanks,
Jake
Hi @the_g_bomb,
I have enabled and re-ran the cspell job, and it still did not pass. 3290470
Kindly check
Thanks,
Jake
a.aaronjake → changed the visibility of the branch 9.0.x to hidden.
Hi @the_g_bomb,
I have checked the pipeline and confirmed the phpcs job succeeded: 3248720
Will now move this to RTBC
Thanks,
Jake
a.aaronjake → made their first commit to this issue’s fork.
Hi @the_g_bomb,
I have reviewed the stylelint job and confirmed it succeed, for anyone's reference: stylelint job success
I will now move this to RTBC
Thanks,
Jake
Hi @the_g_bomb,
I have checked the pipeline and confirmed phpcs job succeeded: phpcs job success
Will now move this to RTBC
Thanks,
Jake
Hi @the_g_bomb,
I have reviewed the pipeline and confirmed the cspell job succeeded: cspell job success
Will now move this to RTBC
Thanks,
Jake
Will there be another meeting? I'd like to join and learn from you guys! Also I'd like to kindly ask some instructions on how to join. :peace:
Thanks,
Jake
Hi @arunsahijpal,
I have applied the commits you made on MR!3, it was applied successfully and confirmed no issues are reported anymore. Please see:
paragraph_control git:(1.0.x) curl https://git.drupalcode.org/project/paragraph_control/-/merge_requests/3.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1401 0 1401 0 0 4826 0 --:--:-- --:--:-- --:--:-- 5021
patching file paragraph_control.install
patching file paragraph_control.module
➜ paragraph_control git:(1.0.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig paragraph_control
➜ contrib git:(main) ✗Will now move this to RTBC
Thanks,
Jake
Hi @dhruv.mittal,
I have checked and re-run the phpcs pipeline, and confirmed the job succeeded. Please check: Phpcs job succeeded
Will now move this to RTBC
Thanks,
Jake
Hi @tr,
I have confirmed that the GitLab CI testing is now turned on, looks like a lot of issues will be created because I saw lots of failed jobs on the pipeline. Lol.
Will now move this to RTBC.
Thanks,
Jake
Hi @kul.pratap.,
I have re-ran the pipeline, confirmed the phpcs errors are now fixed and the pipeline passed:
Gitlab CI pipeline passed phpcs
Will now move this to RTBC since this issue is for the phpcs only.
Thanks,
Jake
Hi sayan_k_dutta,
Confirmed the commit you added to the MR fixed the reported issue.
gnu_terry_pratchett git:(main) ✗ curl https://git.drupalcode.org/project/gnu_terry_pratchett/-/merge_requests/4.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 3290 0 3290 0 0 9154 0 --:--:-- --:--:-- --:--:-- 9426
patching file gnu_terry_pratchett.module
patching file gnu_terry_pratchett.services.yml
patching file src/EventSubscriber/XClacksSubscriber.php
patching file src/Tests/Headers/XClacksTest.php
➜ gnu_terry_pratchett git:(main) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig gnu_terry_pratchett
➜ contrib git:(main) ✗Will now move this to RTBC
Thanks,
Jake
Hi @the_g_bomb,
I have verified the phpcs issues on my terminal, the commits you made on MR!4 can be applied successfully and after applying it, confirmed most issues were fixed, however, one error still persisted. Please see below:
gnu_terry_pratchett git:(main) ✗ curl https://git.drupalcode.org/project/gnu_terry_pratchett/-/merge_requests/4.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 2951 0 2951 0 0 8990 0 --:--:-- --:--:-- --:--:-- 9338
patching file gnu_terry_pratchett.module
patching file gnu_terry_pratchett.services.yml
patching file src/EventSubscriber/XClacksSubscriber.php
patching file src/Tests/Headers/XClacksTest.php
➜ gnu_terry_pratchett git:(main) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig gnu_terry_pratchett
FILE: .../web/modules/contrib/gnu_terry_pratchett/src/Tests/Headers/XClacksTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
32 | ERROR | Public method name "XClacksTest::testXClacksHeaders" is not in
| | lowerCamel format
--------------------------------------------------------------------------------
Time: 135ms; Memory: 10MBKindly check
Thanks,
Jake
Hi @ankitv18,
I have applied the changes you committed on MR17 and after applying it, confirmed a gitlab file with the correct template. Please see attached images for reference.
Will move this to RTBC
Thanks,
Jake
Hi @akulsaxena,
I have applied the patch you provided, confirmed can be applied smoothly, however, there are still errors reported that are on the css files you mentioned. Please see below:
ceremai git:(master) ✗ curl https://www.drupal.org/files/issues/2024-11-04/3361446-coding_standard_Phpcs.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 55292 100 55292 0 0 499k 0 --:--:-- --:--:-- --:--:-- 556k
patching file README.md
patching file README.txt
patching file ceremai.theme
patching file config/install/ceremai.settings.yml
patching file css/advanced.css
patching file css/bootstrap-3.3.7.css
patching file css/bootstrap.css
patching file css/colorscheme.css
patching file css/component.css
patching file css/content.css
patching file css/custom.css
patching file css/footer.css
patching file css/header.css
patching file css/styles.css
patching file js/advanced.js
➜ ceremai git:(master) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig ceremai
FILE: ...erns/Demo-site/drupal-orgissue-v9/web/themes/contrib/ceremai/ceremai.theme
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\block\Entity\Block.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...site/drupal-orgissue-v9/web/themes/contrib/ceremai/css/bootstrap-3.3.7.css
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
3673 | ERROR | Style definitions must end with a semicolon
6420 | ERROR | Style definitions must end with a semicolon
6430 | ERROR | Style definitions must end with a semicolon
--------------------------------------------------------------------------------
FILE: .../Demo-site/drupal-orgissue-v9/web/themes/contrib/ceremai/css/bootstrap.css
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
3662 | ERROR | Style definitions must end with a semicolon
6413 | ERROR | Style definitions must end with a semicolon
6423 | ERROR | Style definitions must end with a semicolon
--------------------------------------------------------------------------------
FILE: ...pal-orgissue-v9/web/themes/contrib/ceremai/templates/system/page.html.twig
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
276 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...eb/themes/contrib/ceremai/templates/node/node--article--slider-1.html.twig
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
23 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...pal-orgissue-v9/web/themes/contrib/ceremai/templates/block/block.html.twig
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
66 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 3.6 secs; Memory: 58.01MBKindly check again
Thanks,
Jake
Hi @the_g_bomb,
I have applied the commits you made on MR!3, and it was applied successfully, also confirmed that the Gitlab CI file was added to the module. Please see image for reference.
Will move this to RTBC
Thanks,
Jake
Hi @the_g_bomb,
I have applied the commits you made on MR!3, confirmed Gitlab CI added. Please see attached image for reference.
Will now move this to RTBC so that it will be merged.
Thanks,
Jake
Hi @gslente,
I have applied your commits on MR!8, however, the README.txt file was not replaced with the README.md. Please see attached image for your reference.
Thanks,
Jake
Hi @barbara.losnc,
Can you please just commit the gitlab ci file and not the whole file, it looks like you included all files - if not, there are still multiple files that are irrelevant to this issue.
Thanks,
Jake
Hi @mohd sahzad,
I have applied the commits you made on MR !2, and confirmed README file was added. Please see attached image for reference.
Will move this to RTBC
Thanks,
Jake
Hi @anktiv18,
I have applied the commits you made on MR!3, it was applied successfully and confirmed gitlab file added with the standard template. Please see attached images for reference. Will move this to RTBC.
Thanks,
Jake
Hi @ankitv18,
I have applied the commits you made on MR!11, it was applied successfully and confirmed GitLab CI file was added with the standard template. Please see the attached images for reference, will also move this to RTBC.
Thanks,
Jake
Hi @acbramley,
Thank you for the response, will now move this to RTBC.
Thanks,
Jake
Hi @acbramley,
I have applied your commits on MR!6, it was applied successfully and confirmed GitLab CI file was added, however, is it fine not to put the standard template there? Please see the attached images for reference. Will move this to 'Needs Work'.
Kindly check
Thanks,
Jake
Hi @gremy,
I have installed the module and applied your commits on MR!2, it was applied successfully and confirmed GitLab CI configuration added, it even follows the standard template. Please see attached images for reference, will also move this to RTBC.
Thanks,
Jake
Hi @jonhattan,
I have applied the MR!12, it was applied successfully and confirmed gitlab CI added w/ the correct template. Please see attached images for reference, will also move this to RTBC.
Thanks,
Jake
Hi @jonathan,
I have applied the commits you made on MR!8, it was applied successfully and confirmed Gitlab CI added with the correct template. Please see attached images. Will move this to RTBC.
Thanks,
Jake
Hi @amit.rawatt777,
I have applied your patch, it was applied so smoothly, however and unfortunately, the reported errors this time increased compared to the previously reported errors. Please see below:
➜ ceremai git:(master) ✗ curl https://www.drupal.org/files/issues/2024-08-26/phpcs-3361446-9.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 56531 100 56531 0 0 328k 0 --:--:-- --:--:-- --:--:-- 351k
patching file README.md
patching file README.txt
patching file ceremai.info.yml
patching file ceremai.theme
patching file config/install/ceremai.settings.yml
patching file css/advanced.css
patching file css/bootstrap-3.3.7.css
patching file css/bootstrap.css
patching file css/colorscheme.css
patching file css/component.css
patching file css/content.css
patching file css/custom.css
patching file css/footer.css
patching file css/header.css
patching file css/styles.css
➜ ceremai git:(master) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig ceremai
FILE: ...erns/Demo-site/drupal-orgissue-v9/web/themes/contrib/ceremai/ceremai.theme
--------------------------------------------------------------------------------
FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\block\Entity\Block.
43 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters
162 | WARNING | [ ] Translatable strings must not begin or end with white
| | spaces, use placeholders with t() for variables
180 | ERROR | [ ] Doc comment is empty
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...site/drupal-orgissue-v9/web/themes/contrib/ceremai/css/bootstrap-3.3.7.css
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
3673 | ERROR | Style definitions must end with a semicolon
6420 | ERROR | Style definitions must end with a semicolon
6430 | ERROR | Style definitions must end with a semicolon
--------------------------------------------------------------------------------
FILE: ...pal-orgissue-v9/web/themes/contrib/ceremai/templates/system/page.html.twig
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
276 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...eb/themes/contrib/ceremai/templates/node/node--article--slider-1.html.twig
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
23 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...pal-orgissue-v9/web/themes/contrib/ceremai/templates/block/block.html.twig
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
66 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 3.62 secs; Memory: 58.01MBKindly check
Thanks,
Jake
Hi @Akshay
I have applied the commits you made on MR!5, confirmed it can be applied successfully, however, there are still indentions issues not yet fixed. Please see below:
➜ parameters git:(1.0.x) curl https://git.drupalcode.org/project/parameters/-/merge_requests/5.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 45872 0 45872 0 0 114k 0 --:--:-- --:--:-- --:--:-- 117k
patching file modules/parameters_ui/src/Controller/ParametersUiController.php
patching file modules/parameters_ui/src/Form/ParameterDeleteForm.php
patching file modules/parameters_ui/src/Form/ParameterForm.php
patching file modules/parameters_ui/src/Form/ParametersCollectionAddForm.php
patching file modules/parameters_ui/src/Form/ParametersCollectionForm.php
patching file modules/parameters_ui/src/Form/ParametersCollectionLockForm.php
patching file modules/parameters_ui/src/Form/ParametersCollectionUnlockForm.php
patching file modules/parameters_ui/src/ParametersUiListBuilder.php
patching file modules/parameters_ui/src/Routing/ParametersUiRouteEnhancer.php
patching file parameters.install
patching file src/Entity/ParametersCollectionStorage.php
patching file src/EventSubscriber/ParametersConfigOverrideSubscriber.php
patching file src/Exception/ParameterNotFoundException.php
patching file src/Internals/ContentSerializationCompilerPass.php
patching file src/Normalizer/Legacy/ParametersContentEntityNormalizer.php
patching file src/Normalizer/ParametersContentEntityNormalizer.php
patching file src/ParameterRepository.php
patching file src/Plugin/Derivative/Parameter/ContentDeriver.php
patching file src/Plugin/Parameter/Bundles.php
patching file src/Plugin/Parameter/Content.php
patching file src/Plugin/Parameter/Fields.php
patching file src/Plugin/Parameter/Http.php
patching file src/Plugin/Parameter/Increment.php
patching file src/Plugin/Parameter/NullObject.php
patching file src/Plugin/Parameter/Roles.php
patching file src/Plugin/Parameter/Types.php
patching file src/Plugin/ParameterManager.php
patching file tests/src/Kernel/ParametersTokenTest.php
➜ parameters git:(1.0.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig parameters
FILE: ...mo-site/drupal10-orgissue/web/modules/contrib/parameters/parameters.module
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
84 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
87 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
89 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...0-orgissue/web/modules/contrib/parameters/src/Plugin/Parameter/Content.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 10 WARNINGS AFFECTING 10 LINES
--------------------------------------------------------------------------------
186 | WARNING | Unused variable $bundle.
189 | WARNING | Unused variable $bundle.
357 | WARNING | Unused variable $cleanupFieldValues.
358 | WARNING | Unused variable $normalizeNewEntities.
363 | WARNING | Unused variable $cleanupFieldValues.
364 | WARNING | Unused variable $normalizeNewEntities.
381 | WARNING | Unused variable $cleanupFieldValues.
382 | WARNING | Unused variable $normalizeNewEntities.
387 | WARNING | Unused variable $cleanupFieldValues.
388 | WARNING | Unused variable $normalizeNewEntities.
--------------------------------------------------------------------------------
Time: 3.45 secs; Memory: 20MBAlso, can you please change the status of the issue to 'Needs Review' if you made your work on it? It is so that this will be seen as 'Needs Review' on the Issues page.
Kindly check
Thanks,
Jake
Hi @Akshay,
I have applied the commits you made on MR!1, it was applied smoothly and confirmed most issues other than unused variables were fixed. For the maintainer/s, please see below for the issues not yet fixed:
slack_rtm git:(8.x-1.x) ✗ curl https://git.drupalcode.org/project/slack_rtm/-/merge_requests/1.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 23345 0 23345 0 0 63877 0 --:--:-- --:--:-- --:--:-- 65209
patching file .gitlab-ci.yml
patching file config/install/slack_rtm.settings.yml
patching file config/schema/slack_rtm.schema.yml
patching file slack_rtm.links.menu.yml
patching file slack_rtm.links.task.yml
patching file slack_rtm.module
patching file slack_rtm.permissions.yml
patching file slack_rtm.routing.yml
patching file src/Batch/SlackRtmBatch.php
patching file src/Entity/SlackRtmMessage.php
patching file src/Entity/SlackRtmMessageCreate.php
patching file src/Entity/SlackRtmMessageInterface.php
patching file src/Entity/SlackRtmMessageViewsData.php
patching file src/Form/SlackRtmMessageConfigForm.php
patching file src/Form/SlackRtmMessageForm.php
patching file src/Plugin/QueueWorker/SlackRtmQueue.php
patching file src/SlackRtmApi.php
patching file src/SlackRtmMessageAccessControlHandler.php
patching file src/SlackRtmMessageListBuilder.php
patching file src/SlackRtmMessageTranslationHandler.php
➜ slack_rtm git:(8.x-1.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig slack_rtm
FILE: ...ite/drupal-orgissue-v9/web/modules/contrib/slack_rtm/slack_rtm.routing.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
17 | WARNING | Open page callback found, please add a comment before the line
| | why there is no access restriction
--------------------------------------------------------------------------------
FILE: ...emo-site/drupal-orgissue-v9/web/modules/contrib/slack_rtm/slack_rtm.module
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
54 | WARNING | Unused variable $slack_rtm_message.
--------------------------------------------------------------------------------
FILE: ...ue-v9/web/modules/contrib/slack_rtm/src/Form/SlackRtmMessageUpdateForm.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
37 | WARNING | Possible useless method overriding detected
45 | WARNING | Unused variable $api.
--------------------------------------------------------------------------------
FILE: ...-v9/web/modules/contrib/slack_rtm/src/Form/SlackRtmMessageSettingsForm.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
12 | WARNING | The class short comment should describe what the class does and
| | not simply repeat the class name
--------------------------------------------------------------------------------
FILE: ...ue-v9/web/modules/contrib/slack_rtm/src/Form/SlackRtmMessageConfigForm.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
208 | WARNING | Possible useless method overriding detected
--------------------------------------------------------------------------------
FILE: ...orgissue-v9/web/modules/contrib/slack_rtm/src/Form/SlackRtmMessageForm.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
59 | WARNING | Possible useless method overriding detected
--------------------------------------------------------------------------------
FILE: ...ssue-v9/web/modules/contrib/slack_rtm/src/Entity/SlackRtmMessageCreate.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
70 | WARNING | Unused variable $t.
--------------------------------------------------------------------------------
FILE: ...-v9/web/modules/contrib/slack_rtm/src/Plugin/QueueWorker/SlackRtmQueue.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
23 | WARNING | Unused variable $result.
--------------------------------------------------------------------------------
Time: 482ms; Memory: 12MBKindly check
Thanks,
Jake
Hi @ankitv18,
Confirmed gitlab template created, however, it slightly does not follow the standard template. The hashes(#) of the 'variables' should also be included. Please see attached images.
Kindly check
Thanks,
Jake
Hi @ptiwebtech,
The issue is still not fixed, moving this to 'Needs Work' so that others will fix this.
Thanks,
Jake
Hi @alok_singh,
I have applied the commits made on MR!4, unfortunately, it did not apply successfully, please see below:
➜ kite git:(main) ✗ curl https://git.drupalcode.org/project/kite/-/merge_requests/4.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:- 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-100 1645 0 1645 0 0 2698 0 --:--:-- --:--:-- --:--:-- 2741
patching file css/sass/__frontpage.scss
Hunk #1 FAILED at 87.
1 out of 1 hunk FAILED -- saving rejects to file css/sass/__frontpage.scss.rej
patching file css/sass/__header.scss
patching file css/style.cssAnd kindly see the attached video, the slider image still not displayed.
Thanks,
Jake
Hi @everyone,
Since there's no proof that the MR!27 fixed the issue, I will provide the evidence. Please see the attached image.
RTBC +1
Thanks,
Jake
Hi @Divyanshi,
I have replicated the issue reported, I applied the patch you provided, and it seems there is a problem with the patch, below is the output after applying the patch:
➜ techy_news git:(main) ✗ curl https://www.drupal.org/files/issues/2024-02-15/simple_news_content_fixed-3421541.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-100 5130 100 5130 0 0 48585 0 --:--:-- --:--:-- --:--:-- 54000
patching file css/style.css
Hunk #3 succeeded at 540 (offset -12 lines).
patching file sass/style.scss
Hunk #1 FAILED at 23.
Hunk #2 FAILED at 89.
Hunk #3 FAILED at 137.
Hunk #4 succeeded at 1037 with fuzz 2 (offset 336 lines).
3 out of 4 hunks FAILED -- saving rejects to file sass/style.scss.rejAnd please see the attached images.
Kindly check
Thanks,
Jake
Hi @alok_singh,
After applying the commits on MR!13, confirmed the 'ul' is working. However, the dropdown menu is still not working. Below is the applying of MR!13 success:
➜ harmony_haven git:(main) ✗ curl https://git.drupalcode.org/project/harmony_haven/-/merge_requests/13.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 6340 0 6340 0 0 18704 0 --:--:-- --:--:-- --:--:-- 19329
patching file .gitlab-ci.yml
patching file css/styles.css
patching file harmony_haven.libraries.yml
patching file templates/menu/menu--main.html.twig
patching file templates/page/page.html.twigPlease see the attached images.
Kindly check
Thanks,
Jake
Hi @rajan kumar@2026,
It seems there is a problem on the patch that you provided, there is a HUNK when applying your patch. Please see:
➜ harmony_haven git:(main) ✗ curl https://www.drupal.org/files/issues/2024-07-31/harmony_haven-3394557.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 489 100 489 0 0 1876 0 --:--:-- --:--:-- --:--:-- 1971
patching file css/styles.css
Hunk #1 succeeded at 895 (offset -3 lines).Kindly check
Thanks,
Jake
HI @prachi6824,
I have applied the patch you provided, however, I was not able to confirm whether it fixed the issue or it did not because the patch FAILED to apply. Please see below:
➜ portfollio_theme git:(1.0.x) curl https://www.drupal.org/files/issues/2023-06-16/indentation-is-not-proper-3367282-%232.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 5690 100 5690 0 0 22072 0 --:--:-- --:--:-- --:--:-- 23130
patching file templates/page.html.twig
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file templates/page.html.twig.rejKindly check
Thanks,
Jake
Hi @everyone,
I have applied MR!4 and confirmed it implements the hook_help, help page looks good too. Please see attached images.
a.aaronjake → made their first commit to this issue’s fork.
Please confirm
Thanks,
Jake
Hi @everyone,
Confirmed hook_help is implemented by the latest commits on MR19 which can be seen on the attached images.
Will also work on the feedback of comment #4.
Hi @Jay Jangid,
Confirmed hook_help is implemented after applying the commits on MR!6. Help page also matches also looks good, please see the attached images.
Will move this to RTBC
Thanks,
Jake
Hi @Neha-Verma,
Applied the patch you provided and confirmed search button is now styled. Please see attached image
Will move this to RTBC
Thanks,
Jake
Hi @aries,
Your patch resulted to HUNKS, please see below:
➜ blogger git:(master) curl https://www.drupal.org/files/issues/beautiful_blogger-5-14.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 21909 100 21909 0 0 70548 0 --:--:-- --:--:-- --:--:-- 73030
patching file blogger.module
Hunk #1 succeeded at 11 (offset -1 lines).
Hunk #2 succeeded at 40 (offset -1 lines).
Hunk #3 succeeded at 49 (offset -1 lines).
Hunk #4 succeeded at 102 (offset -1 lines).
Hunk #5 succeeded at 125 (offset -1 lines).
Hunk #6 succeeded at 166 (offset -1 lines).
Hunk #7 succeeded at 194 (offset -1 lines).
Hunk #8 succeeded at 359 (offset -1 lines).
Hunk #9 succeeded at 420 (offset -1 lines).Kindly check
Thanks,
Jake
Hi @akshaydalvi212,
Applied the latest commits on MR!1, it was applied successfully and confirmed no remaining issue reported.
➜ edit_and_save git:(8.x-1.x) curl https://git.drupalcode.org/project/edit_and_save/-/merge_requests/1.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 2624 0 2624 0 0 7964 0 --:--:-- --:--:-- --:--:-- 8251
patching file README.txt
patching file edit_and_save.info.yml
patching file src/Form/EditAndSaveConfigureForm.php
patching file src/Repository/EditAndSaveRepository.php
➜ edit_and_save git:(8.x-1.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig edit_and_save
➜ contrib git:(master) ✗Will now move this to RTBC
Thanks,
Jake
Hi @avpaderno,
I have applied the commits made on MR!12, it was applied successfully and confirmed no errors reported remaining.
➜ log_stdout git:(8.x-1.x) curl https://git.drupalcode.org/project/log_stdout/-/merge_requests/12.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 2583 0 2583 0 0 7877 0 --:--:-- --:--:-- --:--:-- 8174
patching file README.md
patching file log_stdout.links.menu.yml
patching file src/Logger/Stdout.php
➜ log_stdout git:(8.x-1.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig log_stdout
➜ contrib git:(master) ✗Will now move this to RTBC
Thanks,
Jake
Hi @henriquebauer,
Applied the patch you provided, it was applied successfully, however, there are a lot, like a LOT of errors reported. Please see below:
➜ rpx git:(7.x-2.x) curl https://www.drupal.org/files/issues/2018-06-05/coding_standards-2887732-4.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 115k 100 115k 0 0 345k 0 --:--:-- --:--:-- --:--:-- 360k
patching file rpx.api.php
patching file rpx_core.info
patching file rpx_core.install
patching file rpx_core.module
patching file rpx_core.pages.inc
patching file rpx_core.webapi.inc
patching file rpx_rules.info
patching file rpx_rules.rules.inc
patching file rpx_ui.admin.inc
patching file rpx_ui.css
patching file rpx_ui.info
patching file rpx_ui.install
patching file rpx_ui.module
patching file rpx_ui.pages.inc
patching file rpx_ui.paths.inc
patching file rpx_ui.tokens.inc
patching file rpx_widgets.css
patching file rpx_widgets.info
patching file rpx_widgets.module
patching file views/rpx_ui.views.inc
patching file views/rpx_ui_handler_field_delete_link.inc
patching file views/rpx_ui_handler_field_provider_icon.inc
patching file views/rpx_ui_handler_field_share.inc
patching file views/rpx_ui_handler_filter_provider_name.inc
patching file views/rpx_ui_handler_filter_provider_title.inc
➜ rpx git:(7.x-2.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig rpx
FILE: ...Interns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_ui.module
--------------------------------------------------------------------------------
FOUND 7 ERRORS AND 8 WARNINGS AFFECTING 15 LINES
--------------------------------------------------------------------------------
10 | WARNING | All constants defined by a module must be prefixed with the
| | module's name, expected "RPX_UI_RPX_ACCOUNTS_STRING" but found
| | "RPX_ACCOUNTS_STRING"
155 | ERROR | All functions defined in a module file must be prefixed with
| | the module's name, found "_rpx_own_identities_access" but
| | expected "rpx_ui__rpx_own_identities_access"
192 | WARNING | All variables defined by your module must be prefixed with
| | your module's name to avoid name collisions with others.
| | Expected start with "rpx_ui" but found
| | "rpx_attach_share_link_to_teasers_"
198 | WARNING | All variables defined by your module must be prefixed with
| | your module's name to avoid name collisions with others.
| | Expected start with "rpx_ui" but found
| | "rpx_attach_share_link_to_nodelink_"
204 | WARNING | All variables defined by your module must be prefixed with
| | your module's name to avoid name collisions with others.
| | Expected start with "rpx_ui" but found
| | "rpx_attach_share_link_to_nodecont_"
211 | WARNING | All variables defined by your module must be prefixed with
| | your module's name to avoid name collisions with others.
| | Expected start with "rpx_ui" but found
| | "rpx_attach_share_link_to_nodecont_weight_"
229 | WARNING | All variables defined by your module must be prefixed with
| | your module's name to avoid name collisions with others.
| | Expected start with "rpx_ui" but found
| | "rpx_comment_popup_social_at_once_"
235 | WARNING | All variables defined by your module must be prefixed with
| | your module's name to avoid name collisions with others.
| | Expected start with "rpx_ui" but found
| | "rpx_attach_share_link_to_comments_"
249 | ERROR | All functions defined in a module file must be prefixed with
| | the module's name, found "rpx_get_enabled_provider_array" but
| | expected "rpx_ui_rpx_get_enabled_provider_array"
273 | ERROR | All functions defined in a module file must be prefixed with
| | the module's name, found "_rpx_drupal_field_catalog" but
| | expected "rpx_ui__rpx_drupal_field_catalog"
345 | ERROR | All functions defined in a module file must be prefixed with
| | the module's name, found "_rpx_drupal_field_options" but
| | expected "rpx_ui__rpx_drupal_field_options"
366 | ERROR | All functions defined in a module file must be prefixed with
| | the module's name, found "_rpx_engage_field_options" but
| | expected "rpx_ui__rpx_engage_field_options"
377 | WARNING | Format should be "* Implements hook_foo().", "* Implements
| | hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements
| | hook_foo_BAR_ID_bar() for block templates."
480 | ERROR | All functions defined in a module file must be prefixed with
| | the module's name, found "_rpx_user_help_text" but expected
| | "rpx_ui__rpx_user_help_text"
496 | ERROR | All functions defined in a module file must be prefixed with
| | the module's name, found "_rpx_delete_user_data" but expected
| | "rpx_ui__rpx_delete_user_data"
--------------------------------------------------------------------------------
FILE: ...ns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_widgets.module
--------------------------------------------------------------------------------
FOUND 10 ERRORS AND 13 WARNINGS AFFECTING 23 LINES
--------------------------------------------------------------------------------
5 | WARNING | [ ] Line exceeds 80 characters; contains 95 characters
10 | WARNING | [ ] All constants defined by a module must be prefixed with
| | the module's name, expected
| | "RPX_WIDGETS_RPX_SIGNIN_STRING" but found
| | "RPX_SIGNIN_STRING"
13 | WARNING | [ ] All constants defined by a module must be prefixed with
| | the module's name, expected
| | "RPX_WIDGETS_RPX_DEFAULT_LABEL_NODES_STRING" but found
| | "RPX_DEFAULT_LABEL_NODES_STRING"
14 | WARNING | [ ] All constants defined by a module must be prefixed with
| | the module's name, expected
| | "RPX_WIDGETS_RPX_DEFAULT_MESSAGE_NODES_STRING" but found
| | "RPX_DEFAULT_MESSAGE_NODES_STRING"
15 | WARNING | [ ] All constants defined by a module must be prefixed with
| | the module's name, expected
| | "RPX_WIDGETS_RPX_DEFAULT_LINKTEXT_NODES_STRING" but found
| | "RPX_DEFAULT_LINKTEXT_NODES_STRING"
16 | WARNING | [ ] All constants defined by a module must be prefixed with
| | the module's name, expected
| | "RPX_WIDGETS_RPX_DEFAULT_TITLE_NODES_STRING" but found
| | "RPX_DEFAULT_TITLE_NODES_STRING"
17 | WARNING | [ ] All constants defined by a module must be prefixed with
| | the module's name, expected
| | "RPX_WIDGETS_RPX_DEFAULT_SUMMARY_NODES_STRING" but found
| | "RPX_DEFAULT_SUMMARY_NODES_STRING"
19 | WARNING | [ ] All constants defined by a module must be prefixed with
| | the module's name, expected
| | "RPX_WIDGETS_RPX_DEFAULT_LABEL_COMMENTS_STRING" but found
| | "RPX_DEFAULT_LABEL_COMMENTS_STRING"
20 | WARNING | [ ] All constants defined by a module must be prefixed with
| | the module's name, expected
| | "RPX_WIDGETS_RPX_DEFAULT_MESSAGE_COMMENTS_STRING" but
| | found "RPX_DEFAULT_MESSAGE_COMMENTS_STRING"
21 | WARNING | [ ] All constants defined by a module must be prefixed with
| | the module's name, expected
| | "RPX_WIDGETS_RPX_DEFAULT_LINKTEXT_COMMENTS_STRING" but
| | found "RPX_DEFAULT_LINKTEXT_COMMENTS_STRING"
22 | WARNING | [ ] All constants defined by a module must be prefixed with
| | the module's name, expected
| | "RPX_WIDGETS_RPX_DEFAULT_TITLE_COMMENTS_STRING" but found
| | "RPX_DEFAULT_TITLE_COMMENTS_STRING"
23 | WARNING | [ ] All constants defined by a module must be prefixed with
| | the module's name, expected
| | "RPX_WIDGETS_RPX_DEFAULT_SUMMARY_COMMENTS_STRING" but
| | found "RPX_DEFAULT_SUMMARY_COMMENTS_STRING"
46 | ERROR | [ ] All functions defined in a module file must be prefixed
| | with the module's name, found "_rpx_user_login_form_alter"
| | but expected "rpx_widgets__rpx_user_login_form_alter"
179 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
185 | ERROR | [ ] All functions defined in a module file must be prefixed
| | with the module's name, found "rpx_js" but expected
| | "rpx_widgets_rpx_js"
244 | ERROR | [ ] All functions defined in a module file must be prefixed
| | with the module's name, found "rpx_js_social" but expected
| | "rpx_widgets_rpx_js_social"
306 | ERROR | [ ] All functions defined in a module file must be prefixed
| | with the module's name, found "_rpx_locale" but expected
| | "rpx_widgets__rpx_locale"
322 | ERROR | [ ] All functions defined in a module file must be prefixed
| | with the module's name, found "_rpx_ssl" but expected
| | "rpx_widgets__rpx_ssl"
400 | ERROR | [x] Use null coalesce operator instead of ternary operator.
405 | ERROR | [ ] The array declaration extends to column 175 (the limit is
| | 120). The array content should be split up over multiple
| | lines
460 | ERROR | [ ] All functions defined in a module file must be prefixed
| | with the module's name, found "_rpx_share_button" but
| | expected "rpx_widgets__rpx_share_button"
470 | ERROR | [ ] The array declaration extends to column 140 (the limit is
| | 120). The array content should be split up over multiple
| | lines
516 | ERROR | [ ] All functions defined in a module file must be prefixed
| | with the module's name, found "_rpx_event_enabled" but
| | expected "rpx_widgets__rpx_event_enabled"
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...s/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_rules.rules.inc
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
--------------------------------------------------------------------------------
28 | WARNING | Avoid backslash escaping in translatable strings when
| | possible, use "" quotes instead
40 | WARNING | Translatable strings must not begin or end with white spaces,
| | use placeholders with t() for variables
132 | WARNING | Avoid backslash escaping in translatable strings when
| | possible, use "" quotes instead
134 | WARNING | Avoid backslash escaping in translatable strings when
| | possible, use "" quotes instead
137 | WARNING | Avoid backslash escaping in translatable strings when
| | possible, use "" quotes instead
139 | WARNING | Avoid backslash escaping in translatable strings when
| | possible, use "" quotes instead
145 | WARNING | Line exceeds 80 characters; contains 83 characters
--------------------------------------------------------------------------------
FILE: ...etInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx.api.php
--------------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
--------------------------------------------------------------------------------
30 | ERROR | unserialize() is insecure unless allowed classes are limited.
| | Use a safe format like JSON or use the allowed_classes option.
66 | ERROR | unserialize() is insecure unless allowed classes are limited.
| | Use a safe format like JSON or use the allowed_classes option.
87 | ERROR | unserialize() is insecure unless allowed classes are limited.
| | Use a safe format like JSON or use the allowed_classes option.
114 | ERROR | unserialize() is insecure unless allowed classes are limited.
| | Use a safe format like JSON or use the allowed_classes option.
117 | WARNING | Unused variable $aid.
--------------------------------------------------------------------------------
FILE: ...rns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_ui.tokens.inc
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------
18 | WARNING | Avoid backslash escaping in translatable strings when possible,
| | use "" quotes instead
19 | WARNING | Avoid backslash escaping in translatable strings when possible,
| | use "" quotes instead
24 | WARNING | Avoid backslash escaping in translatable strings when possible,
| | use "" quotes instead
--------------------------------------------------------------------------------
FILE: ...ns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_core.pages.inc
--------------------------------------------------------------------------------
FOUND 5 ERRORS AND 5 WARNINGS AFFECTING 10 LINES
--------------------------------------------------------------------------------
11 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters
13 | WARNING | [ ] Line exceeds 80 characters; contains 127 characters
20 | ERROR | [x] Use null coalesce operator instead of ternary operator.
32 | ERROR | [ ] The array declaration extends to column 181 (the limit is
| | 120). The array content should be split up over multiple
| | lines
101 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters
187 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters
207 | ERROR | [ ] The array declaration extends to column 419 (the limit is
| | 120). The array content should be split up over multiple
| | lines
210 | ERROR | [ ] The array declaration extends to column 469 (the limit is
| | 120). The array content should be split up over multiple
| | lines
218 | ERROR | [ ] The array declaration extends to column 331 (the limit is
| | 120). The array content should be split up over multiple
| | lines
222 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...nterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_ui.install
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------------
12 | WARNING | Line exceeds 80 characters; contains 85 characters
238 | WARNING | Unused variable $k.
259 | WARNING | Line exceeds 80 characters; contains 89 characters
417 | WARNING | Line exceeds 80 characters; contains 85 characters
526 | WARNING | '@todo' should match the format '@todo Fix problem X here.'
--------------------------------------------------------------------------------
FILE: ...terns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_core.module
--------------------------------------------------------------------------------
FOUND 21 ERRORS AND 19 WARNINGS AFFECTING 40 LINES
--------------------------------------------------------------------------------
12 | WARNING | [ ] All constants defined by a module must be prefixed with
| | the module's name, expected "RPX_CORE_RPX_MODULE_VERSION"
| | but found "RPX_MODULE_VERSION"
22 | WARNING | [ ] All constants defined by a module must be prefixed with
| | the module's name, expected "RPX_CORE_RPX_UPDATE_NONE"
| | but found "RPX_UPDATE_NONE"
24 | WARNING | [ ] All constants defined by a module must be prefixed with
| | the module's name, expected "RPX_CORE_RPX_UPDATE_EMPTY"
| | but found "RPX_UPDATE_EMPTY"
26 | WARNING | [ ] All constants defined by a module must be prefixed with
| | the module's name, expected "RPX_CORE_RPX_UPDATE_ALWAYS"
| | but found "RPX_UPDATE_ALWAYS"
28 | WARNING | [ ] All constants defined by a module must be prefixed with
| | the module's name, expected "RPX_CORE_RPX_UPDATE_MAYBE"
| | but found "RPX_UPDATE_MAYBE"
30 | WARNING | [ ] All constants defined by a module must be prefixed with
| | the module's name, expected "RPX_CORE_RPX_UPDATE_ADD" but
| | found "RPX_UPDATE_ADD"
35 | WARNING | [ ] All constants defined by a module must be prefixed with
| | the module's name, expected
| | "RPX_CORE_RPX_SESSION_LIFETIME" but found
| | "RPX_SESSION_LIFETIME"
47 | WARNING | [ ] Open page callback found, please add a comment before the
| | line why there is no access restriction
55 | WARNING | [ ] Open page callback found, please add a comment before the
| | line why there is no access restriction
149 | ERROR | [ ] Unnecessarily gendered language in a comment
179 | WARNING | [ ] Unused variable $mid.
212 | WARNING | [ ] Unused variable $mid.
235 | WARNING | [ ] Unused variable $mid.
259 | ERROR | [ ] All functions defined in a module file must be prefixed
| | with the module's name, found "rpx_user_register_submit"
| | but expected "rpx_core_rpx_user_register_submit"
291 | ERROR | [ ] The array declaration extends to column 142 (the limit is
| | 120). The array content should be split up over multiple
| | lines
339 | ERROR | [ ] All functions defined in a module file must be prefixed
| | with the module's name, found "_rpx_save_profile_picture"
| | but expected "rpx_core__rpx_save_profile_picture"
380 | ERROR | [x] Each PHP statement must be on a line by itself
383 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
400 | ERROR | [ ] All functions defined in a module file must be prefixed
| | with the module's name, found "_rpx_data_map" but
| | expected "rpx_core__rpx_data_map"
404 | ERROR | [ ] unserialize() is insecure unless allowed classes are
| | limited. Use a safe format like JSON or use the
| | allowed_classes option.
459 | ERROR | [ ] All functions defined in a module file must be prefixed
| | with the module's name, found "_rpx_mail_text" but
| | expected "rpx_core__rpx_mail_text"
553 | ERROR | [ ] All functions defined in a module file must be prefixed
| | with the module's name, found "_rpx_providers" but
| | expected "rpx_core__rpx_providers"
596 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
604 | ERROR | [ ] All functions defined in a module file must be prefixed
| | with the module's name, found
| | "_rpx_get_provider_machine_name" but expected
| | "rpx_core__rpx_get_provider_machine_name"
609 | ERROR | [x] Use null coalesce operator instead of ternary operator.
615 | ERROR | [ ] All functions defined in a module file must be prefixed
| | with the module's name, found "_rpx_token_url" but
| | expected "rpx_core__rpx_token_url"
616 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
619 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
642 | ERROR | [ ] All functions defined in a module file must be prefixed
| | with the module's name, found "_rpx_report_missing_field"
| | but expected "rpx_core__rpx_report_missing_field"
651 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
656 | ERROR | [ ] All functions defined in a module file must be prefixed
| | with the module's name, found "_rpx_import_user_data" but
| | expected "rpx_core__rpx_import_user_data"
751 | ERROR | [ ] unserialize() is insecure unless allowed classes are
| | limited. Use a safe format like JSON or use the
| | allowed_classes option.
762 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters
867 | ERROR | [ ] All functions defined in a module file must be prefixed
| | with the module's name, found "_rpx_profile_get_fields"
| | but expected "rpx_core__rpx_profile_get_fields"
913 | ERROR | [ ] All functions defined in a module file must be prefixed
| | with the module's name, found "_rpx_profile_format_value"
| | but expected "rpx_core__rpx_profile_format_value"
953 | ERROR | [ ] All functions defined in a module file must be prefixed
| | with the module's name, found
| | "_rpx_update_engage_mapping" but expected
| | "rpx_core__rpx_update_engage_mapping"
959 | ERROR | [x] Use null coalesce operator instead of ternary operator.
991 | ERROR | [ ] All functions defined in a module file must be prefixed
| | with the module's name, found
| | "_rpx_delete_engage_mapping" but expected
| | "rpx_core__rpx_delete_engage_mapping"
1012 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
1061 | ERROR | [ ] unserialize() is insecure unless allowed classes are
| | limited. Use a safe format like JSON or use the
| | allowed_classes option.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...erns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_core.install
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------
40 | WARNING | Line exceeds 80 characters; contains 87 characters
154 | ERROR | unserialize() is insecure unless allowed classes are limited.
| | Use a safe format like JSON or use the allowed_classes option.
--------------------------------------------------------------------------------
FILE: ...erns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_rules.module
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
15 | WARNING | Open page callback found, please add a comment before the line
| | why there is no access restriction
--------------------------------------------------------------------------------
FILE: ...erns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_ui.pages.inc
--------------------------------------------------------------------------------
FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------------
17 | ERROR | The array declaration extends to column 244 (the limit is
| | 120). The array content should be split up over multiple lines
122 | ERROR | The array declaration extends to column 168 (the limit is
| | 120). The array content should be split up over multiple lines
126 | WARNING | Line exceeds 80 characters; contains 83 characters
137 | WARNING | Line exceeds 80 characters; contains 81 characters
178 | WARNING | Line exceeds 80 characters; contains 86 characters
--------------------------------------------------------------------------------
FILE: ...erns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_ui.admin.inc
--------------------------------------------------------------------------------
FOUND 7 ERRORS AND 39 WARNINGS AFFECTING 46 LINES
--------------------------------------------------------------------------------
23 | WARNING | [ ] Translatable strings must not begin or end with white
| | spaces, use placeholders with t() for variables
40 | WARNING | [ ] All variables defined by your module must be prefixed
| | with your module's name to avoid name collisions with
| | others. Expected start with "rpx_ui" but found
| | "rpx_apikey"
59 | WARNING | [ ] All variables defined by your module must be prefixed
| | with your module's name to avoid name collisions with
| | others. Expected start with "rpx_ui" but found
| | "rpx_signin_string"
65 | WARNING | [ ] All variables defined by your module must be prefixed
| | with your module's name to avoid name collisions with
| | others. Expected start with "rpx_ui" but found
| | "rpx_accounts_string"
103 | WARNING | [ ] All variables defined by your module must be prefixed
| | with your module's name to avoid name collisions with
| | others. Expected start with "rpx_ui" but found
| | "rpx_attach_login_form"
104 | WARNING | [ ] Avoid backslash escaping in translatable strings when
| | possible, use "" quotes instead
117 | WARNING | [ ] All variables defined by your module must be prefixed
| | with your module's name to avoid name collisions with
| | others. Expected start with "rpx_ui" but found
| | "rpx_login_icons_size"
123 | WARNING | [ ] Avoid backslash escaping in translatable strings when
| | possible, use "" quotes instead
129 | WARNING | [ ] All variables defined by your module must be prefixed
| | with your module's name to avoid name collisions with
| | others. Expected start with "rpx_ui" but found
| | "rpx_login_links_weight"
130 | WARNING | [ ] Avoid backslash escaping in translatable strings when
| | possible, use "" quotes instead
136 | WARNING | [ ] All variables defined by your module must be prefixed
| | with your module's name to avoid name collisions with
| | others. Expected start with "rpx_ui" but found
| | "rpx_force_registration_form"
143 | WARNING | [ ] All variables defined by your module must be prefixed
| | with your module's name to avoid name collisions with
| | others. Expected start with "rpx_ui" but found
| | "rpx_extended_authinfo"
150 | WARNING | [ ] All variables defined by your module must be prefixed
| | with your module's name to avoid name collisions with
| | others. Expected start with "rpx_ui" but found
| | "rpx_import_profile_photo"
151 | WARNING | [ ] Avoid backslash escaping in translatable strings when
| | possible, use "" quotes instead
158 | WARNING | [ ] All variables defined by your module must be prefixed
| | with your module's name to avoid name collisions with
| | others. Expected start with "rpx_ui" but found
| | "rpx_javascript_global"
165 | WARNING | [ ] All variables defined by your module must be prefixed
| | with your module's name to avoid name collisions with
| | others. Expected start with "rpx_ui" but found
| | "rpx_openid_override"
181 | WARNING | [ ] All variables defined by your module must be prefixed
| | with your module's name to avoid name collisions with
| | others. Expected start with "rpx_ui" but found
| | "rpx_social_enabled"
197 | WARNING | [ ] All variables defined by your module must be prefixed
| | with your module's name to avoid name collisions with
| | others. Expected start with "rpx_ui" but found
| | "rpx_default_message_nodes"
203 | WARNING | [ ] All variables defined by your module must be prefixed
| | with your module's name to avoid name collisions with
| | others. Expected start with "rpx_ui" but found
| | "rpx_default_linktext_nodes"
209 | WARNING | [ ] All variables defined by your module must be prefixed
| | with your module's name to avoid name collisions with
| | others. Expected start with "rpx_ui" but found
| | "rpx_default_title_nodes"
215 | WARNING | [ ] All variables defined by your module must be prefixed
| | with your module's name to avoid name collisions with
| | others. Expected start with "rpx_ui" but found
| | "rpx_default_summary_nodes"
231 | WARNING | [ ] All variables defined by your module must be prefixed
| | with your module's name to avoid name collisions with
| | others. Expected start with "rpx_ui" but found
| | "rpx_default_message_comments"
237 | WARNING | [ ] All variables defined by your module must be prefixed
| | with your module's name to avoid name collisions with
| | others. Expected start with "rpx_ui" but found
| | "rpx_default_linktext_comments"
243 | WARNING | [ ] All variables defined by your module must be prefixed
| | with your module's name to avoid name collisions with
| | others. Expected start with "rpx_ui" but found
| | "rpx_default_title_comments"
249 | WARNING | [ ] All variables defined by your module must be prefixed
| | with your module's name to avoid name collisions with
| | others. Expected start with "rpx_ui" but found
| | "rpx_default_summary_comments"
273 | WARNING | [ ] Translatable strings must not begin or end with white
| | spaces, use placeholders with t() for variables
288 | WARNING | [ ] All variables defined by your module must be prefixed
| | with your module's name to avoid name collisions with
| | others. Expected start with "rpx_ui" but found
| | "rpx_bypass_email_verification"
442 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
444 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
445 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters
556 | ERROR | [x] Use null coalesce operator instead of ternary operator.
578 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters
622 | WARNING | [ ] Empty return statement not required here
756 | WARNING | [ ] Do not use DELETE queries with db_query(), use
| | db_delete() instead
804 | WARNING | [ ] Translatable strings must not begin or end with white
| | spaces, use placeholders with t() for variables
852 | WARNING | [ ] Avoid backslash escaping in translatable strings when
| | possible, use "" quotes instead
885 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
958 | ERROR | [ ] The array declaration extends to column 138 (the limit is
| | 120). The array content should be split up over multiple
| | lines
976 | WARNING | [ ] Empty return statement not required here
1046 | ERROR | [ ] The array declaration extends to column 121 (the limit is
| | 120). The array content should be split up over multiple
| | lines
1065 | ERROR | [x] Use null coalesce operator instead of ternary operator.
1079 | ERROR | [x] Use null coalesce operator instead of ternary operator.
1113 | ERROR | [ ] Unnecessarily gendered language in a comment
1125 | ERROR | [ ] The array declaration extends to column 143 (the limit is
| | 120). The array content should be split up over multiple
| | lines
1130 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters
1136 | WARNING | [ ] Unused variable $map.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...s/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_core.webapi.inc
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------------
12 | WARNING | The class short comment should describe what the class does
| | and not simply repeat the class name
13 | WARNING | Class name must be prefixed with the project name "RpxUi"
156 | WARNING | Line exceeds 80 characters; contains 82 characters
274 | ERROR | The array declaration extends to column 166 (the limit is
| | 120). The array content should be split up over multiple lines
--------------------------------------------------------------------------------
FILE: ...-v9/web/modules/contrib/rpx/views/rpx_ui_handler_filter_provider_title.inc
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
26 | WARNING | Unused variable $k.
--------------------------------------------------------------------------------
FILE: ...emo-site/drupal-orgissue-v9/web/modules/contrib/rpx/views/rpx_ui.views.inc
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
42 | WARNING | Avoid backslash escaping in translatable strings when possible,
| | use "" quotes instead
--------------------------------------------------------------------------------
FILE: ...l-orgissue-v9/web/modules/contrib/rpx/views/rpx_ui_handler_field_share.inc
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
7 | WARNING | @author tags are not usually used in Drupal, because over time
| | multiple contributors will touch the code anyway
--------------------------------------------------------------------------------
FILE: ...ssue-v9/web/modules/contrib/rpx/views/rpx_ui_handler_field_delete_link.inc
--------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------------
42 | ERROR | [x] Use null coalesce operator instead of ternary operator.
49 | ERROR | [x] Use null coalesce operator instead of ternary operator.
84 | WARNING | [ ] Unused variable $arg.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 2.55 secs; Memory: 30MBKindly check
Thanks,
Jake
Hi @urvashi_vora,
Applied the patch you provided, it was applied successfully, however, there are 2 errors remaining. Please see below:
➜ edit_and_save git:(8.x-1.x) curl https://www.drupal.org/files/issues/2022-07-16/coding-standards-fixed-2886679-7.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1157 100 1157 0 0 4630 0 --:--:-- --:--:-- --:--:-- 4861
patching file README.txt
patching file edit_and_save.info.yml
patching file src/Repository/EditAndSaveRepository.php
➜ edit_and_save git:(8.x-1.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig edit_and_save
FILE: ...v9/web/modules/contrib/edit_and_save/src/Form/EditAndSaveConfigureForm.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Form\ConfigFormBase.
153 | ERROR | [x] Use null coalesce operator instead of ternary operator.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 187ms; Memory: 10MBAnd as expected the MR!1 also have errors remaining, so moving this to Needs Work.
Kindly check
Thanks,
Jake
Hi @urvashi_vora,
Applied the patch you provided, it was applied successfully and confirmed no errors remaining.
➜ opigno_pretest_app git:(7.x-1.x) curl https://www.drupal.org/files/issues/2022-08-05/coding-standards-resolved-2709929-5.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 4691 100 4691 0 0 19748 0 --:--:-- --:--:-- --:--:-- 20665
patching file opigno_pretest_app.info
patching file opigno_pretest_app.install
patching file opigno_pretest_app.module
➜ opigno_pretest_app git:(7.x-1.x) ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig opigno_pretest_app
➜ contrib git:(master) ✗Will now move this to RTBC
Thanks,
Jake
Hi@everyone,
Applied the patch provided on comment #2, confirmed it can be applied successfully, however, one error still reported. Please see below:
➜ nouislider_widget git:(master) ✗ curl https://www.drupal.org/files/issues/2022-06-08/Line_exceeds_80_characters-3284610-1.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 799 100 799 0 0 2951 0 --:--:-- --:--:-- --:--:-- 3096
patching file README.md
➜ nouislider_widget git:(master) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig nouislider_widget
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/nouislider_widget/src/Plugin/Field/FieldWidget/NoUiSliderWidget.php
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\Plugin\Field\FieldWidget\NumberWidget.
-------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------
Time: 142ms; Memory: 10MBKindly check
Thanks,
Jake
Hi @himanshu_jhaloya,
Applied the patch you provided, but apparently, the reported errors were not the only phpcs errors, here are the errors reported by my terminal:
➜ iotapay git:(main) curl https://www.drupal.org/files/issues/2022-08-05/issue-fixed-3284808-2.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 3061 100 3061 0 0 12212 0 --:--:-- --:--:-- --:--:-- 12701
patching file iota_pay_donate.routing.yml
patching file src/Plugin/Block/iota_donate.php
patching file src/Plugin/Block/iota_pay.php
➜ iotapay git:(main) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig iotapay
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/iotapay/iota_pay_donate.routing.yml
---------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/iotapay/iota_pay_donate.info.yml
------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
5 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/iotapay/iota_pay_donate.links.menu.yml
------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/iotapay/templates/iota-pay.html.twig
----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/iotapay/iota_pay_donate.module
----------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
19 | ERROR | [x] Expected 1 newline at end of file; 4 found
22 | ERROR | [ ] More than 2 empty lines are not allowed
----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/iotapay/src/Form/ConfigForm.php
-----------------------------------------------------------------------------------------------------------
FOUND 77 ERRORS AFFECTING 66 LINES
-----------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Whitespace found at end of line
2 | ERROR | [x] Whitespace found at end of line
3 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
3 | ERROR | [x] Whitespace found at end of line
4 | ERROR | [x] Whitespace found at end of line
5 | ERROR | [x] Whitespace found at end of line
6 | ERROR | [x] Whitespace found at end of line
7 | ERROR | [x] Whitespace found at end of line
8 | ERROR | [x] Whitespace found at end of line
9 | ERROR | [x] Whitespace found at end of line
10 | ERROR | [x] Whitespace found at end of line
11 | ERROR | [x] Whitespace found at end of line
12 | ERROR | [x] Whitespace found at end of line
13 | ERROR | [x] Missing class doc comment
13 | ERROR | [x] Whitespace found at end of line
14 | ERROR | [x] Whitespace found at end of line
15 | ERROR | [x] Whitespace found at end of line
16 | ERROR | [x] Whitespace found at end of line
17 | ERROR | [x] Expected 1 blank line before function; 0 found
17 | ERROR | [x] Whitespace found at end of line
18 | ERROR | [x] Whitespace found at end of line
19 | ERROR | [x] Whitespace found at end of line
20 | ERROR | [x] Whitespace found at end of line
21 | ERROR | [x] Whitespace found at end of line
22 | ERROR | [x] Whitespace found at end of line
23 | ERROR | [x] Whitespace found at end of line
24 | ERROR | [x] Whitespace found at end of line
25 | ERROR | [x] Whitespace found at end of line
26 | ERROR | [x] Whitespace found at end of line
27 | ERROR | [x] Whitespace found at end of line
28 | ERROR | [x] Whitespace found at end of line
30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
30 | ERROR | [x] Whitespace found at end of line
31 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
31 | ERROR | [x] Whitespace found at end of line
32 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
32 | ERROR | [x] Whitespace found at end of line
33 | ERROR | [x] Whitespace found at end of line
34 | ERROR | [x] Whitespace found at end of line
35 | ERROR | [x] Whitespace found at end of line
36 | ERROR | [x] Whitespace found at end of line
37 | ERROR | [x] Whitespace found at end of line
38 | ERROR | [x] Whitespace found at end of line
39 | ERROR | [x] Whitespace found at end of line
40 | ERROR | [x] Whitespace found at end of line
41 | ERROR | [x] Whitespace found at end of line
43 | ERROR | [x] Whitespace found at end of line
44 | ERROR | [x] Whitespace found at end of line
46 | ERROR | [x] Whitespace found at end of line
47 | ERROR | [x] Whitespace found at end of line
48 | ERROR | [x] Whitespace found at end of line
49 | ERROR | [x] Whitespace found at end of line
51 | ERROR | [x] Whitespace found at end of line
52 | ERROR | [x] Whitespace found at end of line
53 | ERROR | [x] Whitespace found at end of line
54 | ERROR | [x] Whitespace found at end of line
56 | ERROR | [x] Whitespace found at end of line
57 | ERROR | [x] Whitespace found at end of line
58 | ERROR | [x] Whitespace found at end of line
59 | ERROR | [x] Whitespace found at end of line
61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
61 | ERROR | [x] Whitespace found at end of line
62 | ERROR | [x] Expected 5 space(s) before asterisk; 3 found
62 | ERROR | [x] Whitespace found at end of line
63 | ERROR | [x] Expected 5 space(s) before asterisk; 3 found
63 | ERROR | [x] Whitespace found at end of line
64 | ERROR | [x] Whitespace found at end of line
65 | ERROR | [x] Whitespace found at end of line
66 | ERROR | [x] Whitespace found at end of line
67 | ERROR | [x] Whitespace found at end of line
68 | ERROR | [x] Whitespace found at end of line
71 | ERROR | [x] Whitespace found at end of line
72 | ERROR | [x] Whitespace found at end of line
73 | ERROR | [x] Whitespace found at end of line
75 | ERROR | [ ] Closing class brace must be on a line by itself
75 | ERROR | [x] Expected 1 newline at end of file; 0 found
75 | ERROR | [x] Whitespace found at end of line
-----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 76 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/iotapay/src/Plugin/Block/iota_donate.php
--------------------------------------------------------------------------------------------------------------------
FOUND 15 ERRORS AFFECTING 14 LINES
--------------------------------------------------------------------------------------------------------------------
17 | ERROR | [ ] Class name must begin with a capital letter
17 | ERROR | [ ] Class name must use UpperCamel naming without underscores
20 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found
21 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found
22 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found
23 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found
27 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found
28 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found
29 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found
30 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found
31 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found
41 | ERROR | [x] Whitespace found at end of line
45 | ERROR | [x] Whitespace found at end of line
51 | ERROR | [x] Whitespace found at end of line
53 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 13 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/iotapay/src/Plugin/Block/iota_pay.php
-----------------------------------------------------------------------------------------------------------------
FOUND 13 ERRORS AFFECTING 11 LINES
-----------------------------------------------------------------------------------------------------------------
17 | ERROR | [ ] Class name must begin with a capital letter
17 | ERROR | [ ] Class name must use UpperCamel naming without underscores
26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
27 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
28 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
29 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
30 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
31 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
44 | ERROR | [x] Whitespace found at end of line
47 | ERROR | [x] Whitespace found at end of line
50 | ERROR | [x] Expected 1 blank line after function; 0 found
50 | ERROR | [x] Whitespace found at end of line
51 | ERROR | [x] The closing brace for the class must have an empty line before it
-----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 11 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------
Time: 146ms; Memory: 10MBKindly check
Thanks,
Jake
Hi @jaydev bhatt,
Applied the changes committed on MR!1, it was applied successfully, it fixed most errors, however, one error still reported. Please see below:
➜ architects_zymphonies_theme git:(master) ✗ curl https://git.drupalcode.org/project/architects_zymphonies_theme/-/merge_requests/1.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 135k 0 135k 0 0 349k 0 --:--:-- --:--:-- --:--:-- 360k
patching file architects_zymphonies_theme.libraries.yml
patching file architects_zymphonies_theme.theme
patching file config/install/architects_zymphonies_theme.settings.yml
patching file config/optional/block.block.architects_zymphonies_theme_page_title.yml
patching file css/global.css
patching file css/media.css
patching file includes/fontawesome/css/fontawesome-all.css
patching file includes/owl/assets/owl.carousel.css
patching file includes/smartmenus/sm-core-css.css
➜ architects_zymphonies_theme git:(master) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig architects_zymphonies_theme
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/themes/contrib/architects_zymphonies_theme/templates/layout/page.html.twig
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------
500 | ERROR | [x] Expected 1 newline at end of file; 3 found
--------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------
Time: 720ms; Memory: 24MBKindly check
Thanks,
Jake
Hi @everyone,
Applied patch provided by comment #2, it was applied successfully and confirmed it fixed the reported errors.
➜ ckeditor_entity_link git:(master) ✗ curl https://www.drupal.org/files/issues/2023-01-13/drupal-coding-standard-3333258-2.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1864 100 1864 0 0 2312 0 --:--:-- --:--:-- --:--:-- 2359
patching file js/plugins/entitylink/plugin.js
➜ ckeditor_entity_link git:(master) ✗ ..
➜ contrib git:(master) ✗ cd ckeditor_entity_link
➜ ckeditor_entity_link git:(master) ✗Will now move this to RTBC
Thanks,
Jake
Hi @ptmkenny,
Applied the latest changes committed on MR!13, it was applied successfully on my local, but there are still errors reported aside from dependency injection. Please see below:
➜ consumer_image_styles git:(4.x) curl https://git.drupalcode.org/project/consumer_image_styles/-/merge_requests/13.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 10311 0 10311 0 0 33997 0 --:--:-- --:--:-- --:--:-- 35555
patching file consumer_image_styles.module
patching file src/ImageStylesProvider.php
patching file src/ImageStylesProviderInterface.php
patching file src/Normalizer/LinkCollectionNormalizer.php
patching file src/Plugin/jsonapi/FieldEnhancer/ImageStyles.php
patching file tests/src/Functional/ConsumerImageSylesFunctionalTest.php
➜ consumer_image_styles git:(4.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig consumer_image_styles
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/consumer_image_styles/src/Plugin/jsonapi/FieldEnhancer/ImageStyles.php
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------
52 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
249 | WARNING | [ ] ImageStyle::loadMultiple calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/consumer_image_styles/src/Normalizer/LinkCollectionNormalizer.php
---------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\consumer_image_styles\ImageStylesProviderInterface.
---------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/consumer_image_styles/src/ImageStylesProvider.php
------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 3 WARNINGS AFFECTING 5 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------------
13 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StreamWrapper\StreamWrapperInterface.
74 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
80 | WARNING | [ ] The deprecation-version '4.0.6' does not match the lower-case machine-name standard: drupal:n.n.n or project:n.x-n.n or
| | project:n.x-n.n-label[n] or project:n.n.n or project:n.n.n-label[n]
80 | WARNING | [ ] The removal-version '5.0' does not match the lower-case machine-name standard: drupal:n.n.n or project:n.x-n.n or
| | project:n.x-n.n-label[n] or project:n.n.n or project:n.n.n-label[n]
81 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
114 | ERROR | [ ] The trigger_error message 'Calling %s without $cacheable_metadata is deprecated in 4.0.6; it is required in 5.0.' does not match the
| | relaxed standard format: %thing% is deprecated in %deprecation-version% any free text %removal-version%. %extra-info%. See %cr-link%
------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------------
Time: 404ms; Memory: 12MBKindly check
Thanks,
Jake
Hi @everyone,
Applied the commit made on MR!1 that I guess was from the patch, it was applied not-so successfully that might be the reason one error was still reported. Please see below:
➜ block_country git:(master) ✗ curl https://git.drupalcode.org/project/block_country/-/merge_requests/1.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 3462 0 3462 0 0 9755 0 --:--:-- --:--:-- --:--:-- 10182
patching file README.txt
patching file block_country.info.yml
Hunk #1 FAILED at 2.
1 out of 1 hunk FAILED -- saving rejects to file block_country.info.yml.rej
patching file src/Plugin/Condition/BlockCountry.php
➜ block_country git:(master) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig block_country
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/block_country/src/Plugin/Condition/BlockCountry.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
11 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Cache\Cache.
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------
Time: 191ms; Memory: 10MBHi @kunal_sahu,
Applied the changes you committed on MR!2, it was applied successfully, however there are still few errors reported. Please see below:
➜ image_style_quality git:(main) ✗ curl https://git.drupalcode.org/project/image_style_quality/-/merge_requests/2.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 4275 0 4275 0 0 14507 0 --:--:-- --:--:-- --:--:-- 15159
patching file README.txt
patching file src/MutableQualityToolkitManager.php
patching file src/Plugin/ImageEffect/ImageStyleQualityImageEffect.php
patching file tests/src/Kernel/ImageStyleQualityTest.php
➜ image_style_quality git:(main) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig image_style_quality
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/image_style_quality/README.txt
-------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
36 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/image_style_quality/src/Plugin/ImageEffect/ImageStyleQualityImageEffect.php
----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface.
----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------
Time: 182ms; Memory: 10MBKindly check
Thanks,
Jake
Hi @elber,
Applied the latest changes made on MR!2, it was applied successfully but one file with 2 errors were still reported. Please see below:
➜ shortcut_menu git:(main) ✗ curl https://git.drupalcode.org/project/shortcut_menu/-/merge_requests/2.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 3125 0 3125 0 0 6552 0 --:--:-- --:--:-- --:--:-- 6706
patching file shortcut_menu.install
patching file src/Form/ShortcutMenuSetCustomize.php
patching file src/ShortcutMenuLazyBuilder.php
➜ shortcut_menu git:(main) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig shortcut_menu
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/shortcut_menu/src/Form/ShortcutMenuSetCustomize.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------
177 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
196 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------
Time: 266ms; Memory: 10MBKindly check
Thanks,
Jake
Hi @Rassoni,
Applied the latest changes you committed on MR!16, it was applied not-so successfully and one file with 7 errors were reported. Please see below:
➜ views_filters_summary git:(2.0.x) curl https://git.drupalcode.org/project/views_filters_summary/-/merge_requests/16.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 6973 0 6973 0 0 20567 0 --:--:-- --:--:-- --:--:-- 21655
patching file README.txt
patching file css/views_filters_summary.css
patching file src/Plugin/views/area/ViewsFiltersSummary.php
Hunk #6 succeeded at 460 (offset 1 line).
Hunk #7 succeeded at 507 (offset 1 line).
Hunk #8 succeeded at 538 (offset 1 line).
Hunk #9 succeeded at 559 (offset 2 lines).
Hunk #10 succeeded at 577 (offset 2 lines).
Hunk #11 succeeded at 621 (offset 2 lines).
patching file views_filters_summary.module
➜ views_filters_summary git:(2.0.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig views_filters_summary
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/views_filters_summary/src/Plugin/views/area/ViewsFiltersSummary.php
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 7 LINES
--------------------------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Render\MarkupInterface.
70 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
85 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
129 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
344 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
380 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
609 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
--------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------
Time: 273ms; Memory: 14MBKindly check
Thanks,
Jake
The reported Problem/Motivation aren't the only phpcs errors that was thrown. Please see below:
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig term_reference_fancytree
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/term_reference_fancytree/term_reference_fancytree.install
----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/term_reference_fancytree/docs/how-it-works.md
----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 10 WARNINGS AFFECTING 10 LINES
----------------------------------------------------------------------------------------------------------------------
5 | WARNING | Line exceeds 80 characters; contains 121 characters
8 | WARNING | Line exceeds 80 characters; contains 132 characters
18 | WARNING | Line exceeds 80 characters; contains 170 characters
25 | WARNING | Line exceeds 80 characters; contains 186 characters
31 | WARNING | Line exceeds 80 characters; contains 118 characters
35 | WARNING | Line exceeds 80 characters; contains 126 characters
41 | WARNING | Line exceeds 80 characters; contains 110 characters
43 | WARNING | Line exceeds 80 characters; contains 110 characters
45 | WARNING | Line exceeds 80 characters; contains 254 characters
49 | WARNING | Line exceeds 80 characters; contains 156 characters
----------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/term_reference_fancytree/docs/index.md
---------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 5 WARNINGS AFFECTING 6 LINES
---------------------------------------------------------------------------------------------------------------
5 | WARNING | [ ] Line exceeds 80 characters; contains 147 characters
9 | WARNING | [ ] Line exceeds 80 characters; contains 156 characters
11 | WARNING | [ ] Line exceeds 80 characters; contains 178 characters
13 | WARNING | [ ] Line exceeds 80 characters; contains 174 characters
17 | WARNING | [ ] Line exceeds 80 characters; contains 173 characters
38 | ERROR | [x] Expected 1 newline at end of file; 2 found
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/term_reference_fancytree/readme.md
-----------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 7 WARNINGS AFFECTING 8 LINES
-----------------------------------------------------------------------------------------------------------
5 | WARNING | [ ] Line exceeds 80 characters; contains 147 characters
9 | WARNING | [ ] Line exceeds 80 characters; contains 156 characters
11 | WARNING | [ ] Line exceeds 80 characters; contains 178 characters
13 | WARNING | [ ] Line exceeds 80 characters; contains 174 characters
17 | WARNING | [ ] Line exceeds 80 characters; contains 173 characters
34 | WARNING | [ ] Line exceeds 80 characters; contains 121 characters
37 | WARNING | [ ] Line exceeds 80 characters; contains 132 characters
42 | ERROR | [x] Expected 1 newline at end of file; 2 found
-----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/term_reference_fancytree/src/Plugin/Field/FieldWidget/TreeWidget.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 4 WARNINGS AFFECTING 10 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\FieldItemListInterface.
60 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
61 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
62 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
63 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
64 | ERROR | [x] Array closing indentation error, expected 4 spaces but found 6
95 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
99 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
100 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
101 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/term_reference_fancytree/src/Element/TermReferenceFancytree.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Utility\Html.
159 | WARNING | [x] '@Todo check if we need this.' should match the format '@todo Fix problem X here.'
271 | WARNING | [x] The variable name should be defined after the type
273 | ERROR | [x] Expected one space after the comma, 0 found
----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/term_reference_fancytree/src/Controller/SubTreeController.php
---------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\term_reference_fancytree\Element\TermReferenceFancytree.
---------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------------
Time: 295ms; Memory: 12MBKindly check
Thanks,
Jake
Hi @everyone,
Applied the patch that was provided on comments #2, confirmed it fixed the errors reported. Please see below:
➜ disable_user_view git:(2.0.x) curl https://www.drupal.org/files/issues/2023-03-22/3349517-2.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1003 100 1003 0 0 2650 0 --:--:-- --:--:-- --:--:-- 2725
patching file README.md
patching file disable_user_view.services.yml
➜ disable_user_view git:(2.0.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig disable_user_view
➜ contrib git:(main) ✗Will now move this to RTBC
Thanks,
Jake
Hi @Rassoni,
I have applied the changes you committed on MR!2, some errors were still reported. Please see below:
➜ content_moderation_node_grants git:(1.0.x) curl https://git.drupalcode.org/project/content_moderation_node_grants/-/merge_requests/2.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 881 0 881 0 0 3029 0 --:--:-- --:--:-- --:--:-- 3157
patching file src/Plugin/views/filter/UpdatableFilter.php
➜ content_moderation_node_grants git:(1.0.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig content_moderation_node_grants
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/content_moderation_node_grants/content_moderation_node_grants.module
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------
11 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Utility\Html.
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/content_moderation_node_grants/content_moderation_node_grants.node_grants.inc
------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------
13 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Session\AccountInterface.
------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------
Time: 224ms; Memory: 10MBKindly check
Thanks,
Jake
Hi @everyone,
The patch provided on the the comments #2 cannot be applied. Please see:
➜ cache_alter git:(8.x-1.x) ✗ curl https://www.drupal.org/files/issues/2023-03-23/3349799-2.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1464 100 1464 0 0 17447 0 --:--:-- --:--:-- --:--:-- 19263
patching file README.md
Hunk #1 FAILED at 10.
1 out of 1 hunk FAILED -- saving rejects to file README.md.rej
patching file src/StackMiddleware/ClearRequest.php
Hunk #1 succeeded at 50 with fuzz 2 (offset 2 lines).
➜ cache_alter git:(8.x-1.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig cache_alter
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/cache_alter/README.md
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
----------------------------------------------------------------------------------------------
7 | WARNING | Line exceeds 80 characters; contains 123 characters
9 | WARNING | Line exceeds 80 characters; contains 86 characters
20 | WARNING | Line exceeds 80 characters; contains 88 characters
23 | WARNING | Line exceeds 80 characters; contains 208 characters
38 | WARNING | Line exceeds 80 characters; contains 88 characters
40 | WARNING | Line exceeds 80 characters; contains 214 characters
----------------------------------------------------------------------------------------------
Time: 148ms; Memory: 10MBKindly check
Thanks,
Jake
Hi @Rassoni,
The changes you made on MR!2 can be applied successfully, but there are still errors reported. Please see below:
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig m4032404
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/m4032404/tests/src/Unit/EventSubscriber/M4032404EventSubscriberTest.php
---------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\m4032404\EventSubscriber\M4032404EventSubscriber.
---------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/m4032404/tests/src/Functional/M4032404TestCaseTest.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------
18 | ERROR | [x] Whitespace found at end of line
----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/m4032404/src/EventSubscriber/M4032404EventSubscriber.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactoryInterface.
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------
Time: 182ms; Memory: 10MBPlease check
Thanks,
Jake
Hi @mukesh88,
Applied the changes you committed on MR!13, it was not applied smoothly but surprisingly, no errors reported and confirmed the feedback from comment #6 was addressed.
➜ edit_profiles_perms git:(1.0.x) ✗ curl https://git.drupalcode.org/project/edit_profiles_perms/-/merge_requests/3.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 2124 0 2124 0 0 7305 0 --:--:-- --:--:-- --:--:-- 7505
patching file src/EditProfilesPermsAccessHandler.php
patching file src/EditProfilesPermsPermissions.php
patching file tests/modules/edit_profiles_perms_test/edit_profiles_perms_test.info.yml
Hunk #1 succeeded at 4 with fuzz 1.
➜ edit_profiles_perms git:(1.0.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig edit_profiles_perms
➜ contrib git:(master) ✗Will now move this to RTBC
Thanks,
Jake
Hi @himanshu_jhaloya,
Besides the feedback of comment #5, these are also the unfixed errors of the changes you commited on MR!7. Please see:
➜ layout_paragraphs_toggle_publish git:(1.x) curl https://git.drupalcode.org/project/layout_paragraphs_toggle_publish/-/merge_requests/7.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 3595 0 3595 0 0 12086 0 --:--:-- --:--:-- --:--:-- 12569
patching file README.md
patching file layout_paragraphs_toggle_publish.module
patching file src/Controller/TogglePublish.php
Hunk #4 FAILED at 84.
1 out of 4 hunks FAILED -- saving rejects to file src/Controller/TogglePublish.php.rej
➜ layout_paragraphs_toggle_publish git:(1.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig layout_paragraphs_toggle_publish
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/layout_paragraphs_toggle_publish/layout_paragraphs_toggle_publish.module
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
11 | WARNING | Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements
| | hook_foo_BAR_ID_bar() for block templates."
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/layout_paragraphs_toggle_publish/src/Controller/TogglePublish.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AND 1 WARNING AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Ajax\InvokeCommand.
33 | ERROR | [ ] Only one @var tag is allowed in a member variable comment
39 | ERROR | [ ] Missing member variable doc comment
88 | ERROR | [ ] Comment indentation error, expected only 1 spaces
88 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
90 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------
Time: 152ms; Memory: 10MBKindly check
Thanks,
Jake
Hi @urvashi_vora,
After applying your patch, there are more than errors reported by my terminal than what you reported. Please see below:
➜ imageapi_optimize git:(8.x-2.x) curl https://www.drupal.org/files/issues/2022-06-24/coding-standard-fix-3067484-5.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 45915 100 45915 0 0 145k 0 --:--:-- --:--:-- --:--:-- 150k
patching file README.md
patching file imageapi_optimize.api.php
patching file imageapi_optimize.info.yml
patching file imageapi_optimize.install
patching file imageapi_optimize.module
patching file src/Annotation/ImageAPIOptimizeProcessor.php
patching file src/Entity/ImageAPIOptimizePipeline.php
patching file src/Entity/ImageStyleWithPipeline.php
patching file src/Exception/PluginNotFoundException.php
patching file src/Form/ImageAPIOptimizeDefaultPipelineConfigForm.php
patching file src/Form/ImageAPIOptimizePipelineDeleteForm.php
patching file src/Form/ImageAPIOptimizePipelineEditForm.php
patching file src/Form/ImageAPIOptimizeProcessorDeleteForm.php
patching file src/Form/ImageAPIOptimizeProcessorFormBase.php
patching file src/ImageAPIOptimizeHookImplementations.php
patching file src/ImageAPIOptimizePipelineInterface.php
patching file src/ImageAPIOptimizePipelineListBuilder.php
patching file src/ImageAPIOptimizePipelineStorage.php
patching file src/ImageAPIOptimizePipelineStorageInterface.php
patching file src/ImageAPIOptimizeProcessorBase.php
patching file src/ImageAPIOptimizeProcessorInterface.php
patching file src/ImageAPIOptimizeProcessorPluginCollection.php
patching file tests/module/imageapi_optimize_module_test/src/Plugin/ImageAPIOptimizeProcessor/TestProcessorAppendCharacters.php
patching file tests/module/imageapi_optimize_module_test/src/Plugin/ImageAPIOptimizeProcessor/TestProcessorBlackPNG.php
patching file tests/module/imageapi_optimize_module_test/src/Plugin/ImageAPIOptimizeProcessor/TestProcessorFailedGreenPNG.php
patching file tests/src/Functional/FileMoveTest.php
patching file tests/src/Functional/ImageAdminStylesTest.php
patching file tests/src/Functional/ImageDimensionsTest.php
patching file tests/src/Functional/ImageEffectsTest.php
patching file tests/src/Functional/ImageFieldDefaultImagesTest.php
patching file tests/src/Functional/ImageFieldDisplayTest.php
patching file tests/src/Functional/ImageFieldValidateTest.php
patching file tests/src/Functional/ImageFieldWidgetTest.php
patching file tests/src/Functional/ImageOnTranslatedEntityTest.php
patching file tests/src/Functional/ImageStyleDeleteTest.php
patching file tests/src/Functional/ImageStyleFlushTest.php
patching file tests/src/Functional/ImageStylesPathAndUrlTest.php
patching file tests/src/Functional/QuickEditImageControllerTest.php
patching file tests/src/Functional/Update/ImageUpdateTest.php
patching file tests/src/FunctionalJavascript/ImageAdminStylesTest.php
patching file tests/src/FunctionalJavascript/ImageFieldValidateTest.php
patching file tests/src/FunctionalJavascript/QuickEditImageTest.php
patching file tests/src/Kernel/ImageFormatterTest.php
patching file tests/src/Kernel/ImageImportTest.php
patching file tests/src/Kernel/ImageItemTest.php
patching file tests/src/Kernel/ImageOptimizePipelineTest.php
patching file tests/src/Kernel/ImageStyleCustomStreamWrappersTest.php
patching file tests/src/Kernel/ImageStyleIntegrationTest.php
patching file tests/src/Kernel/ImageThemeFunctionTest.php
patching file tests/src/Kernel/Migrate/d6/MigrateImageCacheTest.php
patching file tests/src/Kernel/Migrate/d7/MigrateImageSettingsTest.php
patching file tests/src/Kernel/Migrate/d7/MigrateImageStylesTest.php
patching file tests/src/Kernel/Views/ImageViewsDataTest.php
patching file tests/src/Kernel/Views/RelationshipUserImageDataTest.php
➜ imageapi_optimize git:(8.x-2.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig imageapi_optimize
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/imageapi_optimize/imageapi_optimize.install
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\imageapi_optimize\Entity\ImageAPIOptimizePipeline.
--------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/imageapi_optimize/src/ImageStyleWithPipelineListBuilder.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
38 | ERROR | [x] Use null coalesce operator instead of ternary operator.
---------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/imageapi_optimize/src/Form/ImageAPIOptimizeProcessorAddForm.php
-----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\imageapi_optimize\ImageAPIOptimizePipelineInterface.
56 | ERROR | [ ] Protected method name "ImageAPIOptimizeProcessorAddForm::prepareImageAPIOptimizeProcessor" is not in lowerCamel format
-----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/imageapi_optimize/src/Form/ImageAPIOptimizeProcessorEditForm.php
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------
28 | ERROR | Protected method name "ImageAPIOptimizeProcessorEditForm::prepareImageAPIOptimizeProcessor" is not in lowerCamel format
--------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/imageapi_optimize/src/Form/ImageAPIOptimizePipelineEditForm.php
-------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------
145 | ERROR | [x] Use null coalesce operator instead of ternary operator.
-------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/imageapi_optimize/src/Form/ImageAPIOptimizeProcessorFormBase.php
-----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Plugin\Exception\PluginNotFoundException.
146 | ERROR | [ ] Protected method name "ImageAPIOptimizeProcessorFormBase::prepareImageAPIOptimizeProcessor" is not in lowerCamel format
-----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/imageapi_optimize/src/ImageAPIOptimizeProcessorPluginCollection.php
-----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------
18 | WARNING | Possible useless method overriding detected
-----------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/imageapi_optimize/src/Entity/ImageAPIOptimizePipeline.php
-------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------
12 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\imageapi_optimize\ImageAPIOptimizeProcessorInterface.
140 | ERROR | [ ] Protected method name "ImageAPIOptimizePipeline::replaceImageAPIOptimizePipeline" is not in lowerCamel format
268 | ERROR | [ ] Public method name "ImageAPIOptimizePipeline::getReplacementID" is not in lowerCamel format
295 | ERROR | [ ] Protected method name "ImageAPIOptimizePipeline::getImageAPIOptimizeProcessorPluginManager" is not in lowerCamel format
-------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/imageapi_optimize/src/ImageAPIOptimizePipelineStorage.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
37 | ERROR | [x] Use null coalesce operator instead of ternary operator.
-------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/imageapi_optimize/src/ImageAPIOptimizePipelineInterface.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
24 | ERROR | Public method name "ImageAPIOptimizePipelineInterface::getReplacementID" is not in lowerCamel format
---------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/imageapi_optimize/src/ImageAPIOptimizeHookImplementations.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
29 | ERROR | Public method name "ImageAPIOptimizeHookImplementations::entity_type_alter" is not in lowerCamel format
44 | ERROR | Public method name "ImageAPIOptimizeHookImplementations::form_image_style_edit_form_alter" is not in lowerCamel format
59 | ERROR | Public method name "ImageAPIOptimizeHookImplementations::config_schema_info_alter" is not in lowerCamel format
-----------------------------------------------------------------------------------------------------------------------------------------
Kindly check and work on it.
Thanks,
Jake
Hi @Soham Sengupta,
After applying the patch you provided, new errors/warnings were reported. Please see:
➜ commerce_promo_bar git:(1.0.x) curl https://www.drupal.org/files/issues/2023-05-06/3358410-7.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 7142 100 7142 0 0 18387 0 --:--:-- --:--:-- --:--:-- 18794
patching file README.md
Hunk #2 FAILED at 33.
1 out of 2 hunks FAILED -- saving rejects to file README.md.rej
patching file commerce_promo_bar.info.yml
patching file commerce_promo_bar.module
Reversed (or previously applied) patch detected! Assume -R? [n] y
Hunk #1 succeeded at 36 (offset 1 line).
Hunk #2 succeeded at 66 (offset 2 lines).
patching file css/promo_bar.form.css
patching file src/Event/PromoBarEvents.php
Hunk #1 FAILED at 2.
1 out of 1 hunk FAILED -- saving rejects to file src/Event/PromoBarEvents.php.rej
patching file src/Plugin/Block/PromoBarBlock.php
Hunk #1 succeeded at 15 (offset 3 lines).
Hunk #2 succeeded at 53 with fuzz 1.
Hunk #3 FAILED at 74.
Hunk #4 FAILED at 96.
Hunk #5 FAILED at 138.
3 out of 5 hunks FAILED -- saving rejects to file src/Plugin/Block/PromoBarBlock.php.rej
patching file templates/commerce-promo-bar.html.twig
Hunk #1 FAILED at 34.
1 out of 1 hunk FAILED -- saving rejects to file templates/commerce-promo-bar.html.twig.rej
➜ commerce_promo_bar git:(1.0.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig commerce_promo_bar
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/commerce_promo_bar/README.md
--------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------
36 | WARNING | Line exceeds 80 characters; contains 84 characters
37 | WARNING | Line exceeds 80 characters; contains 81 characters
--------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/commerce_promo_bar/commerce_promo_bar.module
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------
39 | WARNING | [ ] Line exceeds 80 characters; contains 91 characters
45 | ERROR | [x] Data types in @var tags need to be fully namespaced
69 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/commerce_promo_bar/templates/commerce-promo-bar.html.twig
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
38 | ERROR | [x] Expected 1 newline at end of file; 2 found
-------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------
Time: 638ms; Memory: 14MBKindly check
Thanks,
Jake
Hi @sidharth_soman,
These are the issues reported after MR!1 was merged (I was not the one who merged it). Please see below:
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig fun_fact_quiz
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/fun_fact_quiz/README.md
---------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------
3 | WARNING | Line exceeds 80 characters; contains 128 characters
5 | WARNING | Line exceeds 80 characters; contains 92 characters
25 | WARNING | Line exceeds 80 characters; contains 111 characters
27 | WARNING | Line exceeds 80 characters; contains 123 characters
29 | WARNING | Line exceeds 80 characters; contains 89 characters
---------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/fun_fact_quiz/src/Form/AddQuestionForm.php
----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 7 WARNINGS AFFECTING 8 LINES
----------------------------------------------------------------------------------------------------------------------
14 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
31 | WARNING | Line exceeds 80 characters; contains 81 characters
33 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
38 | ERROR | Comment indentation error, expected only 1 spaces
82 | WARNING | Line exceeds 80 characters; contains 86 characters
110 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
124 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
144 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/fun_fact_quiz/src/Form/ListQuestionsForm.php
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormBase.
14 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
49 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/fun_fact_quiz/src/Controller/FunFactQuizController.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | Doc comment is empty
12 | ERROR | Doc comment is empty
17 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
61 | WARNING | Line exceeds 80 characters; contains 90 characters
----------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/fun_fact_quiz/src/Controller/QuizController.php
---------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
---------------------------------------------------------------------------------------------------------------------------
8 | ERROR | Doc comment is empty
13 | ERROR | Doc comment is empty
48 | WARNING | Unused variable $table.
---------------------------------------------------------------------------------------------------------------------------
Time: 240ms; Memory: 10MBKindly check
Thanks,
Jake
Hi @everyone,
Applied the patch provided on the comment #15, it was applied smoothly but there are still errors reported. Please see below:
➜ privacy_docs_world_map git:(1.0.x) curl https://www.drupal.org/files/issues/2023-05-08/3318479-14-fix-cs-errors.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 21449 100 21449 0 0 54597 0 --:--:-- --:--:-- --:--:-- 56296
patching file privacy_docs_world_map.info.yml
patching file privacy_docs_world_map.module
patching file script/node_edit.js
patching file script/privacy_documents.js
patching file src/Controller/LoadDocumentsDataController.php
patching file src/Form/WorldMapConfigSettingsForm.php
patching file style/jqvmap.css
patching file style/privacy_documents.css
patching file templates/privacy_docs_world_map_block.html.twig
➜ privacy_docs_world_map git:(1.0.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig privacy_docs_world_map
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/privacy_docs_world_map/privacy_docs_world_map.module
----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Routing\RouteMatchInterface.
----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/privacy_docs_world_map/src/Plugin/Block/PrivacyDoucmentsWorldMapBlock.php
-----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactoryInterface.
-----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/privacy_docs_world_map/src/Controller/LoadDocumentsDataController.php
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Controller\ControllerBase.
-------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------
Time: 209ms; Memory: 10MBKindly check
Thanks,
Jake
Hi @sidhatyh_soman,
Applied the changes you committed on MR!, it was applied successfully, however, multiple errors were still reported. Please see below:
Application of MR
➜ xls_views_data_export git:(3.0.x) curl https://git.drupalcode.org/project/xls_views_data_export/-/merge_requests/3.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 36746 0 36746 0 0 79787 0 --:--:-- --:--:-- --:--:-- 82022
patching file src/EventSubscriber/ExportRedirectSubscriber.php
patching file src/Form/XlsExportForm.php
patching file src/Plugin/views/display/XlsDataExport.php
patching file xls_views_data_export.install
patching file xls_views_data_export.module
patching file xls_views_data_export.services.ymlReported Errors (These are not all, my terminal cut it because it was too many)
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/ViewsData/PageViewsData.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Missing class doc comment
10 | ERROR | [x] Opening brace should be on the same line as the declaration
-----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Normalizer/ParagraphFieldNormalizer.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 52 ERRORS AFFECTING 42 LINES
-----------------------------------------------------------------------------------------------------------------------------------
13 | ERROR | [x] Opening brace should be on the same line as the declaration
14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
14 | ERROR | [ ] Missing member variable doc comment
16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
16 | ERROR | [ ] Missing short description in doc comment
19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
24 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
25 | ERROR | [x] Opening brace should be on the same line as the declaration
26 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
28 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
29 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
30 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
32 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
33 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
34 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
36 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
38 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
39 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
40 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
42 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
44 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
45 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
46 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
46 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
47 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
49 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
50 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
51 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
52 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
53 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
55 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
55 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
56 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
58 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8
59 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
60 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
63 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8
65 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8
65 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
65 | ERROR | [x] Use null coalesce operator instead of ternary operator.
66 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
68 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
68 | ERROR | [ ] Missing short description in doc comment
69 | ERROR | [x] Parameter comment must be on the next line
69 | ERROR | [x] Parameter comment must end with a full stop
71 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
72 | ERROR | [x] Opening brace should be on the same line as the declaration
73 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
74 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
74 | ERROR | [x] Expected 1 blank line after function; 0 found
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 49 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Normalizer/ParagraphNormalizerInterface.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 22 ERRORS AFFECTING 11 LINES
---------------------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Missing interface doc comment
10 | ERROR | [x] Opening brace should be on the same line as the declaration
11 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
11 | ERROR | [ ] Missing short description in doc comment
12 | ERROR | [x] Data types in @param tags need to be fully namespaced
12 | ERROR | [x] Parameter comment must be on the next line
12 | ERROR | [x] Parameter comment must end with a full stop
13 | ERROR | [x] Expected 1 spaces after parameter type; 13 found
13 | ERROR | [x] Parameter comment must be on the next line
13 | ERROR | [x] Parameter comment must end with a full stop
14 | ERROR | [x] Expected 1 spaces after parameter type; 14 found
14 | ERROR | [x] Parameter comment must be on the next line
14 | ERROR | [x] Parameter comment must end with a full stop
16 | ERROR | [ ] Description for the @return value is missing
18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
18 | ERROR | [x] Expected 1 blank line before function; 0 found
18 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
20 | ERROR | [ ] Missing short description in doc comment
21 | ERROR | [ ] Description for the @return value is missing
23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
23 | ERROR | [x] Expected 1 blank line after function; 0 found
---------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 18 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Normalizer/BaseParagraphNormalizer.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 21 ERRORS AFFECTING 17 LINES
----------------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Missing class doc comment
10 | ERROR | [x] Opening brace should be on the same line as the declaration
11 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
11 | ERROR | [ ] Missing short description in doc comment
14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
19 | ERROR | [x] Parameter comment must be on the next line
19 | ERROR | [x] Parameter comment must end with a full stop
21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
22 | ERROR | [x] Opening brace should be on the same line as the declaration
23 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
29 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
35 | ERROR | [x] Opening brace should be on the same line as the declaration
36 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
37 | ERROR | [x] Expected 1 blank line after function; 0 found
----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 20 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Normalizer/PageNormalizer.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 101 ERRORS AND 1 WARNING AFFECTING 87 LINES
-------------------------------------------------------------------------------------------------------------------------------
20 | ERROR | [x] Opening brace should be on the same line as the declaration
21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
21 | ERROR | [ ] Missing member variable doc comment
23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
23 | ERROR | [ ] Missing member variable doc comment
25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
25 | ERROR | [ ] Missing member variable doc comment
27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
28 | ERROR | [x] Multi-line function declaration not indented correctly; expected 6 spaces but found 8
29 | ERROR | [x] Multi-line function declaration not indented correctly; expected 6 spaces but found 8
30 | ERROR | [x] Multi-line function declaration not indented correctly; expected 6 spaces but found 8
30 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
31 | ERROR | [x] Multi-line function declaration not indented correctly; expected 6 spaces but found 8
31 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
31 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
33 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
35 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
38 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
41 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
42 | ERROR | [x] Opening brace should be on the same line as the declaration
43 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
43 | ERROR | [x] Data types in @var tags need to be fully namespaced
44 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
45 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
46 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
47 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
49 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
51 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
52 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
53 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
53 | WARNING | [ ] Unused bound variable $object.
55 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
57 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
58 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
60 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
61 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
62 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
63 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
64 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
64 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
65 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
66 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
67 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
68 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
70 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
71 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
73 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12
74 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 16
75 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 20
76 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 16
76 | ERROR | [x] Expected newline after closing brace
77 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 20
78 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 16
79 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12
80 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
82 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
84 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
86 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
88 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
89 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
90 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
91 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
94 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
95 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
96 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
97 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
99 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
100 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
101 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
103 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
104 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
105 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
106 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
106 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
107 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
108 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
110 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
111 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
113 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
116 | ERROR | [ ] Description for the @return value is missing
116 | ERROR | [x] Data types in @return tags need to be fully namespaced
118 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
119 | ERROR | [x] Opening brace should be on the same line as the declaration
120 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
120 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
121 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
125 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
126 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
128 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
129 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
130 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
132 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
133 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
135 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
136 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
137 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
138 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
140 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
141 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
141 | ERROR | [x] Expected 1 blank line after function; 0 found
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 97 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Exception/ContentNotFoundException.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Missing class doc comment
10 | ERROR | [x] Opening brace should be on the same line as the declaration
----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Event/UrlEvent.php
--------------------------------------------------------------------------------------------------------------
FOUND 104 ERRORS AFFECTING 84 LINES
--------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Missing class doc comment
11 | ERROR | [x] Opening brace should be on the same line as the declaration
12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
15 | ERROR | [ ] Missing member variable doc comment
16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
16 | ERROR | [ ] Missing member variable doc comment
17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
17 | ERROR | [ ] Missing member variable doc comment
18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
18 | ERROR | [ ] Missing member variable doc comment
19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
19 | ERROR | [ ] Missing member variable doc comment
20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
20 | ERROR | [ ] Missing member variable doc comment
22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
22 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
23 | ERROR | [x] Opening brace should be on the same line as the declaration
24 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
25 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
26 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
27 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
28 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
31 | ERROR | [ ] Missing short description in doc comment
32 | ERROR | [ ] Description for the @return value is missing
34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
35 | ERROR | [x] Opening brace should be on the same line as the declaration
36 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
39 | ERROR | [x] Missing function doc comment
40 | ERROR | [x] Opening brace should be on the same line as the declaration
41 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
43 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
44 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
46 | ERROR | [x] Missing function doc comment
47 | ERROR | [x] Opening brace should be on the same line as the declaration
48 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
49 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
51 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
51 | ERROR | [x] Missing function doc comment
52 | ERROR | [x] Opening brace should be on the same line as the declaration
53 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
55 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
56 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
58 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
58 | ERROR | [ ] Missing short description in doc comment
59 | ERROR | [ ] Description for the @return value is missing
61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
62 | ERROR | [x] Opening brace should be on the same line as the declaration
63 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
64 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
66 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
66 | ERROR | [ ] Missing short description in doc comment
67 | ERROR | [ ] Missing parameter comment
69 | ERROR | [ ] Description for the @return value is missing
71 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
72 | ERROR | [x] Opening brace should be on the same line as the declaration
73 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
75 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
76 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
78 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
78 | ERROR | [x] Missing function doc comment
79 | ERROR | [x] Opening brace should be on the same line as the declaration
80 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
81 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
83 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
83 | ERROR | [x] Missing function doc comment
84 | ERROR | [x] Opening brace should be on the same line as the declaration
85 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
87 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
88 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
90 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
90 | ERROR | [x] Missing function doc comment
91 | ERROR | [x] Opening brace should be on the same line as the declaration
92 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
93 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
95 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
95 | ERROR | [x] Missing function doc comment
96 | ERROR | [x] Opening brace should be on the same line as the declaration
97 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
99 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
100 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
102 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
102 | ERROR | [ ] Missing short description in doc comment
103 | ERROR | [ ] Description for the @return value is missing
105 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
106 | ERROR | [x] Opening brace should be on the same line as the declaration
107 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
108 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
110 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
110 | ERROR | [ ] Missing short description in doc comment
111 | ERROR | [ ] Missing parameter comment
113 | ERROR | [ ] Description for the @return value is missing
115 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
116 | ERROR | [x] Opening brace should be on the same line as the declaration
117 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
119 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
120 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
120 | ERROR | [x] Expected 1 blank line after function; 0 found
--------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 86 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Event/PageEvent.php
---------------------------------------------------------------------------------------------------------------
FOUND 48 ERRORS AFFECTING 39 LINES
---------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Missing class doc comment
11 | ERROR | [x] Opening brace should be on the same line as the declaration
12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
14 | ERROR | [ ] Missing short description in doc comment
17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
19 | ERROR | [ ] Missing short description in doc comment
20 | ERROR | [x] Data types in @var tags need to be fully namespaced
22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
24 | ERROR | [ ] Missing short description in doc comment
27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
33 | ERROR | [x] Opening brace should be on the same line as the declaration
34 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
35 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
36 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
39 | ERROR | [x] Missing function doc comment
40 | ERROR | [x] Opening brace should be on the same line as the declaration
41 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
44 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
44 | ERROR | [x] Missing function doc comment
45 | ERROR | [x] Opening brace should be on the same line as the declaration
46 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
48 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
49 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
51 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
51 | ERROR | [x] Missing function doc comment
52 | ERROR | [x] Opening brace should be on the same line as the declaration
53 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
54 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
56 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
56 | ERROR | [x] Missing function doc comment
57 | ERROR | [x] Opening brace should be on the same line as the declaration
58 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
60 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
63 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
63 | ERROR | [x] Missing function doc comment
64 | ERROR | [x] Opening brace should be on the same line as the declaration
65 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
66 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
66 | ERROR | [x] Expected 1 blank line after function; 0 found
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 45 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Event/ContentEvent.php
------------------------------------------------------------------------------------------------------------------
FOUND 81 ERRORS AFFECTING 66 LINES
------------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Missing class doc comment
11 | ERROR | [x] Opening brace should be on the same line as the declaration
12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
14 | ERROR | [ ] Missing short description in doc comment
17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
19 | ERROR | [ ] Missing short description in doc comment
22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
24 | ERROR | [ ] Missing short description in doc comment
25 | ERROR | [x] Data types in @var tags need to be fully namespaced
27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
29 | ERROR | [ ] Missing short description in doc comment
32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
34 | ERROR | [ ] Missing member variable doc comment
36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
40 | ERROR | [x] Opening brace should be on the same line as the declaration
41 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
42 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
43 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
44 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
45 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
47 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
47 | ERROR | [x] Missing function doc comment
48 | ERROR | [x] Opening brace should be on the same line as the declaration
49 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
52 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
52 | ERROR | [x] Missing function doc comment
53 | ERROR | [x] Opening brace should be on the same line as the declaration
54 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
56 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
57 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
59 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
59 | ERROR | [x] Missing function doc comment
60 | ERROR | [x] Opening brace should be on the same line as the declaration
61 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
62 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
64 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
64 | ERROR | [x] Missing function doc comment
65 | ERROR | [x] Opening brace should be on the same line as the declaration
66 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
68 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
69 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
71 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
71 | ERROR | [x] Missing function doc comment
72 | ERROR | [x] Opening brace should be on the same line as the declaration
73 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
74 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
76 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
76 | ERROR | [x] Missing function doc comment
77 | ERROR | [x] Opening brace should be on the same line as the declaration
78 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
80 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
81 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
83 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
83 | ERROR | [ ] Missing short description in doc comment
84 | ERROR | [ ] Description for the @return value is missing
86 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
87 | ERROR | [x] Opening brace should be on the same line as the declaration
88 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
89 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
91 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
91 | ERROR | [ ] Missing short description in doc comment
92 | ERROR | [ ] Missing parameter comment
94 | ERROR | [ ] Description for the @return value is missing
96 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
97 | ERROR | [x] Opening brace should be on the same line as the declaration
98 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
100 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
101 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
103 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
103 | ERROR | [x] Missing function doc comment
104 | ERROR | [x] Opening brace should be on the same line as the declaration
105 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
106 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
106 | ERROR | [x] Expected 1 blank line after function; 0 found
------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 71 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Compiler/ControllerArgumentValueResolverPass.php
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 22 ERRORS AFFECTING 18 LINES
--------------------------------------------------------------------------------------------------------------------------------------------
11 | ERROR | [x] Missing class doc comment
12 | ERROR | [x] Opening brace should be on the same line as the declaration
13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
15 | ERROR | [ ] Missing member variable doc comment
16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
16 | ERROR | [ ] Missing member variable doc comment
18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
19 | ERROR | [x] Opening brace should be on the same line as the declaration
20 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
21 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
24 | ERROR | [x] Missing function doc comment
25 | ERROR | [x] Opening brace should be on the same line as the declaration
26 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
27 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
28 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
30 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
31 | ERROR | [x] Object operator not indented correctly; expected 10 spaces but found 12
37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
37 | ERROR | [x] Expected 1 blank line after function; 0 found
--------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 20 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Resolver/PageResolverInterface.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------
11 | ERROR | [x] Opening brace should be on the same line as the declaration
12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
12 | ERROR | [x] Missing function doc comment
12 | ERROR | [x] Expected 1 blank line before function; 0 found
12 | ERROR | [x] Expected 1 blank line after function; 0 found
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Resolver/PageResolver.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 53 ERRORS AFFECTING 41 LINES
----------------------------------------------------------------------------------------------------------------------------
16 | ERROR | [x] Opening brace should be on the same line as the declaration
17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
17 | ERROR | [x] Missing function doc comment
17 | ERROR | [x] Expected 1 blank line before function; 0 found
18 | ERROR | [x] Opening brace should be on the same line as the declaration
19 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
20 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
21 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
22 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
22 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
23 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
23 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
25 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
26 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
27 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
28 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
30 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
31 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
32 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
33 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
33 | ERROR | [x] Concat operator must be surrounded by a single space
34 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
34 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
37 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
38 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
39 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
40 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
40 | ERROR | [x] Expected newline after closing brace
41 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
41 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
42 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
44 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
45 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
46 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
47 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
49 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
52 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
52 | ERROR | [x] Missing function doc comment
52 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
53 | ERROR | [x] Opening brace should be on the same line as the declaration
54 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
54 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
55 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
56 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
58 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
59 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
61 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
62 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
63 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
65 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
66 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
66 | ERROR | [x] Expected 1 blank line after function; 0 found
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 53 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Resolver/ChannelResolver.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 110 ERRORS AND 2 WARNINGS AFFECTING 93 LINES
--------------------------------------------------------------------------------------------------------------------------------------
14 | ERROR | [x] Missing class doc comment
15 | ERROR | [x] Opening brace should be on the same line as the declaration
16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
20 | ERROR | [ ] Missing member variable doc comment
22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
23 | ERROR | [x] Multi-line function declaration not indented correctly; expected 6 spaces but found 8
23 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
25 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
32 | ERROR | [x] Opening brace should be on the same line as the declaration
33 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
33 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
34 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
40 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
41 | ERROR | [x] Opening brace should be on the same line as the declaration
42 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
43 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
45 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
46 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
48 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
49 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
50 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
52 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
53 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
54 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
55 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
56 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
56 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
57 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
59 | WARNING | [x] '@TODO raise an issue' should match the format '@todo Fix problem X here.'
59 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
60 | WARNING | [ ] Line exceeds 80 characters; contains 112 characters
60 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
61 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
62 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
63 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
63 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
64 | ERROR | [x] Line indented incorrectly; expected at least 4 spaces, found 0
64 | ERROR | [x] 12 spaces found before inline comment; expected "// 'path' => $path," but found "// 'path' => $path,"
66 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
68 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
70 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
71 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
71 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
73 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
74 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
76 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
77 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
79 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
79 | ERROR | [x] Missing function doc comment
80 | ERROR | [x] Opening brace should be on the same line as the declaration
81 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
83 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
84 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
85 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
87 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
88 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
89 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
90 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
95 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
95 | ERROR | [x] Language constructs must be followed by a single space; expected 1 space but found "··"
95 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
96 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
98 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
98 | ERROR | [x] Missing function doc comment
99 | ERROR | [x] Opening brace should be on the same line as the declaration
100 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
102 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
103 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
103 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
104 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
106 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
107 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
108 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
109 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
110 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
112 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
116 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
118 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
120 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
121 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
123 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
123 | ERROR | [x] Missing function doc comment
124 | ERROR | [x] Opening brace should be on the same line as the declaration
125 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
126 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
127 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
127 | ERROR | [x] Concat operator must be surrounded by a single space
128 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
130 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
132 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
134 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
134 | ERROR | [x] Missing function doc comment
134 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
135 | ERROR | [x] Opening brace should be on the same line as the declaration
136 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
137 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
138 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
140 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
142 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
143 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
144 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
146 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
147 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
147 | ERROR | [x] Expected 1 blank line after function; 0 found
--------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 110 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Duplicator/ChannelDuplicatorInterface.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 6 LINES
-------------------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Missing interface doc comment
10 | ERROR | [x] Opening brace should be on the same line as the declaration
11 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
15 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
17 | ERROR | [ ] Description for the @return value is missing
22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
22 | ERROR | [x] Expected 1 blank line before function; 0 found
22 | ERROR | [x] Expected 1 blank line after function; 0 found
-------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Duplicator/ChannelDuplicator.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 67 ERRORS AND 3 WARNINGS AFFECTING 62 LINES
----------------------------------------------------------------------------------------------------------------------------
9 | WARNING | [x] Unused use statement
11 | ERROR | [x] Missing class doc comment
12 | ERROR | [x] Opening brace should be on the same line as the declaration
13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
13 | ERROR | [ ] Missing short description in doc comment
14 | ERROR | [x] Data types in @var tags need to be fully namespaced
16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
22 | ERROR | [x] Opening brace should be on the same line as the declaration
23 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
26 | ERROR | [x] Missing function doc comment
27 | ERROR | [x] Opening brace should be on the same line as the declaration
28 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
29 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
31 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
33 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
33 | ERROR | [x] Data types in @var tags need to be fully namespaced
34 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
35 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
36 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
37 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
39 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
40 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
41 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
42 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
43 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
44 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
45 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
46 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
47 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
49 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
52 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
52 | ERROR | [x] Missing function doc comment
53 | ERROR | [x] Opening brace should be on the same line as the declaration
54 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
55 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
58 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
59 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
64 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
65 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
65 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
67 | ERROR | [ ] Description for the @return value is missing
69 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
70 | ERROR | [x] Opening brace should be on the same line as the declaration
71 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
73 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
74 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
75 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
76 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
77 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
78 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
78 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
79 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
80 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
82 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
82 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
83 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
85 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8
86 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 12
87 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 16
88 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 12
89 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8
91 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8
92 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
92 | ERROR | [x] Expected 1 blank line after function; 0 found
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 65 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Tool/UrlGenerator.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 126 ERRORS AND 2 WARNINGS AFFECTING 92 LINES
-------------------------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Missing class doc comment
11 | ERROR | [x] Opening brace should be on the same line as the declaration
12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
12 | ERROR | [x] Missing function doc comment
12 | ERROR | [x] Expected 1 blank line before function; 0 found
13 | ERROR | [x] Opening brace should be on the same line as the declaration
14 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
14 | ERROR | [x] There should be no white space after an opening "{"
14 | WARNING | [ ] Line exceeds 80 characters; contains 97 characters
14 | ERROR | [x] Comments may not appear after statements
14 | ERROR | [x] Inline comments must start with a capital letter
15 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
16 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
18 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
19 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
20 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
22 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
23 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
24 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
26 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
27 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
28 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
30 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
30 | ERROR | [x] Concat operator must be surrounded by a single space
31 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
31 | ERROR | [x] Concat operator must be surrounded by a single space
32 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
34 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
35 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
36 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
38 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
40 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
42 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
43 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
44 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
45 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
47 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
49 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
50 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
50 | ERROR | [x] Concat operator must be surrounded by a single space
51 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
53 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
54 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
56 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
56 | ERROR | [x] Missing function doc comment
57 | ERROR | [x] Opening brace should be on the same line as the declaration
58 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
59 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
60 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
61 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
64 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
66 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
67 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
68 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
70 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
71 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
72 | ERROR | [x] Array indentation error, expected 14 spaces but found 20
73 | ERROR | [x] Array closing indentation error, expected 12 spaces but found 16
76 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12
78 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters
78 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12
78 | ERROR | [x] Inline comments must start with a capital letter
78 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
79 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12
79 | ERROR | [x] Concat operator must be surrounded by a single space
79 | ERROR | [x] Concat operator must be surrounded by a single space
81 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12
82 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 16
83 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12
85 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12
85 | ERROR | [x] Concat operator must be surrounded by a single space
86 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
86 | ERROR | [x] Expected newline after closing brace
87 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
88 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
89 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
90 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
92 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
93 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
95 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
96 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
98 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
98 | ERROR | [x] Missing function doc comment
99 | ERROR | [x] Opening brace should be on the same line as the declaration
100 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
101 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
103 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
104 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
105 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
105 | ERROR | [x] Expected newline after closing brace
106 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
107 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
109 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
110 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
111 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
113 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
115 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
116 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
118 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
118 | ERROR | [x] Missing function doc comment
119 | ERROR | [x] Opening brace should be on the same line as the declaration
120 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
120 | ERROR | [x] Concat operator must be surrounded by a single space
121 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
121 | ERROR | [x] Use null coalesce operator instead of ternary operator.
122 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
122 | ERROR | [x] Concat operator must be surrounded by a single space
123 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
123 | ERROR | [x] Use null coalesce operator instead of ternary operator.
124 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
124 | ERROR | [x] Concat operator must be surrounded by a single space
125 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
126 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
126 | ERROR | [x] Use null coalesce operator instead of ternary operator.
127 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
127 | ERROR | [x] Concat operator must be surrounded by a single space
128 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
128 | ERROR | [x] Concat operator must be surrounded by a single space
130 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
130 | ERROR | [x] Concat operator must be surrounded by a single space
130 | ERROR | [x] Concat operator must be surrounded by a single space
130 | ERROR | [x] Concat operator must be surrounded by a single space
130 | ERROR | [x] Concat operator must be surrounded by a single space
130 | ERROR | [x] Concat operator must be surrounded by a single space
130 | ERROR | [x] Concat operator must be surrounded by a single space
130 | ERROR | [x] Concat operator must be surrounded by a single space
131 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
131 | ERROR | [x] Expected 1 blank line after function; 0 found
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 126 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Tool/ArrayHelper.php
----------------------------------------------------------------------------------------------------------------
FOUND 26 ERRORS AND 1 WARNING AFFECTING 20 LINES
----------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Missing class doc comment
8 | ERROR | [x] Opening brace should be on the same line as the declaration
9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
9 | ERROR | [x] Missing function doc comment
9 | ERROR | [x] Expected 1 blank line before function; 0 found
10 | ERROR | [x] Opening brace should be on the same line as the declaration
11 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
12 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
12 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
13 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
15 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
16 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
18 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
18 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
19 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
21 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
21 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
23 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
23 | WARNING | [ ] Unused variable $k.
24 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
26 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
27 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
28 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
29 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
31 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
32 | ERROR | [x] Expected 1 blank line after function; 0 found
----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 26 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Tool/PreviewHelper.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 17 ERRORS AFFECTING 13 LINES
----------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Missing class doc comment
10 | ERROR | [x] Opening brace should be on the same line as the declaration
11 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
13 | ERROR | [x] Missing function doc comment
14 | ERROR | [x] Opening brace should be on the same line as the declaration
15 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
17 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
17 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
17 | ERROR | [x] Concat operator must be surrounded by a single space
18 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
20 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
21 | ERROR | [x] Concat operator must be surrounded by a single space
25 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
27 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
28 | ERROR | [x] Expected 1 blank line after function; 0 found
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 17 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Tool/Slug.php
---------------------------------------------------------------------------------------------------------
FOUND 20 ERRORS AFFECTING 17 LINES
---------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Missing class doc comment
8 | ERROR | [x] Opening brace should be on the same line as the declaration
9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
9 | ERROR | [x] Missing function doc comment
9 | ERROR | [x] Expected 1 blank line before function; 0 found
10 | ERROR | [x] Opening brace should be on the same line as the declaration
11 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
12 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
13 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
15 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
16 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
17 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
18 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
19 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
20 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
21 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
22 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
24 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
25 | ERROR | [x] Expected 1 blank line after function; 0 found
---------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 20 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Router/RouterSubscriber.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 99 ERRORS AND 6 WARNINGS AFFECTING 80 LINES
-------------------------------------------------------------------------------------------------------------------------------
8 | WARNING | [x] Unused use statement
9 | WARNING | [x] Unused use statement
13 | ERROR | [ ] Missing short description in doc comment
17 | ERROR | [x] Opening brace should be on the same line as the declaration
18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
21 | ERROR | [ ] Missing member variable doc comment
22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
22 | ERROR | [ ] Missing member variable doc comment
24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
25 | ERROR | [x] Opening brace should be on the same line as the declaration
26 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
28 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
31 | ERROR | [x] Missing function doc comment
32 | ERROR | [x] Opening brace should be on the same line as the declaration
33 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
34 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
35 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
39 | ERROR | [x] Missing function doc comment
40 | ERROR | [x] Opening brace should be on the same line as the declaration
41 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
42 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
43 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
45 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
47 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
47 | ERROR | [x] Missing function doc comment
48 | ERROR | [x] Opening brace should be on the same line as the declaration
49 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
52 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
52 | ERROR | [x] Missing function doc comment
53 | ERROR | [x] Opening brace should be on the same line as the declaration
54 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
55 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
55 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
56 | ERROR | [x] Object operator not indented correctly; expected 10 spaces but found 12
57 | ERROR | [x] Space after closing parenthesis of function call prohibited
58 | ERROR | [x] Space found before semicolon; expected ");" but found ")\n ;"
60 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
62 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
63 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
64 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
66 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
68 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
68 | ERROR | [x] Data types in @var tags need to be fully namespaced
69 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
70 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
70 | WARNING | [x] The variable name should be defined after the type
71 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
73 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
74 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
74 | ERROR | [x] Data types in @var tags need to be fully namespaced
75 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
77 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
78 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
79 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
81 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
81 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
81 | ERROR | [x] There should be no white space after an opening "{"
81 | WARNING | [ ] Line exceeds 80 characters; contains 111 characters
81 | ERROR | [x] Comments may not appear after statements
81 | ERROR | [x] Inline comments must start with a capital letter
81 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
82 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
83 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
85 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
87 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
88 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
88 | ERROR | [x] There should be no white space after an opening "{"
88 | WARNING | [ ] Line exceeds 80 characters; contains 146 characters
88 | ERROR | [x] Comments may not appear after statements
88 | ERROR | [x] Inline comments must start with a capital letter
88 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
89 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 24
90 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
92 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
94 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
95 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
96 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
98 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
99 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 24
99 | ERROR | [x] Concat operator must be surrounded by a single space
100 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
102 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
104 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
105 | ERROR | [x] Array indentation error, expected 22 spaces but found 24
106 | ERROR | [x] Array indentation error, expected 22 spaces but found 24
109 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 20
109 | ERROR | [x] Concat operator must be surrounded by a single space
110 | ERROR | [x] Array indentation error, expected 22 spaces but found 24
111 | ERROR | [x] Array indentation error, expected 22 spaces but found 24
112 | ERROR | [x] Array indentation error, expected 22 spaces but found 24
112 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
114 | ERROR | [x] Array indentation error, expected 22 spaces but found 24
116 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
117 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
118 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
120 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
121 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
121 | ERROR | [x] Expected 1 blank line after function; 0 found
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 99 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/xls_views_data_export/xls_views_data_export.module
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
27 | WARNING | Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block templates."
32 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "hook_config_schema_info_alter" but expected "xls_views_data_export_hook_config_schema_info_alter"
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/xls_views_data_export/xls_views_data_export.info.yml
--------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------
7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
8 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
--------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/xls_views_data_export/src/Form/XlsExportForm.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 3 WARNINGS AFFECTING 6 LINES
-------------------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Routing\RouteMatchInterface.
17 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
34 | ERROR | [ ] Class property $xls_mime_types should use lowerCamel naming without underscores
51 | WARNING | [ ] File::load calls should be avoided in classes, use dependency injection instead
160 | WARNING | [ ] Line exceeds 80 characters; contains 114 characters
217 | ERROR | [ ] Description for the @return value is missing
-------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/xls_views_data_export/src/Plugin/views/display/XlsDataExport.php
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 5 WARNINGS AFFECTING 7 LINES
--------------------------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Cache\CacheableMetadata.
20 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
37 | WARNING | [ ] Line exceeds 80 characters; contains 98 characters
151 | WARNING | [ ] Line exceeds 80 characters; contains 92 characters
152 | WARNING | [ ] Line exceeds 80 characters; contains 90 characters
200 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
245 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
--------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/xls_views_data_export/src/EventSubscriber/ExportRedirectSubscriber.php
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 2 WARNINGS AFFECTING 6 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Symfony\Component\HttpKernel\Event\RequestEvent.
17 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
32 | ERROR | [ ] Class property $xls_content_types should use lowerCamel naming without underscores
61 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
63 | ERROR | [ ] Missing parameter comment
73 | WARNING | [ ] File::load calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------
Time: 2.06 secs; Memory: 20MBKindly check
Thanks,
Jake
Hi @sidharth_soman,
The patch #5 you provided could not be applied succesfully, multiple errors still remains unfixed. Please see below:
Application of patch:
➜ ekino_rendr git:(8.x-1.x) curl https://www.drupal.org/files/issues/2022-09-12/coding-standard-issues-3125578-5.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 74686 100 74686 0 0 225k 0 --:--:-- --:--:-- --:--:-- 232k
patching file README.md
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file README.md.rej
patching file doc/serialization.md
patching file ekino_rendr.info.yml
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file ekino_rendr.info.yml.rej
patching file ekino_rendr.links.menu.yml
patching file ekino_rendr.module
Hunk #1 succeeded at 1 with fuzz 1.
patching file ekino_rendr.routing.yml
Hunk #1 succeeded at 99 with fuzz 2 (offset 84 lines).
patching file ekino_rendr.services.yml
Hunk #1 FAILED at 20.
1 out of 1 hunk FAILED -- saving rejects to file ekino_rendr.services.yml.rej
patching file src/Compiler/ParagraphNormalizerExtensionPass.php
patching file src/Controller/ApiController.php
Hunk #1 FAILED at 8.
1 out of 1 hunk FAILED -- saving rejects to file src/Controller/ApiController.php.rej
patching file src/Controller/ViewIndexController.php
patching file src/EkinoRendrServiceProvider.php
Hunk #1 FAILED at 8.
1 out of 1 hunk FAILED -- saving rejects to file src/EkinoRendrServiceProvider.php.rej
patching file src/Entity/Channel.php
Hunk #2 FAILED at 61.
1 out of 2 hunks FAILED -- saving rejects to file src/Entity/Channel.php.rej
patching file src/Entity/ChannelInterface.php
Hunk #1 FAILED at 8.
1 out of 1 hunk FAILED -- saving rejects to file src/Entity/ChannelInterface.php.rej
patching file src/Entity/ChannelListBuilder.php
Hunk #1 FAILED at 11.
1 out of 1 hunk FAILED -- saving rejects to file src/Entity/ChannelListBuilder.php.rej
patching file src/Entity/ChannelType.php
patching file src/Entity/ChannelTypeInterface.php
patching file src/Entity/ChannelTypeListBuilder.php
Hunk #1 FAILED at 11.
1 out of 1 hunk FAILED -- saving rejects to file src/Entity/ChannelTypeListBuilder.php.rej
patching file src/Entity/Page.php
Hunk #1 succeeded at 14 with fuzz 1 (offset 1 line).
Hunk #2 FAILED at 58.
1 out of 2 hunks FAILED -- saving rejects to file src/Entity/Page.php.rej
patching file src/Entity/PageInterface.php
Hunk #1 FAILED at 8.
1 out of 1 hunk FAILED -- saving rejects to file src/Entity/PageInterface.php.rej
patching file src/Entity/PageListBuilder.php
Hunk #1 FAILED at 11.
1 out of 1 hunk FAILED -- saving rejects to file src/Entity/PageListBuilder.php.rej
patching file src/Entity/Template.php
Hunk #1 succeeded at 7 with fuzz 1 (offset -1 lines).
Hunk #2 FAILED at 43.
1 out of 2 hunks FAILED -- saving rejects to file src/Entity/Template.php.rej
patching file src/Entity/TemplateInterface.php
patching file src/Entity/TemplateListBuilder.php
Hunk #1 FAILED at 12.
1 out of 1 hunk FAILED -- saving rejects to file src/Entity/TemplateListBuilder.php.rej
can't find file to patch at input line 1240
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/src/Form/UpsertChannelForm.php b/src/Form/UpsertChannelForm.php
|index ebfa9c6..edc45c4 100644
|--- a/src/Form/UpsertChannelForm.php
|+++ b/src/Form/UpsertChannelForm.php
--------------------------
File to patch:
Skip this patch? [y] y
Skipping patch.
1 out of 1 hunk ignored
can't find file to patch at input line 1501
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/src/Form/UpsertChannelTypeForm.php b/src/Form/UpsertChannelTypeForm.php
|index 659e82b..fe92387 100644
|--- a/src/Form/UpsertChannelTypeForm.php
|+++ b/src/Form/UpsertChannelTypeForm.php
--------------------------
File to patch:
Skip this patch? [y] y
Skipping patch.
1 out of 1 hunk ignored
can't find file to patch at input line 1677
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/src/Form/UpsertPageForm.php b/src/Form/UpsertPageForm.php
|index f553b6a..e03069f 100644
|--- a/src/Form/UpsertPageForm.php
|+++ b/src/Form/UpsertPageForm.php
--------------------------
File to patch:
Skip this patch? [y] y
Skipping patch.
1 out of 1 hunk ignored
patching file src/Model/Container.php
patching file src/Normalizer/BaseParagraphNormalizer.php
Hunk #1 FAILED at 6.
1 out of 1 hunk FAILED -- saving rejects to file src/Normalizer/BaseParagraphNormalizer.php.rej
patching file src/Normalizer/PageNormalizer.php
Hunk #1 FAILED at 4.
1 out of 1 hunk FAILED -- saving rejects to file src/Normalizer/PageNormalizer.php.rej
patching file src/Normalizer/ParagraphFieldNormalizer.php
Hunk #1 FAILED at 9.
1 out of 1 hunk FAILED -- saving rejects to file src/Normalizer/ParagraphFieldNormalizer.php.rej
patching file src/Normalizer/ParagraphNormalizerInterface.php
Hunk #1 FAILED at 6.
1 out of 1 hunk FAILED -- saving rejects to file src/Normalizer/ParagraphNormalizerInterface.php.rejReported Errors (not everything, my terminal cut the errors because it was too many)
23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
23 | ERROR | [ ] Missing member variable doc comment
25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
25 | ERROR | [ ] Missing member variable doc comment
27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
28 | ERROR | [x] Multi-line function declaration not indented correctly; expected 6 spaces but found 8
29 | ERROR | [x] Multi-line function declaration not indented correctly; expected 6 spaces but found 8
30 | ERROR | [x] Multi-line function declaration not indented correctly; expected 6 spaces but found 8
30 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
31 | ERROR | [x] Multi-line function declaration not indented correctly; expected 6 spaces but found 8
31 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
31 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
33 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
35 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
38 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
41 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
42 | ERROR | [x] Opening brace should be on the same line as the declaration
43 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
43 | ERROR | [x] Data types in @var tags need to be fully namespaced
44 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
45 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
46 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
47 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
49 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
51 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
52 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
53 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
53 | WARNING | [ ] Unused bound variable $object.
55 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
57 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
58 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
60 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
61 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
62 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
63 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
64 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
64 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
65 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
66 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
67 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
68 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
70 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
71 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
73 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12
74 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 16
75 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 20
76 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 16
76 | ERROR | [x] Expected newline after closing brace
77 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 20
78 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 16
79 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12
80 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
82 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
84 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
86 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
88 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
89 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
90 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
91 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
94 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
95 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
96 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
97 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
99 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
100 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
101 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
103 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
104 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
105 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
106 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
106 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
107 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
108 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
110 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
111 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
113 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
116 | ERROR | [ ] Description for the @return value is missing
116 | ERROR | [x] Data types in @return tags need to be fully namespaced
118 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
119 | ERROR | [x] Opening brace should be on the same line as the declaration
120 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
120 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
121 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
125 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
126 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
128 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
129 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
130 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
132 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
133 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
135 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
136 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
137 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
138 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
140 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
141 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
141 | ERROR | [x] Expected 1 blank line after function; 0 found
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 97 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Exception/ContentNotFoundException.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Missing class doc comment
10 | ERROR | [x] Opening brace should be on the same line as the declaration
----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Event/UrlEvent.php
--------------------------------------------------------------------------------------------------------------
FOUND 104 ERRORS AFFECTING 84 LINES
--------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Missing class doc comment
11 | ERROR | [x] Opening brace should be on the same line as the declaration
12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
15 | ERROR | [ ] Missing member variable doc comment
16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
16 | ERROR | [ ] Missing member variable doc comment
17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
17 | ERROR | [ ] Missing member variable doc comment
18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
18 | ERROR | [ ] Missing member variable doc comment
19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
19 | ERROR | [ ] Missing member variable doc comment
20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
20 | ERROR | [ ] Missing member variable doc comment
22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
22 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
23 | ERROR | [x] Opening brace should be on the same line as the declaration
24 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
25 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
26 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
27 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
28 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
31 | ERROR | [ ] Missing short description in doc comment
32 | ERROR | [ ] Description for the @return value is missing
34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
35 | ERROR | [x] Opening brace should be on the same line as the declaration
36 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
39 | ERROR | [x] Missing function doc comment
40 | ERROR | [x] Opening brace should be on the same line as the declaration
41 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
43 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
44 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
46 | ERROR | [x] Missing function doc comment
47 | ERROR | [x] Opening brace should be on the same line as the declaration
48 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
49 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
51 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
51 | ERROR | [x] Missing function doc comment
52 | ERROR | [x] Opening brace should be on the same line as the declaration
53 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
55 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
56 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
58 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
58 | ERROR | [ ] Missing short description in doc comment
59 | ERROR | [ ] Description for the @return value is missing
61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
62 | ERROR | [x] Opening brace should be on the same line as the declaration
63 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
64 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
66 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
66 | ERROR | [ ] Missing short description in doc comment
67 | ERROR | [ ] Missing parameter comment
69 | ERROR | [ ] Description for the @return value is missing
71 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
72 | ERROR | [x] Opening brace should be on the same line as the declaration
73 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
75 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
76 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
78 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
78 | ERROR | [x] Missing function doc comment
79 | ERROR | [x] Opening brace should be on the same line as the declaration
80 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
81 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
83 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
83 | ERROR | [x] Missing function doc comment
84 | ERROR | [x] Opening brace should be on the same line as the declaration
85 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
87 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
88 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
90 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
90 | ERROR | [x] Missing function doc comment
91 | ERROR | [x] Opening brace should be on the same line as the declaration
92 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
93 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
95 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
95 | ERROR | [x] Missing function doc comment
96 | ERROR | [x] Opening brace should be on the same line as the declaration
97 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
99 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
100 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
102 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
102 | ERROR | [ ] Missing short description in doc comment
103 | ERROR | [ ] Description for the @return value is missing
105 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
106 | ERROR | [x] Opening brace should be on the same line as the declaration
107 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
108 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
110 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
110 | ERROR | [ ] Missing short description in doc comment
111 | ERROR | [ ] Missing parameter comment
113 | ERROR | [ ] Description for the @return value is missing
115 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
116 | ERROR | [x] Opening brace should be on the same line as the declaration
117 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
119 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
120 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
120 | ERROR | [x] Expected 1 blank line after function; 0 found
--------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 86 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Event/PageEvent.php
---------------------------------------------------------------------------------------------------------------
FOUND 48 ERRORS AFFECTING 39 LINES
---------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Missing class doc comment
11 | ERROR | [x] Opening brace should be on the same line as the declaration
12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
14 | ERROR | [ ] Missing short description in doc comment
17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
19 | ERROR | [ ] Missing short description in doc comment
20 | ERROR | [x] Data types in @var tags need to be fully namespaced
22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
24 | ERROR | [ ] Missing short description in doc comment
27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
33 | ERROR | [x] Opening brace should be on the same line as the declaration
34 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
35 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
36 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
39 | ERROR | [x] Missing function doc comment
40 | ERROR | [x] Opening brace should be on the same line as the declaration
41 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
44 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
44 | ERROR | [x] Missing function doc comment
45 | ERROR | [x] Opening brace should be on the same line as the declaration
46 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
48 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
49 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
51 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
51 | ERROR | [x] Missing function doc comment
52 | ERROR | [x] Opening brace should be on the same line as the declaration
53 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
54 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
56 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
56 | ERROR | [x] Missing function doc comment
57 | ERROR | [x] Opening brace should be on the same line as the declaration
58 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
60 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
63 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
63 | ERROR | [x] Missing function doc comment
64 | ERROR | [x] Opening brace should be on the same line as the declaration
65 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
66 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
66 | ERROR | [x] Expected 1 blank line after function; 0 found
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 45 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Event/ContentEvent.php
------------------------------------------------------------------------------------------------------------------
FOUND 81 ERRORS AFFECTING 66 LINES
------------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Missing class doc comment
11 | ERROR | [x] Opening brace should be on the same line as the declaration
12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
14 | ERROR | [ ] Missing short description in doc comment
17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
19 | ERROR | [ ] Missing short description in doc comment
22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
24 | ERROR | [ ] Missing short description in doc comment
25 | ERROR | [x] Data types in @var tags need to be fully namespaced
27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
29 | ERROR | [ ] Missing short description in doc comment
32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
34 | ERROR | [ ] Missing member variable doc comment
36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
40 | ERROR | [x] Opening brace should be on the same line as the declaration
41 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
42 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
43 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
44 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
45 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
47 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
47 | ERROR | [x] Missing function doc comment
48 | ERROR | [x] Opening brace should be on the same line as the declaration
49 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
52 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
52 | ERROR | [x] Missing function doc comment
53 | ERROR | [x] Opening brace should be on the same line as the declaration
54 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
56 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
57 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
59 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
59 | ERROR | [x] Missing function doc comment
60 | ERROR | [x] Opening brace should be on the same line as the declaration
61 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
62 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
64 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
64 | ERROR | [x] Missing function doc comment
65 | ERROR | [x] Opening brace should be on the same line as the declaration
66 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
68 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
69 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
71 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
71 | ERROR | [x] Missing function doc comment
72 | ERROR | [x] Opening brace should be on the same line as the declaration
73 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
74 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
76 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
76 | ERROR | [x] Missing function doc comment
77 | ERROR | [x] Opening brace should be on the same line as the declaration
78 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
80 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
81 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
83 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
83 | ERROR | [ ] Missing short description in doc comment
84 | ERROR | [ ] Description for the @return value is missing
86 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
87 | ERROR | [x] Opening brace should be on the same line as the declaration
88 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
89 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
91 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
91 | ERROR | [ ] Missing short description in doc comment
92 | ERROR | [ ] Missing parameter comment
94 | ERROR | [ ] Description for the @return value is missing
96 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
97 | ERROR | [x] Opening brace should be on the same line as the declaration
98 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
100 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
101 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
103 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
103 | ERROR | [x] Missing function doc comment
104 | ERROR | [x] Opening brace should be on the same line as the declaration
105 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
106 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
106 | ERROR | [x] Expected 1 blank line after function; 0 found
------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 71 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Compiler/ControllerArgumentValueResolverPass.php
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 22 ERRORS AFFECTING 18 LINES
--------------------------------------------------------------------------------------------------------------------------------------------
11 | ERROR | [x] Missing class doc comment
12 | ERROR | [x] Opening brace should be on the same line as the declaration
13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
15 | ERROR | [ ] Missing member variable doc comment
16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
16 | ERROR | [ ] Missing member variable doc comment
18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
19 | ERROR | [x] Opening brace should be on the same line as the declaration
20 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
21 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
24 | ERROR | [x] Missing function doc comment
25 | ERROR | [x] Opening brace should be on the same line as the declaration
26 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
27 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
28 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
30 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
31 | ERROR | [x] Object operator not indented correctly; expected 10 spaces but found 12
37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
37 | ERROR | [x] Expected 1 blank line after function; 0 found
--------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 20 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Resolver/PageResolverInterface.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------
11 | ERROR | [x] Opening brace should be on the same line as the declaration
12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
12 | ERROR | [x] Missing function doc comment
12 | ERROR | [x] Expected 1 blank line before function; 0 found
12 | ERROR | [x] Expected 1 blank line after function; 0 found
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Resolver/PageResolver.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 53 ERRORS AFFECTING 41 LINES
----------------------------------------------------------------------------------------------------------------------------
16 | ERROR | [x] Opening brace should be on the same line as the declaration
17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
17 | ERROR | [x] Missing function doc comment
17 | ERROR | [x] Expected 1 blank line before function; 0 found
18 | ERROR | [x] Opening brace should be on the same line as the declaration
19 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
20 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
21 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
22 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
22 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
23 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
23 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
25 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
26 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
27 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
28 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
30 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
31 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
32 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
33 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
33 | ERROR | [x] Concat operator must be surrounded by a single space
34 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
34 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
37 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
38 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
39 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
40 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
40 | ERROR | [x] Expected newline after closing brace
41 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
41 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
42 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
44 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
45 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
46 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
47 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
49 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
52 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
52 | ERROR | [x] Missing function doc comment
52 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
53 | ERROR | [x] Opening brace should be on the same line as the declaration
54 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
54 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
55 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
56 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
58 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
59 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
61 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
62 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
63 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
65 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
66 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
66 | ERROR | [x] Expected 1 blank line after function; 0 found
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 53 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Resolver/ChannelResolver.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 110 ERRORS AND 2 WARNINGS AFFECTING 93 LINES
--------------------------------------------------------------------------------------------------------------------------------------
14 | ERROR | [x] Missing class doc comment
15 | ERROR | [x] Opening brace should be on the same line as the declaration
16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
20 | ERROR | [ ] Missing member variable doc comment
22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
23 | ERROR | [x] Multi-line function declaration not indented correctly; expected 6 spaces but found 8
23 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
25 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
32 | ERROR | [x] Opening brace should be on the same line as the declaration
33 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
33 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
34 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
40 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
41 | ERROR | [x] Opening brace should be on the same line as the declaration
42 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
43 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
45 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
46 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
48 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
49 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
50 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
52 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
53 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
54 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
55 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
56 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
56 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
57 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
59 | WARNING | [x] '@TODO raise an issue' should match the format '@todo Fix problem X here.'
59 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
60 | WARNING | [ ] Line exceeds 80 characters; contains 112 characters
60 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
61 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
62 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
63 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
63 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
64 | ERROR | [x] Line indented incorrectly; expected at least 4 spaces, found 0
64 | ERROR | [x] 12 spaces found before inline comment; expected "// 'path' => $path," but found "// 'path' => $path,"
66 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
68 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
70 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
71 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
71 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
73 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
74 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
76 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
77 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
79 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
79 | ERROR | [x] Missing function doc comment
80 | ERROR | [x] Opening brace should be on the same line as the declaration
81 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
83 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
84 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
85 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
87 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
88 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
89 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
90 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
95 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
95 | ERROR | [x] Language constructs must be followed by a single space; expected 1 space but found "··"
95 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
96 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
98 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
98 | ERROR | [x] Missing function doc comment
99 | ERROR | [x] Opening brace should be on the same line as the declaration
100 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
102 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
103 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
103 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
104 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
106 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
107 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
108 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
109 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
110 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
112 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
116 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
118 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
120 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
121 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
123 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
123 | ERROR | [x] Missing function doc comment
124 | ERROR | [x] Opening brace should be on the same line as the declaration
125 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
126 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
127 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
127 | ERROR | [x] Concat operator must be surrounded by a single space
128 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
130 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
132 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
134 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
134 | ERROR | [x] Missing function doc comment
134 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
135 | ERROR | [x] Opening brace should be on the same line as the declaration
136 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
137 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
138 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
140 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
142 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
143 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
144 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
146 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
147 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
147 | ERROR | [x] Expected 1 blank line after function; 0 found
--------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 110 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Duplicator/ChannelDuplicatorInterface.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 6 LINES
-------------------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Missing interface doc comment
10 | ERROR | [x] Opening brace should be on the same line as the declaration
11 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
15 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
17 | ERROR | [ ] Description for the @return value is missing
22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
22 | ERROR | [x] Expected 1 blank line before function; 0 found
22 | ERROR | [x] Expected 1 blank line after function; 0 found
-------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Duplicator/ChannelDuplicator.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 67 ERRORS AND 3 WARNINGS AFFECTING 62 LINES
----------------------------------------------------------------------------------------------------------------------------
9 | WARNING | [x] Unused use statement
11 | ERROR | [x] Missing class doc comment
12 | ERROR | [x] Opening brace should be on the same line as the declaration
13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
13 | ERROR | [ ] Missing short description in doc comment
14 | ERROR | [x] Data types in @var tags need to be fully namespaced
16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
22 | ERROR | [x] Opening brace should be on the same line as the declaration
23 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
26 | ERROR | [x] Missing function doc comment
27 | ERROR | [x] Opening brace should be on the same line as the declaration
28 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
29 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
31 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
33 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
33 | ERROR | [x] Data types in @var tags need to be fully namespaced
34 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
35 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
36 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
37 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
39 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
40 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
41 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
42 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
43 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
44 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
45 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
46 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
47 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
49 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
52 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
52 | ERROR | [x] Missing function doc comment
53 | ERROR | [x] Opening brace should be on the same line as the declaration
54 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
55 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
58 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
59 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
64 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
65 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
65 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
67 | ERROR | [ ] Description for the @return value is missing
69 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
70 | ERROR | [x] Opening brace should be on the same line as the declaration
71 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
73 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
74 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
75 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
76 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
77 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
78 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
78 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
79 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
80 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
82 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
82 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
83 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
85 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8
86 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 12
87 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 16
88 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 12
89 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8
91 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8
92 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
92 | ERROR | [x] Expected 1 blank line after function; 0 found
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 65 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Tool/UrlGenerator.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 126 ERRORS AND 2 WARNINGS AFFECTING 92 LINES
-------------------------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Missing class doc comment
11 | ERROR | [x] Opening brace should be on the same line as the declaration
12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
12 | ERROR | [x] Missing function doc comment
12 | ERROR | [x] Expected 1 blank line before function; 0 found
13 | ERROR | [x] Opening brace should be on the same line as the declaration
14 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
14 | ERROR | [x] There should be no white space after an opening "{"
14 | WARNING | [ ] Line exceeds 80 characters; contains 97 characters
14 | ERROR | [x] Comments may not appear after statements
14 | ERROR | [x] Inline comments must start with a capital letter
15 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
16 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
18 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
19 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
20 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
22 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
23 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
24 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
26 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
27 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
28 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
30 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
30 | ERROR | [x] Concat operator must be surrounded by a single space
31 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
31 | ERROR | [x] Concat operator must be surrounded by a single space
32 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
34 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
35 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
36 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
38 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
40 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
42 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
43 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
44 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
45 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
47 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
49 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
50 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
50 | ERROR | [x] Concat operator must be surrounded by a single space
51 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
53 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
54 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
56 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
56 | ERROR | [x] Missing function doc comment
57 | ERROR | [x] Opening brace should be on the same line as the declaration
58 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
59 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
60 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
61 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
64 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
66 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
67 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
68 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
70 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
71 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
72 | ERROR | [x] Array indentation error, expected 14 spaces but found 20
73 | ERROR | [x] Array closing indentation error, expected 12 spaces but found 16
76 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12
78 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters
78 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12
78 | ERROR | [x] Inline comments must start with a capital letter
78 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
79 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12
79 | ERROR | [x] Concat operator must be surrounded by a single space
79 | ERROR | [x] Concat operator must be surrounded by a single space
81 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12
82 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 16
83 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12
85 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12
85 | ERROR | [x] Concat operator must be surrounded by a single space
86 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
86 | ERROR | [x] Expected newline after closing brace
87 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
88 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
89 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
90 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
92 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
93 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
95 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
96 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
98 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
98 | ERROR | [x] Missing function doc comment
99 | ERROR | [x] Opening brace should be on the same line as the declaration
100 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
101 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
103 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
104 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
105 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
105 | ERROR | [x] Expected newline after closing brace
106 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
107 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
109 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
110 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
111 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
113 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
115 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
116 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
118 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
118 | ERROR | [x] Missing function doc comment
119 | ERROR | [x] Opening brace should be on the same line as the declaration
120 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
120 | ERROR | [x] Concat operator must be surrounded by a single space
121 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
121 | ERROR | [x] Use null coalesce operator instead of ternary operator.
122 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
122 | ERROR | [x] Concat operator must be surrounded by a single space
123 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
123 | ERROR | [x] Use null coalesce operator instead of ternary operator.
124 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
124 | ERROR | [x] Concat operator must be surrounded by a single space
125 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
126 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
126 | ERROR | [x] Use null coalesce operator instead of ternary operator.
127 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
127 | ERROR | [x] Concat operator must be surrounded by a single space
128 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
128 | ERROR | [x] Concat operator must be surrounded by a single space
130 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
130 | ERROR | [x] Concat operator must be surrounded by a single space
130 | ERROR | [x] Concat operator must be surrounded by a single space
130 | ERROR | [x] Concat operator must be surrounded by a single space
130 | ERROR | [x] Concat operator must be surrounded by a single space
130 | ERROR | [x] Concat operator must be surrounded by a single space
130 | ERROR | [x] Concat operator must be surrounded by a single space
130 | ERROR | [x] Concat operator must be surrounded by a single space
131 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
131 | ERROR | [x] Expected 1 blank line after function; 0 found
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 126 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Tool/ArrayHelper.php
----------------------------------------------------------------------------------------------------------------
FOUND 26 ERRORS AND 1 WARNING AFFECTING 20 LINES
----------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Missing class doc comment
8 | ERROR | [x] Opening brace should be on the same line as the declaration
9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
9 | ERROR | [x] Missing function doc comment
9 | ERROR | [x] Expected 1 blank line before function; 0 found
10 | ERROR | [x] Opening brace should be on the same line as the declaration
11 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
12 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
12 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
13 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
15 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
16 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
18 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
18 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
19 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
21 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
21 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
23 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
23 | WARNING | [ ] Unused variable $k.
24 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
26 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
27 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
28 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
29 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
31 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
32 | ERROR | [x] Expected 1 blank line after function; 0 found
----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 26 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Tool/PreviewHelper.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 17 ERRORS AFFECTING 13 LINES
----------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Missing class doc comment
10 | ERROR | [x] Opening brace should be on the same line as the declaration
11 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
13 | ERROR | [x] Missing function doc comment
14 | ERROR | [x] Opening brace should be on the same line as the declaration
15 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
17 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
17 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
17 | ERROR | [x] Concat operator must be surrounded by a single space
18 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
20 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
21 | ERROR | [x] Concat operator must be surrounded by a single space
25 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
27 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
28 | ERROR | [x] Expected 1 blank line after function; 0 found
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 17 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Tool/Slug.php
---------------------------------------------------------------------------------------------------------
FOUND 20 ERRORS AFFECTING 17 LINES
---------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Missing class doc comment
8 | ERROR | [x] Opening brace should be on the same line as the declaration
9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
9 | ERROR | [x] Missing function doc comment
9 | ERROR | [x] Expected 1 blank line before function; 0 found
10 | ERROR | [x] Opening brace should be on the same line as the declaration
11 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
12 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
13 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
15 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
16 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
17 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
18 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
19 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
20 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
21 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
22 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
24 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
25 | ERROR | [x] Expected 1 blank line after function; 0 found
---------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 20 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/ekino_rendr/src/Router/RouterSubscriber.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 99 ERRORS AND 6 WARNINGS AFFECTING 80 LINES
-------------------------------------------------------------------------------------------------------------------------------
8 | WARNING | [x] Unused use statement
9 | WARNING | [x] Unused use statement
13 | ERROR | [ ] Missing short description in doc comment
17 | ERROR | [x] Opening brace should be on the same line as the declaration
18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
21 | ERROR | [ ] Missing member variable doc comment
22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
22 | ERROR | [ ] Missing member variable doc comment
24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
25 | ERROR | [x] Opening brace should be on the same line as the declaration
26 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
28 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
31 | ERROR | [x] Missing function doc comment
32 | ERROR | [x] Opening brace should be on the same line as the declaration
33 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
34 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
35 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
39 | ERROR | [x] Missing function doc comment
40 | ERROR | [x] Opening brace should be on the same line as the declaration
41 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
42 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
43 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
45 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
47 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
47 | ERROR | [x] Missing function doc comment
48 | ERROR | [x] Opening brace should be on the same line as the declaration
49 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
52 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
52 | ERROR | [x] Missing function doc comment
53 | ERROR | [x] Opening brace should be on the same line as the declaration
54 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
55 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
55 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
56 | ERROR | [x] Object operator not indented correctly; expected 10 spaces but found 12
57 | ERROR | [x] Space after closing parenthesis of function call prohibited
58 | ERROR | [x] Space found before semicolon; expected ");" but found ")\n ;"
60 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
62 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
63 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
64 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
66 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
68 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
68 | ERROR | [x] Data types in @var tags need to be fully namespaced
69 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
70 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
70 | WARNING | [x] The variable name should be defined after the type
71 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
73 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
74 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
74 | ERROR | [x] Data types in @var tags need to be fully namespaced
75 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
77 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
78 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
79 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
81 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
81 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
81 | ERROR | [x] There should be no white space after an opening "{"
81 | WARNING | [ ] Line exceeds 80 characters; contains 111 characters
81 | ERROR | [x] Comments may not appear after statements
81 | ERROR | [x] Inline comments must start with a capital letter
81 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
82 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
83 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
85 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
87 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
88 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
88 | ERROR | [x] There should be no white space after an opening "{"
88 | WARNING | [ ] Line exceeds 80 characters; contains 146 characters
88 | ERROR | [x] Comments may not appear after statements
88 | ERROR | [x] Inline comments must start with a capital letter
88 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
89 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 24
90 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
92 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
94 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
95 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
96 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
98 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
99 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 24
99 | ERROR | [x] Concat operator must be surrounded by a single space
100 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
102 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
104 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
105 | ERROR | [x] Array indentation error, expected 22 spaces but found 24
106 | ERROR | [x] Array indentation error, expected 22 spaces but found 24
109 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 20
109 | ERROR | [x] Concat operator must be surrounded by a single space
110 | ERROR | [x] Array indentation error, expected 22 spaces but found 24
111 | ERROR | [x] Array indentation error, expected 22 spaces but found 24
112 | ERROR | [x] Array indentation error, expected 22 spaces but found 24
112 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
114 | ERROR | [x] Array indentation error, expected 22 spaces but found 24
116 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
117 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
118 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
120 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
121 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
121 | ERROR | [x] Expected 1 blank line after function; 0 found
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 99 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------
Time: 1.91 secs; Memory: 18MBKindly check.
Thanks,
Jake
Hi @bharath-kondeti,
Applied the changes you committed on MR!4 and these are the reported errors. Please see below:
➜ menu_link_by_role git:(1.0.x) curl https://git.drupalcode.org/project/menu_link_by_role/-/merge_requests/1.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 6574 0 6574 0 0 17814 0 --:--:-- --:--:-- --:--:-- 18261
patching file README.txt
patching file menu_link_by_role.module
➜ menu_link_by_role git:(1.0.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig menu_link_by_role
FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/menu_link_by_role/menu_link_by_role.module
----------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------
116 | ERROR | [x] Whitespace found at end of line
121 | ERROR | [x] Whitespace found at end of line
122 | ERROR | [x] Return type must not contain variable name "$result"
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------
Time: 146ms; Memory: 10MBKindly check
Thanks,
Jake
Hi @everyone,
Also reviewed MR!4 and confirmed no errors remaining.
site_branding_per_role git:(2.x) curl https://git.drupalcode.org/project/site_branding_per_role/-/merge_requests/4.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1338 0 1338 0 0 3275 0 --:--:-- --:--:-- --:--:-- 3345
patching file src/Plugin/Block/SiteBrandingPerRoleBlock.php
➜ site_branding_per_role git:(2.x) ✗ .
.: not enough arguments
➜ site_branding_per_role git:(2.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig site_branding_per_role
➜ contrib git:(master) ✗Will now move this to RTBC.
Thanks,
Jake
Hi @everyone,
The changes made on the MR !9 were confirmed addressed #16's comments. Please see attached image.
Will now move this to RTBC
Thanks,
Jake
Hi @bharath_kondeti,
Applied the changes you committed on MR!3, it was applied not-so successfully, but miraculously, there are no errors reported.
➜ webform_simplenews_handler git:(2.0.x) curl https://git.drupalcode.org/project/webform_simplenews_handler/-/merge_requests/3.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1805 0 1805 0 0 4388 0 --:--:-- --:--:-- --:--:-- 4467
patching file README.md
patching file src/Plugin/WebformHandler/SubmissionSimplenewsWebformHandler.php
patching file webform_simplenews_handler.info.yml
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file webform_simplenews_handler.info.yml.rej
➜ webform_simplenews_handler git:(2.0.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig webform_simplenews_handler
➜ contrib git:(master) ✗Will not transition this yet so that others will review it too.
Thanks,
Jake
Hi @everyone,
Also applied patch from comment #3, confirmed no issues remaining.
sdb git:(1.0.x) curl https://www.drupal.org/files/issues/2023-10-17/phpcs-issue-fixes.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 2885 100 2885 0 0 6507 0 --:--:-- --:--:-- --:--:-- 6647
patching file simple_date_block.info.yml
patching file src/Plugin/Block/SimpleDateBlock.php
➜ sdb git:(1.0.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig sdb
➜ contrib git:(main) ✗Will now move this to RTBC
Thanks,
Jake
Hi @bakop,
Applied the changes you committed on MR!2, it was applied smoothly but one error still reported. Please see below:
➜ field_image_style git:(8.x-1.x) curl https://git.drupalcode.org/project/field_image_style/-/merge_requests/2.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 15536 0 15536 0 0 33434 0 --:--:-- --:--:-- --:--:-- 34070
patching file field_image_style.module
patching file src/Plugin/Field/FieldFormatter/ImageStyleImageFormatter.php
patching file src/Plugin/Field/FieldType/ImageStyleItem.php
➜ field_image_style git:(8.x-1.x) ✗ ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig field_image_style
FILE: ...d_image_style/src/Plugin/Field/FieldFormatter/ImageStyleImageFormatter.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
12 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\File\FileUrlGeneratorInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 247ms; Memory: 10MBKindly check
Thanks,
Jake
Hi @Nikolay Shapovalov,
Applied the changes you made on MR!1 to the 8.x-1.x branch of this module, it was applied smoothly, however, multiple errors were still reported. Please see below:
➜ entity_vistiors git:(8.x-1.x) curl https://git.drupalcode.org/project/entity_vistiors/-/merge_requests/1.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 12193 0 12193 0 0 29408 0 --:--:-- --:--:-- --:--:-- 30106
patching file entity_visitors.info.yml
patching file entity_visitors.page.inc
patching file src/EntityVisitorsListBuilder.php
patching file src/EventSubscriber/EntityRouteMatchSubscriber.php
patching file src/EventSubscriber/SendMailOnEntityVisitedSubscriber.php
patching file src/Form/EntityVisitiorsConfig.php
patching file src/Form/EntityVisitorsForm.php
patching file src/Form/EntityVisitorsSettingsForm.php
patching file src/Service/EntityVisitorsManager.php
➜ entity_vistiors git:(8.x-1.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig entity_vistiors
FILE: ...modules/contrib/entity_vistiors/src/EntityVisitorsAccessControlHandler.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Access\AccessResult.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...issue-v9/web/modules/contrib/entity_vistiors/src/Entity/EntityVisitors.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Entity\ContentEntityBase.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: .../web/modules/contrib/entity_vistiors/src/Service/EntityVisitorsManager.php
--------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 9 LINES
--------------------------------------------------------------------------------
12 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Config\ConfigManagerInterface.
73 | ERROR | [x] Multi-line function declaration not indented correctly;
| | expected 4 spaces but found 8
74 | ERROR | [x] Multi-line function declaration not indented correctly;
| | expected 4 spaces but found 8
75 | ERROR | [x] Multi-line function declaration not indented correctly;
| | expected 4 spaces but found 8
76 | ERROR | [x] Multi-line function declaration not indented correctly;
| | expected 4 spaces but found 8
77 | ERROR | [x] Multi-line function declaration not indented correctly;
| | expected 4 spaces but found 8
78 | ERROR | [x] Multi-line function declaration not indented correctly;
| | expected 4 spaces but found 8
79 | ERROR | [x] Multi-line function declaration not indented correctly;
| | expected 4 spaces but found 8
79 | ERROR | [x] Multi-line function declarations must have a trailing comma
| | after the last parameter
80 | ERROR | [x] Multi-line function declaration not indented correctly;
| | expected 2 spaces but found 4
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: .../entity_vistiors/src/EventSubscriber/SendMailOnEntityVisitedSubscriber.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Entity\EntityTypeManagerInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...contrib/entity_vistiors/src/EventSubscriber/EntityRouteMatchSubscriber.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
11 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Component\Datetime\TimeInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 357ms; Memory: 10MBKindly check
Thanks,
Jake
Hi @nitin_lama,
Applied the changes you made on MR!1, it was applied smoothly but few errors were still reported. Please see below:
➜ bootstrap_govbr git:(8.1.1) curl https://git.drupalcode.org/project/bootstrap_govbr/-/merge_requests/1.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 224k 0 224k 0 0 431k 0 --:--:-- --:--:-- --:--:-- 437k
patching file README.md
patching file bootstrap_govbr.info.yml
patching file bootstrap_govbr.theme
patching file css/bootstrap.css
patching file css/variables.css
patching file gulpfile.js
patching file js/global.js
➜ bootstrap_govbr git:(8.1.1) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig bootstrap_govbr
FILE: ...l-orgissue-v9/web/modules/contrib/bootstrap_govbr/bootstrap_govbr.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | "core_version_requirement" property is missing in the info.yml
| | file
--------------------------------------------------------------------------------
FILE: ...e/drupal-orgissue-v9/web/modules/contrib/bootstrap_govbr/css/variables.css
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | ERROR | [x] Additional whitespace found at start of file
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...-site/drupal-orgissue-v9/web/modules/contrib/bootstrap_govbr/css/style.css
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------
Time: 1.53 secs; Memory: 52.01MBKindly check
Thanks,
Jake
Hi @Neha-Verma,
The change you made on MR!1 was applied not-so successfully, and as expected multiple errors were reported. Please see below:
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig monobank
FILE: ...nterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/monobank/README.md
--------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------------
3 | ERROR | Missing short description in doc comment
10 | ERROR | Doc comment is empty
13 | ERROR | Invalid function name, expected
| | h_oo_k_monobank_payment_params_alter but found
| | HOOK_monobank_payment_params_alter
22 | ERROR | Doc comment is empty
25 | ERROR | Invalid function name, expected h_oo_k_monobank_api_alter but
| | found HOOK_monobank_api_alter
--------------------------------------------------------------------------------
FILE: ...-orgissue-v9/web/modules/contrib/monobank/templates/monobank-pay.html.twig
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
2 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...-v9/web/modules/contrib/monobank/templates/monobank-success-page.html.twig
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
3 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: .../drupal-orgissue-v9/web/modules/contrib/monobank/src/Form/SettingsForm.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------------
38 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
43 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
98 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
113 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
117 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
117 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
--------------------------------------------------------------------------------
FILE: ...e/drupal-orgissue-v9/web/modules/contrib/monobank/src/Form/PaymentForm.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AND 9 WARNINGS AFFECTING 11 LINES
--------------------------------------------------------------------------------
36 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
37 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
67 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
72 | ERROR | unserialize() is insecure unless allowed classes are limited.
| | Use a safe format like JSON or use the allowed_classes option.
92 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
93 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
105 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
121 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
127 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
141 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
145 | ERROR | unserialize() is insecure unless allowed classes are limited.
| | Use a safe format like JSON or use the allowed_classes option.
--------------------------------------------------------------------------------
FILE: ...Demo-site/drupal-orgissue-v9/web/modules/contrib/monobank/src/Monobank.php
--------------------------------------------------------------------------------
FOUND 8 ERRORS AND 5 WARNINGS AFFECTING 10 LINES
--------------------------------------------------------------------------------
68 | ERROR | [x] The first parameter of a multi-line function declaration
| | must be on the line after the opening bracket
69 | ERROR | [x] Multi-line function declaration not indented correctly;
| | expected 4 spaces but found 6
70 | ERROR | [x] Multi-line function declaration not indented correctly;
| | expected 4 spaces but found 6
71 | ERROR | [x] Multi-line function declaration not indented correctly;
| | expected 4 spaces but found 6
72 | ERROR | [x] Multi-line function declaration not indented correctly;
| | expected 4 spaces but found 6
72 | ERROR | [x] Multi-line function declarations must have a trailing
| | comma after the last parameter
72 | ERROR | [x] The closing parenthesis of a multi-line function
| | declaration must be on a new line
160 | ERROR | [ ] unserialize() is insecure unless allowed classes are
| | limited. Use a safe format like JSON or use the
| | allowed_classes option.
172 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency
| | injection instead
185 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency
| | injection instead
198 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency
| | injection instead
198 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency
| | injection instead
213 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency
| | injection instead
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: .../web/modules/contrib/monobank/src/Plugin/Basket/Payment/BasketMonobank.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------------
6 | WARNING | [x] Unused use statement
6 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is
| | Drupal\basket\Plugins\Payment\Annotation\BasketPayment.
11 | ERROR | [ ] Missing short description in doc comment
50 | WARNING | [ ] t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
87 | WARNING | [ ] Only string literals should be passed to t() where possible
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...e/drupal-orgissue-v9/web/modules/contrib/monobank/src/Controller/Pages.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------
72 | WARNING | Only string literals should be passed to t() where possible
114 | ERROR | unserialize() is insecure unless allowed classes are limited.
| | Use a safe format like JSON or use the allowed_classes option.
156 | WARNING | Code after the EXIT statement on line 154 cannot be executed
--------------------------------------------------------------------------------
Time: 501ms; Memory: 12MBKindly check
Thanks,
Jake
Hi @sakthi_dev,
Applied the changes made on MR!1, it was applied smoothly but multiple files with an error were still reported. Please see below:
➜ fieldory git:(8.x-1.x) curl https://git.drupalcode.org/project/fieldory/-/merge_requests/1.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 21702 0 21702 0 0 54027 0 --:--:-- --:--:-- --:--:-- 55081
patching file README.md
patching file fieldory_examples/src/Commands/FieldoryExamplesCommands.php
patching file src/Annotation/Fieldory.php
patching file src/Constants/FieldoryId.php
patching file src/Exception/InvalidFieldoryException.php
patching file src/Exception/InvalidFrequentlyUsedOptionsException.php
patching file src/Exception/InvalidPropertyException.php
patching file src/Exception/ModuleNotInstalledException.php
patching file src/FieldoryBase.php
patching file src/FieldoryBundle.php
patching file src/FieldoryInterface.php
patching file src/FieldoryManager.php
patching file src/FrequentlyUsedOptions/BoolFrequentlyUsedOptions.php
patching file src/FrequentlyUsedOptions/FloatFrequentlyUsedOptions.php
patching file src/FrequentlyUsedOptions/IntegerFrequentlyUsedOptions.php
patching file src/FrequentlyUsedOptions/ListIntegerFrequentlyUsedOptions.php
patching file src/FrequentlyUsedOptions/ParagraphFrequentlyUsedOptions.php
patching file src/FrequentlyUsedOptions/TermFrequentlyUsedOptions.php
patching file src/FrequentlyUsedOptionsBase.php
patching file src/Plugin/Fieldory/BoolField.php
patching file src/Plugin/Fieldory/FloatField.php
patching file src/Plugin/Fieldory/IntegerField.php
patching file src/Plugin/Fieldory/ListIntegerField.php
patching file src/Plugin/Fieldory/MonthYearField.php
patching file src/Plugin/Fieldory/ParagraphField.php
patching file src/Plugin/Fieldory/StringField.php
patching file src/Plugin/Fieldory/TelephoneField.php
patching file src/Plugin/Fieldory/TermField.php
patching file src/Plugin/Fieldory/TextLongField.php
➜ fieldory git:(8.x-1.x) ✗ ..
➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig fieldory
FILE: ...trib/fieldory/src/FrequentlyUsedOptions/ParagraphFrequentlyUsedOptions.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is
| | Drupal\fieldory\Exception\InvalidPropertyException.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...s/contrib/fieldory/src/FrequentlyUsedOptions/BoolFrequentlyUsedOptions.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is
| | Drupal\fieldory\Exception\InvalidPropertyException.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: .../contrib/fieldory/src/FrequentlyUsedOptions/FloatFrequentlyUsedOptions.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is
| | Drupal\fieldory\Exception\InvalidPropertyException.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...ib/fieldory/src/FrequentlyUsedOptions/ListIntegerFrequentlyUsedOptions.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is
| | Drupal\fieldory\Exception\InvalidPropertyException.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...s/contrib/fieldory/src/FrequentlyUsedOptions/TermFrequentlyUsedOptions.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is
| | Drupal\fieldory\Exception\InvalidPropertyException.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...ontrib/fieldory/src/FrequentlyUsedOptions/IntegerFrequentlyUsedOptions.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is
| | Drupal\fieldory\Exception\InvalidPropertyException.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 512ms; Memory: 12MBKindly check
Thanks,
Jake