Account created on 9 May 2024, 8 months ago
#

Recent comments

I agree, the failed jobs should have their own issue, hence, will move this to RTBC as I have confirmed that the GitLab has been enabled.

Thanks,
Jake

Hi @kinyein,

It is recommended to use GitLab CI to run automated fixes, I have enabled the pipeline and as can be seen, the phpcs job failed.

Kindly check

Thanks,
Jake

Hi @kinyein,

I have enabled the Gitlab pipeline and confirmed the phpcs job failed.

Kindly check

Thanks,
Jake

a.aaronjake made their first commit to this issue’s fork.

Hi @ismaelromero,

I have checked the pipeline and re-ran the phpcs job. Confirmed no errors remaining and the job suceeded.

Will now move this to RTBC

Thanks,
Jake

I have enabled the GitLab, however the composer failed and as obvious as it is, the phpcs and related jobs have not ran yet.

Kindly check and fix

Thanks,
Jake

Hi @rohit rana,

I have applied the patch you provided, it was applied (as seen below:) successfully yet, the twitter logo has not changed and the display is still the old logo. And also I noticed an error on the homepage regarding the theme.

 yg_restaurant git:(2.0.x) curl https://www.drupal.org/files/issues/2024-11-30/issue-resolved-3425635-8.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3276  100  3276    0     0   5581      0 --:--:-- --:--:-- --:--:--  5707
patching file templates/html.html.twig
patching file templates/page--403.html.twig
patching file templates/page--404.html.twig
patching file templates/page--front.html.twig
patching file templates/page.html.twig
➜  yg_restaurant git:(2.0.x) ✗

Please see attached images for reference.

Thanks,
Jake

Hi @divyansh.gupta,

I have also checked the pipeline and confirmed the phpcs job succeeded.

Will now move this to RTBC but feel free to re-transition if other related jobs needs to be fixed on this issue.

Thanks,
Jake

Hi @niharika.s,

I have applied the patch you provided, and confirmed a README.md file is added to the module with the correct information that also follows the standard template. Attaching images for reference.

Will now move this to RTBC.

Thanks,
Jake

Hi @akulsaxena, & @avpaderno,

I have checked the pipeline and confirmed the phpcs are updated according to the suggestions. I have also re-ran the phpcs job and confirmed it suceeded.

Will now move this to RTBC.

Thanks,
Jake

Hi @liam morland,

I have replicated the issue and applied the patch you provided, confirmed the issue is solved, however, would it be possible to display the radio buttons at the center of the column. Please see images for reference.

Thanks,
Jake

Hi @anybody,

I have checked the pipeline and found that the cspell job failed, please check

Thanks,
Jake

Hi @akulsaxena,

I have checked the pipeline and re-ran the phpcs and cspell jobs and confirmed the jobs succeeded.

Will now move this to RTBC.

Thanks,
Jake

Hi @sayan_k_dutta,

I have checked the pipeline and reran the phpstan job. Confirmed the job succeeded.

Will now move this to RTBC.

Thanks,
J//ake

Hi @kul.pratap,

I have checked the pipeline and re-ran the phpcs job, confirmed it succeeded.

Will now move this to RTBC.

Thanks,
Jake

Hi @divyansh.gupta,

I have checked and re-ran the phpcs job and confirmed it passed.

Will now move this to RTBC

Thanks,
Jake

Hi @akulsaxena,

I have checked and even re-ran the job and confirmed phpcs passed.

Will now move this to RTBC

Thanks,
Jake

Hi @Jasonac91,

Kindly check the MR !20 because it has an error. Will now move this to 'Needs Work'.

Thanks,
Jake

Hi @ismaelromero,

I have applied the commits you made on MR !34 and confirmed it fixed all reported issues.

svg_image_field git:(2.3.x) curl https://git.drupalcode.org/project/svg_image_field/-/merge_requests/34.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2504    0  2504    0     0   6202      0 --:--:-- --:--:-- --:--:--  6387
patching file CONTRIBUTING.md
patching file README.md
➜  svg_image_field git:(2.3.x) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig svg_image_field
➜  contrib git:(main) ✗

Will now move this to RTBC

Thanks,
Jake

Hi @reveen.thakur51,

I have reviewed the MR and confirmed the configuration of GitLab CI is added and the pipeline is working properly.

Will now move this to RTBC since it is noted that the jobs can be checked on separate issues.

Thanks,
Jake

Hi @torfj,

I have confirmed the commits you made on MR!4 and confirmed the README.md follows the standard template. I have added an image for reference.

Will now move this to RTBC

Thanks,
Jake

Hi @ankitv18,

I have reviewed your commits and confirmed the gitlab template was added to the MR!3, also confirmed can run the pipeline.

Will now move this to RTBC

Thanks,
Jake

Hi @gremy,

I have confirmed that a GitLab CI configuration was added to the MR and that the pipeline may run without error, however, some jobs resulted an error. Kindly advise whether to create another issue for the failed jobs or should it be fixed in this issue.

Thanks,
Jake

Hi @gremy,

I confirm that a GitLab CI configuration is added to the MR, confirmed pipeline can run without errors, however, the jobs needs to be fixed. Should another issue be created for the failed jobs or should it be fixed in this issue?

Kindly advise on the best solution there is.

Thanks,
Jake

Hi @everyone,

I have also enabled and ran the phpcs job confirmed passed.

Thanks,
Jake

Hi @kul.pratap,

I have reviewed the pipeline and confirmed the cspell job succeeded. For the phpcs errors, I think it is fine since there is another ticket for it, you can check it here 🐛 phpcs: 12 failed, 12 total tests Active if you'd like.

Will move this to RTBC now.

Thanks,
Jake

Hi @chhavi.sharma,

I have reviewed your changes on MR!5 and confirmed the suggestion of sir @avpaderno was followed and the phpcs job passed.

Will now move this to RTBC

Thanks,
Jake

Hi @the_g_bomb,

I have enabled and re-ran the cspell job, and it still did not pass. 3290470

Kindly check

Thanks,
Jake

Hi @the_g_bomb,

I have checked the pipeline and confirmed the phpcs job succeeded: 3248720

Will now move this to RTBC

Thanks,
Jake

Hi @the_g_bomb,

I have reviewed the stylelint job and confirmed it succeed, for anyone's reference: stylelint job success

I will now move this to RTBC

Thanks,
Jake

Hi @the_g_bomb,

I have checked the pipeline and confirmed phpcs job succeeded: phpcs job success

Will now move this to RTBC

Thanks,
Jake

Hi @the_g_bomb,

I have reviewed the pipeline and confirmed the cspell job succeeded: cspell job success

Will now move this to RTBC

Thanks,
Jake

Will there be another meeting? I'd like to join and learn from you guys! Also I'd like to kindly ask some instructions on how to join. :peace:

Thanks,
Jake

Hi @arunsahijpal,

I have applied the commits you made on MR!3, it was applied successfully and confirmed no issues are reported anymore. Please see:

paragraph_control git:(1.0.x) curl https://git.drupalcode.org/project/paragraph_control/-/merge_requests/3.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1401    0  1401    0     0   4826      0 --:--:-- --:--:-- --:--:--  5021
patching file paragraph_control.install
patching file paragraph_control.module
➜  paragraph_control git:(1.0.x) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig paragraph_control

➜  contrib git:(main) ✗

Will now move this to RTBC

Thanks,
Jake

Hi @dhruv.mittal,

I have checked and re-run the phpcs pipeline, and confirmed the job succeeded. Please check: Phpcs job succeeded

Will now move this to RTBC

Thanks,
Jake

Hi @tr,

I have confirmed that the GitLab CI testing is now turned on, looks like a lot of issues will be created because I saw lots of failed jobs on the pipeline. Lol.

Will now move this to RTBC.

Thanks,
Jake

Hi @kul.pratap.,

I have re-ran the pipeline, confirmed the phpcs errors are now fixed and the pipeline passed:
Gitlab CI pipeline passed phpcs

Will now move this to RTBC since this issue is for the phpcs only.

Thanks,
Jake

Hi sayan_k_dutta,

Confirmed the commit you added to the MR fixed the reported issue.

gnu_terry_pratchett git:(main) ✗ curl https://git.drupalcode.org/project/gnu_terry_pratchett/-/merge_requests/4.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3290    0  3290    0     0   9154      0 --:--:-- --:--:-- --:--:--  9426
patching file gnu_terry_pratchett.module
patching file gnu_terry_pratchett.services.yml
patching file src/EventSubscriber/XClacksSubscriber.php
patching file src/Tests/Headers/XClacksTest.php
➜  gnu_terry_pratchett git:(main) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig gnu_terry_pratchett
➜  contrib git:(main) ✗

Will now move this to RTBC

Thanks,
Jake

Hi @the_g_bomb,

I have verified the phpcs issues on my terminal, the commits you made on MR!4 can be applied successfully and after applying it, confirmed most issues were fixed, however, one error still persisted. Please see below:

 gnu_terry_pratchett git:(main) ✗ curl https://git.drupalcode.org/project/gnu_terry_pratchett/-/merge_requests/4.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2951    0  2951    0     0   8990      0 --:--:-- --:--:-- --:--:--  9338
patching file gnu_terry_pratchett.module
patching file gnu_terry_pratchett.services.yml
patching file src/EventSubscriber/XClacksSubscriber.php
patching file src/Tests/Headers/XClacksTest.php
➜  gnu_terry_pratchett git:(main) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig gnu_terry_pratchett

FILE: .../web/modules/contrib/gnu_terry_pratchett/src/Tests/Headers/XClacksTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 32 | ERROR | Public method name "XClacksTest::testXClacksHeaders" is not in
    |       | lowerCamel format
--------------------------------------------------------------------------------

Time: 135ms; Memory: 10MB

Kindly check

Thanks,
Jake

Hi @ankitv18,

I have applied the changes you committed on MR17 and after applying it, confirmed a gitlab file with the correct template. Please see attached images for reference.

Will move this to RTBC

Thanks,
Jake

Hi @akulsaxena,

I have applied the patch you provided, confirmed can be applied smoothly, however, there are still errors reported that are on the css files you mentioned. Please see below:

ceremai git:(master) ✗ curl https://www.drupal.org/files/issues/2024-11-04/3361446-coding_standard_Phpcs.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 55292  100 55292    0     0   499k      0 --:--:-- --:--:-- --:--:--  556k
patching file README.md
patching file README.txt
patching file ceremai.theme
patching file config/install/ceremai.settings.yml
patching file css/advanced.css
patching file css/bootstrap-3.3.7.css
patching file css/bootstrap.css
patching file css/colorscheme.css
patching file css/component.css
patching file css/content.css
patching file css/custom.css
patching file css/footer.css
patching file css/header.css
patching file css/styles.css
patching file js/advanced.js
➜  ceremai git:(master) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig ceremai

FILE: ...erns/Demo-site/drupal-orgissue-v9/web/themes/contrib/ceremai/ceremai.theme
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is Drupal\block\Entity\Block.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...site/drupal-orgissue-v9/web/themes/contrib/ceremai/css/bootstrap-3.3.7.css
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
 3673 | ERROR | Style definitions must end with a semicolon
 6420 | ERROR | Style definitions must end with a semicolon
 6430 | ERROR | Style definitions must end with a semicolon
--------------------------------------------------------------------------------


FILE: .../Demo-site/drupal-orgissue-v9/web/themes/contrib/ceremai/css/bootstrap.css
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
 3662 | ERROR | Style definitions must end with a semicolon
 6413 | ERROR | Style definitions must end with a semicolon
 6423 | ERROR | Style definitions must end with a semicolon
--------------------------------------------------------------------------------


FILE: ...pal-orgissue-v9/web/themes/contrib/ceremai/templates/system/page.html.twig
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 276 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...eb/themes/contrib/ceremai/templates/node/node--article--slider-1.html.twig
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 23 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...pal-orgissue-v9/web/themes/contrib/ceremai/templates/block/block.html.twig
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 66 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 3.6 secs; Memory: 58.01MB

Kindly check again

Thanks,
Jake

Hi @the_g_bomb,

I have applied the commits you made on MR!3, and it was applied successfully, also confirmed that the Gitlab CI file was added to the module. Please see image for reference.

Will move this to RTBC

Thanks,
Jake

Hi @the_g_bomb,

I have applied the commits you made on MR!3, confirmed Gitlab CI added. Please see attached image for reference.

Will now move this to RTBC so that it will be merged.

Thanks,
Jake

Hi @gslente,

I have applied your commits on MR!8, however, the README.txt file was not replaced with the README.md. Please see attached image for your reference.

Thanks,
Jake

📌 | Mundus | Gitlab CI

Hi @barbara.losnc,

Can you please just commit the gitlab ci file and not the whole file, it looks like you included all files - if not, there are still multiple files that are irrelevant to this issue.

Thanks,
Jake

Hi @mohd sahzad,

I have applied the commits you made on MR !2, and confirmed README file was added. Please see attached image for reference.

Will move this to RTBC

Thanks,
Jake

Hi @anktiv18,

I have applied the commits you made on MR!3, it was applied successfully and confirmed gitlab file added with the standard template. Please see attached images for reference. Will move this to RTBC.

Thanks,
Jake

Hi @ankitv18,

I have applied the commits you made on MR!11, it was applied successfully and confirmed GitLab CI file was added with the standard template. Please see the attached images for reference, will also move this to RTBC.

Thanks,
Jake

Hi @acbramley,

Thank you for the response, will now move this to RTBC.

Thanks,
Jake

Hi @acbramley,

I have applied your commits on MR!6, it was applied successfully and confirmed GitLab CI file was added, however, is it fine not to put the standard template there? Please see the attached images for reference. Will move this to 'Needs Work'.

Kindly check

Thanks,
Jake

Hi @gremy,

I have installed the module and applied your commits on MR!2, it was applied successfully and confirmed GitLab CI configuration added, it even follows the standard template. Please see attached images for reference, will also move this to RTBC.

Thanks,
Jake

Hi @jonhattan,

I have applied the MR!12, it was applied successfully and confirmed gitlab CI added w/ the correct template. Please see attached images for reference, will also move this to RTBC.

Thanks,
Jake

Hi @jonathan,

I have applied the commits you made on MR!8, it was applied successfully and confirmed Gitlab CI added with the correct template. Please see attached images. Will move this to RTBC.

Thanks,
Jake

Hi @amit.rawatt777,

I have applied your patch, it was applied so smoothly, however and unfortunately, the reported errors this time increased compared to the previously reported errors. Please see below:

➜  ceremai git:(master) ✗ curl https://www.drupal.org/files/issues/2024-08-26/phpcs-3361446-9.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 56531  100 56531    0     0   328k      0 --:--:-- --:--:-- --:--:--  351k
patching file README.md
patching file README.txt
patching file ceremai.info.yml
patching file ceremai.theme
patching file config/install/ceremai.settings.yml
patching file css/advanced.css
patching file css/bootstrap-3.3.7.css
patching file css/bootstrap.css
patching file css/colorscheme.css
patching file css/component.css
patching file css/content.css
patching file css/custom.css
patching file css/footer.css
patching file css/header.css
patching file css/styles.css
➜  ceremai git:(master) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig ceremai

FILE: ...erns/Demo-site/drupal-orgissue-v9/web/themes/contrib/ceremai/ceremai.theme
--------------------------------------------------------------------------------
FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------------
   9 | ERROR   | [x] Use statements should be sorted alphabetically. The first
     |         |     wrong one is Drupal\block\Entity\Block.
  43 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters
 162 | WARNING | [ ] Translatable strings must not begin or end with white
     |         |     spaces, use placeholders with t() for variables
 180 | ERROR   | [ ] Doc comment is empty
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...site/drupal-orgissue-v9/web/themes/contrib/ceremai/css/bootstrap-3.3.7.css
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
 3673 | ERROR | Style definitions must end with a semicolon
 6420 | ERROR | Style definitions must end with a semicolon
 6430 | ERROR | Style definitions must end with a semicolon
--------------------------------------------------------------------------------

FILE: ...pal-orgissue-v9/web/themes/contrib/ceremai/templates/system/page.html.twig
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 276 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...eb/themes/contrib/ceremai/templates/node/node--article--slider-1.html.twig
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 23 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...pal-orgissue-v9/web/themes/contrib/ceremai/templates/block/block.html.twig
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 66 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 3.62 secs; Memory: 58.01MB

Kindly check

Thanks,
Jake

Hi @Akshay

I have applied the commits you made on MR!5, confirmed it can be applied successfully, however, there are still indentions issues not yet fixed. Please see below:

➜  parameters git:(1.0.x) curl https://git.drupalcode.org/project/parameters/-/merge_requests/5.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 45872    0 45872    0     0   114k      0 --:--:-- --:--:-- --:--:--  117k
patching file modules/parameters_ui/src/Controller/ParametersUiController.php
patching file modules/parameters_ui/src/Form/ParameterDeleteForm.php
patching file modules/parameters_ui/src/Form/ParameterForm.php
patching file modules/parameters_ui/src/Form/ParametersCollectionAddForm.php
patching file modules/parameters_ui/src/Form/ParametersCollectionForm.php
patching file modules/parameters_ui/src/Form/ParametersCollectionLockForm.php
patching file modules/parameters_ui/src/Form/ParametersCollectionUnlockForm.php
patching file modules/parameters_ui/src/ParametersUiListBuilder.php
patching file modules/parameters_ui/src/Routing/ParametersUiRouteEnhancer.php
patching file parameters.install
patching file src/Entity/ParametersCollectionStorage.php
patching file src/EventSubscriber/ParametersConfigOverrideSubscriber.php
patching file src/Exception/ParameterNotFoundException.php
patching file src/Internals/ContentSerializationCompilerPass.php
patching file src/Normalizer/Legacy/ParametersContentEntityNormalizer.php
patching file src/Normalizer/ParametersContentEntityNormalizer.php
patching file src/ParameterRepository.php
patching file src/Plugin/Derivative/Parameter/ContentDeriver.php
patching file src/Plugin/Parameter/Bundles.php
patching file src/Plugin/Parameter/Content.php
patching file src/Plugin/Parameter/Fields.php
patching file src/Plugin/Parameter/Http.php
patching file src/Plugin/Parameter/Increment.php
patching file src/Plugin/Parameter/NullObject.php
patching file src/Plugin/Parameter/Roles.php
patching file src/Plugin/Parameter/Types.php
patching file src/Plugin/ParameterManager.php
patching file tests/src/Kernel/ParametersTokenTest.php
➜  parameters git:(1.0.x) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig parameters

FILE: ...mo-site/drupal10-orgissue/web/modules/contrib/parameters/parameters.module
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
 84 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
 87 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
 89 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...0-orgissue/web/modules/contrib/parameters/src/Plugin/Parameter/Content.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 10 WARNINGS AFFECTING 10 LINES
--------------------------------------------------------------------------------
 186 | WARNING | Unused variable $bundle.
 189 | WARNING | Unused variable $bundle.
 357 | WARNING | Unused variable $cleanupFieldValues.
 358 | WARNING | Unused variable $normalizeNewEntities.
 363 | WARNING | Unused variable $cleanupFieldValues.
 364 | WARNING | Unused variable $normalizeNewEntities.
 381 | WARNING | Unused variable $cleanupFieldValues.
 382 | WARNING | Unused variable $normalizeNewEntities.
 387 | WARNING | Unused variable $cleanupFieldValues.
 388 | WARNING | Unused variable $normalizeNewEntities.
--------------------------------------------------------------------------------

Time: 3.45 secs; Memory: 20MB

Also, can you please change the status of the issue to 'Needs Review' if you made your work on it? It is so that this will be seen as 'Needs Review' on the Issues page.

Kindly check

Thanks,
Jake

Hi @Akshay,

I have applied the commits you made on MR!1, it was applied smoothly and confirmed most issues other than unused variables were fixed. For the maintainer/s, please see below for the issues not yet fixed:

slack_rtm git:(8.x-1.x) ✗ curl https://git.drupalcode.org/project/slack_rtm/-/merge_requests/1.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 23345    0 23345    0     0  63877      0 --:--:-- --:--:-- --:--:-- 65209
patching file .gitlab-ci.yml
patching file config/install/slack_rtm.settings.yml
patching file config/schema/slack_rtm.schema.yml
patching file slack_rtm.links.menu.yml
patching file slack_rtm.links.task.yml
patching file slack_rtm.module
patching file slack_rtm.permissions.yml
patching file slack_rtm.routing.yml
patching file src/Batch/SlackRtmBatch.php
patching file src/Entity/SlackRtmMessage.php
patching file src/Entity/SlackRtmMessageCreate.php
patching file src/Entity/SlackRtmMessageInterface.php
patching file src/Entity/SlackRtmMessageViewsData.php
patching file src/Form/SlackRtmMessageConfigForm.php
patching file src/Form/SlackRtmMessageForm.php
patching file src/Plugin/QueueWorker/SlackRtmQueue.php
patching file src/SlackRtmApi.php
patching file src/SlackRtmMessageAccessControlHandler.php
patching file src/SlackRtmMessageListBuilder.php
patching file src/SlackRtmMessageTranslationHandler.php
➜  slack_rtm git:(8.x-1.x) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig slack_rtm

FILE: ...ite/drupal-orgissue-v9/web/modules/contrib/slack_rtm/slack_rtm.routing.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 17 | WARNING | Open page callback found, please add a comment before the line
    |         | why there is no access restriction
--------------------------------------------------------------------------------


FILE: ...emo-site/drupal-orgissue-v9/web/modules/contrib/slack_rtm/slack_rtm.module
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 54 | WARNING | Unused variable $slack_rtm_message.
--------------------------------------------------------------------------------


FILE: ...ue-v9/web/modules/contrib/slack_rtm/src/Form/SlackRtmMessageUpdateForm.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 37 | WARNING | Possible useless method overriding detected
 45 | WARNING | Unused variable $api.
--------------------------------------------------------------------------------


FILE: ...-v9/web/modules/contrib/slack_rtm/src/Form/SlackRtmMessageSettingsForm.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 12 | WARNING | The class short comment should describe what the class does and
    |         | not simply repeat the class name
--------------------------------------------------------------------------------


FILE: ...ue-v9/web/modules/contrib/slack_rtm/src/Form/SlackRtmMessageConfigForm.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 208 | WARNING | Possible useless method overriding detected
--------------------------------------------------------------------------------


FILE: ...orgissue-v9/web/modules/contrib/slack_rtm/src/Form/SlackRtmMessageForm.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 59 | WARNING | Possible useless method overriding detected
--------------------------------------------------------------------------------


FILE: ...ssue-v9/web/modules/contrib/slack_rtm/src/Entity/SlackRtmMessageCreate.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 70 | WARNING | Unused variable $t.
--------------------------------------------------------------------------------


FILE: ...-v9/web/modules/contrib/slack_rtm/src/Plugin/QueueWorker/SlackRtmQueue.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 23 | WARNING | Unused variable $result.
--------------------------------------------------------------------------------

Time: 482ms; Memory: 12MB

Kindly check

Thanks,
Jake

Hi @ankitv18,

Confirmed gitlab template created, however, it slightly does not follow the standard template. The hashes(#) of the 'variables' should also be included. Please see attached images.

Kindly check

Thanks,
Jake

Hi @ptiwebtech,

The issue is still not fixed, moving this to 'Needs Work' so that others will fix this.

Thanks,
Jake

Hi @alok_singh,

I have applied the commits made on MR!4, unfortunately, it did not apply successfully, please see below:

➜  kite git:(main) ✗ curl https://git.drupalcode.org/project/kite/-/merge_requests/4.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:-  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:-100  1645    0  1645    0     0   2698      0 --:--:-- --:--:-- --:--:--  2741
patching file css/sass/__frontpage.scss
Hunk #1 FAILED at 87.
1 out of 1 hunk FAILED -- saving rejects to file css/sass/__frontpage.scss.rej
patching file css/sass/__header.scss
patching file css/style.css

And kindly see the attached video, the slider image still not displayed.

Thanks,
Jake

Hi @everyone,

Since there's no proof that the MR!27 fixed the issue, I will provide the evidence. Please see the attached image.
RTBC +1

Thanks,
Jake

Hi @Divyanshi,

I have replicated the issue reported, I applied the patch you provided, and it seems there is a problem with the patch, below is the output after applying the patch:

➜  techy_news git:(main) ✗ curl https://www.drupal.org/files/issues/2024-02-15/simple_news_content_fixed-3421541.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:-100  5130  100  5130    0     0  48585      0 --:--:-- --:--:-- --:--:-- 54000
patching file css/style.css
Hunk #3 succeeded at 540 (offset -12 lines).
patching file sass/style.scss
Hunk #1 FAILED at 23.
Hunk #2 FAILED at 89.
Hunk #3 FAILED at 137.
Hunk #4 succeeded at 1037 with fuzz 2 (offset 336 lines).
3 out of 4 hunks FAILED -- saving rejects to file sass/style.scss.rej

And please see the attached images.

Kindly check

Thanks,
Jake

Hi @alok_singh,

After applying the commits on MR!13, confirmed the 'ul' is working. However, the dropdown menu is still not working. Below is the applying of MR!13 success:

➜  harmony_haven git:(main) ✗ curl https://git.drupalcode.org/project/harmony_haven/-/merge_requests/13.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  6340    0  6340    0     0  18704      0 --:--:-- --:--:-- --:--:-- 19329
patching file .gitlab-ci.yml
patching file css/styles.css
patching file harmony_haven.libraries.yml
patching file templates/menu/menu--main.html.twig
patching file templates/page/page.html.twig

Please see the attached images.

Kindly check

Thanks,
Jake

Hi @rajan kumar@2026,

It seems there is a problem on the patch that you provided, there is a HUNK when applying your patch. Please see:

➜  harmony_haven git:(main) ✗ curl https://www.drupal.org/files/issues/2024-07-31/harmony_haven-3394557.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   489  100   489    0     0   1876      0 --:--:-- --:--:-- --:--:--  1971
patching file css/styles.css
Hunk #1 succeeded at 895 (offset -3 lines).

Kindly check

Thanks,
Jake

HI @prachi6824,

I have applied the patch you provided, however, I was not able to confirm whether it fixed the issue or it did not because the patch FAILED to apply. Please see below:

➜  portfollio_theme git:(1.0.x) curl https://www.drupal.org/files/issues/2023-06-16/indentation-is-not-proper-3367282-%232.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  5690  100  5690    0     0  22072      0 --:--:-- --:--:-- --:--:-- 23130
patching file templates/page.html.twig
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file templates/page.html.twig.rej

Kindly check

Thanks,
Jake

Hi @everyone,

I have applied MR!4 and confirmed it implements the hook_help, help page looks good too. Please see attached images.

Hi @everyone,

Confirmed hook_help is implemented by the latest commits on MR19 which can be seen on the attached images.
Will also work on the feedback of comment #4.

Hi @Jay Jangid,

Confirmed hook_help is implemented after applying the commits on MR!6. Help page also matches also looks good, please see the attached images.

Will move this to RTBC

Thanks,
Jake

Hi @Neha-Verma,

Applied the patch you provided and confirmed search button is now styled. Please see attached image

Will move this to RTBC

Thanks,
Jake

Hi @aries,

Your patch resulted to HUNKS, please see below:

➜  blogger git:(master) curl https://www.drupal.org/files/issues/beautiful_blogger-5-14.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 21909  100 21909    0     0  70548      0 --:--:-- --:--:-- --:--:-- 73030
patching file blogger.module
Hunk #1 succeeded at 11 (offset -1 lines).
Hunk #2 succeeded at 40 (offset -1 lines).
Hunk #3 succeeded at 49 (offset -1 lines).
Hunk #4 succeeded at 102 (offset -1 lines).
Hunk #5 succeeded at 125 (offset -1 lines).
Hunk #6 succeeded at 166 (offset -1 lines).
Hunk #7 succeeded at 194 (offset -1 lines).
Hunk #8 succeeded at 359 (offset -1 lines).
Hunk #9 succeeded at 420 (offset -1 lines).

Kindly check

Thanks,
Jake

Hi @akshaydalvi212,

Applied the latest commits on MR!1, it was applied successfully and confirmed no remaining issue reported.

➜  edit_and_save git:(8.x-1.x) curl https://git.drupalcode.org/project/edit_and_save/-/merge_requests/1.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2624    0  2624    0     0   7964      0 --:--:-- --:--:-- --:--:--  8251
patching file README.txt
patching file edit_and_save.info.yml
patching file src/Form/EditAndSaveConfigureForm.php
patching file src/Repository/EditAndSaveRepository.php
➜  edit_and_save git:(8.x-1.x) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig edit_and_save
➜  contrib git:(master) ✗

Will now move this to RTBC

Thanks,
Jake

Hi @avpaderno,

I have applied the commits made on MR!12, it was applied successfully and confirmed no errors reported remaining.

➜  log_stdout git:(8.x-1.x) curl https://git.drupalcode.org/project/log_stdout/-/merge_requests/12.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2583    0  2583    0     0   7877      0 --:--:-- --:--:-- --:--:--  8174
patching file README.md
patching file log_stdout.links.menu.yml
patching file src/Logger/Stdout.php
➜  log_stdout git:(8.x-1.x) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig log_stdout
➜  contrib git:(master) ✗

Will now move this to RTBC

Thanks,
Jake

Hi @henriquebauer,

Applied the patch you provided, it was applied successfully, however, there are a lot, like a LOT of errors reported. Please see below:

➜  rpx git:(7.x-2.x) curl https://www.drupal.org/files/issues/2018-06-05/coding_standards-2887732-4.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  115k  100  115k    0     0   345k      0 --:--:-- --:--:-- --:--:--  360k
patching file rpx.api.php
patching file rpx_core.info
patching file rpx_core.install
patching file rpx_core.module
patching file rpx_core.pages.inc
patching file rpx_core.webapi.inc
patching file rpx_rules.info
patching file rpx_rules.rules.inc
patching file rpx_ui.admin.inc
patching file rpx_ui.css
patching file rpx_ui.info
patching file rpx_ui.install
patching file rpx_ui.module
patching file rpx_ui.pages.inc
patching file rpx_ui.paths.inc
patching file rpx_ui.tokens.inc
patching file rpx_widgets.css
patching file rpx_widgets.info
patching file rpx_widgets.module
patching file views/rpx_ui.views.inc
patching file views/rpx_ui_handler_field_delete_link.inc
patching file views/rpx_ui_handler_field_provider_icon.inc
patching file views/rpx_ui_handler_field_share.inc
patching file views/rpx_ui_handler_filter_provider_name.inc
patching file views/rpx_ui_handler_filter_provider_title.inc
➜  rpx git:(7.x-2.x) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig rpx

FILE: ...Interns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_ui.module
--------------------------------------------------------------------------------
FOUND 7 ERRORS AND 8 WARNINGS AFFECTING 15 LINES
--------------------------------------------------------------------------------
  10 | WARNING | All constants defined by a module must be prefixed with the
     |         | module's name, expected "RPX_UI_RPX_ACCOUNTS_STRING" but found
     |         | "RPX_ACCOUNTS_STRING"
 155 | ERROR   | All functions defined in a module file must be prefixed with
     |         | the module's name, found "_rpx_own_identities_access" but
     |         | expected "rpx_ui__rpx_own_identities_access"
 192 | WARNING | All variables defined by your module must be prefixed with
     |         | your module's name to avoid name collisions with others.
     |         | Expected start with "rpx_ui" but found
     |         | "rpx_attach_share_link_to_teasers_"
 198 | WARNING | All variables defined by your module must be prefixed with
     |         | your module's name to avoid name collisions with others.
     |         | Expected start with "rpx_ui" but found
     |         | "rpx_attach_share_link_to_nodelink_"
 204 | WARNING | All variables defined by your module must be prefixed with
     |         | your module's name to avoid name collisions with others.
     |         | Expected start with "rpx_ui" but found
     |         | "rpx_attach_share_link_to_nodecont_"
 211 | WARNING | All variables defined by your module must be prefixed with
     |         | your module's name to avoid name collisions with others.
     |         | Expected start with "rpx_ui" but found
     |         | "rpx_attach_share_link_to_nodecont_weight_"
 229 | WARNING | All variables defined by your module must be prefixed with
     |         | your module's name to avoid name collisions with others.
     |         | Expected start with "rpx_ui" but found
     |         | "rpx_comment_popup_social_at_once_"
 235 | WARNING | All variables defined by your module must be prefixed with
     |         | your module's name to avoid name collisions with others.
     |         | Expected start with "rpx_ui" but found
     |         | "rpx_attach_share_link_to_comments_"
 249 | ERROR   | All functions defined in a module file must be prefixed with
     |         | the module's name, found "rpx_get_enabled_provider_array" but
     |         | expected "rpx_ui_rpx_get_enabled_provider_array"
 273 | ERROR   | All functions defined in a module file must be prefixed with
     |         | the module's name, found "_rpx_drupal_field_catalog" but
     |         | expected "rpx_ui__rpx_drupal_field_catalog"
 345 | ERROR   | All functions defined in a module file must be prefixed with
     |         | the module's name, found "_rpx_drupal_field_options" but
     |         | expected "rpx_ui__rpx_drupal_field_options"
 366 | ERROR   | All functions defined in a module file must be prefixed with
     |         | the module's name, found "_rpx_engage_field_options" but
     |         | expected "rpx_ui__rpx_engage_field_options"
 377 | WARNING | Format should be "* Implements hook_foo().", "* Implements
     |         | hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements
     |         | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "* Implements
     |         | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements
     |         | hook_foo_BAR_ID_bar() for block templates."
 480 | ERROR   | All functions defined in a module file must be prefixed with
     |         | the module's name, found "_rpx_user_help_text" but expected
     |         | "rpx_ui__rpx_user_help_text"
 496 | ERROR   | All functions defined in a module file must be prefixed with
     |         | the module's name, found "_rpx_delete_user_data" but expected
     |         | "rpx_ui__rpx_delete_user_data"
--------------------------------------------------------------------------------


FILE: ...ns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_widgets.module
--------------------------------------------------------------------------------
FOUND 10 ERRORS AND 13 WARNINGS AFFECTING 23 LINES
--------------------------------------------------------------------------------
   5 | WARNING | [ ] Line exceeds 80 characters; contains 95 characters
  10 | WARNING | [ ] All constants defined by a module must be prefixed with
     |         |     the module's name, expected
     |         |     "RPX_WIDGETS_RPX_SIGNIN_STRING" but found
     |         |     "RPX_SIGNIN_STRING"
  13 | WARNING | [ ] All constants defined by a module must be prefixed with
     |         |     the module's name, expected
     |         |     "RPX_WIDGETS_RPX_DEFAULT_LABEL_NODES_STRING" but found
     |         |     "RPX_DEFAULT_LABEL_NODES_STRING"
  14 | WARNING | [ ] All constants defined by a module must be prefixed with
     |         |     the module's name, expected
     |         |     "RPX_WIDGETS_RPX_DEFAULT_MESSAGE_NODES_STRING" but found
     |         |     "RPX_DEFAULT_MESSAGE_NODES_STRING"
  15 | WARNING | [ ] All constants defined by a module must be prefixed with
     |         |     the module's name, expected
     |         |     "RPX_WIDGETS_RPX_DEFAULT_LINKTEXT_NODES_STRING" but found
     |         |     "RPX_DEFAULT_LINKTEXT_NODES_STRING"
  16 | WARNING | [ ] All constants defined by a module must be prefixed with
     |         |     the module's name, expected
     |         |     "RPX_WIDGETS_RPX_DEFAULT_TITLE_NODES_STRING" but found
     |         |     "RPX_DEFAULT_TITLE_NODES_STRING"
  17 | WARNING | [ ] All constants defined by a module must be prefixed with
     |         |     the module's name, expected
     |         |     "RPX_WIDGETS_RPX_DEFAULT_SUMMARY_NODES_STRING" but found
     |         |     "RPX_DEFAULT_SUMMARY_NODES_STRING"
  19 | WARNING | [ ] All constants defined by a module must be prefixed with
     |         |     the module's name, expected
     |         |     "RPX_WIDGETS_RPX_DEFAULT_LABEL_COMMENTS_STRING" but found
     |         |     "RPX_DEFAULT_LABEL_COMMENTS_STRING"
  20 | WARNING | [ ] All constants defined by a module must be prefixed with
     |         |     the module's name, expected
     |         |     "RPX_WIDGETS_RPX_DEFAULT_MESSAGE_COMMENTS_STRING" but
     |         |     found "RPX_DEFAULT_MESSAGE_COMMENTS_STRING"
  21 | WARNING | [ ] All constants defined by a module must be prefixed with
     |         |     the module's name, expected
     |         |     "RPX_WIDGETS_RPX_DEFAULT_LINKTEXT_COMMENTS_STRING" but
     |         |     found "RPX_DEFAULT_LINKTEXT_COMMENTS_STRING"
  22 | WARNING | [ ] All constants defined by a module must be prefixed with
     |         |     the module's name, expected
     |         |     "RPX_WIDGETS_RPX_DEFAULT_TITLE_COMMENTS_STRING" but found
     |         |     "RPX_DEFAULT_TITLE_COMMENTS_STRING"
  23 | WARNING | [ ] All constants defined by a module must be prefixed with
     |         |     the module's name, expected
     |         |     "RPX_WIDGETS_RPX_DEFAULT_SUMMARY_COMMENTS_STRING" but
     |         |     found "RPX_DEFAULT_SUMMARY_COMMENTS_STRING"
  46 | ERROR   | [ ] All functions defined in a module file must be prefixed
     |         |     with the module's name, found "_rpx_user_login_form_alter"
     |         |     but expected "rpx_widgets__rpx_user_login_form_alter"
 179 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
 185 | ERROR   | [ ] All functions defined in a module file must be prefixed
     |         |     with the module's name, found "rpx_js" but expected
     |         |     "rpx_widgets_rpx_js"
 244 | ERROR   | [ ] All functions defined in a module file must be prefixed
     |         |     with the module's name, found "rpx_js_social" but expected
     |         |     "rpx_widgets_rpx_js_social"
 306 | ERROR   | [ ] All functions defined in a module file must be prefixed
     |         |     with the module's name, found "_rpx_locale" but expected
     |         |     "rpx_widgets__rpx_locale"
 322 | ERROR   | [ ] All functions defined in a module file must be prefixed
     |         |     with the module's name, found "_rpx_ssl" but expected
     |         |     "rpx_widgets__rpx_ssl"
 400 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
 405 | ERROR   | [ ] The array declaration extends to column 175 (the limit is
     |         |     120). The array content should be split up over multiple
     |         |     lines
 460 | ERROR   | [ ] All functions defined in a module file must be prefixed
     |         |     with the module's name, found "_rpx_share_button" but
     |         |     expected "rpx_widgets__rpx_share_button"
 470 | ERROR   | [ ] The array declaration extends to column 140 (the limit is
     |         |     120). The array content should be split up over multiple
     |         |     lines
 516 | ERROR   | [ ] All functions defined in a module file must be prefixed
     |         |     with the module's name, found "_rpx_event_enabled" but
     |         |     expected "rpx_widgets__rpx_event_enabled"
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...s/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_rules.rules.inc
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
--------------------------------------------------------------------------------
  28 | WARNING | Avoid backslash escaping in translatable strings when
     |         | possible, use "" quotes instead
  40 | WARNING | Translatable strings must not begin or end with white spaces,
     |         | use placeholders with t() for variables
 132 | WARNING | Avoid backslash escaping in translatable strings when
     |         | possible, use "" quotes instead
 134 | WARNING | Avoid backslash escaping in translatable strings when
     |         | possible, use "" quotes instead
 137 | WARNING | Avoid backslash escaping in translatable strings when
     |         | possible, use "" quotes instead
 139 | WARNING | Avoid backslash escaping in translatable strings when
     |         | possible, use "" quotes instead
 145 | WARNING | Line exceeds 80 characters; contains 83 characters
--------------------------------------------------------------------------------


FILE: ...etInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx.api.php
--------------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
--------------------------------------------------------------------------------
  30 | ERROR   | unserialize() is insecure unless allowed classes are limited.
     |         | Use a safe format like JSON or use the allowed_classes option.
  66 | ERROR   | unserialize() is insecure unless allowed classes are limited.
     |         | Use a safe format like JSON or use the allowed_classes option.
  87 | ERROR   | unserialize() is insecure unless allowed classes are limited.
     |         | Use a safe format like JSON or use the allowed_classes option.
 114 | ERROR   | unserialize() is insecure unless allowed classes are limited.
     |         | Use a safe format like JSON or use the allowed_classes option.
 117 | WARNING | Unused variable $aid.
--------------------------------------------------------------------------------


FILE: ...rns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_ui.tokens.inc
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------
 18 | WARNING | Avoid backslash escaping in translatable strings when possible,
    |         | use "" quotes instead
 19 | WARNING | Avoid backslash escaping in translatable strings when possible,
    |         | use "" quotes instead
 24 | WARNING | Avoid backslash escaping in translatable strings when possible,
    |         | use "" quotes instead
--------------------------------------------------------------------------------


FILE: ...ns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_core.pages.inc
--------------------------------------------------------------------------------
FOUND 5 ERRORS AND 5 WARNINGS AFFECTING 10 LINES
--------------------------------------------------------------------------------
  11 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters
  13 | WARNING | [ ] Line exceeds 80 characters; contains 127 characters
  20 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
  32 | ERROR   | [ ] The array declaration extends to column 181 (the limit is
     |         |     120). The array content should be split up over multiple
     |         |     lines
 101 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters
 187 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters
 207 | ERROR   | [ ] The array declaration extends to column 419 (the limit is
     |         |     120). The array content should be split up over multiple
     |         |     lines
 210 | ERROR   | [ ] The array declaration extends to column 469 (the limit is
     |         |     120). The array content should be split up over multiple
     |         |     lines
 218 | ERROR   | [ ] The array declaration extends to column 331 (the limit is
     |         |     120). The array content should be split up over multiple
     |         |     lines
 222 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...nterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_ui.install
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------------
  12 | WARNING | Line exceeds 80 characters; contains 85 characters
 238 | WARNING | Unused variable $k.
 259 | WARNING | Line exceeds 80 characters; contains 89 characters
 417 | WARNING | Line exceeds 80 characters; contains 85 characters
 526 | WARNING | '@todo' should match the format '@todo Fix problem X here.'
--------------------------------------------------------------------------------


FILE: ...terns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_core.module
--------------------------------------------------------------------------------
FOUND 21 ERRORS AND 19 WARNINGS AFFECTING 40 LINES
--------------------------------------------------------------------------------
   12 | WARNING | [ ] All constants defined by a module must be prefixed with
      |         |     the module's name, expected "RPX_CORE_RPX_MODULE_VERSION"
      |         |     but found "RPX_MODULE_VERSION"
   22 | WARNING | [ ] All constants defined by a module must be prefixed with
      |         |     the module's name, expected "RPX_CORE_RPX_UPDATE_NONE"
      |         |     but found "RPX_UPDATE_NONE"
   24 | WARNING | [ ] All constants defined by a module must be prefixed with
      |         |     the module's name, expected "RPX_CORE_RPX_UPDATE_EMPTY"
      |         |     but found "RPX_UPDATE_EMPTY"
   26 | WARNING | [ ] All constants defined by a module must be prefixed with
      |         |     the module's name, expected "RPX_CORE_RPX_UPDATE_ALWAYS"
      |         |     but found "RPX_UPDATE_ALWAYS"
   28 | WARNING | [ ] All constants defined by a module must be prefixed with
      |         |     the module's name, expected "RPX_CORE_RPX_UPDATE_MAYBE"
      |         |     but found "RPX_UPDATE_MAYBE"
   30 | WARNING | [ ] All constants defined by a module must be prefixed with
      |         |     the module's name, expected "RPX_CORE_RPX_UPDATE_ADD" but
      |         |     found "RPX_UPDATE_ADD"
   35 | WARNING | [ ] All constants defined by a module must be prefixed with
      |         |     the module's name, expected
      |         |     "RPX_CORE_RPX_SESSION_LIFETIME" but found
      |         |     "RPX_SESSION_LIFETIME"
   47 | WARNING | [ ] Open page callback found, please add a comment before the
      |         |     line why there is no access restriction
   55 | WARNING | [ ] Open page callback found, please add a comment before the
      |         |     line why there is no access restriction
  149 | ERROR   | [ ] Unnecessarily gendered language in a comment
  179 | WARNING | [ ] Unused variable $mid.
  212 | WARNING | [ ] Unused variable $mid.
  235 | WARNING | [ ] Unused variable $mid.
  259 | ERROR   | [ ] All functions defined in a module file must be prefixed
      |         |     with the module's name, found "rpx_user_register_submit"
      |         |     but expected "rpx_core_rpx_user_register_submit"
  291 | ERROR   | [ ] The array declaration extends to column 142 (the limit is
      |         |     120). The array content should be split up over multiple
      |         |     lines
  339 | ERROR   | [ ] All functions defined in a module file must be prefixed
      |         |     with the module's name, found "_rpx_save_profile_picture"
      |         |     but expected "rpx_core__rpx_save_profile_picture"
  380 | ERROR   | [x] Each PHP statement must be on a line by itself
  383 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
  400 | ERROR   | [ ] All functions defined in a module file must be prefixed
      |         |     with the module's name, found "_rpx_data_map" but
      |         |     expected "rpx_core__rpx_data_map"
  404 | ERROR   | [ ] unserialize() is insecure unless allowed classes are
      |         |     limited. Use a safe format like JSON or use the
      |         |     allowed_classes option.
  459 | ERROR   | [ ] All functions defined in a module file must be prefixed
      |         |     with the module's name, found "_rpx_mail_text" but
      |         |     expected "rpx_core__rpx_mail_text"
  553 | ERROR   | [ ] All functions defined in a module file must be prefixed
      |         |     with the module's name, found "_rpx_providers" but
      |         |     expected "rpx_core__rpx_providers"
  596 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
  604 | ERROR   | [ ] All functions defined in a module file must be prefixed
      |         |     with the module's name, found
      |         |     "_rpx_get_provider_machine_name" but expected
      |         |     "rpx_core__rpx_get_provider_machine_name"
  609 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
  615 | ERROR   | [ ] All functions defined in a module file must be prefixed
      |         |     with the module's name, found "_rpx_token_url" but
      |         |     expected "rpx_core__rpx_token_url"
  616 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
  619 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
  642 | ERROR   | [ ] All functions defined in a module file must be prefixed
      |         |     with the module's name, found "_rpx_report_missing_field"
      |         |     but expected "rpx_core__rpx_report_missing_field"
  651 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
  656 | ERROR   | [ ] All functions defined in a module file must be prefixed
      |         |     with the module's name, found "_rpx_import_user_data" but
      |         |     expected "rpx_core__rpx_import_user_data"
  751 | ERROR   | [ ] unserialize() is insecure unless allowed classes are
      |         |     limited. Use a safe format like JSON or use the
      |         |     allowed_classes option.
  762 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters
  867 | ERROR   | [ ] All functions defined in a module file must be prefixed
      |         |     with the module's name, found "_rpx_profile_get_fields"
      |         |     but expected "rpx_core__rpx_profile_get_fields"
  913 | ERROR   | [ ] All functions defined in a module file must be prefixed
      |         |     with the module's name, found "_rpx_profile_format_value"
      |         |     but expected "rpx_core__rpx_profile_format_value"
  953 | ERROR   | [ ] All functions defined in a module file must be prefixed
      |         |     with the module's name, found
      |         |     "_rpx_update_engage_mapping" but expected
      |         |     "rpx_core__rpx_update_engage_mapping"
  959 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
  991 | ERROR   | [ ] All functions defined in a module file must be prefixed
      |         |     with the module's name, found
      |         |     "_rpx_delete_engage_mapping" but expected
      |         |     "rpx_core__rpx_delete_engage_mapping"
 1012 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
 1061 | ERROR   | [ ] unserialize() is insecure unless allowed classes are
      |         |     limited. Use a safe format like JSON or use the
      |         |     allowed_classes option.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...erns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_core.install
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------
  40 | WARNING | Line exceeds 80 characters; contains 87 characters
 154 | ERROR   | unserialize() is insecure unless allowed classes are limited.
     |         | Use a safe format like JSON or use the allowed_classes option.
--------------------------------------------------------------------------------


FILE: ...erns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_rules.module
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 15 | WARNING | Open page callback found, please add a comment before the line
    |         | why there is no access restriction
--------------------------------------------------------------------------------


FILE: ...erns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_ui.pages.inc
--------------------------------------------------------------------------------
FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------------
  17 | ERROR   | The array declaration extends to column 244 (the limit is
     |         | 120). The array content should be split up over multiple lines
 122 | ERROR   | The array declaration extends to column 168 (the limit is
     |         | 120). The array content should be split up over multiple lines
 126 | WARNING | Line exceeds 80 characters; contains 83 characters
 137 | WARNING | Line exceeds 80 characters; contains 81 characters
 178 | WARNING | Line exceeds 80 characters; contains 86 characters
--------------------------------------------------------------------------------


FILE: ...erns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_ui.admin.inc
--------------------------------------------------------------------------------
FOUND 7 ERRORS AND 39 WARNINGS AFFECTING 46 LINES
--------------------------------------------------------------------------------
   23 | WARNING | [ ] Translatable strings must not begin or end with white
      |         |     spaces, use placeholders with t() for variables
   40 | WARNING | [ ] All variables defined by your module must be prefixed
      |         |     with your module's name to avoid name collisions with
      |         |     others. Expected start with "rpx_ui" but found
      |         |     "rpx_apikey"
   59 | WARNING | [ ] All variables defined by your module must be prefixed
      |         |     with your module's name to avoid name collisions with
      |         |     others. Expected start with "rpx_ui" but found
      |         |     "rpx_signin_string"
   65 | WARNING | [ ] All variables defined by your module must be prefixed
      |         |     with your module's name to avoid name collisions with
      |         |     others. Expected start with "rpx_ui" but found
      |         |     "rpx_accounts_string"
  103 | WARNING | [ ] All variables defined by your module must be prefixed
      |         |     with your module's name to avoid name collisions with
      |         |     others. Expected start with "rpx_ui" but found
      |         |     "rpx_attach_login_form"
  104 | WARNING | [ ] Avoid backslash escaping in translatable strings when
      |         |     possible, use "" quotes instead
  117 | WARNING | [ ] All variables defined by your module must be prefixed
      |         |     with your module's name to avoid name collisions with
      |         |     others. Expected start with "rpx_ui" but found
      |         |     "rpx_login_icons_size"
  123 | WARNING | [ ] Avoid backslash escaping in translatable strings when
      |         |     possible, use "" quotes instead
  129 | WARNING | [ ] All variables defined by your module must be prefixed
      |         |     with your module's name to avoid name collisions with
      |         |     others. Expected start with "rpx_ui" but found
      |         |     "rpx_login_links_weight"
  130 | WARNING | [ ] Avoid backslash escaping in translatable strings when
      |         |     possible, use "" quotes instead
  136 | WARNING | [ ] All variables defined by your module must be prefixed
      |         |     with your module's name to avoid name collisions with
      |         |     others. Expected start with "rpx_ui" but found
      |         |     "rpx_force_registration_form"
  143 | WARNING | [ ] All variables defined by your module must be prefixed
      |         |     with your module's name to avoid name collisions with
      |         |     others. Expected start with "rpx_ui" but found
      |         |     "rpx_extended_authinfo"
  150 | WARNING | [ ] All variables defined by your module must be prefixed
      |         |     with your module's name to avoid name collisions with
      |         |     others. Expected start with "rpx_ui" but found
      |         |     "rpx_import_profile_photo"
  151 | WARNING | [ ] Avoid backslash escaping in translatable strings when
      |         |     possible, use "" quotes instead
  158 | WARNING | [ ] All variables defined by your module must be prefixed
      |         |     with your module's name to avoid name collisions with
      |         |     others. Expected start with "rpx_ui" but found
      |         |     "rpx_javascript_global"
  165 | WARNING | [ ] All variables defined by your module must be prefixed
      |         |     with your module's name to avoid name collisions with
      |         |     others. Expected start with "rpx_ui" but found
      |         |     "rpx_openid_override"
  181 | WARNING | [ ] All variables defined by your module must be prefixed
      |         |     with your module's name to avoid name collisions with
      |         |     others. Expected start with "rpx_ui" but found
      |         |     "rpx_social_enabled"
  197 | WARNING | [ ] All variables defined by your module must be prefixed
      |         |     with your module's name to avoid name collisions with
      |         |     others. Expected start with "rpx_ui" but found
      |         |     "rpx_default_message_nodes"
  203 | WARNING | [ ] All variables defined by your module must be prefixed
      |         |     with your module's name to avoid name collisions with
      |         |     others. Expected start with "rpx_ui" but found
      |         |     "rpx_default_linktext_nodes"
  209 | WARNING | [ ] All variables defined by your module must be prefixed
      |         |     with your module's name to avoid name collisions with
      |         |     others. Expected start with "rpx_ui" but found
      |         |     "rpx_default_title_nodes"
  215 | WARNING | [ ] All variables defined by your module must be prefixed
      |         |     with your module's name to avoid name collisions with
      |         |     others. Expected start with "rpx_ui" but found
      |         |     "rpx_default_summary_nodes"
  231 | WARNING | [ ] All variables defined by your module must be prefixed
      |         |     with your module's name to avoid name collisions with
      |         |     others. Expected start with "rpx_ui" but found
      |         |     "rpx_default_message_comments"
  237 | WARNING | [ ] All variables defined by your module must be prefixed
      |         |     with your module's name to avoid name collisions with
      |         |     others. Expected start with "rpx_ui" but found
      |         |     "rpx_default_linktext_comments"
  243 | WARNING | [ ] All variables defined by your module must be prefixed
      |         |     with your module's name to avoid name collisions with
      |         |     others. Expected start with "rpx_ui" but found
      |         |     "rpx_default_title_comments"
  249 | WARNING | [ ] All variables defined by your module must be prefixed
      |         |     with your module's name to avoid name collisions with
      |         |     others. Expected start with "rpx_ui" but found
      |         |     "rpx_default_summary_comments"
  273 | WARNING | [ ] Translatable strings must not begin or end with white
      |         |     spaces, use placeholders with t() for variables
  288 | WARNING | [ ] All variables defined by your module must be prefixed
      |         |     with your module's name to avoid name collisions with
      |         |     others. Expected start with "rpx_ui" but found
      |         |     "rpx_bypass_email_verification"
  442 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
  444 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
  445 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters
  556 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
  578 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters
  622 | WARNING | [ ] Empty return statement not required here
  756 | WARNING | [ ] Do not use DELETE queries with db_query(), use
      |         |     db_delete() instead
  804 | WARNING | [ ] Translatable strings must not begin or end with white
      |         |     spaces, use placeholders with t() for variables
  852 | WARNING | [ ] Avoid backslash escaping in translatable strings when
      |         |     possible, use "" quotes instead
  885 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
  958 | ERROR   | [ ] The array declaration extends to column 138 (the limit is
      |         |     120). The array content should be split up over multiple
      |         |     lines
  976 | WARNING | [ ] Empty return statement not required here
 1046 | ERROR   | [ ] The array declaration extends to column 121 (the limit is
      |         |     120). The array content should be split up over multiple
      |         |     lines
 1065 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
 1079 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
 1113 | ERROR   | [ ] Unnecessarily gendered language in a comment
 1125 | ERROR   | [ ] The array declaration extends to column 143 (the limit is
      |         |     120). The array content should be split up over multiple
      |         |     lines
 1130 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters
 1136 | WARNING | [ ] Unused variable $map.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...s/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_core.webapi.inc
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------------
  12 | WARNING | The class short comment should describe what the class does
     |         | and not simply repeat the class name
  13 | WARNING | Class name must be prefixed with the project name "RpxUi"
 156 | WARNING | Line exceeds 80 characters; contains 82 characters
 274 | ERROR   | The array declaration extends to column 166 (the limit is
     |         | 120). The array content should be split up over multiple lines
--------------------------------------------------------------------------------


FILE: ...-v9/web/modules/contrib/rpx/views/rpx_ui_handler_filter_provider_title.inc
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 26 | WARNING | Unused variable $k.
--------------------------------------------------------------------------------


FILE: ...emo-site/drupal-orgissue-v9/web/modules/contrib/rpx/views/rpx_ui.views.inc
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 42 | WARNING | Avoid backslash escaping in translatable strings when possible,
    |         | use "" quotes instead
--------------------------------------------------------------------------------


FILE: ...l-orgissue-v9/web/modules/contrib/rpx/views/rpx_ui_handler_field_share.inc
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 7 | WARNING | @author tags are not usually used in Drupal, because over time
   |         | multiple contributors will touch the code anyway
--------------------------------------------------------------------------------


FILE: ...ssue-v9/web/modules/contrib/rpx/views/rpx_ui_handler_field_delete_link.inc
--------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------------
 42 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
 49 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
 84 | WARNING | [ ] Unused variable $arg.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 2.55 secs; Memory: 30MB

Kindly check

Thanks,
Jake

Hi @urvashi_vora,

Applied the patch you provided, it was applied successfully, however, there are 2 errors remaining. Please see below:

➜  edit_and_save git:(8.x-1.x) curl https://www.drupal.org/files/issues/2022-07-16/coding-standards-fixed-2886679-7.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1157  100  1157    0     0   4630      0 --:--:-- --:--:-- --:--:--  4861
patching file README.txt
patching file edit_and_save.info.yml
patching file src/Repository/EditAndSaveRepository.php
➜  edit_and_save git:(8.x-1.x) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig edit_and_save

FILE: ...v9/web/modules/contrib/edit_and_save/src/Form/EditAndSaveConfigureForm.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
   8 | ERROR | [x] Use statements should be sorted alphabetically. The first
     |       |     wrong one is Drupal\Core\Form\ConfigFormBase.
 153 | ERROR | [x] Use null coalesce operator instead of ternary operator.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 187ms; Memory: 10MB

And as expected the MR!1 also have errors remaining, so moving this to Needs Work.

Kindly check

Thanks,
Jake

Hi @urvashi_vora,

Applied the patch you provided, it was applied successfully and confirmed no errors remaining.

➜  opigno_pretest_app git:(7.x-1.x) curl https://www.drupal.org/files/issues/2022-08-05/coding-standards-resolved-2709929-5.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  4691  100  4691    0     0  19748      0 --:--:-- --:--:-- --:--:-- 20665
patching file opigno_pretest_app.info
patching file opigno_pretest_app.install
patching file opigno_pretest_app.module
➜  opigno_pretest_app git:(7.x-1.x) ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig opigno_pretest_app
➜  contrib git:(master) ✗

Will now move this to RTBC

Thanks,
Jake

Hi@everyone,

Applied the patch provided on comment #2, confirmed it can be applied successfully, however, one error still reported. Please see below:

➜  nouislider_widget git:(master) ✗ curl https://www.drupal.org/files/issues/2022-06-08/Line_exceeds_80_characters-3284610-1.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   799  100   799    0     0   2951      0 --:--:-- --:--:-- --:--:--  3096
patching file README.md
➜  nouislider_widget git:(master) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig nouislider_widget

FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/nouislider_widget/src/Plugin/Field/FieldWidget/NoUiSliderWidget.php
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------
 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\Plugin\Field\FieldWidget\NumberWidget.
-------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------

Time: 142ms; Memory: 10MB

Kindly check

Thanks,
Jake

Hi @himanshu_jhaloya,

Applied the patch you provided, but apparently, the reported errors were not the only phpcs errors, here are the errors reported by my terminal:

➜  iotapay git:(main) curl https://www.drupal.org/files/issues/2022-08-05/issue-fixed-3284808-2.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3061  100  3061    0     0  12212      0 --:--:-- --:--:-- --:--:-- 12701
patching file iota_pay_donate.routing.yml
patching file src/Plugin/Block/iota_donate.php
patching file src/Plugin/Block/iota_pay.php
➜  iotapay git:(main) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig iotapay

FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/iotapay/iota_pay_donate.routing.yml
---------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------
 9 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/iotapay/iota_pay_donate.info.yml
------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
 5 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/iotapay/iota_pay_donate.links.menu.yml
------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/iotapay/templates/iota-pay.html.twig
----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/iotapay/iota_pay_donate.module
----------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------
  1 | ERROR | [x] Missing file doc comment
 19 | ERROR | [x] Expected 1 newline at end of file; 4 found
 22 | ERROR | [ ] More than 2 empty lines are not allowed
----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/iotapay/src/Form/ConfigForm.php
-----------------------------------------------------------------------------------------------------------
FOUND 77 ERRORS AFFECTING 66 LINES
-----------------------------------------------------------------------------------------------------------
  1 | ERROR | [x] Whitespace found at end of line
  2 | ERROR | [x] Whitespace found at end of line
  3 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
  3 | ERROR | [x] Whitespace found at end of line
  4 | ERROR | [x] Whitespace found at end of line
  5 | ERROR | [x] Whitespace found at end of line
  6 | ERROR | [x] Whitespace found at end of line
  7 | ERROR | [x] Whitespace found at end of line
  8 | ERROR | [x] Whitespace found at end of line
  9 | ERROR | [x] Whitespace found at end of line
 10 | ERROR | [x] Whitespace found at end of line
 11 | ERROR | [x] Whitespace found at end of line
 12 | ERROR | [x] Whitespace found at end of line
 13 | ERROR | [x] Missing class doc comment
 13 | ERROR | [x] Whitespace found at end of line
 14 | ERROR | [x] Whitespace found at end of line
 15 | ERROR | [x] Whitespace found at end of line
 16 | ERROR | [x] Whitespace found at end of line
 17 | ERROR | [x] Expected 1 blank line before function; 0 found
 17 | ERROR | [x] Whitespace found at end of line
 18 | ERROR | [x] Whitespace found at end of line
 19 | ERROR | [x] Whitespace found at end of line
 20 | ERROR | [x] Whitespace found at end of line
 21 | ERROR | [x] Whitespace found at end of line
 22 | ERROR | [x] Whitespace found at end of line
 23 | ERROR | [x] Whitespace found at end of line
 24 | ERROR | [x] Whitespace found at end of line
 25 | ERROR | [x] Whitespace found at end of line
 26 | ERROR | [x] Whitespace found at end of line
 27 | ERROR | [x] Whitespace found at end of line
 28 | ERROR | [x] Whitespace found at end of line
 30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
 30 | ERROR | [x] Whitespace found at end of line
 31 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
 31 | ERROR | [x] Whitespace found at end of line
 32 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
 32 | ERROR | [x] Whitespace found at end of line
 33 | ERROR | [x] Whitespace found at end of line
 34 | ERROR | [x] Whitespace found at end of line
 35 | ERROR | [x] Whitespace found at end of line
 36 | ERROR | [x] Whitespace found at end of line
 37 | ERROR | [x] Whitespace found at end of line
 38 | ERROR | [x] Whitespace found at end of line
 39 | ERROR | [x] Whitespace found at end of line
 40 | ERROR | [x] Whitespace found at end of line
 41 | ERROR | [x] Whitespace found at end of line
 43 | ERROR | [x] Whitespace found at end of line
 44 | ERROR | [x] Whitespace found at end of line
 46 | ERROR | [x] Whitespace found at end of line
 47 | ERROR | [x] Whitespace found at end of line
 48 | ERROR | [x] Whitespace found at end of line
 49 | ERROR | [x] Whitespace found at end of line
 51 | ERROR | [x] Whitespace found at end of line
 52 | ERROR | [x] Whitespace found at end of line
 53 | ERROR | [x] Whitespace found at end of line
 54 | ERROR | [x] Whitespace found at end of line
 56 | ERROR | [x] Whitespace found at end of line
 57 | ERROR | [x] Whitespace found at end of line
 58 | ERROR | [x] Whitespace found at end of line
 59 | ERROR | [x] Whitespace found at end of line
 61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 61 | ERROR | [x] Whitespace found at end of line
 62 | ERROR | [x] Expected 5 space(s) before asterisk; 3 found
 62 | ERROR | [x] Whitespace found at end of line
 63 | ERROR | [x] Expected 5 space(s) before asterisk; 3 found
 63 | ERROR | [x] Whitespace found at end of line
 64 | ERROR | [x] Whitespace found at end of line
 65 | ERROR | [x] Whitespace found at end of line
 66 | ERROR | [x] Whitespace found at end of line
 67 | ERROR | [x] Whitespace found at end of line
 68 | ERROR | [x] Whitespace found at end of line
 71 | ERROR | [x] Whitespace found at end of line
 72 | ERROR | [x] Whitespace found at end of line
 73 | ERROR | [x] Whitespace found at end of line
 75 | ERROR | [ ] Closing class brace must be on a line by itself
 75 | ERROR | [x] Expected 1 newline at end of file; 0 found
 75 | ERROR | [x] Whitespace found at end of line
-----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 76 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/iotapay/src/Plugin/Block/iota_donate.php
--------------------------------------------------------------------------------------------------------------------
FOUND 15 ERRORS AFFECTING 14 LINES
--------------------------------------------------------------------------------------------------------------------
 17 | ERROR | [ ] Class name must begin with a capital letter
 17 | ERROR | [ ] Class name must use UpperCamel naming without underscores
 20 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found
 21 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found
 22 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found
 23 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found
 27 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found
 28 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found
 29 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found
 30 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found
 31 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found
 41 | ERROR | [x] Whitespace found at end of line
 45 | ERROR | [x] Whitespace found at end of line
 51 | ERROR | [x] Whitespace found at end of line
 53 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 13 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/iotapay/src/Plugin/Block/iota_pay.php
-----------------------------------------------------------------------------------------------------------------
FOUND 13 ERRORS AFFECTING 11 LINES
-----------------------------------------------------------------------------------------------------------------
 17 | ERROR | [ ] Class name must begin with a capital letter
 17 | ERROR | [ ] Class name must use UpperCamel naming without underscores
 26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
 27 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
 28 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
 29 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
 30 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
 31 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
 44 | ERROR | [x] Whitespace found at end of line
 47 | ERROR | [x] Whitespace found at end of line
 50 | ERROR | [x] Expected 1 blank line after function; 0 found
 50 | ERROR | [x] Whitespace found at end of line
 51 | ERROR | [x] The closing brace for the class must have an empty line before it
-----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 11 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------

Time: 146ms; Memory: 10MB

Kindly check

Thanks,
Jake

Hi @jaydev bhatt,

Applied the changes committed on MR!1, it was applied successfully, it fixed most errors, however, one error still reported. Please see below:

➜  architects_zymphonies_theme git:(master) ✗ curl https://git.drupalcode.org/project/architects_zymphonies_theme/-/merge_requests/1.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  135k    0  135k    0     0   349k      0 --:--:-- --:--:-- --:--:--  360k
patching file architects_zymphonies_theme.libraries.yml
patching file architects_zymphonies_theme.theme
patching file config/install/architects_zymphonies_theme.settings.yml
patching file config/optional/block.block.architects_zymphonies_theme_page_title.yml
patching file css/global.css
patching file css/media.css
patching file includes/fontawesome/css/fontawesome-all.css
patching file includes/owl/assets/owl.carousel.css
patching file includes/smartmenus/sm-core-css.css
➜  architects_zymphonies_theme git:(master) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig architects_zymphonies_theme

FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/themes/contrib/architects_zymphonies_theme/templates/layout/page.html.twig
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------
 500 | ERROR | [x] Expected 1 newline at end of file; 3 found
--------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------

Time: 720ms; Memory: 24MB

Kindly check

Thanks,
Jake

Hi @everyone,

Applied patch provided by comment #2, it was applied successfully and confirmed it fixed the reported errors.

➜  ckeditor_entity_link git:(master) ✗ curl https://www.drupal.org/files/issues/2023-01-13/drupal-coding-standard-3333258-2.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1864  100  1864    0     0   2312      0 --:--:-- --:--:-- --:--:--  2359
patching file js/plugins/entitylink/plugin.js
➜  ckeditor_entity_link git:(master) ✗ ..
➜  contrib git:(master) ✗ cd ckeditor_entity_link
➜  ckeditor_entity_link git:(master) ✗

Will now move this to RTBC

Thanks,
Jake

Hi @ptmkenny,

Applied the latest changes committed on MR!13, it was applied successfully on my local, but there are still errors reported aside from dependency injection. Please see below:

➜  consumer_image_styles git:(4.x) curl https://git.drupalcode.org/project/consumer_image_styles/-/merge_requests/13.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 10311    0 10311    0     0  33997      0 --:--:-- --:--:-- --:--:-- 35555
patching file consumer_image_styles.module
patching file src/ImageStylesProvider.php
patching file src/ImageStylesProviderInterface.php
patching file src/Normalizer/LinkCollectionNormalizer.php
patching file src/Plugin/jsonapi/FieldEnhancer/ImageStyles.php
patching file tests/src/Functional/ConsumerImageSylesFunctionalTest.php
➜  consumer_image_styles git:(4.x) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig consumer_image_styles

FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/consumer_image_styles/src/Plugin/jsonapi/FieldEnhancer/ImageStyles.php
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------
  52 | ERROR   | [x] Multi-line function declarations must have a trailing comma after the last parameter
 249 | WARNING | [ ] ImageStyle::loadMultiple calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/consumer_image_styles/src/Normalizer/LinkCollectionNormalizer.php
---------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\consumer_image_styles\ImageStylesProviderInterface.
---------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/consumer_image_styles/src/ImageStylesProvider.php
------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 3 WARNINGS AFFECTING 5 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------------
  13 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StreamWrapper\StreamWrapperInterface.
  74 | ERROR   | [x] Multi-line function declarations must have a trailing comma after the last parameter
  80 | WARNING | [ ] The deprecation-version '4.0.6' does not match the lower-case machine-name standard: drupal:n.n.n or project:n.x-n.n or
     |         |     project:n.x-n.n-label[n] or project:n.n.n or project:n.n.n-label[n]
  80 | WARNING | [ ] The removal-version '5.0' does not match the lower-case machine-name standard: drupal:n.n.n or project:n.x-n.n or
     |         |     project:n.x-n.n-label[n] or project:n.n.n or project:n.n.n-label[n]
  81 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 114 | ERROR   | [ ] The trigger_error message 'Calling %s without $cacheable_metadata is deprecated in 4.0.6; it is required in 5.0.' does not match the
     |         |     relaxed standard format: %thing% is deprecated in %deprecation-version% any free text %removal-version%. %extra-info%. See %cr-link%
------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------------

Time: 404ms; Memory: 12MB

Kindly check

Thanks,
Jake

Hi @everyone,

Applied the commit made on MR!1 that I guess was from the patch, it was applied not-so successfully that might be the reason one error was still reported. Please see below:

➜  block_country git:(master) ✗ curl https://git.drupalcode.org/project/block_country/-/merge_requests/1.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3462    0  3462    0     0   9755      0 --:--:-- --:--:-- --:--:-- 10182
patching file README.txt
patching file block_country.info.yml
Hunk #1 FAILED at 2.
1 out of 1 hunk FAILED -- saving rejects to file block_country.info.yml.rej
patching file src/Plugin/Condition/BlockCountry.php
➜  block_country git:(master) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig block_country

FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/block_country/src/Plugin/Condition/BlockCountry.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
 11 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Cache\Cache.
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------

Time: 191ms; Memory: 10MB

Hi @kunal_sahu,

Applied the changes you committed on MR!2, it was applied successfully, however there are still few errors reported. Please see below:

➜  image_style_quality git:(main) ✗ curl https://git.drupalcode.org/project/image_style_quality/-/merge_requests/2.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  4275    0  4275    0     0  14507      0 --:--:-- --:--:-- --:--:-- 15159
patching file README.txt
patching file src/MutableQualityToolkitManager.php
patching file src/Plugin/ImageEffect/ImageStyleQualityImageEffect.php
patching file tests/src/Kernel/ImageStyleQualityTest.php
➜  image_style_quality git:(main) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig image_style_quality

FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/image_style_quality/README.txt
-------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
 36 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------

FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/image_style_quality/src/Plugin/ImageEffect/ImageStyleQualityImageEffect.php
----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface.
----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------

Time: 182ms; Memory: 10MB

Kindly check

Thanks,
Jake

Hi @elber,

Applied the latest changes made on MR!2, it was applied successfully but one file with 2 errors were still reported. Please see below:

➜  shortcut_menu git:(main) ✗ curl https://git.drupalcode.org/project/shortcut_menu/-/merge_requests/2.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3125    0  3125    0     0   6552      0 --:--:-- --:--:-- --:--:--  6706
patching file shortcut_menu.install
patching file src/Form/ShortcutMenuSetCustomize.php
patching file src/ShortcutMenuLazyBuilder.php
➜  shortcut_menu git:(main) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig shortcut_menu

FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/shortcut_menu/src/Form/ShortcutMenuSetCustomize.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------
 177 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
 196 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------

Time: 266ms; Memory: 10MB

Kindly check

Thanks,
Jake

Production build 0.71.5 2024