- š®š¹Italy apaderno Brescia, š®š¹
The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.
- Status changed to Needs review
over 1 year ago 12:22pm 27 June 2023 - šµš°Pakistan RTMKLIK
RTM KLIK is a Malaysian website that offers a platform for viewers to watch the latest online dramas and live shows. This website provides a convenient way for people to access and enjoy a wide range of Malaysian dramas and live broadcasts.
- Status changed to Needs work
5 months ago 6:49am 19 July 2024 Hi @everyone,
I applied @kunal_singh's patch, it was applied not-so successfully, might be the reason the errors below were reported. Please see:
slack_rtm git:(8.x-1.x) curl https://www.drupal.org/files/issues/2020-09-13/3164056-12.patch | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 19264 100 19264 0 0 45895 0 --:--:-- --:--:-- --:--:-- 46757 patching file config/install/slack_rtm.settings.yml patching file config/schema/slack_rtm.schema.yml patching file slack_rtm.links.menu.yml patching file slack_rtm.links.task.yml patching file slack_rtm.module patching file slack_rtm.permissions.yml patching file slack_rtm.routing.yml patching file src/Batch/SlackRtmBatch.php patching file src/Entity/SlackRtmMessageCreate.php patching file src/Entity/SlackRtmMessageInterface.php patching file src/Entity/SlackRtmMessageViewsData.php patching file src/Form/SlackRtmMessageConfigForm.php patching file src/Form/SlackRtmMessageForm.php patching file src/Form/SlackRtmMessageSettingsForm.php patching file src/Form/SlackRtmMessageUpdateForm.php patching file src/Plugin/QueueWorker/SlackRtmQueue.php patching file src/SlackRtmApi.php Hunk #5 FAILED at 242. Hunk #7 succeeded at 344 (offset 4 lines). Hunk #8 succeeded at 373 (offset 4 lines). Hunk #9 succeeded at 392 (offset 4 lines). Hunk #10 succeeded at 421 (offset 4 lines). 1 out of 10 hunks FAILED -- saving rejects to file src/SlackRtmApi.php.rej patching file src/SlackRtmMessageListBuilder.php patching file src/SlackRtmMessageTranslationHandler.php ā slack_rtm git:(8.x-1.x) ā cd .. ā contrib git:(master) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig slack_rtm FILE: ...ite/drupal-orgissue-v9/web/modules/contrib/slack_rtm/slack_rtm.routing.yml -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES -------------------------------------------------------------------------------- 7 | WARNING | The administration page callback should probably use | | "administer site configuration" - which implies the user can | | change something - rather than "access administration pages" | | which is about viewing but not changing configurations. 17 | WARNING | Open page callback found, please add a comment before the line | | why there is no access restriction -------------------------------------------------------------------------------- FILE: ...emo-site/drupal-orgissue-v9/web/modules/contrib/slack_rtm/slack_rtm.module -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 54 | WARNING | Unused variable $slack_rtm_message. -------------------------------------------------------------------------------- FILE: ...-site/drupal-orgissue-v9/web/modules/contrib/slack_rtm/src/SlackRtmApi.php -------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES -------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Core\Url. 244 | ERROR | [x] Functions must not contain multiple empty lines in a row; | | found 2 empty lines 260 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, | | question marks, colons, or closing parentheses -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...ue-v9/web/modules/contrib/slack_rtm/src/Form/SlackRtmMessageConfigForm.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Component\Utility\NestedArray. -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...orgissue-v9/web/modules/contrib/slack_rtm/src/Form/SlackRtmMessageForm.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Component\Datetime\TimeInterface. -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...l-orgissue-v9/web/modules/contrib/slack_rtm/src/Entity/SlackRtmMessage.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Core\Entity\ContentEntityBase. -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: .../web/modules/contrib/slack_rtm/src/SlackRtmMessageAccessControlHandler.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Core\Access\AccessResult. -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- Time: 472ms; Memory: 12MB
Kindly check
Thanks,
Jake- š®š¹Italy apaderno Brescia, š®š¹
Let's create a merge request, now that patches are no longer tested.
- Assigned to akshaydalvi212
- š®š³India akshaydalvi212
akshaydalvi212 ā changed the visibility of the branch 3164056-fix-phpcs-issues to hidden.
- š®š³India akshaydalvi212
akshaydalvi212 ā changed the visibility of the branch 3164056-fix-phpcs-issues to active.
- Issue was unassigned.
- š®š³India akshaydalvi212
hi,
I worked on the issues and resolved them.
Only some remaining issues can be reviewed by module maintainers for further removal of the unused $variable.Thanks and regards
Akshay. Hi @Akshay,
I have applied the commits you made on MR!1, it was applied smoothly and confirmed most issues other than unused variables were fixed. For the maintainer/s, please see below for the issues not yet fixed:
slack_rtm git:(8.x-1.x) ā curl https://git.drupalcode.org/project/slack_rtm/-/merge_requests/1.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 23345 0 23345 0 0 63877 0 --:--:-- --:--:-- --:--:-- 65209 patching file .gitlab-ci.yml patching file config/install/slack_rtm.settings.yml patching file config/schema/slack_rtm.schema.yml patching file slack_rtm.links.menu.yml patching file slack_rtm.links.task.yml patching file slack_rtm.module patching file slack_rtm.permissions.yml patching file slack_rtm.routing.yml patching file src/Batch/SlackRtmBatch.php patching file src/Entity/SlackRtmMessage.php patching file src/Entity/SlackRtmMessageCreate.php patching file src/Entity/SlackRtmMessageInterface.php patching file src/Entity/SlackRtmMessageViewsData.php patching file src/Form/SlackRtmMessageConfigForm.php patching file src/Form/SlackRtmMessageForm.php patching file src/Plugin/QueueWorker/SlackRtmQueue.php patching file src/SlackRtmApi.php patching file src/SlackRtmMessageAccessControlHandler.php patching file src/SlackRtmMessageListBuilder.php patching file src/SlackRtmMessageTranslationHandler.php ā slack_rtm git:(8.x-1.x) ā .. ā contrib git:(master) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig slack_rtm FILE: ...ite/drupal-orgissue-v9/web/modules/contrib/slack_rtm/slack_rtm.routing.yml -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 17 | WARNING | Open page callback found, please add a comment before the line | | why there is no access restriction -------------------------------------------------------------------------------- FILE: ...emo-site/drupal-orgissue-v9/web/modules/contrib/slack_rtm/slack_rtm.module -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 54 | WARNING | Unused variable $slack_rtm_message. -------------------------------------------------------------------------------- FILE: ...ue-v9/web/modules/contrib/slack_rtm/src/Form/SlackRtmMessageUpdateForm.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES -------------------------------------------------------------------------------- 37 | WARNING | Possible useless method overriding detected 45 | WARNING | Unused variable $api. -------------------------------------------------------------------------------- FILE: ...-v9/web/modules/contrib/slack_rtm/src/Form/SlackRtmMessageSettingsForm.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 12 | WARNING | The class short comment should describe what the class does and | | not simply repeat the class name -------------------------------------------------------------------------------- FILE: ...ue-v9/web/modules/contrib/slack_rtm/src/Form/SlackRtmMessageConfigForm.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 208 | WARNING | Possible useless method overriding detected -------------------------------------------------------------------------------- FILE: ...orgissue-v9/web/modules/contrib/slack_rtm/src/Form/SlackRtmMessageForm.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 59 | WARNING | Possible useless method overriding detected -------------------------------------------------------------------------------- FILE: ...ssue-v9/web/modules/contrib/slack_rtm/src/Entity/SlackRtmMessageCreate.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 70 | WARNING | Unused variable $t. -------------------------------------------------------------------------------- FILE: ...-v9/web/modules/contrib/slack_rtm/src/Plugin/QueueWorker/SlackRtmQueue.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 23 | WARNING | Unused variable $result. -------------------------------------------------------------------------------- Time: 482ms; Memory: 12MB
Kindly check
Thanks,
Jake