Fix the issues reported by phpcs

Created on 7 August 2020, over 4 years ago
Updated 12 September 2024, 3 months ago

Problem/Motivation

FILE: /slack_rtm/slack_rtm.links.menu.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 11 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /slack_rtm/slack_rtm.routing.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 17 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /slack_rtm/config/install/slack_rtm.settings.yml
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
 2 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------


FILE: /slack_rtm/config/schema/slack_rtm.schema.yml
-------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------
 18 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------


FILE: /slack_rtm/slack_rtm.module
--------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------------------
  6 | ERROR | [x] Doc comment short description must be on the first line
 10 | ERROR | [x] There must be one blank line after the last USE statement; 2 found;
 16 | ERROR | [x] Expected 1 blank line before function; 2 found
 38 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found
 62 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------


FILE: /slack_rtm/slack_rtm.links.task.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 30 | ERROR | [x] Expected 1 newline at end of file; 4 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /slack_rtm/slack_rtm.permissions.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 13 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /slack_rtm/src/SlackRtmApi.php
----------------------------------------------------------------------------------------------------
FOUND 21 ERRORS AND 1 WARNING AFFECTING 21 LINES
----------------------------------------------------------------------------------------------------
  43 | ERROR   | [x] Doc comment short description must end with a full stop
  74 | ERROR   | [x] Parameter comment must end with a full stop
 160 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
 161 | ERROR   | [x] Expected 2 space(s) before asterisk; 1 found
 162 | ERROR   | [x] Expected 2 space(s) before asterisk; 1 found
 163 | ERROR   | [x] Expected 2 space(s) before asterisk; 1 found
 164 | ERROR   | [x] Expected 2 space(s) before asterisk; 1 found
 165 | ERROR   | [x] Expected 2 space(s) before asterisk; 1 found
 166 | ERROR   | [x] Expected 2 space(s) before asterisk; 1 found
 166 | ERROR   | [ ] Description for the @return value is missing
 167 | ERROR   | [x] Expected 2 space(s) before asterisk; 1 found
 240 | ERROR   | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
 255 | ERROR   | [x] Whitespace found at end of line
 256 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks,
     |         |     colons, or closing parentheses
 264 | ERROR   | [x] Short array syntax must be used to define arrays
 269 | WARNING | [x] A comma should follow the last multiline array item. Found:
     |         |     '/src/Batch/SlackRtmBatch.php'
 337 | ERROR   | [x] Expected "object|null" but found "object|NULL" for function return type
 366 | ERROR   | [x] Expected "array|null" but found "array|NULL" for function return type
 385 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks,
     |         |     colons, or closing parentheses
 392 | ERROR   | [x] Inline comments must start with a capital letter
 413 | ERROR   | [x] Expected 1 blank line after function; 0 found
 414 | ERROR   | [x] The closing brace for the class must have an empty line before it
----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 21 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------


FILE: /slack_rtm/src/Form/SlackRtmMessageUpdateForm.php
-----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 37 | WARNING | Possible useless method overriding detected
-----------------------------------------------------------------------------------


FILE: /slack_rtm/src/Form/SlackRtmMessageConfigForm.php
----------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 6 WARNINGS AFFECTING 11 LINES
----------------------------------------------------------------------------------------------------
   7 | WARNING | [x] Unused use statement
  37 | ERROR   | [ ] Doc comment for parameter $database does not match actual variable name
     |         |     <undefined>
 143 | WARNING | [x] There must be no blank line following an inline comment
 156 | WARNING | [ ] Only string literals should be passed to t() where possible
 174 | WARNING | [ ] Only string literals should be passed to t() where possible
 182 | WARNING | [ ] Only string literals should be passed to t() where possible
 200 | WARNING | [ ] Possible useless method overriding detected
 218 | ERROR   | [x] Tag value indented incorrectly; expected 1 space but found 2
 220 | ERROR   | [x] Tag value indented incorrectly; expected 1 space but found 2
 220 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 239 | ERROR   | [x] Expected 1 blank line after function; 0 found
 240 | ERROR   | [x] The closing brace for the class must have an empty line before it
----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------


FILE: /slack_rtm/src/Form/SlackRtmMessageForm.php
-----------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------
 59 | WARNING | Possible useless method overriding detected
-----------------------------------------------------------------------------


FILE: /slack_rtm/src/Entity/SlackRtmMessageInterface.php
------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------
 89 | ERROR | [x] Expected 1 blank line after function; 0 found
------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------


FILE: /slack_rtm/src/Entity/SlackRtmMessageCreate.php
----------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AND 1 WARNING AFFECTING 9 LINES
----------------------------------------------------------------------------------------------------
  1 | ERROR   | [x] The PHP open tag must be followed by exactly one blank line
  2 | ERROR   | [x] Namespaced classes, interfaces and traits should not begin with a file doc
    |         |     comment
  6 | ERROR   | [x] Doc comment short description must end with a full stop
  6 | ERROR   | [ ] Doc comment short description must be on a single line, further text should be
    |         |     a separate paragraph
  9 | ERROR   | [x] There must be one blank line after the namespace declaration
 13 | WARNING | [x] Unused use statement
 15 | ERROR   | [x] Missing class doc comment
 27 | ERROR   | [ ] Missing parameter comment
 36 | ERROR   | [ ] Description for the @return value is missing
 93 | ERROR   | [x] Expected 1 newline at end of file; 0 found
 93 | ERROR   | [x] The closing brace for the class must have an empty line before it
----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------


FILE: /slack_rtm/src/Entity/SlackRtmMessageViewsData.php
------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------
 19 | WARNING | [x] There must be no blank line following an inline comment
------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------


FILE: /slack_rtm/src/Plugin/QueueWorker/SlackRtmQueue.php
-------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
-------------------------------------------------------------------------------------
 25 | ERROR | [x] Expected 1 newline at end of file; 0 found
 25 | ERROR | [x] The closing brace for the class must have an empty line before it
-------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------


FILE: /slack_rtm/src/SlackRtmMessageListBuilder.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 52 | WARNING | [ ] Only string literals should be passed to t() where possible
 55 | WARNING | [x] There must be no blank line following an inline comment
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: /slack_rtm/src/Batch/SlackRtmBatch.php
----------------------------------------------------------------------------------------
FOUND 5 ERRORS AND 1 WARNING AFFECTING 5 LINES
----------------------------------------------------------------------------------------
  6 | ERROR   | [x] There must be one blank line after the last USE statement; 2 found;
 26 | ERROR   | [x] Expected 1 space between comma and argument "$context"; 2 found
 26 | ERROR   | [x] Expected one space after the comma, 2 found
 64 | WARNING | [x] A comma should follow the last multiline array item. Found: )
 72 | ERROR   | [x] Expected 1 blank line after function; 0 found
 73 | ERROR   | [x] The closing brace for the class must have an empty line before it
----------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------


FILE: /slack_rtm/src/SlackRtmMessageTranslationHandler.php
--------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------
 12 | WARNING | [x] There must be no blank line following an inline comment
--------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------

Steps to reproduce

Use below command with arguments.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/slack_rtm

Proposed resolution

Fix the issue found from phpcs command

šŸ“Œ Task
Status

Needs work

Version

1.0

Component

Code

Created by

šŸ‡®šŸ‡³India harishh

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹

    The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.

  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • Status changed to Needs review over 1 year ago
  • šŸ‡®šŸ‡³India Ashutosh Ahirwal India

    I have updated the issue summary.

  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • šŸ‡µšŸ‡°Pakistan RTMKLIK

    RTM KLIK is a Malaysian website that offers a platform for viewers to watch the latest online dramas and live shows. This website provides a convenient way for people to access and enjoy a wide range of Malaysian dramas and live broadcasts.

  • Status changed to Needs work 5 months ago
  • Hi @everyone,

    I applied @kunal_singh's patch, it was applied not-so successfully, might be the reason the errors below were reported. Please see:

    slack_rtm git:(8.x-1.x) curl https://www.drupal.org/files/issues/2020-09-13/3164056-12.patch | patch -p1
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100 19264  100 19264    0     0  45895      0 --:--:-- --:--:-- --:--:-- 46757
    patching file config/install/slack_rtm.settings.yml
    patching file config/schema/slack_rtm.schema.yml
    patching file slack_rtm.links.menu.yml
    patching file slack_rtm.links.task.yml
    patching file slack_rtm.module
    patching file slack_rtm.permissions.yml
    patching file slack_rtm.routing.yml
    patching file src/Batch/SlackRtmBatch.php
    patching file src/Entity/SlackRtmMessageCreate.php
    patching file src/Entity/SlackRtmMessageInterface.php
    patching file src/Entity/SlackRtmMessageViewsData.php
    patching file src/Form/SlackRtmMessageConfigForm.php
    patching file src/Form/SlackRtmMessageForm.php
    patching file src/Form/SlackRtmMessageSettingsForm.php
    patching file src/Form/SlackRtmMessageUpdateForm.php
    patching file src/Plugin/QueueWorker/SlackRtmQueue.php
    patching file src/SlackRtmApi.php
    Hunk #5 FAILED at 242.
    Hunk #7 succeeded at 344 (offset 4 lines).
    Hunk #8 succeeded at 373 (offset 4 lines).
    Hunk #9 succeeded at 392 (offset 4 lines).
    Hunk #10 succeeded at 421 (offset 4 lines).
    1 out of 10 hunks FAILED -- saving rejects to file src/SlackRtmApi.php.rej
    patching file src/SlackRtmMessageListBuilder.php
    patching file src/SlackRtmMessageTranslationHandler.php
    āžœ  slack_rtm git:(8.x-1.x) āœ— cd ..
    āžœ  contrib git:(master) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig slack_rtm
    
    FILE: ...ite/drupal-orgissue-v9/web/modules/contrib/slack_rtm/slack_rtm.routing.yml
    --------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------------
      7 | WARNING | The administration page callback should probably use
        |         | "administer site configuration" - which implies the user can
        |         | change something - rather than "access administration pages"
        |         | which is about viewing but not changing configurations.
     17 | WARNING | Open page callback found, please add a comment before the line
        |         | why there is no access restriction
    --------------------------------------------------------------------------------
    
    
    FILE: ...emo-site/drupal-orgissue-v9/web/modules/contrib/slack_rtm/slack_rtm.module
    --------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------------
     54 | WARNING | Unused variable $slack_rtm_message.
    --------------------------------------------------------------------------------
    
    
    FILE: ...-site/drupal-orgissue-v9/web/modules/contrib/slack_rtm/src/SlackRtmApi.php
    --------------------------------------------------------------------------------
    FOUND 3 ERRORS AFFECTING 3 LINES
    --------------------------------------------------------------------------------
       7 | ERROR | [x] Use statements should be sorted alphabetically. The first
         |       |     wrong one is Drupal\Core\Url.
     244 | ERROR | [x] Functions must not contain multiple empty lines in a row;
         |       |     found 2 empty lines
     260 | ERROR | [x] Inline comments must end in full-stops, exclamation marks,
         |       |     question marks, colons, or closing parentheses
    --------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------------
    
    
    FILE: ...ue-v9/web/modules/contrib/slack_rtm/src/Form/SlackRtmMessageConfigForm.php
    --------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------------
     9 | ERROR | [x] Use statements should be sorted alphabetically. The first
       |       |     wrong one is Drupal\Component\Utility\NestedArray.
    --------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------------
    
    
    FILE: ...orgissue-v9/web/modules/contrib/slack_rtm/src/Form/SlackRtmMessageForm.php
    --------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------------
     9 | ERROR | [x] Use statements should be sorted alphabetically. The first
       |       |     wrong one is Drupal\Component\Datetime\TimeInterface.
    --------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------------
    
    
    FILE: ...l-orgissue-v9/web/modules/contrib/slack_rtm/src/Entity/SlackRtmMessage.php
    --------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------------
     7 | ERROR | [x] Use statements should be sorted alphabetically. The first
       |       |     wrong one is Drupal\Core\Entity\ContentEntityBase.
    --------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------------
    
    
    FILE: .../web/modules/contrib/slack_rtm/src/SlackRtmMessageAccessControlHandler.php
    --------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------------
     8 | ERROR | [x] Use statements should be sorted alphabetically. The first
       |       |     wrong one is Drupal\Core\Access\AccessResult.
    --------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------------
    
    Time: 472ms; Memory: 12MB

    Kindly check

    Thanks,
    Jake

  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹

    Let's create a merge request, now that patches are no longer tested.

  • Pipeline finished with Failed
    5 months ago
    Total: 321s
    #228629
  • Assigned to akshaydalvi212
  • šŸ‡®šŸ‡³India akshaydalvi212

    i will work on this issue.

  • šŸ‡®šŸ‡³India akshaydalvi212

    akshaydalvi212 ā†’ changed the visibility of the branch 3164056-fix-phpcs-issues to hidden.

  • šŸ‡®šŸ‡³India akshaydalvi212

    akshaydalvi212 ā†’ changed the visibility of the branch 3164056-fix-phpcs-issues to active.

  • Pipeline finished with Failed
    4 months ago
    Total: 76s
    #266114
  • Pipeline finished with Failed
    4 months ago
    Total: 76s
    #266118
  • Pipeline finished with Failed
    4 months ago
    Total: 76s
    #266127
  • Pipeline finished with Failed
    4 months ago
    Total: 79s
    #266147
  • Pipeline finished with Failed
    4 months ago
    Total: 80s
    #266730
  • Pipeline finished with Failed
    4 months ago
    Total: 83s
    #266749
  • Issue was unassigned.
  • šŸ‡®šŸ‡³India akshaydalvi212

    hi,
    I worked on the issues and resolved them.
    Only some remaining issues can be reviewed by module maintainers for further removal of the unused $variable.

    Thanks and regards
    Akshay.

  • Hi @Akshay,

    I have applied the commits you made on MR!1, it was applied smoothly and confirmed most issues other than unused variables were fixed. For the maintainer/s, please see below for the issues not yet fixed:

    slack_rtm git:(8.x-1.x) āœ— curl https://git.drupalcode.org/project/slack_rtm/-/merge_requests/1.diff | patch -p1
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100 23345    0 23345    0     0  63877      0 --:--:-- --:--:-- --:--:-- 65209
    patching file .gitlab-ci.yml
    patching file config/install/slack_rtm.settings.yml
    patching file config/schema/slack_rtm.schema.yml
    patching file slack_rtm.links.menu.yml
    patching file slack_rtm.links.task.yml
    patching file slack_rtm.module
    patching file slack_rtm.permissions.yml
    patching file slack_rtm.routing.yml
    patching file src/Batch/SlackRtmBatch.php
    patching file src/Entity/SlackRtmMessage.php
    patching file src/Entity/SlackRtmMessageCreate.php
    patching file src/Entity/SlackRtmMessageInterface.php
    patching file src/Entity/SlackRtmMessageViewsData.php
    patching file src/Form/SlackRtmMessageConfigForm.php
    patching file src/Form/SlackRtmMessageForm.php
    patching file src/Plugin/QueueWorker/SlackRtmQueue.php
    patching file src/SlackRtmApi.php
    patching file src/SlackRtmMessageAccessControlHandler.php
    patching file src/SlackRtmMessageListBuilder.php
    patching file src/SlackRtmMessageTranslationHandler.php
    āžœ  slack_rtm git:(8.x-1.x) āœ— ..
    āžœ  contrib git:(master) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig slack_rtm
    
    FILE: ...ite/drupal-orgissue-v9/web/modules/contrib/slack_rtm/slack_rtm.routing.yml
    --------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------------
     17 | WARNING | Open page callback found, please add a comment before the line
        |         | why there is no access restriction
    --------------------------------------------------------------------------------
    
    
    FILE: ...emo-site/drupal-orgissue-v9/web/modules/contrib/slack_rtm/slack_rtm.module
    --------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------------
     54 | WARNING | Unused variable $slack_rtm_message.
    --------------------------------------------------------------------------------
    
    
    FILE: ...ue-v9/web/modules/contrib/slack_rtm/src/Form/SlackRtmMessageUpdateForm.php
    --------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------------
     37 | WARNING | Possible useless method overriding detected
     45 | WARNING | Unused variable $api.
    --------------------------------------------------------------------------------
    
    
    FILE: ...-v9/web/modules/contrib/slack_rtm/src/Form/SlackRtmMessageSettingsForm.php
    --------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------------
     12 | WARNING | The class short comment should describe what the class does and
        |         | not simply repeat the class name
    --------------------------------------------------------------------------------
    
    
    FILE: ...ue-v9/web/modules/contrib/slack_rtm/src/Form/SlackRtmMessageConfigForm.php
    --------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------------
     208 | WARNING | Possible useless method overriding detected
    --------------------------------------------------------------------------------
    
    
    FILE: ...orgissue-v9/web/modules/contrib/slack_rtm/src/Form/SlackRtmMessageForm.php
    --------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------------
     59 | WARNING | Possible useless method overriding detected
    --------------------------------------------------------------------------------
    
    
    FILE: ...ssue-v9/web/modules/contrib/slack_rtm/src/Entity/SlackRtmMessageCreate.php
    --------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------------
     70 | WARNING | Unused variable $t.
    --------------------------------------------------------------------------------
    
    
    FILE: ...-v9/web/modules/contrib/slack_rtm/src/Plugin/QueueWorker/SlackRtmQueue.php
    --------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------------
     23 | WARNING | Unused variable $result.
    --------------------------------------------------------------------------------
    
    Time: 482ms; Memory: 12MB

    Kindly check

    Thanks,
    Jake

Production build 0.71.5 2024