๐Ÿ‡ฎ๐Ÿ‡ณIndia @akshaydalvi212

Account created on 13 August 2021, almost 3 years ago
  • Associate Engineer - Full Stack at QED42ย 
#

Merge Requests

More

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

Removed all the phpcs issues only some warnings are remaining.
kindly review the MR.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

I will work on this and resolve the issues and raise the MR.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

Resolved all the issues only the below issues remain.
you can review the updated MR.

FILE: /home/admin1/task/drupal9-os/web/modules/contrib/eck-3422393/tests/src/Unit/UnitTestBase.php
--------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------
51 | WARNING | Unused variable $methods.
81 | WARNING | Unused private method getEntityManagerMock()
--------------------------------------------------------------------------------------------------

FILE: /home/admin1/task/drupal9-os/web/modules/contrib/eck-3422393/eck.module
-------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------
27 | WARNING | Global constants should not be used, move it to a class or interface
32 | WARNING | Global constants should not be used, move it to a class or interface
-------------------------------------------------------------------------------------

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

akshaydalvi212 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

Resolved the remaining phpcs issues.
kindly review.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

Raised the MR with the changes required.
Kindly review the same.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

I will work on this issue and raised the MR.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

Raised the MR with the needful changes.
kindly review the MR.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

I will provide the MR for replacing $this->t() to t().

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

akshaydalvi212 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

Fix the remaining Dependency injection issues.
kindly review.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

I will work on this issue.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

Raised the MR and solved the Coding standards errors using the command
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

Updated the code and remove the format-size()
kindly review this MR.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

updated the code and removed the depreciated format_size().
kindly review the MR.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

Updating new patch.
kindly review the patch.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

As i reviewed the patch,
will applying the patch it is providing error as corrupt patch at line 125.

hence I will work on this and provide the correct patch.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

I will review the patch.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

Updated the comments and removed the mentioned code.
kindly review the PR.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

Will work on the added comment in the PR.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

Updated the code and raised the PR.
only unused variable warnings remain.
kindly review the PR changes.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

will work on this and update the PR.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

Updated the MR and committed the isset() check
as the $form_id will be set when the function is called and hence isset($form_id) check is unnecessary.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

I will work on this.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

updated the PR kindly review it.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

I will work on this issue, and provide the MR.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

hey,
MR is raised,
kindly review and test the MR.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

Hey,
will provide the MR for the updating Entity timestamp.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

akshaydalvi212 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

Raised the MR, kindly review it.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

I will update the code and provide the MR for the same.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

akshaydalvi212 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

Added the Patch which solves the issues.
kindly review the patch.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

Updated the Contributor.md file and manage to keep 80 characters per line.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

I will try to manage 80 characters per line for the contributor.md file

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

akshaydalvi212 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

hey @gueguerreiro,
Please review and add the patch to the branch 8.x-1.4.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

The patch #2 is not working with version 8.x-1.4 hence re-rolling the patch.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

Updated the code and raised the MR for removing the reported errors.
Kindly review the MR.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

hey @yashmalviya,
Thank you for the patch but while applying the patch getting errors as shown in the image.

will make changes the also raise the MR which will remove the reporting errors.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

I will review the patch.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

Updated the MR for getting the hook_help() content from the README.md file directly.
also updated The README.md file and removed the phpcs errors.
kindly review the MR.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

this approach is good but we can use the README.md file directly in hook_help() implementation.
will update the code according.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

Updated the MR as per suggested.
kindly review the MR.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

I will update the MR as per comments added on the MR.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

Made the suggested changes in the MR.
kindly review the MR.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

I will work on the comments added to the MR and update the MR accordingly.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

Resolved all the Errors and raised the MR.
kindly review the MR.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

I will updated the code so as to resolve the reported errors and raise the MR.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

akshaydalvi212 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

I raised the MR which removes all the reported errors only
"unused variable $settings" need to be confirmed by the module's maintainers.
kindly review the MR.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

I will remove the reported errors and raise a MR for the same.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

akshaydalvi212 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

Raised the MR which removes all the reported errors.
only warning as unused variables $field_storage_type and $delta is remaining which need to be confirmed from module maintainers.
kindly review the MR.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

I will work on this issue and raise the MR for the same.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

MR updated as needed.
kindly review the MR.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

hey @sidharth_soman,
thanks for the MR it looks good but,
it still has a warning as shown in the below image.

I will work on it and update the MR.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

Removed both dependency injection and fnmatch() warning.
raised the MR with all the changes.
kindly review the MR.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

i will work on this and update with an MR.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

akshaydalvi212 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

Provided the MR which will resolve the reported issues above.
kindly review the MR.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

The patch is not getting applied and throwing errors.
ss is attached for reference.

will work on it and provide an MR for the better approach.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

i will review the patch.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

updated the MR as per suggestion #4.
kindly review.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

I will replace the code with the suggested script in #4.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

Updated the code and raised the MR.
kindly review.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

I will update the PHP deprecation code.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

Kindly review the MR and sorry was not in a condition to work on it for the last 2-3 days.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

I will work on the MR as I raised at #7 and as suggested in #9 and #12 will update the MR accordingly.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

I will update the MR and README.md file as per the suggestion provided.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

kindly review the new patch file.
interdiff file is also provided.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

I will work on this and will provide new patch file and interdiff file.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

i had removed the warnings with the MR.
kindly review.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

akshaydalvi212 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

providing updated patch and interdiff files.
kindly review.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

I will provide an updated patch which will solve the suggested changes and interdiff file.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

kindly review the patch.
fixed all the indention issues.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

I will work on it and provide updated patch file.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

akshaydalvi212 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

I will replace the $notificationId with $id in the MR.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

Resolved the issues kindly review.

๐Ÿ‡ฎ๐Ÿ‡ณIndia akshaydalvi212

I will resolve the remaining issues reported above.

Production build 0.69.0 2024