🇮🇳India @akshaydalvi212

Hi,

I tried the MR !2 changes on drupal 10.3.3 and it is working fine with space in between two articles, read more and add comment buttons.
for more reference you can refer the screenshot attach below.

Thanks.

hi @cleavinjosh,
Resolved the last issue, you can review the MR now.
Thanks and regards.

I will remove the remaining issue.

akshaydalvi212 → made their first commit to this issue’s fork.

Hi,
I resolved almost all the phpcs issues, only some unused variable and private methods issues are remaining

Thanks

hi,
I will work on this issues and resolve it as well.

hi,
I removed the remaining issues related to the array declarations.
only unused variables issues are remaining for the Content.php file.
FILE: /home/admin1/open-source/drupal10.3/drupal/modules/contrib/parameters/src/Plugin/Parameter/Content.php
------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 10 WARNINGS AFFECTING 10 LINES
------------------------------------------------------------------------------------------------------------
186 | WARNING | Unused variable $bundle.
189 | WARNING | Unused variable $bundle.
357 | WARNING | Unused variable $cleanupFieldValues.
358 | WARNING | Unused variable $normalizeNewEntities.
363 | WARNING | Unused variable $cleanupFieldValues.
364 | WARNING | Unused variable $normalizeNewEntities.
381 | WARNING | Unused variable $cleanupFieldValues.
382 | WARNING | Unused variable $normalizeNewEntities.
387 | WARNING | Unused variable $cleanupFieldValues.
388 | WARNING | Unused variable $normalizeNewEntities.
------------------------------------------------------------------------------------------------------------

akshaydalvi212 → made their first commit to this issue’s fork.

I had removed the indentation error in the Readme file.

akshaydalvi212 → made their first commit to this issue’s fork.

hi,
I worked on the issues and resolved them.
Only some remaining issues can be reviewed by module maintainers for further removal of the unused $variable.

Thanks and regards
Akshay.

akshaydalvi212 → changed the visibility of the branch 3164056-fix-phpcs-issues to active.

akshaydalvi212 → changed the visibility of the branch 3164056-fix-phpcs-issues to hidden.

i will work on this issue.

Hi @arijit acharya

Sorry I was just acting as an helping hand and doesn't want to make any noise.
my intension was just to help and nothing else.
will stop action on this issues.

Sorry again.

akshaydalvi212 → made their first commit to this issue’s fork.

I will work on this issue and resolve all the errors.

akshaydalvi212 → made their first commit to this issue’s fork.

hi @a.aaronjake,

Removed the remaining coding standard errors and now you can review.

Thanks and regards
Akshay Dalvi

I will remove the remaining issues.

I had worked and solved the phpcs issues.

akshaydalvi212 → made their first commit to this issue’s fork.

akshaydalvi212 → made their first commit to this issue’s fork.

I will remove the remaining phpcs errors.

Hi

I had fixed the remaining phpcs issues and raised the PR as here

and all the phpcs errors are removed
kindly test and review.

Thanks.

i will remove the remaining errors.

akshaydalvi212 → made their first commit to this issue’s fork.

Hey @tohesi,

Sorry, I also tried removing the deprecation errors I encountered on my local with the new branch PR.

Adding the image as an attachment when I encountered the error on the configuration setting page of Fastly.

I will work on this issue.

Kristen Pol → credited akshaydalvi212 → .

Removed all the phpcs issues only some warnings are remaining.
kindly review the MR.

I will work on this and resolve the issues and raise the MR.

Resolved all the issues only the below issues remain.
you can review the updated MR.

FILE: /home/admin1/task/drupal9-os/web/modules/contrib/eck-3422393/tests/src/Unit/UnitTestBase.php
--------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------
51 | WARNING | Unused variable $methods.
81 | WARNING | Unused private method getEntityManagerMock()
--------------------------------------------------------------------------------------------------

FILE: /home/admin1/task/drupal9-os/web/modules/contrib/eck-3422393/eck.module
-------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------
27 | WARNING | Global constants should not be used, move it to a class or interface
32 | WARNING | Global constants should not be used, move it to a class or interface
-------------------------------------------------------------------------------------

akshaydalvi212 → made their first commit to this issue’s fork.

Resolved the remaining phpcs issues.
kindly review.

Raised the MR with the changes required.
Kindly review the same.

I will work on this issue and raised the MR.

Raised the MR with the needful changes.
kindly review the MR.

I will provide the MR for replacing $this->t() to t().

akshaydalvi212 → made their first commit to this issue’s fork.

Fix the remaining Dependency injection issues.
kindly review.

I will work on this issue.

Raised the MR and solved the Coding standards errors using the command
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml

Updated the code and remove the format-size()
kindly review this MR.

I will work no this issue.

updated the code and removed the depreciated format_size().
kindly review the MR.

I will work on this issue.

akshaydalvi212 → made their first commit to this issue’s fork.

Updating new patch.
kindly review the patch.

As i reviewed the patch,
will applying the patch it is providing error as corrupt patch at line 125.

hence I will work on this and provide the correct patch.

I will review the patch.

Updated the comments and removed the mentioned code.
kindly review the PR.

Will work on the added comment in the PR.

Updated the code and raised the PR.
only unused variable warnings remain.
kindly review the PR changes.

will work on this and update the PR.

Updated the MR and committed the isset() check
as the $form_id will be set when the function is called and hence isset($form_id) check is unnecessary.

I will work on this.

updated the PR kindly review it.

I will work on this issue, and provide the MR.

Will provide some docs for the returns values.

hey,
MR is raised,
kindly review and test the MR.

Hey,
will provide the MR for the updating Entity timestamp.

akshaydalvi212 → made their first commit to this issue’s fork.

Raised the MR, kindly review it.

I will update the code and provide the MR for the same.

akshaydalvi212 → made their first commit to this issue’s fork.

Added the Patch which solves the issues.
kindly review the patch.

I will try to resolve this issue.

akshaydalvi212 → made their first commit to this issue’s fork.

Updated the Contributor.md file and manage to keep 80 characters per line.

I will try to manage 80 characters per line for the contributor.md file

akshaydalvi212 → made their first commit to this issue’s fork.

akshaydalvi212 → made their first commit to this issue’s fork.

hey @gueguerreiro,
Please review and add the patch to the branch 8.x-1.4.

The patch #2 is not working with version 8.x-1.4 hence re-rolling the patch.

Updated the code and raised the MR for removing the reported errors.
Kindly review the MR.

hey @yashmalviya,
Thank you for the patch but while applying the patch getting errors as shown in the image.

will make changes the also raise the MR which will remove the reporting errors.

I will review the patch.

Updated the MR for getting the hook_help() content from the README.md file directly.
also updated The README.md file and removed the phpcs errors.
kindly review the MR.

this approach is good but we can use the README.md file directly in hook_help() implementation.
will update the code according.

I will review the patch.

Updated the MR as per suggested.
kindly review the MR.

I will update the MR as per comments added on the MR.

Made the suggested changes in the MR.
kindly review the MR.

I will work on the comments added to the MR and update the MR accordingly.

Resolved all the Errors and raised the MR.
kindly review the MR.

I will updated the code so as to resolve the reported errors and raise the MR.