- Issue created by @zniki.ru
- ๐ฎ๐ณIndia Anjali Mehta
Anjali Mehta โ made their first commit to this issueโs fork.
- First commit to issue fork.
- last update
about 1 year ago 48 pass - Status changed to Needs review
about 1 year ago 1:01pm 2 January 2024 - Status changed to Needs work
about 1 year ago 1:36pm 2 January 2024 - ๐ท๐บRussia zniki.ru
Thanks for you contribution, I didn't check changes yet.
There are 2 issues left in thetests/src/Functional/PathautoBulkUpdateTest.php
.FILE: ...es/custom/pathauto-3411808/tests/src/Functional/PathautoBulkUpdateTest.php -------------------------------------------------------------------------------- 20 | ERROR | [x] Expected 2 space(s) before asterisk; 3 found | | (Drupal.Commenting.DocCommentAlignment.SpaceBeforeStar) 21 | ERROR | [x] Expected 2 space(s) before asterisk; 3 found | | (Drupal.Commenting.DocCommentAlignment.SpaceBeforeStar)
Source https://git.drupalcode.org/issue/pathauto-3411808/-/jobs/558800
- last update
about 1 year ago 48 pass - Status changed to Needs review
about 1 year ago 5:34am 3 January 2024 - ๐ท๐บRussia zniki.ru
All Drupal.Commenting violations fixed. List of fixed sniffs:
[ ] Drupal.Commenting.DocComment.MissingShort 18 [ ] Drupal.Commenting.FunctionComment.MissingReturnComment 10 [x] Drupal.Commenting.FunctionComment.Missing 5 [ ] Drupal.Commenting.DocComment.ShortFullStop 4 [ ] Drupal.Commenting.DocComment.ShortNotCapital 4 [ ] Drupal.Commenting.DocComment.ParamNotFirst 3 [ ] Drupal.Commenting.DocComment.ShortSingleLine 3 [x] Drupal.Commenting.FunctionComment.ParamCommentFullStop 3 [x] Drupal.Commenting.DocCommentAlignment.SpaceBeforeStar 2 [ ] Drupal.Commenting.FunctionComment.MissingParamType 2 [ ] Drupal.Commenting.FunctionComment.ThrowsNoFullStop 2 [x] Drupal.Commenting.InlineVariableComment.VarInline 2 [x] Drupal.Commenting.ClassComment.Missing 1 [x] Drupal.Commenting.DataTypeNamespace.DataTypeNamespace 1 [ ] Drupal.Commenting.Deprecated.DeprecatedMissingSeeTag 1 [ ] Drupal.Commenting.Deprecated.IncorrectTextLayout 1 [x] Drupal.Commenting.FileComment.Missing 1 [ ] Drupal.Commenting.FunctionComment.MissingParamComment 1 [ ] Drupal.Commenting.FunctionComment.ParamCommentNotCapital 1 [ ] Drupal.Commenting.FunctionComment.ParamMissingDefinition 1 [x] Drupal.Commenting.InlineComment.NotCapital 1
MR is ready for review.
- ๐จ๐ญSwitzerland berdir Switzerland
Tests are currently failing, I will not commit low prio things like coding standard fixes until they pass again. The test fails are likely caused by Drupal 10.2 changes. I suggest opening a separate issue to investigate and fix those first.
- last update
about 1 year ago 48 pass - last update
about 1 year ago 48 pass - last update
about 1 year ago 48 pass - last update
about 1 year ago 48 pass - last update
about 1 year ago 48 pass - ๐ท๐บRussia zniki.ru
Update MR, add phpcs.xml file and exclude rules that will be fixed in different issues.
Gitlab CI check phpcs passed. - last update
about 1 year ago 48 pass - Status changed to Needs work
about 1 year ago 10:17pm 23 January 2024 - last update
about 1 year ago 48 pass - ๐ฎ๐ณIndia sakthi_dev
Addressed some comments in MR. Please fix others.
- last update
about 1 year ago 48 pass - last update
about 1 year ago 48 pass - last update
about 1 year ago 48 pass - Assigned to akshaydalvi212
- Open on Drupal.org โCore: 10.2.x + Environment: PHP 8.1 & MySQL 5.7last update
12 months ago Not currently mergeable. - Issue was unassigned.
- Status changed to Needs review
12 months ago 1:07pm 1 April 2024 - ๐ฎ๐ณIndia akshaydalvi212
Resolved the remaining phpcs issues.
kindly review. - Assigned to zniki.ru
- Status changed to Needs work
9 months ago 6:22am 20 June 2024 - ๐ท๐บRussia zniki.ru
@akshaydalvi212 thanks for your contribution, this issue is only about to fix Drupal.Commenting violations.
I will revert commit b043409c, because it contains changes not related to these cs rules.
And I will resolve merge conflict. - Issue was unassigned.
- Status changed to Needs review
9 months ago 8:49am 20 June 2024 - ๐ท๐บRussia zniki.ru
Resolve Merge conflict and update some comments. Ready for review.
During review please take a closer look at order of @hook, @throws, @annotation in src/Commands/PathautoCommands.php not sure, that this is correct order, welcome for suggestion.
And I don't know how to fix "Missing short description in doc comment" at pathauto.api.php:10. This is last one from Drupal.Commenting in code base for now,
CS Report updated in the IS.