- Merge request !57Issue #3305870: Not rendering correctly in Layout builder preview → (Open) created by aprice42
- 🇺🇸United States Greg Boggs Portland Oregon
Awesome. Thanks @odai Jbr. Can you update the merge request so I can get this into the release?
- Assigned to akshaydalvi212
- Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 8last update
about 1 year ago Not currently mergeable. - Issue was unassigned.
- Status changed to Needs review
about 1 year ago 10:31am 13 March 2024 - last update
about 1 year ago 6 pass - last update
about 1 year ago Patch Failed to Apply - last update
about 1 year ago Patch Failed to Apply - Status changed to Needs work
about 1 year ago 5:12pm 13 March 2024 - 🇺🇸United States Greg Boggs Portland Oregon
It looks like it needs a rebase against the latest 2.0 code so that it's mergeable. The dev release has a buuunch of coding standards fixes that have probably impacted this merge.
- First commit to issue fork.
- last update
11 months ago 6 pass, 2 fail - last update
11 months ago 6 pass, 2 fail - 🇩🇪Germany spuky
brought the MR up to dev things to do
- convert \Drupal::routeMatch()->getParameters(); to DI
- fix Unittests - last update
11 months ago 6 pass, 2 fail - last update
11 months ago 6 pass, 2 fail - last update
11 months ago 7 pass - Status changed to Needs review
11 months ago 1:22pm 30 June 2024 - First commit to issue fork.
- 🇳🇿New Zealand ericgsmith
I've added test coverage.
https://git.drupalcode.org/issue/easy_breadcrumb-3305870/-/jobs/5365762#... shows the error I mentioned in the MR:
There was 1 error: 1) Drupal\Tests\easy_breadcrumb\Functional\EasyBreadcrumbLayoutBuilderTest::testLayoutBuilderSupport Exception: Warning: Undefined array key "entity_type_id"
After reverting fdf560dd the test now passes : https://git.drupalcode.org/issue/easy_breadcrumb-3305870/-/jobs/5365770
However this reintroduces the phpstan issue.
Have not done a proper review of the code / changes - likely the intent of fdf560dd should still be progress to resolve the issue although now there is test coverage to ensure it works.
Setting to needs work as it either needs the baseline updated / accepted or improvements to not introduce new phpstan issues.