Compatibility with coding standards

Can someone review this small Pull Request ?
There is not big changes ..

Reviewed by running
phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml views_filters_summary against this branch.

Confirmed no issues found. Moving to RTBC.

Updated MR to fix eslint issues in addition to phpcs.

Moving back to Needs Review.

Hi @mdranove,

Applied the latest changes on MR!21 successfully, however, there are errors reported. Please see below:

views_filters_summary git:(2.0.x) curl https://git.drupalcode.org/project/views_filters_summary/-/merge_requests/21.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 12957    0 12957    0     0  23361      0 --:--:-- --:--:-- --:--:-- 23774
patching file README.txt
patching file css/views_filters_summary.css
patching file js/views-filters-summary.js
patching file src/Plugin/views/area/ViewsFiltersSummary.php
patching file views_filters_summary.module
➜  views_filters_summary git:(2.0.x) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig views_filters_summary

FILE: ...ontrib/views_filters_summary/src/Plugin/views/area/ViewsFiltersSummary.php
--------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------------
  70 | ERROR | [x] Multi-line function declarations must have a trailing comma
     |       |     after the last parameter
  85 | ERROR | [x] Multi-line function declarations must have a trailing comma
     |       |     after the last parameter
 129 | ERROR | [x] Multi-line function declarations must have a trailing comma
     |       |     after the last parameter
 344 | ERROR | [x] Multi-line function declarations must have a trailing comma
     |       |     after the last parameter
 380 | ERROR | [x] Multi-line function declarations must have a trailing comma
     |       |     after the last parameter
 609 | ERROR | [x] Multi-line function declarations must have a trailing comma
     |       |     after the last parameter
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 283ms; Memory: 14MB

Kindly check

Thanks,
Jake

I will remove the remaining phpcs errors.

Hi @akshaydalvi212,

Applied the latest changes you committed on MR!21, confirmed it resolved phpcs errors/warnings reported.

views_filters_summary git:(2.0.x) curl https://git.drupalcode.org/project/views_filters_summary/-/merge_requests/21.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 14684    0 14684    0     0  35104      0 --:--:-- --:--:-- --:--:-- 36167
patching file README.txt
patching file css/views_filters_summary.css
patching file js/views-filters-summary.js
patching file src/Plugin/views/area/ViewsFiltersSummary.php
patching file views_filters_summary.module
➜  views_filters_summary git:(2.0.x) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig views_filters_summary
➜  contrib git:(main) ✗

Will now move this to RTBC

Thanks,
Jake

Should be fixed in 3.0.x-dev branch.

Automatically closed - issue fixed for 2 weeks with no activity.