morgannc → changed the visibility of the branch 3456271-security-flaw-allowing to hidden.
morgannc → created an issue.
morgannc → created an issue.
morgannc → created an issue.
Can someone review this small Pull Request ?
There is not big changes ..
Phpcs and Drupal standards were correctly applied, so no change there. I mainly tested the new code implemented for compatibility.
For the README, I think it's a good idea to include one, given the paradigm shift in text/date input (to explain how the module works and behaves).
I'm switching the issue back to "Need Work". After testing on mobile, the datepicker doesn't open automatically, so I need to find a way to force it to open in javascript so that it behaves like a date input.
I create other issue to adding placeholder support with text field modifier :
https://www.drupal.org/project/date_popup/issues/3424371
✨
Adding placeholder support
Needs review
But this is on the news version of module 2.x series.
I'm taking advantage of this issue to run drupal/coder over the source code and add a README.
morgannc → created an issue.
The logic is wrong. Placeholder attributes are not allowed on date fields. Today, the latest version of the module allows placeholders to be displayed on inputs, but this goes against current HTML rules :
https://html.spec.whatwg.org/multipage/input.html#date-state-(type%3Ddate)
The following content attributes must not be specified and do not apply to the element: accept, alt, checked, dirname, formaction, formenctype, formmethod, formnovalidate, formtarget, height, maxlength, minlength, multiple, pattern, placeholder, popovertarget, popovertargetaction, size, src, and width.
If you need to display pre-defined text or text on top of your element, turn to other solutions such as CSS, or even consider a text field (note that this may have repercussions in terms of ux/ui and values returned).
Adding my organization to this contribution.
morgannc → created an issue.
morgannc → created an issue.
Thanks for helping !
Thanks for your reply !
What can I do about my existing issue (
https://www.drupal.org/project/menu_link_attributes/issues/3419481
📌
Compatibility with coding standards
Needs review
) ?
morgannc → created an issue.