- Issue created by @ankitv18
- Assigned to arijit acharya
Hello,
I reviewed the MR20, but I can still find issues reported by phpcs. Attaching a screenshot below for the reference.
Also, adding a commit in a day, to fix it.
- First commit to issue fork.
Hi @akshaydalvi212,
This issue was previously assigned to me, and I have been actively working on it. According to our community guidelines, if an issue is already assigned, other contributors are expected to allow the assigned developer some time to resolve it before taking any further action.
I would kindly request that we adhere to the established community protocols and ensure that assigned issues are respected.- 🇮🇳India akshaydalvi212
Hi @arijit acharya
Sorry I was just acting as an helping hand and doesn't want to make any noise.
my intension was just to help and nothing else.
will stop action on this issues.Sorry again.
Thank you @akshaydalvi212 for your response and for your willingness to help. I completely understand your intention to assist, and I truly appreciate your willingness to contribute.
- Issue was unassigned.
- Status changed to Needs review
4 months ago 1:08pm 28 August 2024
Attaching the screenshot, in this image we find some of the phpcs reported in the .module file.
Issues present in line 313-317 of the file, are due to a function which is kept commented. The function might be kept commented due to som e purpose by the maintainer, so I have not deleted that. For the issue present in line 287 need more info from the maintainer.- Status changed to Needs work
4 months ago 1:15pm 28 August 2024 - 🇮🇳India ankitv18
Phpunit are failing please fix those ~~ moving back into NW
- 🇮🇳India sourav_paul Kolkata
I've checked those phpcs issues & Tested the MR.
MR !20 applied cleanlysourav@sourav-Mi-Notebook-Pro:~/projects/my_site/web/modules/contrib/monitoring$ curl https://git.drupalcode.org/project/monitoring/-/merge_requests/20.diff | git apply -v % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 566k 0 566k 0 0 483k 0 --:--:-- 0:00:01 --:--:-- 484k Checking patch README.txt... Checking patch drush.services.yml... Checking patch modules/demo/monitoring_demo.install... Checking patch modules/demo/monitoring_demo.module... Checking patch modules/demo/src/Controller/FrontPage.php... Checking patch modules/demo/tests/src/Functional/MonitoringDemoTest.php... Checking patch modules/monitoring_mail/config/schema/monitoring_mail.schema.yml... Checking patch modules/monitoring_mail/monitoring_mail.module... Checking patch modules/monitoring_mail/tests/src/Kernel/MonitoringMailKernelTest.php... Checking patch modules/multigraph/monitoring_multigraph.module... Checking patch modules/multigraph/src/Entity/Multigraph.php... Checking patch modules/multigraph/src/Form/MultigraphDeleteForm.php... Checking patch modules/multigraph/src/Form/MultigraphForm.php... Checking patch modules/multigraph/src/MultigraphInterface.php... Checking patch modules/multigraph/src/MultigraphListBuilder.php... Checking patch modules/multigraph/src/Plugin/rest/resource/MonitoringMultigraphResource.php... Checking patch modules/multigraph/tests/src/Functional/MultigraphServicesTest.php... Checking patch modules/multigraph/tests/src/Functional/MultigraphWebTest.php... Checking patch modules/multigraph/tests/src/Unit/Entity/MultigraphUnitTest.php... Checking patch modules/test/monitoring_test.install... Checking patch modules/test/src/Plugin/QueueWorker/TestWorker.php... Checking patch modules/test/src/Plugin/monitoring/SensorPlugin/TestSensorPlugin.php... Checking patch monitoring.api.php... Checking patch monitoring.css... Checking patch monitoring.drush.inc... Checking patch monitoring.install... Checking patch monitoring.module... Checking patch monitoring.monitoring_sensors.inc... Checking patch review.txt... Checking patch src/Annotation/SensorPlugin.php... Checking patch src/Commands/MonitoringCommands.php... Checking patch src/Controller/CategoryAutocompleteController.php... Checking patch src/Controller/ConfigAutocompleteController.php... Checking patch src/Controller/ForceRunController.php... Checking patch src/Controller/RebuildSensorList.php... Checking patch src/Controller/RequirementsIgnore.php... Checking patch src/Controller/SensorList.php... Checking patch src/Controller/TemporaryFilesController.php... Checking patch src/Element/VerboseTableResult.php... Checking patch src/Entity/SensorConfig.php... Checking patch src/Entity/SensorResultDataInterface.php... Checking patch src/Entity/SensorResultEntity.php... Checking patch src/Entity/ViewsData/SensorResultViewsData.php... Checking patch src/Form/MonitoringSettingsForm.php... Checking patch src/Form/SensorDeleteForm.php... Checking patch src/Form/SensorDetailForm.php... Checking patch src/Form/SensorForm.php... Checking patch src/Plugin/monitoring/SensorPlugin/CommerceTurnoverSensorPlugin.php... Checking patch src/Plugin/monitoring/SensorPlugin/ConfigValueSensorPlugin.php... Checking patch src/Plugin/monitoring/SensorPlugin/ContentEntityAggregatorSensorPlugin.php... Checking patch src/Plugin/monitoring/SensorPlugin/CoreRequirementsSensorPlugin.php... Checking patch src/Plugin/monitoring/SensorPlugin/CronLastRunAgeSensorPlugin.php... Checking patch src/Plugin/monitoring/SensorPlugin/DatabaseAggregatorSensorPlugin.php... Checking patch src/Plugin/monitoring/SensorPlugin/DatabaseDiskUsagePlugin.php... Checking patch src/Plugin/monitoring/SensorPlugin/Dblog404SensorPlugin.php... Checking patch src/Plugin/monitoring/SensorPlugin/DisappearedSensorsSensorPlugin.php... Checking patch src/Plugin/monitoring/SensorPlugin/DiskUsageSensorPlugin.php... Checking patch src/Plugin/monitoring/SensorPlugin/ElysiaCronSensorPlugin.php... Checking patch src/Plugin/monitoring/SensorPlugin/EnabledModulesSensorPlugin.php... Checking patch src/Plugin/monitoring/SensorPlugin/GitDirtyTreeSensorPlugin.php... Checking patch src/Plugin/monitoring/SensorPlugin/ImageMissingStyleSensorPlugin.php... Checking patch src/Plugin/monitoring/SensorPlugin/NonExistingUserFailedLoginsSensorPlugin.php... Checking patch src/Plugin/monitoring/SensorPlugin/PaymentTurnoverSensorPlugin.php... Checking patch src/Plugin/monitoring/SensorPlugin/PhpNoticesSensorPlugin.php... Checking patch src/Plugin/monitoring/SensorPlugin/QueueSizeSensorPlugin.php... Checking patch src/Plugin/monitoring/SensorPlugin/RequirementsRecapSensorPlugin.php... Checking patch src/Plugin/monitoring/SensorPlugin/ResponseTimeSensorPlugin.php... Checking patch src/Plugin/monitoring/SensorPlugin/SearchApiUnindexedSensorPlugin.php... Checking patch src/Plugin/monitoring/SensorPlugin/SolrDiskUsageSensorPlugin.php... Checking patch src/Plugin/monitoring/SensorPlugin/StateValueSensorPlugin.php... Checking patch src/Plugin/monitoring/SensorPlugin/SystemLoadSensorPlugin.php... Checking patch src/Plugin/monitoring/SensorPlugin/SystemMemorySensorPlugin.php... Checking patch src/Plugin/monitoring/SensorPlugin/TemporaryFilesUsagesSensorPlugin.php... Checking patch src/Plugin/monitoring/SensorPlugin/TwigDebugSensorPlugin.php... Checking patch src/Plugin/monitoring/SensorPlugin/UltimateCronErrorsSensorPlugin.php... Checking patch src/Plugin/monitoring/SensorPlugin/UpdateStatusSensorPlugin.php... Checking patch src/Plugin/monitoring/SensorPlugin/UserFailedLoginsSensorPlugin.php... Checking patch src/Plugin/monitoring/SensorPlugin/UserIntegritySensorPlugin.php... Checking patch src/Plugin/monitoring/SensorPlugin/ViewDisplayAggregatorSensorPlugin.php... Checking patch src/Plugin/monitoring/SensorPlugin/WatchdogAggregatorSensorPlugin.php... Checking patch src/Plugin/rest/resource/MonitoringSensorConfigResource.php... Checking patch src/Plugin/rest/resource/MonitoringSensorResultResource.php... Checking patch src/Plugin/views/field/SensorMessage.php... Checking patch src/Plugin/views/field/SensorName.php... Checking patch src/Result/SensorResult.php... Checking patch src/Result/SensorResultInterface.php... Checking patch src/Sensor/DisabledSensorException.php... Checking patch src/Sensor/NonExistingSensorException.php... Checking patch src/Sensor/SensorCompilationException.php... Checking patch src/Sensor/SensorManager.php... Checking patch src/Sensor/Thresholds.php... Checking patch src/SensorConfigAccessControlHandler.php... Checking patch src/SensorConfigInterface.php... Checking patch src/SensorListBuilder.php... Checking patch src/SensorPlugin/DatabaseAggregatorSensorPluginBase.php... Checking patch src/SensorPlugin/ExtendedInfoSensorPluginInterface.php... Checking patch src/SensorPlugin/SensorPluginBase.php... Checking patch src/SensorPlugin/SensorPluginInterface.php... Checking patch src/SensorPlugin/ValueComparisonSensorPluginBase.php... Checking patch src/SensorRunner.php... Checking patch tests/src/Functional/MonitoringCaptchaTest.php... Checking patch tests/src/Functional/MonitoringCommerceTest.php... Checking patch tests/src/Functional/MonitoringCoreWebTest.php... Checking patch tests/src/Functional/MonitoringRebuildTest.php... Checking patch tests/src/Functional/MonitoringServicesTest.php... Checking patch tests/src/Functional/MonitoringTestBase.php... Checking patch tests/src/Functional/MonitoringTestTrait.php... Checking patch tests/src/Functional/MonitoringUITest.php... Checking patch tests/src/Functional/MonitoringViewDisplayTest.php... Checking patch tests/src/FunctionalJavascript/MonitoringUiJavascriptTest.php... Checking patch tests/src/Kernel/MonitoringApiTest.php... Checking patch tests/src/Kernel/MonitoringCoreKernelTest.php... Checking patch tests/src/Kernel/MonitoringCronErrorPluginTest.php... Checking patch tests/src/Kernel/MonitoringDiskUsageSensorTest.php... Checking patch tests/src/Kernel/MonitoringPastTest.php... Checking patch tests/src/Kernel/MonitoringRedirect404SensorTest.php... Checking patch tests/src/Kernel/MonitoringResponseTimeSensorTest.php... Checking patch tests/src/Kernel/MonitoringSearchAPITest.php... Checking patch tests/src/Kernel/MonitoringSystemLoadSensorTest.php... Checking patch tests/src/Kernel/MonitoringSystemMemoryPluginTest.php... Checking patch tests/src/Kernel/MonitoringUnitTestBase.php... Applied patch README.txt cleanly. Applied patch drush.services.yml cleanly. Applied patch modules/demo/monitoring_demo.install cleanly. Applied patch modules/demo/monitoring_demo.module cleanly. Applied patch modules/demo/src/Controller/FrontPage.php cleanly. Applied patch modules/demo/tests/src/Functional/MonitoringDemoTest.php cleanly. Applied patch modules/monitoring_mail/config/schema/monitoring_mail.schema.yml cleanly. Applied patch modules/monitoring_mail/monitoring_mail.module cleanly. Applied patch modules/monitoring_mail/tests/src/Kernel/MonitoringMailKernelTest.php cleanly. Applied patch modules/multigraph/monitoring_multigraph.module cleanly. Applied patch modules/multigraph/src/Entity/Multigraph.php cleanly. Applied patch modules/multigraph/src/Form/MultigraphDeleteForm.php cleanly. Applied patch modules/multigraph/src/Form/MultigraphForm.php cleanly. Applied patch modules/multigraph/src/MultigraphInterface.php cleanly. Applied patch modules/multigraph/src/MultigraphListBuilder.php cleanly. Applied patch modules/multigraph/src/Plugin/rest/resource/MonitoringMultigraphResource.php cleanly. Applied patch modules/multigraph/tests/src/Functional/MultigraphServicesTest.php cleanly. Applied patch modules/multigraph/tests/src/Functional/MultigraphWebTest.php cleanly. Applied patch modules/multigraph/tests/src/Unit/Entity/MultigraphUnitTest.php cleanly. Applied patch modules/test/monitoring_test.install cleanly. Applied patch modules/test/src/Plugin/QueueWorker/TestWorker.php cleanly. Applied patch modules/test/src/Plugin/monitoring/SensorPlugin/TestSensorPlugin.php cleanly. Applied patch monitoring.api.php cleanly. Applied patch monitoring.css cleanly. Applied patch monitoring.drush.inc cleanly. Applied patch monitoring.install cleanly. Applied patch monitoring.module cleanly. Applied patch monitoring.monitoring_sensors.inc cleanly. Applied patch review.txt cleanly. Applied patch src/Annotation/SensorPlugin.php cleanly. Applied patch src/Commands/MonitoringCommands.php cleanly. Applied patch src/Controller/CategoryAutocompleteController.php cleanly. Applied patch src/Controller/ConfigAutocompleteController.php cleanly. Applied patch src/Controller/ForceRunController.php cleanly. Applied patch src/Controller/RebuildSensorList.php cleanly. Applied patch src/Controller/RequirementsIgnore.php cleanly. Applied patch src/Controller/SensorList.php cleanly. Applied patch src/Controller/TemporaryFilesController.php cleanly. Applied patch src/Element/VerboseTableResult.php cleanly. Applied patch src/Entity/SensorConfig.php cleanly. Applied patch src/Entity/SensorResultDataInterface.php cleanly. Applied patch src/Entity/SensorResultEntity.php cleanly. Applied patch src/Entity/ViewsData/SensorResultViewsData.php cleanly. Applied patch src/Form/MonitoringSettingsForm.php cleanly. Applied patch src/Form/SensorDeleteForm.php cleanly. Applied patch src/Form/SensorDetailForm.php cleanly. Applied patch src/Form/SensorForm.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/CommerceTurnoverSensorPlugin.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/ConfigValueSensorPlugin.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/ContentEntityAggregatorSensorPlugin.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/CoreRequirementsSensorPlugin.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/CronLastRunAgeSensorPlugin.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/DatabaseAggregatorSensorPlugin.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/DatabaseDiskUsagePlugin.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/Dblog404SensorPlugin.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/DisappearedSensorsSensorPlugin.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/DiskUsageSensorPlugin.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/ElysiaCronSensorPlugin.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/EnabledModulesSensorPlugin.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/GitDirtyTreeSensorPlugin.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/ImageMissingStyleSensorPlugin.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/NonExistingUserFailedLoginsSensorPlugin.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/PaymentTurnoverSensorPlugin.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/PhpNoticesSensorPlugin.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/QueueSizeSensorPlugin.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/RequirementsRecapSensorPlugin.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/ResponseTimeSensorPlugin.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/SearchApiUnindexedSensorPlugin.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/SolrDiskUsageSensorPlugin.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/StateValueSensorPlugin.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/SystemLoadSensorPlugin.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/SystemMemorySensorPlugin.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/TemporaryFilesUsagesSensorPlugin.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/TwigDebugSensorPlugin.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/UltimateCronErrorsSensorPlugin.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/UpdateStatusSensorPlugin.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/UserFailedLoginsSensorPlugin.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/UserIntegritySensorPlugin.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/ViewDisplayAggregatorSensorPlugin.php cleanly. Applied patch src/Plugin/monitoring/SensorPlugin/WatchdogAggregatorSensorPlugin.php cleanly. Applied patch src/Plugin/rest/resource/MonitoringSensorConfigResource.php cleanly. Applied patch src/Plugin/rest/resource/MonitoringSensorResultResource.php cleanly. Applied patch src/Plugin/views/field/SensorMessage.php cleanly. Applied patch src/Plugin/views/field/SensorName.php cleanly. Applied patch src/Result/SensorResult.php cleanly. Applied patch src/Result/SensorResultInterface.php cleanly. Applied patch src/Sensor/DisabledSensorException.php cleanly. Applied patch src/Sensor/NonExistingSensorException.php cleanly. Applied patch src/Sensor/SensorCompilationException.php cleanly. Applied patch src/Sensor/SensorManager.php cleanly. Applied patch src/Sensor/Thresholds.php cleanly. Applied patch src/SensorConfigAccessControlHandler.php cleanly. Applied patch src/SensorConfigInterface.php cleanly. Applied patch src/SensorListBuilder.php cleanly. Applied patch src/SensorPlugin/DatabaseAggregatorSensorPluginBase.php cleanly. Applied patch src/SensorPlugin/ExtendedInfoSensorPluginInterface.php cleanly. Applied patch src/SensorPlugin/SensorPluginBase.php cleanly. Applied patch src/SensorPlugin/SensorPluginInterface.php cleanly. Applied patch src/SensorPlugin/ValueComparisonSensorPluginBase.php cleanly. Applied patch src/SensorRunner.php cleanly. Applied patch tests/src/Functional/MonitoringCaptchaTest.php cleanly. Applied patch tests/src/Functional/MonitoringCommerceTest.php cleanly. Applied patch tests/src/Functional/MonitoringCoreWebTest.php cleanly. Applied patch tests/src/Functional/MonitoringRebuildTest.php cleanly. Applied patch tests/src/Functional/MonitoringServicesTest.php cleanly. Applied patch tests/src/Functional/MonitoringTestBase.php cleanly. Applied patch tests/src/Functional/MonitoringTestTrait.php cleanly. Applied patch tests/src/Functional/MonitoringUITest.php cleanly. Applied patch tests/src/Functional/MonitoringViewDisplayTest.php cleanly. Applied patch tests/src/FunctionalJavascript/MonitoringUiJavascriptTest.php cleanly. Applied patch tests/src/Kernel/MonitoringApiTest.php cleanly. Applied patch tests/src/Kernel/MonitoringCoreKernelTest.php cleanly. Applied patch tests/src/Kernel/MonitoringCronErrorPluginTest.php cleanly. Applied patch tests/src/Kernel/MonitoringDiskUsageSensorTest.php cleanly. Applied patch tests/src/Kernel/MonitoringPastTest.php cleanly. Applied patch tests/src/Kernel/MonitoringRedirect404SensorTest.php cleanly. Applied patch tests/src/Kernel/MonitoringResponseTimeSensorTest.php cleanly. Applied patch tests/src/Kernel/MonitoringSearchAPITest.php cleanly. Applied patch tests/src/Kernel/MonitoringSystemLoadSensorTest.php cleanly. Applied patch tests/src/Kernel/MonitoringSystemMemoryPluginTest.php cleanly. Applied patch tests/src/Kernel/MonitoringUnitTestBase.php cleanly.but there is still some error showing by phpcs
sourav@sourav-Mi-Notebook-Pro:~/projects/my_site$ vendor/bin/phpcs web/modules/contrib/monitoring/ --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml --standard=DrupalPractice,Drupal FILE: ...ome/sourav/projects/my_site/web/modules/contrib/monitoring/tests/src/FunctionalJavascript/MonitoringUiJavascriptTest.php ------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------ 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is | | Drupal\FunctionalJavascriptTests\DrupalSelenium2Driver. ------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------ FILE: ...av/projects/my_site/web/modules/contrib/monitoring/modules/monitoring_mail/tests/src/Kernel/MonitoringMailKernelTest.php ------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------ 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is | | Drupal\Tests\monitoring\Kernel\MonitoringUnitTestBase. ------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------ FILE: ...e/sourav/projects/my_site/web/modules/contrib/monitoring/modules/multigraph/tests/src/Unit/Entity/MultigraphUnitTest.php ------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------ 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Tests\UnitTestCase. ------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------ FILE: /home/sourav/projects/my_site/web/modules/contrib/monitoring/modules/demo/monitoring_demo.install ------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------ 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is | | Drupal\Component\Render\FormattableMarkup. ------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------ FILE: /home/sourav/projects/my_site/web/modules/contrib/monitoring/monitoring.module ------------------------------------------------------------------------------------------------------------------------------ FOUND 5 ERRORS AND 3 WARNINGS AFFECTING 5 LINES ------------------------------------------------------------------------------------------------------------------------------ 287 | WARNING | [ ] The @see url '\Drupal\monitoring\Entity\SensorResultEntity|null' does not match the standard: | | http(s)://www.drupal.org/node/n or http(s)://www.drupal.org/project/aaa/issues/n 287 | ERROR | [ ] Content missing for @see tag in function comment 313 | ERROR | [x] Inline comments must start with a capital letter 314 | ERROR | [ ] Comment indentation error, expected only 1 spaces 315 | WARNING | [ ] Line exceeds 80 characters; contains 119 characters 315 | ERROR | [ ] Comment indentation error, expected only 3 spaces 317 | WARNING | [ ] There must be no blank line following an inline comment 317 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing | | parentheses ------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------ FILE: /home/sourav/projects/my_site/web/modules/contrib/monitoring/src/Result/SensorResult.php ----------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------- 530 | ERROR | [x] Parameter $previous_result has null default value, but is not marked as nullable. ----------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------- FILE: /home/sourav/projects/my_site/web/modules/contrib/monitoring/src/Result/SensorResultInterface.php ------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------- 213 | ERROR | [x] Parameter $previous_result has null default value, but is not marked as nullable. ------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------- FILE: ...urav/projects/my_site/web/modules/contrib/monitoring/src/Plugin/monitoring/SensorPlugin/CommerceTurnoverSensorPlugin.php ------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------ 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is | | Drupal\Core\Datetime\DateFormatterInterface. ------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------ Time: 2.11 secs; Memory: 28MBPlease fix those as well...