Hi @yuvalbh,
I tried to recreate this issue by following your steps, but could not replicate it.
Steps followed to reproduce
- made a fresh drupal 10.3.1 site installation. Attached the screen shot for the system info.
- Updated to drupal version 10.4.0, following from
Drupal update document →
applied this command to update the
composer require drupal/core-recommended:10.4.0 drupal/core-composer-scaffold:10.4.0 drupal/core-project-message:10.4.0 --update-with-all-dependenciesthen
drush updbfollowed bydrush cr. Attaching a screen shot for the system info.
Please provide more info to reproduce the issue.
Thank you @swirt. I look forward to hearing their perspectives. Moving this to needs review state.
Thank you @swirt. I look forward to hearing their perspectives. Moving this issue in needs review state.
Hi @swirt,
An assist towards creating the logo for the file. Please review the design and provide the feedback.
Hi @swirt, sorry for the inconvenience, some some reasons I think the images got failed to upload. I have added it again, please review.
Hi @swirt,
I have some ideas regarding the design and I am sharing it with you.
This image shows the state when the alt text validation is not enabled. We can see that 'Length Restriction', 'Prevent using filename in Alt Text', 'Validation Rules' sections are in read-only state.
Now when we are enabling the validation we see that all these sections turn operational.
Now when we start configuring and click on the 'Enable Length Restriction' checkbox, we are given a field where we set the max length.
Also when we click on add rule option we get somewhat this kind of interface.
Please do let me know about your opinion on this.
Hi @charles belov, I have thought to rename the display of 'Local tasks' to 'Contextual Tools', raised the MR as well for it.
The reason for selecting this name is that it clearly conveys that the menu provides tools specifically related to the current context.
Please review and share your opinion on it.
Updated the MR to resolve the merge conflicts. The phpcs issue, now exits in only two file,
- /tests/src/Functional/MonitoringUITest.php
- /monitoring.module
These are due to commented code and function respectively. Needs mentor's attention for it.
Hello @sourav_paul,
I revisited the issue and checked for phpcs issues available. I found these issues were left for fixing,
I have updated the MR. However you can still find some of the issues, left in the .module file, this is left on purpose, as this needs maintainer's attention as why is the code left commented.
Okay @swirt, understood. I'm unassigning myself from this task for now. I'll keep an eye on the UX design progress and will be happy to assist once the blocker is resolved.
Hi @swirt, I have made a push for creating the basic repo and the readme file, please review it once.
I would like to sincerely apologize for the mistake I made earlier. I overlooked the fact that the '1.0.x' branch was not present. As a result, I created the '3495132-initiate-repo' branch, following the usual process for other contributions. After pushing the branch, I attempted to create a merge request, only to find that no other branches were available. I kindly request your assistance in deleting the '3495132-initiate-repo' branch.
arijit acharya → changed the visibility of the branch 3495132-initiate-repo to hidden.
scott_euser → credited arijit acharya → .
Hello,
I have reviewed the issue. I have installed the 8.x-1.10 release of the module. And found the error reported by alex bukach exists. I applied the patch given by alex bukach and found the error getting resolved. Attaching screenshot for convenience.
Before patch
After patch
Looks good to me. Moving it to RTBC.
Hello,
I have checked both the branches, 8.x-1.x and the 2.x, both showed the below error in the console.
After applying the MR !3 the error got resolved. Attaching screenshot for the reference.
The MR looks good to me so moving this to RTBC.
Attaching the screenshot, in this image we find some of the phpcs reported in the .module file.
Issues present in line 313-317 of the file, are due to a function which is kept commented. The function might be kept commented due to som e purpose by the maintainer, so I have not deleted that. For the issue present in line 287 need more info from the maintainer.
Thank you @akshaydalvi212 for your response and for your willingness to help. I completely understand your intention to assist, and I truly appreciate your willingness to contribute.
Hello,
I have tested this feature on my local. It looks good to me. Attaching screenshot for reference. Moving this to RTBC.
Hi @akshaydalvi212,
This issue was previously assigned to me, and I have been actively working on it. According to our community guidelines, if an issue is already assigned, other contributors are expected to allow the assigned developer some time to resolve it before taking any further action.
I would kindly request that we adhere to the established community protocols and ensure that assigned issues are respected.
Hello,
I reviewed the MR20, but I can still find issues reported by phpcs. Attaching a screenshot below for the reference.
Also, adding a commit in a day, to fix it.
Hello,
I have reviewed the MR. I attached a demo script and it is showing properly in the site. Attaching the screenshot for the relevance. It looks good to me so, moving this to RTBC.
I've noticed that the code fix appears to be already implemented in the module's info.yml file. Based on this, it seems likely the issue has been resolved. So moving it to closed(outdated).
Thanks @esha_kundu for pointing the typo. Updated it. Please review.
Hi Vishal Prasad!
Configured the otp length dynamical through config form. Please review.
Hello kenyoOwen,
Updated the file as per your suggestion.
Hi,
The MR !10 raised by sheetal-wish is having issues. It might be due to the wrong branch against which it is raised . It must be raised against the 9.x-1.x branch, but it is raised against the 8.x-2.x branch. I am raising another MR against 9.x-1.x branch which resolves the issue.
Hello, I have tested the MR. It looks good to me. Moving this to RTBC.
Hi!
Reviewed the MR4 present in #17. Found the some of the errors are still present. Moving it to needs work. Attaching screen shot for the reference.
I have removed the hard coded time implemented for otp resend to something configurable through form. Please review and merge.
Arijit Acharya → created an issue.
Hello,
I also tried to reproduce the error as mentioned by @irodriguez but could not. I tried to reproduce it for 4.0.2 release as well as the 4.0.x-dev branch, but found everything working as expected.
@chaitanyadessai It seems you are testing it against D10. However the issue is for D11.
Applied the patch in #3 and the MR in #5, both are applied successfully. But on visiting the config page/admin/config/search/sitemap getting the below error.
Moving this to NW.
Moving this to RTBC
@gnuget I have rechecked, you are right. The issue exists if someone manually enters /user/login. I have applied and verified that the
patch →
resolves the issue. However the MR that you have raised is not passing the pipeline. Kindly look into it and try to pass the pipeline.
I attempted to reproduce the issue by following the steps provided. Contrary to the described problem, when logging out, the system does not force the user to change their password. Instead, it logs the user out of the site without any password change requirement.
However, the system does enforce a password change under the following conditions:
- When the user logs in after being logged out.
- When the user refreshes the site while already logged in.
In these scenarios, the user is prompted to change their password.
I am providing an image of the marked checkbox and a screen recording showing no effect on logout.
Hello @nisha_j I have rechecked the MR, but could not could not match with your review. I found all the ## headings accompanied with 2lines of space. Attaching the screenshot of the MR. If I am overlooking something, please specify the line number.
I see this issue getting resolved in the latest version of the module.
Moving this to RTBC. Requesting the maintainer to close the issue as outdated.
Sorry for the multiple commits. As stylelint was not setup in the local so took the extra commits.
Updated the patch from @ni.pineau@gmail.com with updated border color when hover and active.
The patch applied is fine. But as a user I think the border color is still not eye catching, probably a prominent black color in place of grey would be more soothing to the eyes. I leave it on the maintainer of this module to decide it.
Moving this to Needs work state. Also attaching a MR in some time for the fix.
Thank You.
Arijit Acharya → made their first commit to this issue’s fork.
Resolved the phpcs issue. Please Review and Merge.
Arijit Acharya → created an issue.
Resolved the merge conflict. Updated the README.md file by adding proper spacing and following the php coding standards. Please Review.
Arijit Acharya → made their first commit to this issue’s fork.
Raised an MR for the issue. Please review and merge.
Arijit Acharya → made their first commit to this issue’s fork.
Updated the MR as suggested. Please review.
Fixed the phpcs issues. Please review and merge.
Arijit Acharya → made their first commit to this issue’s fork.
I encountered some of the warnings, listing them below. I also created a MR to fix them.
Sorry there has been a type in creating the branch, the issue id anyhow got missed in the branch name while creating the branch. It was not intensional, I regret for it.
Kindly review and merge.
FILE: ...app/web/modules/custom/tmgmt_openai-3371272/tmgmt_openai.install
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
14 | WARNING | Line exceeds 80 characters; contains 119 characters
----------------------------------------------------------------------
FILE: ...pp/web/modules/custom/tmgmt_openai-3371272/tmgmt_openai.info.yml
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
6 | WARNING | All dependencies must be prefixed with the project
| | name, for example "drupal:"
----------------------------------------------------------------------
FILE: ..._openai-3371272/src/Plugin/tmgmt/Translator/OpenAiTranslator.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
255 | WARNING | Line exceeds 80 characters; contains 85 characters
267 | WARNING | Line exceeds 80 characters; contains 85 characters
----------------------------------------------------------------------
Arijit Acharya → made their first commit to this issue’s fork.
I applied the MR!3 and addressed some of the issues flagged by PHPCS. However, no issues were detected in the 'viewer.info.yml' file. Below, I have listed the errors encountered. Additionally, I have raised an MR to resolve these issues. Please review and merge.
FILE: ...modules/custom/viewer-3356240/src/Controller/CKEditorPreview.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The
| | first wrong one is
| | Drupal\Core\Entity\EntityTypeManagerInterface.
71 | ERROR | [x] Whitespace found at end of line
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...ules/custom/viewer-3356240/src/Plugin/CKEditor5Plugin/Viewer.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...eb/modules/custom/viewer-3356240/src/Form/CKEditorDialogForm.php
----------------------------------------------------------------------
FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically.
| | The first wrong one is
| | Drupal\Core\Ajax\AjaxResponse.
10 | WARNING | [x] Unused use statement
11 | WARNING | [x] Unused use statement
19 | ERROR | [x] Whitespace found at end of line
----------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: /app/web/modules/custom/viewer-3356240/src/ViewerModule.php
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
60 | ERROR | [x] The first parameter of a multi-line function
| | declaration must be on the line after the opening
| | bracket
64 | ERROR | [x] Multi-line function declarations must have a
| | trailing comma after the last parameter
64 | ERROR | [x] The closing parenthesis of a multi-line function
| | declaration must be on a new line
----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
Arijit Acharya → made their first commit to this issue’s fork.
Hello @nikolay-shapovalov I have resolved the comments that you have mentioned in the MR. Please review.
Arijit Acharya → made their first commit to this issue’s fork.
Updated the README.md file, please review.
Arijit Acharya → made their first commit to this issue’s fork.
Arijit Acharya → made their first commit to this issue’s fork.
Updated the service file, made a generalised query method for running all the queries present in the controller. Updated the Readme.md file. Fixed the phpcs issues.
Please review and merge.
Updated the code. Please review.
Arijit Acharya → created an issue.
Solved the issue by setting default value of the opacity to 1. As when we choose the record opacity option in the field settings, it expects a value from the opacity field. Now initially this value was set to NULL, so it was creating the issue.
Please review the MR and Merge it.
Arijit Acharya → made their first commit to this issue’s fork.