Contrib.social

Fix phpcs issues.

Open on Drupal.org →
Created on 19 June 2024, 10 months ago
Updated 16 July 2024, 10 months ago

Problem/Motivation

Getting the below phpcs errors.

FILE: ...ules/custom/login_time_restriction/login_time_restriction.module
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The
   |       |     first wrong one is
   |       |     Drupal\Core\Form\FormStateInterface.
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...m/login_time_restriction/src/Controller/AccessTimeController.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
  8 | ERROR | [x] Use statements should be sorted alphabetically. The
    |       |     first wrong one is Drupal\Core\Cache\Cache.
 42 | ERROR | [x] Multi-line function declarations must have a
    |       |     trailing comma after the last parameter
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...les/custom/login_time_restriction/src/Facade/TimeRangeFacade.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The
   |       |     first wrong one is
   |       |     Drupal\Core\Entity\EntityTypeManagerInterface.
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ..._time_restriction/src/Form/LoginTimeRestrictionAdminSettings.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The
   |       |     first wrong one is
   |       |     Drupal\Core\Config\ConfigFactoryInterface.
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ..._restriction/src/EventSubscriber/ValidRequestEventSubscriber.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The
   |       |     first wrong one is
   |       |     Drupal\Core\Entity\EntityTypeManagerInterface.
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...les/custom/login_time_restriction/login_time_restriction.install
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 15 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
    |       |     "FALSE" but found "false"
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Proposed resolution

Running the phpcbf command will result in the fix of the issues.

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

arijit acharya

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @arijit acharya
  • Merge request !43455663-fix-phpcs-issues: Fixed the phpcs issues. → (Merged) created by arijit acharya
  • Comment 10 months ago →
    arijit acharya

    Resolved the phpcs issue. Please Review and Merge.

  • Pipeline finished with Success
    10 months ago
    Total: 314s
    #202792
  • Issue was unassigned.
  • Status changed to Needs review 10 months ago
  • Comment 10 months ago →
    arijit acharya
  • Status changed to RTBC 10 months ago
  • Comment 10 months ago →
    🇮🇳India dev16.addweb

    I've tested the MR !4 and it applied successfully , no phpcs issues found after applying MR.

     % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  5267    0  5267    0     0   9289      0 --:--:-- --:--:-- --:--:--  9272
Checking patch login_time_restriction.install...
Checking patch login_time_restriction.module...
Checking patch src/Controller/AccessTimeController.php...
Checking patch src/EventSubscriber/ValidRequestEventSubscriber.php...
Checking patch src/Facade/TimeRangeFacade.php...
Checking patch src/Form/LoginTimeRestrictionAdminSettings.php...
Applied patch login_time_restriction.install cleanly.
Applied patch login_time_restriction.module cleanly.
Applied patch src/Controller/AccessTimeController.php cleanly.
Applied patch src/EventSubscriber/ValidRequestEventSubscriber.php cleanly.
Applied patch src/Facade/TimeRangeFacade.php cleanly.
Applied patch src/Form/LoginTimeRestrictionAdminSettings.php cleanly.
  • Status changed to Fixed 10 months ago
  • Comment 10 months ago →
    🇮🇳India kunal_singh

    Thanks you so much for the contribution.

  • Comment 10 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024