Fix the issues reported by phpcs

Provided patch get applied cleanly but there are so many remaining issue found by PHPCS command

Used command with argumanets
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/syncommerce

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/syncommerce/assets/js/index.js
-------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------------
9 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
47 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
58 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
-------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/syncommerce/assets/js/product_old.js
-------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------------------
12 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
19 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
43 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
138 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
-------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/syncommerce/assets/js/index_old.js
-----------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
42 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
-----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/syncommerce/assets/js/product.js
---------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Additional whitespace found at start of file
26 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
33 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
56 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
130 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
---------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/syncommerce/assets/gulpfile.js
-------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
13 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
-------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/syncommerce/src/Form/ProductsEditForm.php
------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------
185 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
205 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/syncommerce/src/Controller/SyncommerceController.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 8 WARNINGS AFFECTING 9 LINES
---------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Serialization\Json.
48 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
62 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
137 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
139 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
153 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
183 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
207 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
227 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------

Time: 431ms; Memory: 18MB

Hi , I have fixed the issues and added a patch for this , please review

Hi,
I have applied the patch #4.
The patch is successfully applied without any errors.

Please don't run phpcs check on .js, .css files.

To check linting on .js please use eslint → .
To check .css please use stylelint → .

Please exclude changes made to these files.
You can create separate issue with these changes.

MR created for the changes. Please review.

Thanks for suggested changes.
Please check my comments, I left in the MR.

Please update IS, update command (check comment #6), update phpcs report on latest 8.x-1.x branch.

Hi,

As per comment #6 I have updated issue summary please check

Arijit Acharya → made their first commit to this issue’s fork.

Hello @nikolay-shapovalov I have resolved the comments that you have mentioned in the MR. Please review.

Hi, I can confirm that provided MR!1 resolves the phpcs issues successfully. Getting no phpcs errors after applying this MR. RTBC+1