- Issue created by @Gurkawal
- ๐ฎ๐ณIndia mohd sahzad
Mohd Sahzad โ made their first commit to this issueโs fork.
- Status changed to Needs review
8 months ago 9:54am 15 March 2024 - Status changed to Needs work
8 months ago 1:22pm 4 April 2024 - ๐ต๐ญPhilippines clarkssquared
Hi
Moving this to needs work to fix the merge conflict in the MR
Arijit Acharya โ made their first commit to this issueโs fork.
Resolved the merge conflict. Updated the README.md file by adding proper spacing and following the php coding standards. Please Review.
- Status changed to Needs review
5 months ago 9:57am 19 June 2024 - Status changed to Needs work
5 months ago 5:19am 21 June 2024 Hi, @Arijit Acharya. I reviewed the README.md file. In the file, there are no two lines prior to the ## headings. Please refer to the standard template and update the file according to the recommended template standards.
So changing the status to Needs Work.
Thankyou.Hello @nisha_j I have rechecked the MR, but could not could not match with your review. I found all the ## headings accompanied with 2lines of space. Attaching the screenshot of the MR. If I am overlooking something, please specify the line number.
- Status changed to Needs review
5 months ago 1:58pm 24 June 2024 - Status changed to Needs work
4 months ago 1:22am 11 July 2024 - ๐ต๐ญPhilippines kenyoOwen
Hi Arijit Acharya
I reviewed your changes in MR!2 and for the configuration section you can remove
Enable the module at Administration > Extend.
since that part is in the installation section. As per README.md template configuration should beOrdered lists use "1", for easier updates and to avoid errors
, you can also remove this oneTo use this shipping method just try to follow next steps:
Thanks.
- Status changed to Needs review
4 months ago 5:41am 12 July 2024 - Status changed to Needs work
3 months ago 8:26am 14 August 2024 Hello @Arijit Acharya,
I have reviewed the MR!2 and as per my finding the name of the module Physical Fields is not updated here, it is provided as just Physical.
Apart from that the changes looks good and all the above stated issues have been addressed.
ThanksThanks @esha_kundu for pointing the typo. Updated it. Please review.
- Status changed to Needs review
3 months ago 8:56am 14 August 2024 - Status changed to RTBC
3 months ago 9:09am 14 August 2024 I re-reviewed the MR!2 and the typo I mentioned in #15 ๐ README.txt file replace with README.md file Needs review has been fixed. Hence, moving to RTBC.
Thanks