- Issue created by @naveenvalecha
- Status changed to Needs review
5 months ago 10:03am 21 June 2024 - 🇮🇳India sarwan_verma
Hi @naveenvalecha,
I have fixed this "Drupal 11 compatibility fixes for sitemap" and also attached patch ,
please review and verify . - Status changed to Needs work
5 months ago 10:54am 21 June 2024 - 🇮🇳India naveenvalecha New Delhi
@sarwan_verma
Thank you for your contribution. Please create a Merge request https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... → - Merge request !25Issue #3454907: Drupal 11 compatibility fixes for sitemap → (Merged) created by Unnamed author
- Status changed to Needs review
5 months ago 12:55pm 21 June 2024 - 🇮🇳India sarwan_verma
I have created MR. please review it once.
- Status changed to Needs work
5 months ago 6:56pm 27 June 2024 Applied the patch in #3 and the MR in #5, both are applied successfully. But on visiting the config page
/admin/config/search/sitemap
getting the below error.
Moving this to NW.- Assigned to arijit acharya
- Status changed to Needs review
5 months ago 6:52am 28 June 2024 - 🇮🇳India chaitanyadessai Goa
MR and patch applied successfully no errors found attaching ss.
@chaitanyadessai It seems you are testing it against D10. However the issue is for D11.
- Issue was unassigned.
- Status changed to RTBC
4 months ago 4:12pm 31 July 2024 - 🇮🇳India Tirupati_Singh
I've applied the MR as a patch and the patch applied with no errors. After applying the patch the module is now compatible with Drupal 11 and it's working fine. Getting no error on visiting the module config page
/admin/config/search/sitemap
. Attaching the screenshots of the module config and sitemap page for reference. - First commit to issue fork.
- 🇨🇦Canada mparker17 UTC-4
The code in the merge request had several PHPCS and PHPStan errors; and none of the changes accounted for the Book module moving into contrib → in Drupal 11, so I had to make extensive changes to the merge request to account for that (via a new sitemap_book sub-module).
I also need to file a follow-up issue, because I couldn't figure out how to move the book-plugin-specific config into the new sitemap_book sub-module, so I'll do that before merging this.
-
mparker17 →
committed 66910c59 on 8.x-2.x authored by
sarwan_verma →
Issue #3454907: Drupal 11 compatibility fixes for sitemap
-
mparker17 →
committed 66910c59 on 8.x-2.x authored by
sarwan_verma →
- Status changed to Fixed
4 months ago 11:02pm 2 August 2024 - 🇨🇦Canada mparker17 UTC-4
Going to mark this as fixed; I'll create a new release after resolving some other issues.
- 🇨🇦Canada mparker17 UTC-4
Note that this change was released in sitemap-8.x-2.0-beta7 → , but resulted in a follow-up issue, 🐛 Error when running sitemap_update_8202 Fixed , which was released in sitemap-8.x-2.0-beta8 → .
Automatically closed - issue fixed for 2 weeks with no activity.