🇮🇳India @sarwan

Hi @Masood Ahmad,

Patch #2 works for me, and I have created MR!2 based on the patch.
Kindly review and verify.
Thanks!.

sarwan_verma → made their first commit to this issue’s fork.

sarwan_verma → made their first commit to this issue’s fork.

I have successfully applied the patch and tested its functionality. I have also created MR! 23.
Kindly review and verify.
thanks.

sarwan_verma → made their first commit to this issue’s fork.

Hi @imclean,

I have resolved the pending issue for Drupal 11 and created Merge Request MR! 3.
Please review and verify.
Thank!

sarwan_verma → made their first commit to this issue’s fork.

Hi@ yasheshb,
I have resolved the issue of not being able to install 6.0.0-alpha8 on Drupal 10.3.1. I have also attached the patch.
Kindly review and verify.

Thanks!.

sarwan_verma → made their first commit to this issue’s fork.

Hi @Grimreaper,

I have resolved Drupal 11 compatibility issue and created MR!23.

Kindly review and verify.

sarwan_verma → made their first commit to this issue’s fork.

Hi @aman_lnwebworks,

I have reviewed the module, but I am not getting any PHPCS errors. For more clarity, I have attached a screenshot. Please change the status accordingly.

Thanks,

Hi @donquixote,

I have resolved this issue with passing null to strpos and created MR!23.

Kindly review and verify.

sarwan_verma → made their first commit to this issue’s fork.

Hi @Berdir,

I have resolved the Drupal 11 issue and created MR!60. Please review and verify.

Thanks!

sarwan_verma → made their first commit to this issue’s fork.

sarwan_verma → made their first commit to this issue’s fork.

Hi @Chandansha,
I have resolved the errors and warnings, pushed the changes, and attached a screenshot.
Thanks!!

I have reviewed MR !18 and encountered some issues, which I have now resolved and pushed the
changes. Thanks!

sarwan_verma → made their first commit to this issue’s fork.

I have reviewed MR !20, but I encountered some issues. I have fixed the remaining issues.

Kindly review and verify
Thanks

sarwan_verma → made their first commit to this issue’s fork.

Reviewed MR !3 and found one error below.

Kindly fix the remaining issue.

Thanks

vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig../ ~/project/drupal10/web/modules/contrib/redirects_fixer

FILE: /home/developer/project/drupal10/web/modules/contrib/redirects_fixer/src/BatchManager.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
-----------------------------------------------------------------------------------------------------------------------
126 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
198 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
200 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
206 | WARNING | Only string literals should be passed to t() where possible
334 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
497 | WARNING | Only string literals should be passed to t() where possible
-----------------------------------------------------------------------------------------------------------------------

FILE: /home/developer/project/drupal10/web/modules/contrib/redirects_fixer/src/LinksManager.php
-----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------
86 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------

FILE: /home/developer/project/drupal10/web/modules/contrib/redirects_fixer/src/Controller/FixLinksController.php
----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------
70 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
100 | WARNING | Avoid backslash escaping in translatable strings when possible, use "" quotes instead
----------------------------------------------------------------------------------------------------------------

Time: 293ms; Memory: 12MB

Hi @amanmansuri72,
I have resolved all the PHPCS issues and created MR!4. I have also attached screenshots for additional clarity.
Please review and verify.
thanks

Hi@amanmansuri72,

I have fixed the remaining PHPCS issues and created MR!1. I've also attached a screenshot.
Kindly review and verify.
Thanks.

sarwan_verma → made their first commit to this issue’s fork.

Hi @Prem Suthar,

I have resolved all PHPCS issues and created MR!4. and also attached a screenshot
please review and verification.
Thank you!

Yes, I can confirm that after removing the restriction, everything is working as expected.
Also I'm attaching the patch for the same. Thanks.

Hi @KlemenDEV,

I have resolved the version issue and also attached the patch. Please review and verify it.

Drupal version: 10.3.1

sarwan_verma → made their first commit to this issue’s fork.

hey @gMaximus,

when you move an issue to the "Fixed" state, please remember to give credit to the contributors.

Thankyou !

Hi @Hetal.Solanki,

I have updated the README.txt file to README.md and created MR!3. Please review and verify.

please review and verify
thanks

Hi @Hetal.Solanki,

I have tested the module, but I am not getting any PHPCS issues. For reference, I have attached a screenshot.

Thanks!.

Hi @mortona2k,

I have updated the dependency module issues and created MR!1.
Please review and verify. .

Thanks

sarwan_verma → made their first commit to this issue’s fork.

Hi @lostcarpark,

I have resolved the RendererInterface::renderInIsolation() issue and created MR!21.

Kindly review and verify.

Thanks!

Hi @kopeboy , yukare
I have successfully applied patch #5, and it work for me. I have also created MR #12. For additional clarity, please refer to the attached screenshot. Please review and verify.
thanks

sarwan_verma → made their first commit to this issue’s fork.

Hi @Hetal.Solanki, jigish.addweb

I have thoroughly reviewed MR !8 and can confirm that it resolves all the PHPCS issues.
For additional clarity, please refer to the attached screenshot. Excellent work on this!
Moving it to RTBC.
Thanks!

Hi @2dareis2do,

I have fixed the "argument must be of type array|object Warning" and created MR!12. For additional clarity, please refer to the attached screenshot. Please review and verify.

Thanks.

sarwan_verma → made their first commit to this issue’s fork.

HI @grndlvl,

I have resolved the Drupal 11 issues and created MR!6.
Please review and verify.

sarwan_verma → made their first commit to this issue’s fork.

Hi @Prem Suthar,
I have fixed all PHPCS errors and created MR!2. For additional clarity, please refer to the attached screenshot.
Kindly review and verify.
thanks.

Hi @bhaveshdas, lostcarpark

I have completed a thorough review of MR !9 and can confirm that it addresses all the PHPCS issues effectively. For your reference, please see the attached screenshot.

Moving it to RTBC. Thank you

Hi @wouters_f,

There's already an existing patch to fix this issue at ' https://www.drupal.org/files/issues/2024-06-18/type_declaration.patch → '.
I have tested it with that, and I can confirm that this issue no longer occurs after applying the patch. Thanks!

Hi @nilesh.addweb, Marcus_Johansson

I have thoroughly reviewed MR !3 and can confirm that it resolves all the PHPCS issues.
For additional clarity, please refer to the attached screenshot. Excellent work on this!
Moving it to RTBC. Thanks!

Hi @frogdog_tech,

I have successfully applied patch #2, and it is working fine. I have also created MR #!1.
Please review and verify.

Thanks

sarwan_verma → made their first commit to this issue’s fork.

sarwan_verma → made their first commit to this issue’s fork.

HI @bluegeek9,
I have thoroughly tested MR!15, and it's functioning perfectly on my end.
For additional clarity, Please refer to the attached screenshot.
Thanks.

Hi @tawellman,

I have created MR!3 for the above issue, Please review it once.

sarwan_verma → made their first commit to this issue’s fork.

Hi @2dareis2do,

I have created MR!11 for the above issue, Please review it once.

sarwan_verma → made their first commit to this issue’s fork.

Hi @ankitv18,

I have created MR!43 for the above issue, Please review it once.

sarwan_verma → made their first commit to this issue’s fork.

Hi @CNDexter,

I have fixed this issue "ValueError: array_chunk(): Argument #2 ($length) must be greater than 0 in array_chunk()" and also attached patch ,
please review and verify .

Hi @bhaveshdas,

I have created MR!3 for the above issue, Please review it once.

sarwan_verma → made their first commit to this issue’s fork.

Hi @ tikaszvince,

I have created MR!5 for the above issue, Please review it once.

sarwan_verma → made their first commit to this issue’s fork.

Hi @santhosh@21,

I have created MR!3 for the above patch, Please review it once.

sarwan_verma → made their first commit to this issue’s fork.

Hi @radheymkumar,
I can confirm that the patch is working fine, Created MR #!6 for the same.
Please review and verify .

sarwan_verma → made their first commit to this issue’s fork.

Hi @radheymkumar,
I can confirm that the patch is working fine, Created MR #!3 for the same.
Please review and verify .

sarwan_verma → made their first commit to this issue’s fork.

Hi @SocialNicheGuru,

I have fixed this "Upgrade inline_entity_reference ^1.0 || ^3.0" and also attached patch.
please review and verify .

sarwan_verma → made their first commit to this issue’s fork.

Hi @ SocialNicheGuru,

I have resolved this issue "Use IEF ^1.0 || ^3.0" and also attached patch ,
kindly review and verify .

sarwan_verma → made their first commit to this issue’s fork.

Hi @vishal-lnwebworks,

I have test the module but already avalabe Readme.md file.
thanks .

sarwan_verma → made their first commit to this issue’s fork.

Hi @nicxvan,

I have created MR!3 for the above issue, Please review it once.

sarwan_verma → made their first commit to this issue’s fork.

Hi @bob.hinrichs,

I have created MR!3 for the above issue, Please review it once.

sarwan_verma → made their first commit to this issue’s fork.

Hi@ vishal-lnwebworks,

I have created MR!7 for the above issue, Please review it once.

sarwan_verma → made their first commit to this issue’s fork.

Hi @maxilein,

I have fixed this issue "Error with latest version" and also attached patch ,
kindly review and verify.

Hi @duncancm,

I have created MR!3 for the above issue, Please review it once.

sarwan_verma → made their first commit to this issue’s fork.