XsendfileImageStyleDownloadController::deliver() has wrong signature

Created on 16 October 2024, about 1 month ago

Problem/Motivation

XsendfileImageStyleDownloadController extends Drupal\image\Controller\ImageStyleDownloadController and the deliver() function of that class changed its signature with Drupal 10.3. Therefore XsendfileImageStyleDownloadController is no longer compatible with Drupal\image\Controller\ImageStyleDownloadController.

Steps to reproduce

Try to install xsendfile with Drupal >=10.3 or >=11.0. The installation will fail and an error message will be logged about the imcompatible implementation of deliver().

Proposed resolution

Update XsendfileImageStyleDownloadController::deliver() to match Drupal\image\Controller\ImageStyleDownloadController.

🐛 Bug report

Status

Active

Version

1.0

Component

Code

Created by

🇩🇪Germany lukas_w

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @lukas_w
Comment about 1 month ago →
🇩🇪Germany lukas_w
Comment about 1 month ago →
🇮🇳India sarwan_verma
Hi,

I have resolved the "XsendfileImageStyleDownloadController::deliver() has wrong signature" issue, created a patch, and attached it.

Please review and verify.

Thanks!
Comment about 1 month ago →
🇩🇪Germany lukas_w
Thanks for the patch. While it should fix the issue at hand, I think it's sensible to also bring in the changes from ImageStyleDownloadController::deliver() that caused the change of the signature, like I did in the issue fork. See https://git.drupalcode.org/issue/xsendfile-3481160/-/commit/07c97a9792a7...

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024