'Settings' option not accessible

Hi,

I have resolved the "construct" issue for Drupal 10 and created MR!27. I’ve also attached a screenshot.
Please review and verify.

Thank you!

The CR that introduced this is https://www.drupal.org/node/3404140 →

This means that with this change, we need to remove support for Drupal 9, and have it only ^10.2 || ^11.0

Confirming that this fixes the issue.
Just attaching a static patch that safely can be used in composer.json.

It seems I already made this change in #3452009 (https://git.drupalcode.org/project/openid_connect/-/merge_requests/110/d...).

That being said, I think dropping support for Drupal 9 is acceptable being that it has not been supported for over a year now. Would you agree?

I updated the merge request to add a test to confirm the settings form is loading on Drupal 10 and 11.

I think dropping support for Drupal 9 is acceptable being that it has not been supported for over a year now. Would you agree?

As a fellow contrib module maintainer I'd like to give my own perspective. I have dropped support for any unsupported versions from my own modules. That's because GitLab CI only tests on supported versions. Therefore, you can't guarantee compatibility with old versions. You might even break an old website at some point with a future change. So I actually consider it to be potentially harmful to continue declaring compatibility that you can't test against.

Of course, in this case you're being forced to make a change that you know will break compatibility. As far as that goes, you gotta do what you gotta do. Ultimately, it's on people with outdated versions of Core to get busy updating anyway. They can always remain on the old version of the module until they can upgrade.

All that said, I reviewed the MR. The test is short and sweet, so there isn't much to say. If it were up to me, I might change the test function name from testSettingsFormAccessible() to be more generic, e.g. testSettingsForm(), as an indication to others that assertions for testing other things about the form should also go in there. But I'll make this RTBC since that's a minor, subjective change.

Thanks @dcam! I made the method name change you suggested.

Since Drupal 9 is no longer supported and the form changes were already made that broke the settings form in D9, I went ahead and dropped support for that version.

Automatically closed - issue fixed for 2 weeks with no activity.

Alpha6 → causes an issue in keycloak reported by two others

I'm not sure which change in alpha6 is causing this.