- Issue created by @kopeboy
- 🇺🇬Uganda Thomas Kaisuka
I can confirm am getting the same issue when i upgrade ckeditor to ckeditor 5
- First commit to issue fork.
- 🇮🇳India sarwan_verma
Hi,
I have resolved the "CKEditor 5 text formats" issue and created MR!5.
Kindly review it.Thanks!
- 🇮🇹Italy kopeboy Milan
Thanks but the error is still there and preventing me to save the text format form even after applying MR!5
- 🇪🇪Estonia drugan
Hi guys,
Thank you for being interested in the module. I would recommend removing the lines below from the
ReadmehelpMarkdown
class.* settings = { * "quick_tips" = "", * },
It's optional, see: https://api.drupal.org/api/drupal/core%21modules%21filter%21src%21Annota...
Also, please update code in the
ReadmeHelpController
class:$admin_tasks = \Drupal::service('system.module_admin_links_helper')->getModuleAdminLinks($name);
Inject the service as a dependency of the class.
- 🇮🇹Italy kopeboy Milan
I had to do that, plus also remove this from ReadmehelpMarddown.php:
/** * {@inheritdoc} */ public function settingsForm(array $form, FormStateInterface $form_state) { $form['quick_tips'] = [ '#type' => 'item', '#title' => $this->t('Quick tips'), '#description' => $this->t('You can use <a href=":readmehelp" name=":name">markdown syntax</a> like in [...]', [ ':readmehelp' => Url::fromRoute('help.page', ['name' => $this->provider])->toString(), ':github' => 'https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet', ':name' => 'readmehelp-filter', ]), ]; return $form; }
- Merge request !6Issue 3471147: quick_tips is not a supported key + deprecations → (Open) created by kopeboy
- 🇪🇪Estonia drugan
@kopeboy
Please, inject services in the class constructor.
- Status changed to Needs review
16 days ago 7:31pm 5 November 2024 - 🇮🇹Italy kopeboy Milan
Sorry, I didn't even now what "inject services in the class constructor" meant 😅😇, so I asked ChatGPT and tried to provide a new MR accordingly.