Error when trying to save CKEditor text formats: 'quick_tips' is not a supported key

I can confirm am getting the same issue when i upgrade ckeditor to ckeditor 5

Hi,
I have resolved the "CKEditor 5 text formats" issue and created MR!5.
Kindly review it.

Thanks!

Thanks but the error is still there and preventing me to save the text format form even after applying MR!5

Hi guys,

Thank you for being interested in the module. I would recommend removing the lines below from the ReadmehelpMarkdown class.

 *   settings = {
 *     "quick_tips" = "",
 *   },

It's optional, see: https://api.drupal.org/api/drupal/core%21modules%21filter%21src%21Annota...

Also, please update code in the ReadmeHelpController class:

$admin_tasks = \Drupal::service('system.module_admin_links_helper')->getModuleAdminLinks($name);

Inject the service as a dependency of the class.

I had to do that, plus also remove this from ReadmehelpMarddown.php:

  /**
   * {@inheritdoc}
   */
  public function settingsForm(array $form, FormStateInterface $form_state) {
    $form['quick_tips'] = [
      '#type' => 'item',
      '#title' => $this->t('Quick tips'),
      '#description' => $this->t('You can use <a href=":readmehelp" name=":name">markdown syntax</a> like in [...]', [
        ':readmehelp' => Url::fromRoute('help.page', ['name' => $this->provider])->toString(),
        ':github' => 'https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet',
        ':name' => 'readmehelp-filter',
      ]),
    ];

    return $form;
  }

@kopeboy

Please, inject services in the class constructor.

Sorry, I didn't even now what "inject services in the class constructor" meant 😅😇, so I asked ChatGPT and tried to provide a new MR accordingly.

MR !6 does not apply (clean) nor does it solve the issue here in my drupal 10.4.6

Hi @kopeboy @tomsaw,

Thanks for having interest in the module, and sorry for being irresponsive.

Can I assign any of you or both as maintainers for the module?

Please, let me know.

Thank you. These changes work, and need to be merged.
Can an admin please click the merge button?

I applied these changes as a patch,
and can confirm it has worked on my Drupal 10.5.0 installation.

Your time and effort is appreciated.