- Issue created by @tikaszvince
- First commit to issue fork.
- Merge request !14Issue #3482358: Compatibility with book contrib module version 2.0 → (Merged) created by Unnamed author
- 🇮🇳India sarwan_verma
Hi,
I have resolved the issue: "Cannot install 1.1 with the contrib Book v2 module" and created MR!14.
Kindly review it.Thanks
- 🇩🇪Germany simonbaese Berlin
This module is not tagged as compatible with version 2 of the contrib book module. There is no stable release yet. I want to avoid playing catch-up with upstream changes. Please use version 1 of the book module.
- 🇭🇺Hungary tikaszvince
Since the contrib Book module has a stable 2.0 release → and this is the recomended version over 1.0 I think we can say the module has a stable API this module can build on.
- 🇭🇺Hungary tikaszvince
After some review I thinke we can mark 🐛 Some return type is not compatible with Block module Active and 🐛 Does not install (Composer lies) Active as related issues.
- 🇩🇪Germany simonbaese Berlin
Can you please test the MR in your project? I do not have a project meeting the described scenario.
- 🇭🇺Hungary tikaszvince
Hi @simonbaese,
I can adjust my block settings, the block is displayed properly, without any errors.
It looks good for me. The changes from MR work well
I would appreciate it if the maintainers would merge this code and create a new release
I currently have the module installed from the fork-
simonbaese →
committed 6392a747 on 2.0.x authored by
sarwan_verma →
Issue #3482358 by simonbaese, sarwan_verma, tikaszvince, igor mashevskyi...
-
simonbaese →
committed 6392a747 on 2.0.x authored by
sarwan_verma →
- 🇩🇪Germany simonbaese Berlin
Unfortunately, we have to juggle versions after the Drupal core book module deprecation. Moving forward, please use version ^2.0 when using the contrib book module ^2.0.
Automatically closed - issue fixed for 2 weeks with no activity.