- Issue created by @gnuget
- Status changed to Needs review
2 months ago 4:35am 25 June 2024 - ๐ฒ๐ฝMexico gnuget Puebla
Here a patch version of the merge request.
Thanks!
I attempted to reproduce the issue by following the steps provided. Contrary to the described problem, when logging out, the system does not force the user to change their password. Instead, it logs the user out of the site without any password change requirement.
However, the system does enforce a password change under the following conditions:
- When the user logs in after being logged out.
- When the user refreshes the site while already logged in.
In these scenarios, the user is prompted to change their password.
I am providing an image of the marked checkbox and a screen recording showing no effect on logout.
- ๐ฒ๐ฝMexico gnuget Puebla
Hello!
Yes, you are right.
I'm going to update my steps to reproduce it, the thing is the
log out
link already has the CSRF token to allow to log out immediately and that is already working as expectedThe problem is when you type manually
/user/logout
in the browser address bar (without the CSRF token) then it should display the "confirm logout" page but instead it redirects the user to change the password page again. @gnuget I have rechecked, you are right. The issue exists if someone manually enters
/user/login
. I have applied and verified that the patch โ resolves the issue. However the MR that you have raised is not passing the pipeline. Kindly look into it and try to pass the pipeline.- ๐ฒ๐ฝMexico gnuget Puebla
I think it was a false positive, I just re ran the pipeline and I think it is now passing. ๐
Thanks for your help reviewing this.
David.
- Status changed to RTBC
2 months ago 6:44am 26 June 2024 CI tests are currently failing on Drupal >= 10.3 because of the ๐ Can't log out on translated site in tests - causes issues for 10.3 umami test Fixed change, so this patch is necessary for tests to successfully pass.
- ๐ฎ๐ณIndia vishalkhode
vishalkhode โ made their first commit to this issueโs fork.
-
vishalkhode โ
committed dc096686 on 4.0.x authored by
gnuget โ
Issue #3456907 by gnuget, Arijit Acharya: CI test failures - Ignore the...
-
vishalkhode โ
committed dc096686 on 4.0.x authored by
gnuget โ
- Status changed to Fixed
about 1 month ago 9:23am 31 July 2024 - ๐ฎ๐ณIndia vishalkhode
Thanks everyone for the changes. Looks good to me. Hence, moving it ahead.
Automatically closed - issue fixed for 2 weeks with no activity.