🇲🇽Mexico @gnuget

It seems that the only change needed was in the `info.yml` file, so I think this is ready for a small release.

I'm going to create it soon.

I'm planning to create a Drupal 11 release this week, I'm going to close this issue to see if we can get a Automated Drupal 11 compatibility fixes Automatically.

kristen pol → credited gnuget → .

The changes looks pretty stright forward. Merged!

Thanks for your help testing this Rajab.

I think it was a false positive, I just re ran the pipeline and I think it is now passing. 🙌

Thanks for your help reviewing this.

David.

Hello!

Yes, you are right.

I'm going to update my steps to reproduce it, the thing is the log out link already has the CSRF token to allow to log out immediately and that is already working as expected

The problem is when you type manually /user/logout in the browser address bar (without the CSRF token) then it should display the "confirm logout" page but instead it redirects the user to change the password page again.

Here a patch version of the merge request.

Thanks!

gnuget → created an issue.

Ignore #63 it was a problem in my setup.

My error was the following:

LibClamAV Error: cli_loaddbdir(): No supported database files found in /var/lib/clamav
ERROR: Can't open file or directory

I forgot to execute freshclam to update the virus database so it was failing when testing the file.

Once I executed the file everything started working as expected.

No need to do anything else than update Drupal to version 10.3

:-)

I just tested this on Drupal 10.3 (which was released yesterday) and it seems that there is still some work to do:

This is the error in Drupal 10.2:

Uploaded file public://inline-images/my-file.jpg could not be checked, and was deleted.

and then:

Symfony\Component\HttpKernel\Exception\UnprocessableEntityHttpException: Object(Drupal\file\Entity\File): The anti-virus scanner could not check the file, so the file cannot be uploaded. Contact the site administrator if this problem persists. in Drupal\ckeditor5\Controller\CKEditor5ImageController->upload() (line 201 of /var/www/docroot/core/modules/ckeditor5/src/Controller/CKEditor5ImageController.php).

This is the error in Drupal 10.3:

Uploaded file /tmp/phpCxbjJz could not be checked, and was deleted.

And then:

Symfony\Component\HttpKernel\Exception\UnprocessableEntityHttpException: Object(Drupal\file\Entity\File): The anti-virus scanner could not check the file, so the file cannot be uploaded. Contact the site administrator if this problem persists. in Drupal\ckeditor5\Controller\CKEditor5ImageController->upload() (line 176 of /var/www/docroot/core/modules/ckeditor5/src/Controller/CKEditor5ImageController.php).

This works great.

I have just some doubts about the use of the file.validator service, it seems that it was added in Drupal 10.2 which was released just one month ago.

I know that this is something that is not working anyway but the module's info file says:

core_version_requirement: ^9.2 || ^10

I wonder what is best if take advantage of this new service and just bump the core version requirement to ^10.2 or be more flexible and support at least older versions of Drupal 10?

I understand that this branch hasn't a single release yet, so we can do whatever we want 😆 but what is the best thing to do?

Thoughts?

I create a merge request because the DrupalCi does not allow me to see the console output anymore, and it is hard to check why it is failing.

Here the pipeline, it seems that some tests are still failing, those are expected to fail or with your current patch all the tests should pass?
https://git.drupalcode.org/project/filefield_sources/-/jobs/1423706

David.

I tried to replicate this issue without luck.

Can you please provide a list of steps?

The patch looks I just want to test it before to commit it.

Thanks!

Hi @rschwab.

It seems that your patch cannot be applied using the dev version of the module.

```
git apply -v --index 3442719-test-love.patch
Checking patch tests/src/Functional/EmptyValuesTest.php...
error: tests/src/Functional/EmptyValuesTest.php: does not match index
Checking patch tests/src/Functional/FileFieldSourcesTestBase.php...
error: tests/src/Functional/FileFieldSourcesTestBase.php: does not match index
Checking patch tests/src/Functional/MultipleValuesTest.php...
error: tests/src/Functional/MultipleValuesTest.php: does not match index
```

Not sure why.

#21 worked for me too.

Thanks!!!

I checked the patch and looks good to me.

But not so sure to understand these two lines :

            .find("input[type=checkbox]:checked")
            .attr("checked", "checked");

It finds all the checkboxes that are `checked` and adds the attribute `checked`?

Thanks!!!

I just realized that relying on the patch generated by the merge request might not be best idea given that if it is updated the Merge Request the patch will be updated, so here a static version of the patch.

I added the tests and adjusted a bit the method used to order the facet summary (instead of rely in the configuration, the `#weight` is checked).

The same tests that fails on the dev version of the module are failing here so the new tests are passing 🥳

This is ready to be reviewed.

Thanks @Grimreaper and @nmillin for the initial work.

(I created two more branches by accident lol, I'm still learning how to use gitlab instead of rely on patches, apologies for that 😅)

gnuget → made their first commit to this issue’s fork.

Here a new patch that shouldn't break the tests.

Here a patch that provides this option in the field config page:

gnuget → created an issue.

Here an initial patch.

gnuget → created an issue.

+1 to this.

Thank you for all your work on moving this forward @stefanos.petrakis

Hi @sim_1

The credit appeared as expected in my profile all good from my side.

This is great news!

Thanks!!!

I haven't tested this thoroughly, that is why I merged this just in the dev branch and I didn't create a new release, if a new issue arise, please create a new ticket.

I will wait a few days then I will test it carefully then I will create a new release.

Thanks!

The patch looks straightforward, I'm going to commit it and wait a few weeks so it can be tested in the dev branch and then create a new release with it.