Entire comments form can be hidden by Comment Notify's JavaScript

Created on 26 May 2021, about 3 years ago
Updated 5 February 2024, 5 months ago

Problem/Motivation

https://geo.coop/ reported that authenticated users, including site managers, could not see comments, although anonymous visitors could.

This problem was traced to Comment Notify JavaScript:

var radiosHolder = radios.parent().parent();

And the later radiosHolder.hide();

Steps to reproduce

Very likely theme-specific (though that is all available from https://gitlab.com/agaric/sites/geo ).

Proposed resolution

Target a class or ID (more) directly rather than using parent().parent()

Remaining tasks

  • βœ… Create merge request fixing bug
  • βœ… Test
  • ❌ Code review

User interface changes

None, except that GEO.coop will be able to use Comment Notify without the entire comments section disappearing.

API changes

None.

Data model changes

None.

πŸ› Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States mlncn Minneapolis, MN, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.69.0 2024