- Status changed to Needs work
about 2 years ago 2:19pm 17 January 2023 - Status changed to Needs review
about 2 years ago 3:02pm 17 January 2023 - π©πͺGermany Grevil
@sim_1, @kevinquillen what do you think? Should we follow the suggestion by @kevinquillen in #13 and reset this module's version to 1.0.x?
- πΊπΈUnited States kevinquillen
Has anyone seen other instances of using 1.x.x on other projects when they start using semver releases over the previous way?
- πΊπΈUnited States sim_1
I did some digging and couldn't find any examples of people doing that. I think it's fine just to do it. If it doesn't work we'll push a 7.x.x semver branch instead I guess.
So does it sound right that we'll create a 1.x.x-dev branch to test on first. And then merge this patch in with that if it works successfully?
- πΊπΈUnited States sim_1
Lol well I tried and it did not in fact work. I'm going to make a 7.0.x branch instead.
- πΊπΈUnited States sim_1
Ok there should now be a 7.x-dev branch to start testing off of. I know it's a little confusing because we're also supporting D7 branches. If people think we should just bump it to 10x or something we can.
- π©πͺGermany Grevil
@sim_1 very nice! It might be, but I think that is fine! As long as we are getting this D10 ready. :)
- Status changed to RTBC
almost 2 years ago 2:16pm 31 January 2023 - π©πͺGermany Grevil
Alright! Everything looks good to me!
One of the maintainer needs to change the target-branch of the MR to
7.x
, and then we can safely merge this! I would still suggest creating a beta release.
Furthermore, as we can only test the composer.json once there is 7.x a release, I created this follow-up issue here: π [9.x] Test: Automatic requirement of the drupal contrib stable theme through composer.json Fixed . - π©πͺGermany Grevil
I also checked if the code additions from π Turn off base theme css and js in sub themes by default Fixed would have any impact on the D10 compatibility, but they don't!
- πΊπΈUnited States sim_1
Ok, I'm going to try merging. I've changed the target in gitlab. My only fear right now is that last time i did this, the automatic contrib credit thing didn't work. So fingers crossed that goes smoothly!
-
sim_1 β
committed 17e50e14 on 7.x authored by
Anybody β
Issue #3304155 by Grevil, gnuget, Anybody, kevinquillen: Automated...
-
sim_1 β
committed 17e50e14 on 7.x authored by
Anybody β
- Status changed to Fixed
almost 2 years ago 5:54pm 1 February 2023 - πΊπΈUnited States sim_1
Ok, I think that partially worked. @Grevil I tried to give you author credit, but because @anybody was the one to make the commit on the branch I guess it overwrote what I had selected in the checkboxes? If anyone knows a more foolproof way of doing this please let me know. I now think the only way to do it consistently is making and pushing the commit manually/with the command line.
- https://www.drupal.org/docs/develop/git/git-for-drupal-project-maintaine... β
- https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett... βOk, marking this issue fixed. I'll make a beta release and then if someone has time to work on π [9.x] Test: Automatic requirement of the drupal contrib stable theme through composer.json Fixed that would great!
- π©πͺGermany Anybody Porta Westfalica
Thank you very much @sim_1!
Hum, just saw this on the module page:
And now I'm sadly quite convinced this is super confusing for users. :(
So I think we "have to" create 9.x instead of 7.x and should remove the 7.x branch. Otherwise this will cause UX-trouble, I guess. (Even if it doesn't cause technical issues.)@Grevil and me are one company, so I think we're fine with the credits. I'll pass him a beer after work ;);)
Thank you! Nice to see this committed anyway! - πΊπΈUnited States sim_1
I think you're right. Ok, changed to a 9.0.0-beta1 release.
- π²π½Mexico gnuget Puebla
Hi @sim_1
The credit appeared as expected in my profile all good from my side.
This is great news!
Thanks!!!
- π©πͺGermany Grevil
Great Stuff! Thanks everyone! :)
@sim_1 I got the credit as well, so all good on this end!
In my experience, the credit is given once the issue is set to "fixed". So only the credit setting on that very comment is important. Even if the credits will sometimes "reset" after the "fixed comment" is sent, it gets granted accordingly.
- πΊπΈUnited States sim_1
I want to ask on this issue since it has the most visibility: How do we feel about keeping the D8 version as a recommended release? I feel fine (maybe after another week for some more testing) removing it from the recommended release list. I don't feel that we have the overall capacity to maintain both releases and I don't think there's much of a reason to. Do others agree?
- π©πͺGermany Anybody Porta Westfalica
@sim_1: Totally agree!
btw, zurb_foundation development seems pretty dead? But that's a different topic / issue...
- πΊπΈUnited States kevinquillen
It does seem that way (Zurb co), but I think the best course of action is to get it Drupal 10 compatible and usable. That will give users a few years until Drupal 11 to change or make a decision on what to do.
Automatically closed - issue fixed for 2 weeks with no activity.