- Issue created by @rschwab
- Status changed to Needs review
7 months ago 10:57pm 22 April 2024 - last update
7 months ago Patch Failed to Apply - Status changed to Needs work
7 months ago 3:58am 24 April 2024 - π²π½Mexico gnuget Puebla
Hi @rschwab.
It seems that your patch cannot be applied using the dev version of the module.
```
git apply -v --index 3442719-test-love.patch
Checking patch tests/src/Functional/EmptyValuesTest.php...
error: tests/src/Functional/EmptyValuesTest.php: does not match index
Checking patch tests/src/Functional/FileFieldSourcesTestBase.php...
error: tests/src/Functional/FileFieldSourcesTestBase.php: does not match index
Checking patch tests/src/Functional/MultipleValuesTest.php...
error: tests/src/Functional/MultipleValuesTest.php: does not match index
```Not sure why.
- πΊπΈUnited States rschwab
I'm not sure why either. It works for me on a fresh pull:
me@local:~/repos/filefield9/web/modules$ git clone --branch '2.0.x' https://git.drupalcode.org/project/filefield_sources.git Cloning into 'filefield_sources'... remote: Enumerating objects: 1797, done. remote: Counting objects: 100% (64/64), done. remote: Compressing objects: 100% (45/45), done. remote: Total 1797 (delta 16), reused 52 (delta 12), pack-reused 1733 Receiving objects: 100% (1797/1797), 376.69 KiB | 2.77 MiB/s, done. Resolving deltas: 100% (1171/1171), done. me@local:~/repos/filefield9/web/modules$ cd filefield_sources/ me@local:~/repos/filefield9/web/modules/filefield_sources$ git apply -v --index 3442719-test-love.patch Checking patch tests/src/Functional/EmptyValuesTest.php... Checking patch tests/src/Functional/FileFieldSourcesTestBase.php... Checking patch tests/src/Functional/MultipleValuesTest.php... Applied patch tests/src/Functional/EmptyValuesTest.php cleanly. Applied patch tests/src/Functional/FileFieldSourcesTestBase.php cleanly. Applied patch tests/src/Functional/MultipleValuesTest.php cleanly.
- last update
7 months ago Patch Failed to Apply - Merge request !10Issue #3104846 by gnuget, goodDenis, shadowwolf218: Cannot upload a file with... β (Merged) created by gnuget
- π²π½Mexico gnuget Puebla
I create a merge request because the DrupalCi does not allow me to see the console output anymore, and it is hard to check why it is failing.
Here the pipeline, it seems that some tests are still failing, those are expected to fail or with your current patch all the tests should pass?
https://git.drupalcode.org/project/filefield_sources/-/jobs/1423706David.
- πΊπΈUnited States rschwab
Yes these test failures are fixed elsewhere. Here's the links in error order:
- π Fatal error when trying to use File browser RTBC
- π Dont use curl, use the drupal client instead RTBC
- π Dont use curl, use the drupal client instead RTBC
- π Make sure $callback is_callable. ( TypeError: call_user_func_array(): Argument #1 ($callback) must be a valid callback, function "FileSizeLimit" not found or invalid function name ) Needs review
- π Dont use curl, use the drupal client instead RTBC
- π Dont use curl, use the drupal client instead RTBC
-
gnuget β
committed 3905bb00 on 2.0.x
Issue #3442719 by gnuget, rschwab: Test updates for D10 field edit form
-
gnuget β
committed 3905bb00 on 2.0.x
- Status changed to Fixed
7 months ago 10:14pm 25 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.