- last update
6 months ago 15 pass - 🇺🇸United States rschwab
Since php 8 is required for Drupal 10, I'm marking this as a child of 📌 Drupal 10 compatibility Needs work to try and get that ticket completed. This potentially solves the last errors in the D10 test suite.
- last update
6 months ago 15 pass - last update
6 months ago 15 pass - Status changed to Needs review
6 months ago 9:59pm 12 December 2023 - 🇺🇸United States rschwab
Applied #9 to an issue fork, then removed the legacy curl functions that are no longer in use. Currently passing all tests, but needs community review.
- Status changed to Needs work
5 months ago 12:20pm 7 February 2024 - 🇭🇺Hungary szato
There is a fatal php error because of duplicate use statements.
I'm going to rebase the MR8 on 2.0.x and fix these.
- Status changed to Needs review
5 months ago 12:53pm 7 February 2024 - 🇺🇸United States rschwab
In case anyone wants a patch to test this, the current MR is attached here in patch format.
- 🇺🇸United States rschwab
I think we still need WidgetInterface when the function is restored in Remote.php:
/** * Implements hook_filefield_source_settings(). */ public static function settings(WidgetInterface $plugin) {
I'm not sure how it happened, but when I look at this branch Drupal/Field/WidgetInterface is no longer included at all (there were not doubles somehow).
- 🇫🇷France erwangel
I tried MR 8 on a Drupal 10.2.6 which applied with no problem on ffs 2.0.x-dev. Using it on a media module image field (admin/content/media) as well as directly on a node with media field, the remote image is downloaded and listed in admin/content/files but when saving the media or the node I get:
Error: Object of class Drupal\media\Entity\MediaType could not be converted to string in Drupal\Component\Render\HtmlEscapedText->__construct() (line 31 of /path_to_site/web/core/lib/Drupal/Component/Render/HtmlEscapedText.php).