The phpunit jobs in GitLab CI are sometimes failing with this:
1) Drupal\Tests\address\FunctionalJavascript\AddressDefaultWidgetTest::testCountries
TypeError: Behat\Mink\Element\TraversableElement::findButton(): Argument #1 ($locator) must be of type string, Drupal\Core\StringTranslation\TranslatableMarkup given, called in /builds/project/address/web/core/tests/Drupal/Tests/WebAssert.php on line 143
/builds/project/address/vendor/behat/mink/src/Element/TraversableElement.php:97
/builds/project/address/web/core/tests/Drupal/Tests/WebAssert.php:143
/builds/project/address/web/core/tests/Drupal/Tests/UiHelperTrait.php:78
/builds/project/address/tests/src/FunctionalJavascript/AddressDefaultWidgetTest.php:193
/builds/project/address/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
That comes from:
$this->submitForm($edit, $this->t('Save settings'));
Unless we're testing translation, we don't want to use t() in tests.
Remove t() from tests except where we're actually testing translatability.
Fixed
2.0
Code
Pipelines are consistently happy again with this change, so merged, cherry-picked and pushed.
Automatically closed - issue fixed for 2 weeks with no activity.