- Issue created by @sidharth_soman
- 🇮🇳India sidharth_soman Bangalore
Finding the above errors. I'll work on solving them.
- @sidharth_soman opened merge request.
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 9:14am 30 March 2023 - 🇮🇳India sidharth_soman Bangalore
I have fixed all of the above except for the dependency injection. Please review the MR.
Thanks. - Assigned to omkar_yewale
- 🇮🇳India omkar_yewale Mumbai
Hi sidharth_soman, I have made some updates to the code and fixed the issue related to the
\Drupal calls should be avoided in classes, use dependency injection instead
Please review the patch.
- Issue was unassigned.
- Status changed to Needs work
about 1 year ago 7:56am 31 March 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
public function applies(RouteMatchInterface $route_match): bool { return $route_match->getRouteName() === 'system.admin_content'; + }
An empty line is not necessary after a
return
line.+ /** + * Constructs a Help object. + * + * @param \Drupal\contextual_help\HelpManager $help_manager + * The help manager service.
The short description is missing the class namespace.
+ /** + * The RedirectDestinationInterface service. + * + * @var \Drupal\Core\Routing\RedirectDestinationInterface
That is not the service name, but the class name. The service could be probably be described as The redirect service. or The redirect destination service. as another comment describes it. I would rather use the description used on
Drupal::destination()
in both the cases: The redirect destination helper.+ * @param \Drupal\Core\Cache\CacheBackendInterface $cache_backend + * Cache backend instance to use.
That description is missing an article.
/** * Get a link to the help plugin text by plugin definition. * - * @param $definition + * @param array $definition * The plugin definition.
Since that comment is changed, the verb used on the short description should be changed to use the third person singular (which is an on-topic change since this issue is about coding standards).
- First commit to issue fork.
- @kalash-j opened merge request.
- Status changed to Needs review
9 months ago 12:09pm 3 October 2023 - 🇮🇳India kalash-j jaipur
I have created the MR !2 with the required changes please check
- Status changed to Needs work
9 months ago 12:55pm 3 October 2023 - First commit to issue fork.
- Status changed to Needs review
9 months ago 5:41pm 4 October 2023 - 🇮🇳India kalash-j jaipur
i have done required changes that were mention in MR !2 comments
- Status changed to Needs work
19 days ago 5:58am 7 June 2024 - Status changed to Needs review
19 days ago 8:31am 7 June 2024