🇮🇳India @deepak5423

Please review,
Thank You

This issue is also occurring with the Title and ID attributes

deepak5423 → created an issue.

Hi @tirupati_singh,

Now it looks good to me.

Thank you.

Hi @tirupati_singh,

MR looks good to me.

Thank you.

deepak5423 → created an issue.

Please convert the patch into MR.
Thanks.

Hi samit,

Please solve the Merge conflicts.

Thank you.

Thanks for the review @avpaderno,

I have updated the module accordingly.
Please review.

Thanks for the review @avpaderno,

I have updated the module accordingly.
Please review.

deepak5423 → created an issue.

Hi,

I have tested the MR !14.
All the issues of phpstan and phpcs are fixed.
Moving the issue to RTBC.

Thanks.

Hi,

I have updated the MR according to the review comments.
Moving the issue to Needs Review.

Thanks.

Hi,

I have reviewed MR !12, Where the gitlab-ci file is added properly.
Moving the ticket to RTBC.

Thanks.

Hi,

The added gilab-ci files look good to me and all the tests are also getting passed.
Moving the issue to RTBC.

Thanks.

Hi,

The added gilab-ci files look good to me and all the tests are also getting passed.
Moving the issue to RTBC.

Thanks.

Hi,

The added gilab-ci files look good to me and it follow the standard.
Moving the issue to RTBC.

Thanks.

Hi,

I have reviewed MR !10, Where every tests are getting pass and gitlab ci file is added properly.
Moving the ticket to RTBC.

Thanks.

cspell, eslint and phpstan tests are still failing.
Moving the ticket to need work.

The gitlab-ci file is added properly and tests are also running.
Moving the ticket to RTBC.

The file name should be .gitlab-ci.yml after doing this tests will run.
Moving the ticket to need work.

Tests are running properly.
Moving the ticket to RTBC.

Updated the README.md file.
Please review.

Removed gitlab-ci file.
Moving the ticket to RTBC.

deepak5423 → made their first commit to this issue’s fork.

cspell tests are now passing.
Moving the ticket to RTBC.

PHP unit test is now running and all PHP unit tests are passing.
Moving the ticket to RTBC.

All the pipelines are passing.
Moving the ticket to RTBC.

Hi @alexpott,

Phpunit test is still failing.
Moving the ticket to RTBC.

Gitlab ci file added and all tests are passing.
Moving the ticket to RTBC.

eslint test are passing.
Moving the ticket to RTBC.

cspell test is passing.
Moving the ticket to RTBC.

The pipeline is running properly and gitlab ci file is added properly.
Moving the ticket to RTBC.

Hi dtfabio,
Stylelint tests are now passing.
Moving the ticket to RTBC.

Hi idebr,
There is no error left for eslint so moving the ticket to RTBC.

Hi heddn,
eslint is still failing so moving the ticket to need work.

Gitlab-ci template is added properly. Tests are also running.
Moving the ticket to RTBC.

@nilesh.addweb phpstan test is still failing.
Moving the ticket to NW.

Gitlab-ci file is properly add and tests and pipeline is running.
Moving the ticket to RTBC.

Gitllab ci file is properly added.
Moving the ticket to RTBC.

Gitlab ci added properly.
Moving the tickek to RTBC.

@eiriksm The changes looks fine drupalci file is deleted in MR !11.
Moving the ticket to RTBC.

I have checked the issue and now its pass all the gitlab pipeline tests.
Moving the ticket to RTBC.

Hi, @markie thanks for the update and for closing this issue. However, I noticed no credit given to me for resolving this issue. Is there something I am missing! :)

Hi,
I have noticed the changes mentioned earlier and have fixed them.

Regarding comment #14, point 6: Since we wanted to have a popup on the same screen without any redirection to another route for confirm form, we decided to stick with the JavaScript popup. As for the bulk operation link to delete the paragraph types, it seems like a functionality we might consider implementing in a future release of the module if needed.

Moving to Needs Review.
Please review.

Thanks.

please review.

deepak5423 → made their first commit to this issue’s fork.

Hi @stephen.geinosky,
Yes, tests should be in a separate ticket.

Hi @stephen.geinosky,
There was a small mistake in the file name convention, I updated it.
Please review.

deepak5423 → made their first commit to this issue’s fork.

please review

deepak5423 → made their first commit to this issue’s fork.

Hi @riddhi.addweb,
Please try to apply patch on 2.0.x, and if its still not works please let me know

please review

I have pulled the latest changes of 2.0.x branch and Fixed the phpcs error.
Please review.

deepak5423 → made their first commit to this issue’s fork.

please review

phpunit test looks like something unexpected could someone else look into this

please review

please review

Thanks for the reviews.

I have added the changes accordingly.
Please review.

I have made the changes. The project is now ready to be reviewed.

deepak5423 → created an issue.

@webfaqtory I think it is better to add file_delete module as a dependency of the File Replace (D8+)

deepak5423 → changed the visibility of the branch 1.x to hidden.

deepak5423 → changed the visibility of the branch 1.x to hidden.

deepak5423 → made their first commit to this issue’s fork.

deepak5423 → made their first commit to this issue’s fork.

Please review

deepak5423 → made their first commit to this issue’s fork.

No Phpcs error in !MR1.

Please review !MR43.

deepak5423 → changed the visibility of the branch 8.x-1.x to hidden.

@adwivedi008 please review

deepak5423 → made their first commit to this issue’s fork.

deepak5423 → changed the visibility of the branch 1.0.x to hidden.

deepak5423 → changed the visibility of the branch 3428012-1 to hidden.

please review

deepak5423 → made their first commit to this issue’s fork.

Added the Readme.md file

deepak5423 → made their first commit to this issue’s fork.

@DamienMcKenna please review

deepak5423 → made their first commit to this issue’s fork.

@Vishal Prasad !MR55 is not following the README.md standards. Please follow the README.md → standards.

@kalash-j there are still some phpcs issue left.

I have applied !MR7 no phpcs found.
It looks good to me.

After applying !MR5 no phpcs error was found.
Looks good to me.

@kalash-j pipeline is working properly.