deepak5423 → changed the visibility of the branch 1.x to hidden.
deepak5423 → changed the visibility of the branch 1.x to hidden.
deepak5423 → made their first commit to this issue’s fork.
deepak5423 → made their first commit to this issue’s fork.
Please review
deepak5423 → made their first commit to this issue’s fork.
No Phpcs error in !MR1.
Please review !MR43.
deepak5423 → changed the visibility of the branch 8.x-1.x to hidden.
@adwivedi008 please review
deepak5423 → made their first commit to this issue’s fork.
deepak5423 → changed the visibility of the branch 1.0.x to hidden.
deepak5423 → changed the visibility of the branch 3428012-1 to hidden.
please review
deepak5423 → made their first commit to this issue’s fork.
Added the Readme.md file
deepak5423 → made their first commit to this issue’s fork.
@DamienMcKenna please review
deepak5423 → made their first commit to this issue’s fork.
@Vishal Prasad !MR55 is not following the README.md standards. Please follow the README.md → standards.
@kalash-j there are still some phpcs issue left.
I have applied !MR7 no phpcs found.
It looks good to me.
After applying !MR5 no phpcs error was found.
Looks good to me.
@kalash-j pipeline is working properly.
@Indranil Roy, It is mentioned in the ticket that Stylelint needs to be added but it's missing in the pipeline.
Please add Stylelint.
deepak5423 → made their first commit to this issue’s fork.
@kenyoOwen I have updated the MR according to the standards.
Please review
Updated the README.md according to the standards.
@shelane we can close the ticket.
@VladimirAus please review
I will be working on this
@inst please refer to this 🐛 Deprecated function: explode() Fixed issue this might help you.
@ady1503 Can you please elaborate on the reproducing steps because I cannot?
@tarasiadis please write the step to reproduce the error because when I select bootstrap table it shows a different error which is "TypeError: array_filter(): Argument #1 ($array) must be of type array, null given in array_filter() (line 372 of modules/contrib/views_bootstrap/views_bootstrap.theme.inc)."
deepak5423 → made their first commit to this issue’s fork.
Hi @webfaqtory, Do we need the Delete button in replace file form page?
I think it is better to remove the option delete button from replace file form because we have an option to delete files from /admin/content/files.
@kenyoOwen @vishal-Yaduvanshi please review the changes.
deepak5423 → made their first commit to this issue’s fork.
@kenyoOwen @Anybody changes added please review.
Hi, @malcomio thanks for the update and for closing this issue. However, I noticed that there was no credit given to me for resolving this issue. Is there something I am missing! :)
@malcomio please review.
deepak5423 → made their first commit to this issue’s fork.
The error is occurring due to the reason that when the verify email field is enabled, the user_admin_settings form validate() throws an exception that 'password_length' is an invalid key.
Used approach
Create a separate config file for storing the password length field value and retrieve it from the same, instead of updating the user schema.
Create a hook_update() to move the password length field value from the user schema to the config file for existing sites.
@szt please review
@zengenuity please review.
deepak5423 → made their first commit to this issue’s fork.
@generalredneck, I have fixed the phpcs issue please review it.
deepak5423 → made their first commit to this issue’s fork.
I have created the MR for the issue.
I have created the MR for the issue
deepak5423 → changed the visibility of the branch 3448292-missing-license-url-in-libraries to hidden.
deepak5423 → made their first commit to this issue’s fork.
deepak5423 → made their first commit to this issue’s fork.
Hi, @pcambra thanks for the update and for closing this issue. However, I noticed that there was no credit given to me for resolving this issue. Is there something I am missing! :)
@acbramley I have closed the MR-14. Back to NW to address #15
I have reviewed the MR-13 given by @Andrii Momotov.
The changes look fine to me.
I am moving the ticket to RTBC.
@Andrii Momotov sorry for the inconvenience caused by my side.
I have closed my MR.
Hi @Anybody, I have updated the README.md file as per your comments.
deepak5423 → made their first commit to this issue’s fork.
@clarkssquared I have created the MR and followed the Drupal README.md template standards.
@pcambra I have created the README.md file please review it.
@el1_1el I have raised the MR fixing the typo error in the mentioned files. please review and merge
deepak5423 → made their first commit to this issue’s fork.
@rohitsharma401 I have added a README.md file please review
@acbramley I have raised the MR with proper phpcs testing. please review.
deepak5423 → made their first commit to this issue’s fork.