๐Ÿ‡ฎ๐Ÿ‡ณIndia @deepak5423

Account created on 14 September 2023, 9 months ago
#

Merge Requests

More

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

deepak5423 โ†’ changed the visibility of the branch 1.x to hidden.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

deepak5423 โ†’ changed the visibility of the branch 1.x to hidden.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

deepak5423 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

deepak5423 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

Please review

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

deepak5423 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

deepak5423 โ†’ changed the visibility of the branch 8.x-1.x to hidden.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

deepak5423 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

deepak5423 โ†’ changed the visibility of the branch 1.0.x to hidden.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

deepak5423 โ†’ changed the visibility of the branch 3428012-1 to hidden.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

deepak5423 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

Added the Readme.md file

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

deepak5423 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

@DamienMcKenna please review

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

deepak5423 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

@Vishal Prasad !MR55 is not following the README.md standards. Please follow the README.md โ†’ standards.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

@kalash-j there are still some phpcs issue left.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

I have applied !MR7 no phpcs found.
It looks good to me.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

After applying !MR5 no phpcs error was found.
Looks good to me.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

@kalash-j pipeline is working properly.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

@Indranil Roy, It is mentioned in the ticket that Stylelint needs to be added but it's missing in the pipeline.
Please add Stylelint.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

deepak5423 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

@kenyoOwen I have updated the MR according to the standards.
Please review

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

Updated the README.md according to the standards.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

@shelane we can close the ticket.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

@VladimirAus please review

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

I will be working on this

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

@inst please refer to this ๐Ÿ› Deprecated function: explode() Fixed issue this might help you.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

@ady1503 Can you please elaborate on the reproducing steps because I cannot?

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

@tarasiadis please write the step to reproduce the error because when I select bootstrap table it shows a different error which is "TypeError: array_filter(): Argument #1 ($array) must be of type array, null given in array_filter() (line 372 of modules/contrib/views_bootstrap/views_bootstrap.theme.inc)."

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

deepak5423 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

Hi @webfaqtory, Do we need the Delete button in replace file form page?
I think it is better to remove the option delete button from replace file form because we have an option to delete files from /admin/content/files.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

@kenyoOwen @vishal-Yaduvanshi please review the changes.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

deepak5423 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

@kenyoOwen @Anybody changes added please review.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

Hi, @malcomio thanks for the update and for closing this issue. However, I noticed that there was no credit given to me for resolving this issue. Is there something I am missing! :)

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

@malcomio please review.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

deepak5423 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

The error is occurring due to the reason that when the verify email field is enabled, the user_admin_settings form validate() throws an exception that 'password_length' is an invalid key.

Used approach
Create a separate config file for storing the password length field value and retrieve it from the same, instead of updating the user schema.
Create a hook_update() to move the password length field value from the user schema to the config file for existing sites.

@szt please review

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

@generalredneck, I have fixed the phpcs issue please review it.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

deepak5423 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

I have created the MR for the issue.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

I have created the MR for the issue

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

deepak5423 โ†’ changed the visibility of the branch 3448292-missing-license-url-in-libraries to hidden.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

deepak5423 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

deepak5423 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

Hi, @pcambra thanks for the update and for closing this issue. However, I noticed that there was no credit given to me for resolving this issue. Is there something I am missing! :)

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

@acbramley I have closed the MR-14. Back to NW to address #15

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

I have reviewed the MR-13 given by @Andrii Momotov.
The changes look fine to me.
I am moving the ticket to RTBC.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

@Andrii Momotov sorry for the inconvenience caused by my side.
I have closed my MR.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

Hi @Anybody, I have updated the README.md file as per your comments.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

deepak5423 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

@clarkssquared I have created the MR and followed the Drupal README.md template standards.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

@pcambra I have created the README.md file please review it.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

@el1_1el I have raised the MR fixing the typo error in the mentioned files. please review and merge

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

deepak5423 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

@rohitsharma401 I have added a README.md file please review

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

@acbramley I have raised the MR with proper phpcs testing. please review.

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepak5423

deepak5423 โ†’ made their first commit to this issueโ€™s fork.

Production build 0.69.0 2024