- Issue created by @batigolix
- First commit to issue fork.
- Assigned to nexusnovaz
- Issue was unassigned.
- Status changed to Needs work
7 months ago 9:45pm 30 July 2024 - 🇬🇧United Kingdom nexusnovaz
Resolved cspell and most phpcs issues. I'm unsure how to properly resolve the final issues.
Remaining phpcs issue:
FILE: ...tom/migrate_devel-3458112/src/EventSubscriber/MigrationEventSubscriber.php -------------------------------------------------------------------------------- FOUND 10 ERRORS AFFECTING 10 LINES -------------------------------------------------------------------------------- 33 | ERROR | Variable "Source" starts with a capital letter, but only | | $lowerCamelCase or $snake_case is allowed | | (Drupal.NamingConventions.ValidVariableName.LowerStart) 34 | ERROR | Variable "Destination" starts with a capital letter, but only | | $lowerCamelCase or $snake_case is allowed | | (Drupal.NamingConventions.ValidVariableName.LowerStart) 43 | ERROR | Variable "Source" starts with a capital letter, but only | | $lowerCamelCase or $snake_case is allowed | | (Drupal.NamingConventions.ValidVariableName.LowerStart) 47 | ERROR | Variable "Destination" starts with a capital letter, but only | | $lowerCamelCase or $snake_case is allowed | | (Drupal.NamingConventions.ValidVariableName.LowerStart) 68 | ERROR | Variable "Source" starts with a capital letter, but only | | $lowerCamelCase or $snake_case is allowed | | (Drupal.NamingConventions.ValidVariableName.LowerStart) 69 | ERROR | Variable "Destination" starts with a capital letter, but only | | $lowerCamelCase or $snake_case is allowed | | (Drupal.NamingConventions.ValidVariableName.LowerStart) 70 | ERROR | Variable "DestinationIDValues" starts with a capital letter, but | | only $lowerCamelCase or $snake_case is allowed | | (Drupal.NamingConventions.ValidVariableName.LowerStart) 79 | ERROR | Variable "Source" starts with a capital letter, but only | | $lowerCamelCase or $snake_case is allowed | | (Drupal.NamingConventions.ValidVariableName.LowerStart) 83 | ERROR | Variable "Destination" starts with a capital letter, but only | | $lowerCamelCase or $snake_case is allowed | | (Drupal.NamingConventions.ValidVariableName.LowerStart) 87 | ERROR | Variable "DestinationIDValues" starts with a capital letter, but | | only $lowerCamelCase or $snake_case is allowed | | (Drupal.NamingConventions.ValidVariableName.LowerStart) --------------------------------------------------------------------------------
Remaining phpstan issues:
------ --------------------------------------------------------------------- Line migrate_devel.drush.inc ------ --------------------------------------------------------------------- 27 Function drush_get_option not found. 💡 Learn more at https://phpstan.org/user-guide/discovering-symbols 55 Access to constant DEBUG on an unknown class Drush\Log\LogLevel. 💡 Learn more at https://phpstan.org/user-guide/discovering-symbols 112 Access to constant ALERT on an unknown class Drush\Log\LogLevel. 💡 Learn more at https://phpstan.org/user-guide/discovering-symbols ------ ---------------------------------------------------------------------
- Assigned to hetal.solanki
- 🇮🇳India hetal.solanki
@batigolix, @NexusNovaz
I've fixed the last MR!6 pipeline issue.
so moving this issue into review.Thank you!!
- Issue was unassigned.
- Status changed to Needs review
7 months ago 6:12am 31 July 2024 - Status changed to RTBC
7 months ago 11:33am 31 July 2024 - 🇮🇳India deepak5423
I have checked the issue and now its pass all the gitlab pipeline tests.
Moving the ticket to RTBC. -
batigolix →
committed 85fd053c on 8.x-2.x authored by
NexusNovaz →
Issue #3458112 by Hetal.Solanki, NexusNovaz, batigolix, deepak5423: Make...
-
batigolix →
committed 85fd053c on 8.x-2.x authored by
NexusNovaz →
- Status changed to Fixed
7 months ago 3:39pm 31 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.