Make code pass the gitlab pipeline

Created on 30 June 2024, 8 months ago
Updated 14 August 2024, 6 months ago

Problem/Motivation

We recently added the gitlab CI pipeline for code checking.

The code does not pass all the tests.

Steps to reproduce

Check the recent gitlab pipeline run, for the failed tests.

Proposed resolution

Fix all the code styling warning.

📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

🇳🇱Netherlands batigolix Utrecht

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @batigolix
  • First commit to issue fork.
  • 🇬🇧United Kingdom nexusnovaz

    Hey! I'll take a look at this!

  • Assigned to nexusnovaz
  • Merge request !6Resolve #3458112 "Make code pass" → (Merged) created by nexusnovaz
  • Pipeline finished with Success
    7 months ago
    Total: 128s
    #238781
  • Issue was unassigned.
  • Status changed to Needs work 7 months ago
  • 🇬🇧United Kingdom nexusnovaz

    Resolved cspell and most phpcs issues. I'm unsure how to properly resolve the final issues.

    Remaining phpcs issue:

    FILE: ...tom/migrate_devel-3458112/src/EventSubscriber/MigrationEventSubscriber.php
    --------------------------------------------------------------------------------
    FOUND 10 ERRORS AFFECTING 10 LINES
    --------------------------------------------------------------------------------
     33 | ERROR | Variable "Source" starts with a capital letter, but only
        |       | $lowerCamelCase or $snake_case is allowed
        |       | (Drupal.NamingConventions.ValidVariableName.LowerStart)
     34 | ERROR | Variable "Destination" starts with a capital letter, but only
        |       | $lowerCamelCase or $snake_case is allowed
        |       | (Drupal.NamingConventions.ValidVariableName.LowerStart)
     43 | ERROR | Variable "Source" starts with a capital letter, but only
        |       | $lowerCamelCase or $snake_case is allowed
        |       | (Drupal.NamingConventions.ValidVariableName.LowerStart)
     47 | ERROR | Variable "Destination" starts with a capital letter, but only
        |       | $lowerCamelCase or $snake_case is allowed
        |       | (Drupal.NamingConventions.ValidVariableName.LowerStart)
     68 | ERROR | Variable "Source" starts with a capital letter, but only
        |       | $lowerCamelCase or $snake_case is allowed
        |       | (Drupal.NamingConventions.ValidVariableName.LowerStart)
     69 | ERROR | Variable "Destination" starts with a capital letter, but only
        |       | $lowerCamelCase or $snake_case is allowed
        |       | (Drupal.NamingConventions.ValidVariableName.LowerStart)
     70 | ERROR | Variable "DestinationIDValues" starts with a capital letter, but
        |       | only $lowerCamelCase or $snake_case is allowed
        |       | (Drupal.NamingConventions.ValidVariableName.LowerStart)
     79 | ERROR | Variable "Source" starts with a capital letter, but only
        |       | $lowerCamelCase or $snake_case is allowed
        |       | (Drupal.NamingConventions.ValidVariableName.LowerStart)
     83 | ERROR | Variable "Destination" starts with a capital letter, but only
        |       | $lowerCamelCase or $snake_case is allowed
        |       | (Drupal.NamingConventions.ValidVariableName.LowerStart)
     87 | ERROR | Variable "DestinationIDValues" starts with a capital letter, but
        |       | only $lowerCamelCase or $snake_case is allowed
        |       | (Drupal.NamingConventions.ValidVariableName.LowerStart)
    --------------------------------------------------------------------------------
    

    Remaining phpstan issues:

     ------ --------------------------------------------------------------------- 
      Line   migrate_devel.drush.inc                                              
     ------ --------------------------------------------------------------------- 
      27     Function drush_get_option not found.                                 
             💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
      55     Access to constant DEBUG on an unknown class Drush\Log\LogLevel.     
             💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
      112    Access to constant ALERT on an unknown class Drush\Log\LogLevel.     
             💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
     ------ --------------------------------------------------------------------- 
    
  • Assigned to hetal.solanki
  • Pipeline finished with Success
    7 months ago
    Total: 129s
    #239051
  • Pipeline finished with Success
    7 months ago
    Total: 130s
    #239052
  • Pipeline finished with Success
    7 months ago
    Total: 140s
    #239054
  • Pipeline finished with Success
    7 months ago
    Total: 131s
    #239058
  • Pipeline finished with Success
    7 months ago
    Total: 132s
    #239061
  • Pipeline finished with Success
    7 months ago
    Total: 128s
    #239062
  • 🇮🇳India hetal.solanki

    @batigolix, @NexusNovaz

    I've fixed the last MR!6 pipeline issue.
    so moving this issue into review.

    Thank you!!

  • Issue was unassigned.
  • Status changed to Needs review 7 months ago
  • Status changed to RTBC 7 months ago
  • 🇮🇳India deepak5423

    I have checked the issue and now its pass all the gitlab pipeline tests.
    Moving the ticket to RTBC.

  • 🇳🇱Netherlands batigolix Utrecht
  • Pipeline finished with Skipped
    7 months ago
    #239694
  • 🇳🇱Netherlands batigolix Utrecht

    Many thanks to all contributors.

  • Status changed to Fixed 7 months ago
  • 🇳🇱Netherlands batigolix Utrecht
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024