Utrecht
Account created on 26 April 2005, over 20 years ago
#

Merge Requests

More

Recent comments

🇳🇱Netherlands batigolix Utrecht

There were some conflicts as a result of 🐛 Replace usage of 'whitelist' with 'allowlist' Active

I fixed those so that it can be reviewed again

🇳🇱Netherlands batigolix Utrecht

Thanks for helping out with this one

🇳🇱Netherlands batigolix Utrecht

batigolix changed the visibility of the branch 3.0.x to hidden.

🇳🇱Netherlands batigolix Utrecht

Many thanks to everybody helping out with this one

🇳🇱Netherlands batigolix Utrecht

batigolix changed the visibility of the branch 3540181-improve-modal to hidden.

🇳🇱Netherlands batigolix Utrecht

batigolix created an issue.

🇳🇱Netherlands batigolix Utrecht

With the help of Claude I created a first draft

🇳🇱Netherlands batigolix Utrecht

Weight is included in the output, so you can use it to order. See for example:

       "link": {
            "id": "menu_link_content:32bd5d0f-0c96-470c-bb17-f30bfd113638",
            "weight": "11",
            "title": "phanecric",
            "description": "Description of phanecric.",
            "menu_name": "main",
            "provider": "menu_link_content",
            "parent": "",
            "enabled": true,
            "expanded": false,

Feel free to re-open the issue if this does not serve your needs.

🇳🇱Netherlands batigolix Utrecht

Coding standards issues have been fixed. Phpunit still fails but that is in theory not part of this issue

🇳🇱Netherlands batigolix Utrecht

I tested this with subpathauto 1.x, redirect 1.11 and drupal 10.5 and I cannot reproduce the issue.

Please provide more detailed reproduction steps if the problem still exists.

🇳🇱Netherlands batigolix Utrecht

I tested this with subpathauto 1.x, redirect 1.11 and drupal 10.5 and I cannot reproduce the issue.

Please provide more detailed reproduction steps if the problem still exists.

🇳🇱Netherlands batigolix Utrecht

I propose to postpone this, and go for the more generic solution of Ignore specific paths Needs work

🇳🇱Netherlands batigolix Utrecht

@lazzyvn please se the merge request for any changes.

Personally, I think the generic solution provided in this issue is better than the specific solution proposed in Add option to ignore admin paths Needs review

I tested the MR and it works well.

🇳🇱Netherlands batigolix Utrecht
🇳🇱Netherlands batigolix Utrecht

Check the README.md (included in the merge request) that explains how to create a separator between the prioritized and normal countries. This will enable the indentation.

As an extension of a default Drupal select field, there is no setting for the size of the field. It adapts to to the longest available value.

Please explain the issue with the whitespace in the patch (you mean in the merge request?) . The code passes the gitlab CI checks for code styling, so it should be good. But please explain in more details where it can be improved.

🇳🇱Netherlands batigolix Utrecht

batigolix made their first commit to this issue’s fork.

🇳🇱Netherlands batigolix Utrecht
🇳🇱Netherlands batigolix Utrecht
🇳🇱Netherlands batigolix Utrecht
🇳🇱Netherlands batigolix Utrecht
🇳🇱Netherlands batigolix Utrecht
🇳🇱Netherlands batigolix Utrecht
🇳🇱Netherlands batigolix Utrecht
🇳🇱Netherlands batigolix Utrecht

batigolix created an issue.

🇳🇱Netherlands batigolix Utrecht

I checked the contrast of this icon.

The changes were well and the colour contrast now meets WCAG SC1.4.11.

See these screenshots:

Before:

After:

🇳🇱Netherlands batigolix Utrecht

Using Claude I drafted a first version of an improved documentation and configuration form

🇳🇱Netherlands batigolix Utrecht

I tested the patch and it resolve the problem. Thank you for helping out with this one

🇳🇱Netherlands batigolix Utrecht

I tested the patch and it resolve the problem. Thank you for helping out with this one

🇳🇱Netherlands batigolix Utrecht

All the communication with Matomo is done in the module Matomo reporting.

The MOM module only takes care of showing the metrics in a pop up

I move this issue to Matomo reporting module.

Can you explain further what kind of call would be made in order it to be secure? Do you know if there's any documentation on how to achieve this?

🇳🇱Netherlands batigolix Utrecht

Can you explain this in a little bit more detail?

If I look at the page in the front end as a user with sufficient permissions (also using gin as admin theme), then I can see the link to the metrics in a secondary toolbar.

Can you provide some screenshot that explains how and where you would like to have an menu link?

🇳🇱Netherlands batigolix Utrecht

Great. I tested this and the country fields now show up as Feeds destination.

🇳🇱Netherlands batigolix Utrecht

Thanks for the feedback. I made the requested changes. Please review again

🇳🇱Netherlands batigolix Utrecht

I tested this , and it works fine. I ll merge it. Thanks for the effort

🇳🇱Netherlands batigolix Utrecht

This feature is included in the 2.x version.

🇳🇱Netherlands batigolix Utrecht

Veel dank!

🇳🇱Netherlands batigolix Utrecht

batigolix changed the visibility of the branch 3532906-better-documentation- to hidden.

🇳🇱Netherlands batigolix Utrecht

I took a new approach and I created a dedicated field widget for the priority countries.

🇳🇱Netherlands batigolix Utrecht

With the help of Claude code I created a functional test that creates a path file entity.

It fails on D 11, but that is expected because the D 11 compatibility is not released yet.

🇳🇱Netherlands batigolix Utrecht

batigolix created an issue.

🇳🇱Netherlands batigolix Utrecht

This is an old issue. Lots of things have changed over the last two years.

As far as I can see, there is no problem with PDF URLs.

I close this issue. Feel free to reopen if you continue running into similar problems.

🇳🇱Netherlands batigolix Utrecht

Thank you for reviewing this. I still have some doubts whether this new feature makes sense. Especially whether it should. be combined with the selected countries field.

I will leave this open for a little while to get more feedback.

🇳🇱Netherlands batigolix Utrecht

I am going to merge this and I create a beta release for the D11 version of this module. It has not been thoroughly tested yet, but hopefully with a beta D11 release available it will be easier for other contributors to give this module a decent run through on D11.

https://www.drupal.org/project/o365/releases/5.1.0-beta1

Please create new tickets for any issues that you find related to this D1 release.

🇳🇱Netherlands batigolix Utrecht

batigolix made their first commit to this issue’s fork.

🇳🇱Netherlands batigolix Utrecht

@gekkie check out the link in the comments and see if that module serves your needs.

🇳🇱Netherlands batigolix Utrecht

Thanks for reporting this error.

I'm not sure what happened but after applying the patch, I ran into similar errors .So I fixed those and I created a new release.

Please let me know if you notice any more problems.

Production build 0.71.5 2024