Utrecht
Account created on 26 April 2005, almost 20 years ago
#

Merge Requests

More

Recent comments

🇳🇱Netherlands batigolix Utrecht

Thanks for helping out with this one

🇳🇱Netherlands batigolix Utrecht

I tested this and it works fine for me, so I'm gonna merge this

🇳🇱Netherlands batigolix Utrecht

This is coming along nicely thank you very much, thank you very much for the contributions.

I looked at the MR and added some remarks.

🇳🇱Netherlands batigolix Utrecht

I feel there are issues being mixed up here:

1. IPs are being added to the flood table even after they have been white listed. This means the white listing functionality isn't working properly and that should be addressed.

2. White listed IPs are being shown in /admin/people/flood-unblock , because at the time of recording they were not white listed. This is working as a designed. The list at /admin/people/flood-unblock shows what is in Drupal core's flood table. We should not filter anything away (even white listed IPs) or remove anything without the user's knowing about this. The user already has the option to remove items from the table, so i so we don't need to do that, so we don't need to do that in the background.

If you provide a patch, then ensure that it only addresses problem 1: of white listed IPs still ending up in the flood table after they having been white listed.

Is there more information on how this problem can be reproduced?

🇳🇱Netherlands batigolix Utrecht

Feel free to contribute a patch

🇳🇱Netherlands batigolix Utrecht

Thanks for helping out with this one

🇳🇱Netherlands batigolix Utrecht

I think all fields should be mandatory because otherwise it doesnt maken a lot of sense. So I updated the merge request to reflect that. this can be reviewed

🇳🇱Netherlands batigolix Utrecht

batigolix made their first commit to this issue’s fork.

🇳🇱Netherlands batigolix Utrecht

Feel free to reopen if there's indeed a problem with this module

🇳🇱Netherlands batigolix Utrecht

batigolix changed the visibility of the branch 8.x-1.x to hidden.

🇳🇱Netherlands batigolix Utrecht

batigolix changed the visibility of the branch 3273635-missing-userid-definition to active.

🇳🇱Netherlands batigolix Utrecht

batigolix changed the visibility of the branch 3273635-missing-userid-definition to hidden.

🇳🇱Netherlands batigolix Utrecht

batigolix changed the visibility of the branch 3273635-missing-userid-definition to hidden.

🇳🇱Netherlands batigolix Utrecht

batigolix changed the visibility of the branch 3273635-missing-userid-definition to hidden.

🇳🇱Netherlands batigolix Utrecht

batigolix made their first commit to this issue’s fork.

🇳🇱Netherlands batigolix Utrecht

batigolix made their first commit to this issue’s fork.

🇳🇱Netherlands batigolix Utrecht

Thanks for the help with this one. I will be creating a D10 release soon.

🇳🇱Netherlands batigolix Utrecht

Wait for 📌 Clarify dependency on Matomo module Active as it contains some code styling fixes as well

🇳🇱Netherlands batigolix Utrecht

batigolix made their first commit to this issue’s fork.

🇳🇱Netherlands batigolix Utrecht

This needs documentation in the readme.

This example is missing the source key and should use the same example field name as the other examples. And maybe use another options as example a "source" may be confusing. It should be something like:

* @code
 * process:
 *   field_tricky:
 *     -
 *       plugin: debug
 *       dump: source_ids
 *.      source: whatever
 * @endcode
 *
 * This will print all IDs from the source. Options for the "dump"
 * configuration are:
🇳🇱Netherlands batigolix Utrecht

Patches and MR's are welcome. Keep in mind the remarks in #1 and #2

🇳🇱Netherlands batigolix Utrecht

Patches and MR's are welcome, but the interest in Drupal 7 may be waning.

🇳🇱Netherlands batigolix Utrecht

Is this still an issue? I can add a URL without any path ('matomo.php'), e.g. https://matomo.example.com for it to work well.

🇳🇱Netherlands batigolix Utrecht

This has been fixed . I will create an issue regarding the remarks in #28 and #29

🇳🇱Netherlands batigolix Utrecht

Thanks for the help with this one.

🇳🇱Netherlands batigolix Utrecht

I tested the changes and it works well. I did not get anymore PHPCS errors.

I am gonna merge this to see what the pipeline comes back with. If there are remaining errors then I create new issues.

🇳🇱Netherlands batigolix Utrecht

Thanks for the help with this one.

🇳🇱Netherlands batigolix Utrecht

Thanks for the help with this one.

Production build 0.71.5 2024