🇳🇱Netherlands @batigolix

This has been fixed in other issues

This has already been fixed in another issue

This has already been fixed in another issue

This has been fixed in another issue

This is already fixed via other issues

I moved the patch to a merge request.

I tested this change:

- If you click on a token in the list, it will populate the last field that had focus. With this change, the last field will become the new token filter field. See screenshot
- It needs some styling to make it look a bit smoother (I checked it with Gin) . See screenshot
- I checked how filter field are being used in Views , maybe that pattern can be applied here as well. See screenshot

The sticky bar uses as background a mix between white and the accent color that the user has chosen. You can make the background and the text of the sticky bar darker (and get a >3 contrasat), but at some point you run into contrast problem with the submit button (which has a fixed color).

Probably it is more feasible to remove the Gin specific styling for the sticky bulk edit bar, but it is quite a big change in the original design.

batigolix → made their first commit to this issue’s fork.

I tried this locally but I did not see a difference.

@utkarsh_kumar_singh can you add screenshots that show the changes that you made?

Leaving this open for future bot updates.

This change introduces a new problem because the background and foreground colour of the active menu item is the same. See the screenshots.

The contrast for the light mode seems to be okay. It's more than five.
Contrast in dark mode is also okay. It's more than six.

So actually, there is a couple of approaches possible:

- it can be done like in Oliveiro using CSS borders and transforming them. See the Olivero CSS example above
- it can be left like it is now because the separator is visible and the screen reader pronounces it so the behaviour is the same for both experiences. But one could also argue that the screen reader already knows that this is a list so an extra separator is redundant.
- another option is to add an alternative text in the CSS, but I would not prefer that because that means having content in the CSS files and that may open a new can of (multilingual) worms
- I also had a quick look at how other websites solve this and for example on the MDN website is using a mask-image property for a separator image. See for example https://developer.mozilla.org/en-US/docs/Web/CSS :

.breadcrumbs-container li .breadcrumb:after {
    background-color: var(--icon-secondary);
    content: "";
    display: block;
    flex-shrink: 0;
    height: 12px;
    margin-right: .5rem;
    -webkit-mask-image: url(/static/media/chevron.05a124d379047e16d746.svg);
    mask-image: url(/static/media/chevron.05a124d379047e16d746.svg);
    -webkit-mask-size: 12px;
    mask-size: 12px;
    transform: rotate(-90deg);
    width: 12px
}

The situation is different for Gin, Claro and Olivero:

Gin uses the "/" character as content of the ::before pseudo element in its css:

.gin-breadcrumb__item + .gin-breadcrumb__item::before {
  content: "/";
  opacity: .3;
  font-size: var(--gin-font-size-xs);
  vertical-align: middle;
  display: inline-block;
  padding: 0 .5em;
  background: none;
}

/themes/contrib/gin/dist/css/components/breadcrumb.css

Claro uses an svg as content of the ::before pseudo element in its css:
https://eleven.ddev.site/core/themes/claro/css/components/breadcrumb.css...

.breadcrumb__item + .breadcrumb__item::before {
  display: inline-block;
  padding: 0 0.75rem;
  content: url("data:image/svg+xml,%3csvg xmlns='http://www.w3.org/2000/svg' height='8' width='5'%3e%3cpath fill='currentColor' d='M1.207.647L.5 1.354 3.146 4 .5 6.647l.707.707L4.561 4z'/%3e%3c/svg%3e");
}

/core/themes/claro/css/components/breadcrumb.css

Olivero has an empty ::before pseudo element in its css, but creates the separator by rotating borders :) :

.breadcrumb__item:nth-child(n + 2)::before {
  display: inline-block;
  width: 0.5rem;
  height: 0.5rem;
  margin-inline: 1rem 1.25rem;
  content: "";
  transform: rotate(45deg); /* LTR */
  border-block-start: 2px solid var(--color--gray-45);
  border-inline-end: 2px solid var(--color--gray-45);
}

/core/themes/olivero/css/components/breadcrumb.css

I think we can conclude that the Claro and Gin issues are separate (though related) and that a separate issue is need for Claro

As for the possible solutions: Gin can use the method from Olivero, reemoving the content and using a (rotated) border, or an alternative text can be defined for the content property https://developer.mozilla.org/en-US/docs/Web/CSS/content#image_combined_... &&
https://dev.to/whitep4nth3r/hide-text-in-css-pseudo-elements-from-screen...

I'll have a look at the latter to see if there are any drawbacks.

Thanks for helping out with this one

I tested this and it works fine for me, so I'm gonna merge this

batigolix → created an issue.

This is coming along nicely thank you very much, thank you very much for the contributions.

I looked at the MR and added some remarks.

I feel there are issues being mixed up here:

1. IPs are being added to the flood table even after they have been white listed. This means the white listing functionality isn't working properly and that should be addressed.

2. White listed IPs are being shown in /admin/people/flood-unblock , because at the time of recording they were not white listed. This is working as a designed. The list at /admin/people/flood-unblock shows what is in Drupal core's flood table. We should not filter anything away (even white listed IPs) or remove anything without the user's knowing about this. The user already has the option to remove items from the table, so i so we don't need to do that, so we don't need to do that in the background.

If you provide a patch, then ensure that it only addresses problem 1: of white listed IPs still ending up in the flood table after they having been white listed.

Is there more information on how this problem can be reproduced?

Feel free to contribute a patch

Thanks for helping out with this one

I think all fields should be mandatory because otherwise it doesnt maken a lot of sense. So I updated the merge request to reflect that. this can be reviewed

batigolix → made their first commit to this issue’s fork.

Feel free to reopen if there's indeed a problem with this module

batigolix → changed the visibility of the branch 8.x-1.x to hidden.

batigolix → changed the visibility of the branch 3273635-missing-userid-definition to active.

batigolix → changed the visibility of the branch 3273635-missing-userid-definition to hidden.

batigolix → changed the visibility of the branch 3273635-missing-userid-definition to hidden.

batigolix → changed the visibility of the branch 3273635-missing-userid-definition to hidden.

batigolix → made their first commit to this issue’s fork.

batigolix → made their first commit to this issue’s fork.

Duplicate of 📌 Automated Drupal 10 compatibility fixes Needs review

Thanks for the help with this one. I will be creating a D10 release soon.

Setting this to active so the bot can post updates

batigolix → made their first commit to this issue’s fork.

Thanks for the help on this one

batigolix → created an issue.

batigolix → created an issue.

Example 📌 Allow login with option to select which account Active

Wait for 📌 Clarify dependency on Matomo module Active as it contains some code styling fixes as well

Waiting for ✨ Method to use the refresh token Needs review

Thanks for the help with this one.

batigolix → made their first commit to this issue’s fork.

Thanks for this nice addition.

Dankjewel

I tested this patch and it works well.

Thanks for the help with this one.

Here is the follow up: 📌 Make code pass Gitlab CI pipeline Active

batigolix → created an issue.

This needs documentation in the readme.

This example is missing the source key and should use the same example field name as the other examples. And maybe use another options as example a "source" may be confusing. It should be something like:

* @code
 * process:
 *   field_tricky:
 *     -
 *       plugin: debug
 *       dump: source_ids
 *.      source: whatever
 * @endcode
 *
 * This will print all IDs from the source. Options for the "dump"
 * configuration are:

Patches and MR's are welcome. Keep in mind the remarks in #1 and #2

Patches and MR's are welcome, but the interest in Drupal 7 may be waning.

Thanks for the help on this one.

Thanks everybody!

Thanks for the help with this one.

Is this still an issue? I can add a URL without any path ('matomo.php'), e.g. https://matomo.example.com for it to work well.

See ✨ Move the code from the separate dependency pfrenssen/matomo-reporting-api into this module Active