Thanks for helping out with this one
I tested this and it works fine for me, so I'm gonna merge this
batigolix → created an issue.
This is coming along nicely thank you very much, thank you very much for the contributions.
I looked at the MR and added some remarks.
I feel there are issues being mixed up here:
1. IPs are being added to the flood table even after they have been white listed. This means the white listing functionality isn't working properly and that should be addressed.
2. White listed IPs are being shown in /admin/people/flood-unblock , because at the time of recording they were not white listed. This is working as a designed. The list at /admin/people/flood-unblock shows what is in Drupal core's flood table. We should not filter anything away (even white listed IPs) or remove anything without the user's knowing about this. The user already has the option to remove items from the table, so i so we don't need to do that, so we don't need to do that in the background.
If you provide a patch, then ensure that it only addresses problem 1: of white listed IPs still ending up in the flood table after they having been white listed.
Is there more information on how this problem can be reproduced?
Feel free to contribute a patch
Thanks for helping out with this one
I think all fields should be mandatory because otherwise it doesnt maken a lot of sense. So I updated the merge request to reflect that. this can be reviewed
batigolix → made their first commit to this issue’s fork.
Feel free to reopen if there's indeed a problem with this module
batigolix → changed the visibility of the branch 8.x-1.x to hidden.
batigolix → changed the visibility of the branch 3273635-missing-userid-definition to active.
batigolix → changed the visibility of the branch 3273635-missing-userid-definition to hidden.
batigolix → changed the visibility of the branch 3273635-missing-userid-definition to hidden.
batigolix → changed the visibility of the branch 3273635-missing-userid-definition to hidden.
batigolix → made their first commit to this issue’s fork.
batigolix → made their first commit to this issue’s fork.
Duplicate of 📌 Automated Drupal 10 compatibility fixes Needs review
Thanks for the help with this one. I will be creating a D10 release soon.
Setting this to active so the bot can post updates
batigolix → made their first commit to this issue’s fork.
Thanks for the help on this one
batigolix → created an issue.
batigolix → created an issue.
Example 📌 Allow login with option to select which account Active
Wait for 📌 Clarify dependency on Matomo module Active as it contains some code styling fixes as well
Waiting for ✨ Method to use the refresh token Needs review
Thanks for the help with this one.
batigolix → made their first commit to this issue’s fork.
Thanks for this nice addition.
Dankjewel
I tested this patch and it works well.
Thanks for the help with this one.
Here is the follow up: 📌 Make code pass Gitlab CI pipeline Active
batigolix → created an issue.
This needs documentation in the readme.
This example is missing the source key and should use the same example field name as the other examples. And maybe use another options as example a "source" may be confusing. It should be something like:
* @code
* process:
* field_tricky:
* -
* plugin: debug
* dump: source_ids
*. source: whatever
* @endcode
*
* This will print all IDs from the source. Options for the "dump"
* configuration are:
Patches and MR's are welcome. Keep in mind the remarks in #1 and #2
Patches and MR's are welcome, but the interest in Drupal 7 may be waning.
Thanks for the help on this one.
Thanks everybody!
Thanks for the help with this one.
Is this still an issue? I can add a URL without any path ('matomo.php'), e.g. https://matomo.example.com for it to work well.
batigolix → created an issue.
This has been fixed . I will create an issue regarding the remarks in #28 and #29
I moved the patch to MR
Thanks for the help with this one.
I tested the changes and it works well. I did not get anymore PHPCS errors.
I am gonna merge this to see what the pipeline comes back with. If there are remaining errors then I create new issues.
Thanks for the help with this one.
Thanks for the help with this one.