- 🇳🇱Netherlands batigolix Utrecht
I created this issue by mistake in a forked sandbox project. I close it
- 🇳🇱Netherlands batigolix Utrecht
batigolix → changed the visibility of the branch 3458111-fix_cs_issues to active.
- 🇳🇱Netherlands batigolix Utrecht
Yes this issue still needs work.
No work has been done on this yet.See the pipeline warnings:
https://git.drupalcode.org/project/dynamic_layouts/-/pipelines - 🇮🇳India kalash-j jaipur
kalash-j → changed the visibility of the branch 3459966-fix-the-issues to hidden.
- 🇮🇳India kalash-j jaipur
kalash-j → changed the visibility of the branch 3459966-fix-the-issues to active.
- 🇲🇦Morocco b.khouy 🇲🇦 Morocco
I've integrated PHPCS, PHPStan, and the necessary linters into the project's GitLab CI to ensure clean and consistent code for all future contributions. The fixes have been merged into the 1.0.x branch.
To apply these fixes in your projects before the next official release, you can run the following command:
composer require 'drupal/domain_entity_type:1.0.x-dev@dev'
Thank you, everyone!
Hey @lostcarpark!!
When I'm rebasing the message shows current branch is upto date. And can you please help me with the thing that is leaving me in confusion that while going on the 2.0.x branch from issues it shows it was updated one year ago but when I visit the branch from the module it shows it was updated 15 hours ago , as I'm newbie please help me with this.- 🇮🇪Ireland lostcarpark
Thanks for the update. Unfortunately, it's still running the old Gitlab CI pipeline. You need to rebase the code from the 2.0.x branch to get the new pipeline to run. Please see the rebasing instructions → in the Drupal user guide.
Happy to review when current pipeline is running.
- 🇮🇪Ireland lostcarpark
Hi,
Thank you for working on this.
How have you configured PHPCS?
You don't seem to have the same settings as the Gitlab CI, as many of the issues listed above aren't reported by the CI.
The modules CI configuration was out of date, which meant tests were not running correctly.
Please rebase and resubmit this issue so the checks run against the CI, and if they pass, I can review.
I don't mind having cleaner code than Gitlab CI requires, providing the CI checks pass.