- Issue created by @bhaveshdas
- Issue was unassigned.
- 🇮🇳India bhaveshdas
I have fixed phpcs Issues and created MR, Could you please review it.
Thankyou !
- 🇮🇳India sarwan_verma
Hi @bhaveshdas, lostcarpark
I have completed a thorough review of MR !9 and can confirm that it addresses all the PHPCS issues effectively. For your reference, please see the attached screenshot.
Moving it to RTBC. Thank you
- Status changed to RTBC
5 months ago 10:25am 15 July 2024 - Status changed to Needs work
about 1 month ago 9:55pm 23 October 2024 - 🇮🇪Ireland lostcarpark
Hi,
Thank you for working on this.
How have you configured PHPCS?
You don't seem to have the same settings as the Gitlab CI, as many of the issues listed above aren't reported by the CI.
The modules CI configuration was out of date, which meant tests were not running correctly.
Please rebase and resubmit this issue so the checks run against the CI, and if they pass, I can review.
I don't mind having cleaner code than Gitlab CI requires, providing the CI checks pass. - 🇮🇪Ireland lostcarpark
Thanks for the update. Unfortunately, it's still running the old Gitlab CI pipeline. You need to rebase the code from the 2.0.x branch to get the new pipeline to run. Please see the rebasing instructions → in the Drupal user guide.
Happy to review when current pipeline is running.
Hey @lostcarpark!!
When I'm rebasing the message shows current branch is upto date. And can you please help me with the thing that is leaving me in confusion that while going on the 2.0.x branch from issues it shows it was updated one year ago but when I visit the branch from the module it shows it was updated 15 hours ago , as I'm newbie please help me with this.