Fix the issues reported by phpcs

Thank you for reporting this, Suthat, I will run PHPCS and apply the suggested fixes.

I will keep this ticket as a 'to do' for now: I have ongoing changes already affecting another branch that would trigger many conflicts if I were to work on this topic now. Once those changes are merged back to the dev branch and deployed, I can kick-start the PHPCS adjustments.

Thank you for taking over the ticket, abhiyanshu. I will ask you to wait for my sign to fork this and start working. Many thanks for helping!

@mabho No worries, I'll fix this locally and attach a patch once the PHPCS issues are resolved. Thanks.

@abhiyanshu, I just completed applying multiple changes to the project, and released a new alpha9 version. If you are still willing to run the task on this issue queue, you can grab the latest version just released, run phpcs again and apply the suggested fixes. Let me know if you are willing to do that. I can also go over this task. Many thanks!

Sure @mabho,
I somehow missed the notification and just got the message after the MR.
I will continue addressing any remaining issues in the new alpha9 version. Thank you for your patience and understanding.

@abhiyanshu, I can see your changes on top of mine, thank you for your contributions, it truly helped me see further and investigate deeper on this validation landscape, I am learning a lot from this interaction.

Some comments here:

• We don't need to validate anything within the fonts/* folder. That folder is auto-generated by Icomoon and I don't want to revalidate things every time I push a new icon (when that happens, Icomoon generates an entirely new package of files that I just replace/overwrite on top of the existing ones, including CSS, HTML, SASS, font files). We can exclude any changes within that folder.
• The updates need to be applied to the SASS files, we don't want to validate the compiled CSS files. We also want folder /js/dist to be left out of the validation.
• It looks like Javascript code validation is done via Eslint, not PHPCS. Please, check this documentation on how to specify Drupal coding standards ( https://www.drupal.org/drupalorg/docs/drupal-ci/using-coderphpcs-in-drup... → ) and this Acquia recommended project as references: https://github.com/acquia/drupal-recommended-project/blob/master/phpcs.x.... Javascript should thus be left out of the <arg name="extensions" /> values.
• I am also leaving the .md file out of the PHPCS scope, I reworked the file to limit each line to 80 characters maximum, but it is very limiting to keep that rule.
• Finally, I have an update for the phpcs.xml.dist file that is redeclaring the exclude folders within the exclude-pattern rules block and, most important, it is adjusting the file extensions we want to validate according to the benchmarks mentioned above. In order to run PHPCS out of these new rules you will need to rename phpcs.xml.dist to phpcs.xml. You can run it with the command you see in the documentation: vendor/bin/phpcs --standard=web/modules/custom/visual_debugger/phpcs.xml web/modules/custom/visual_debugger (edit paths accordingly depending on your environment).

Because of all these differences, I reverted your commit, and packed the adjusted phpcs.xml.dist file, but your help was invaluable and I will provide all the credit on this thread.

One final question: do you know if we can get PHPCS to validate SCSS files with the same recommendations it delivers to CSS files: my SCSS validation did not find the problem with the hexadecimal uppercase codes and other issues the original validation raised when running on CSS.