🇮🇳India @amanbtr72

thejimbirch → credited amanbtr72 → .

Without login it also takes more space, the issue is with login due to the fixed admin toolbar on the left.

Needs fix.

@vaish I have tested and made a small change and pushed to the same MR, now it's working with 10.2 also.

Kindly review.

Thanks

Kindly review MR !2

Thanks

amanbtr72 → made their first commit to this issue’s fork.

spellcheck tested in the core folder for the above 9 words which were not found and resolved.

Looks Good.

Below is the report generated by spellcheck on my local machine.

Issues found:
drupalci
corepack
Validatable
validatable
drush
Drush
SIMPLETEST
simpletest
lullabot
langcode
umami
Langcodes
Langcode
dblog
tempstore
langcodes
Umami
olivero
LANGCODE
Olivero
Simpletest
Bartik
dependees
Dependees
Dependee
dependee
dependee's
bartik
druplicon
Dblog
DBLOG
Druplicon
DRUPLICON
Tempstore
Olivero's
UMAMI
CSpell: Files checked: 15264, Issues found: 7385 in 2685 files.

Moving the issue with RTBC+1

I have made some necessary changes, Kindly review MR 8926.

Thanks

amanmansuri72 → made their first commit to this issue’s fork.

Not only "EntityDisplayBase" uses the method many other files also contains "removeComponent"

Need to change there also.

Are we going to do this with the this issue or need to create another issue tickets

Search "removeComponent" (67 hits in 44 files of 30291 searched) [Normal]
  D:\wamp64\www\drupal10\core\lib\Drupal\Core\Entity\Display\EntityDisplayInterface.php (1 hit)
	Line  67:   public function removeComponent($name);
  D:\wamp64\www\drupal10\core\lib\Drupal\Core\Entity\EntityDisplayBase.php (5 hits)
	Line 184:             $this->removeComponent($name);
	Line 200:             $this->removeComponent($name);
	Line 376:   public function removeComponent($name) {
	Line 450:         $this->removeComponent($entity->getName());
	Line 480:             $this->removeComponent($name);
  D:\wamp64\www\drupal10\core\lib\Drupal\Core\Entity\EntityDisplayRepositoryInterface.php (1 hit)
	Line 135:    *   ->removeComponent('field_image')
  D:\wamp64\www\drupal10\core\lib\Drupal\Core\Entity\EntityViewBuilder.php (1 hit)
	Line 513:           $display->removeComponent($name);
  D:\wamp64\www\drupal10\core\modules\comment\comment.module (1 hit)
	Line 759:           $view_display->removeComponent($field);
  D:\wamp64\www\drupal10\core\modules\comment\src\Tests\CommentTestTrait.php (2 hits)
	Line 104:           $display->removeComponent($field_name)->save();
	Line 122:           $display->removeComponent($field_name)->save();
  D:\wamp64\www\drupal10\core\modules\comment\tests\src\Functional\CommentDisplayConfigurableTest.php (2 hits)
	Line 79:     $display->removeComponent('uid')
	Line 80:       ->removeComponent('created')
  D:\wamp64\www\drupal10\core\modules\comment\tests\src\Functional\CommentLinksTest.php (2 hits)
	Line 139:       ->removeComponent('links')
	Line 152:       ->removeComponent('links')
  D:\wamp64\www\drupal10\core\modules\comment\tests\src\Functional\CommentTestBase.php (1 hit)
	Line 256:       $form_display->removeComponent('subject');
  D:\wamp64\www\drupal10\core\modules\config\tests\src\Functional\ConfigExportImportUITest.php (1 hit)
	Line 140:       ->removeComponent($this->fieldName)
  D:\wamp64\www\drupal10\core\modules\contact\tests\src\Functional\ContactSitewideTest.php (1 hit)
	Line 495:       ->removeComponent('mail')
  D:\wamp64\www\drupal10\core\modules\field\tests\src\Functional\FormTest.php (1 hit)
	Line 654:       ->removeComponent($this->field->getName())
  D:\wamp64\www\drupal10\core\modules\field\tests\src\Kernel\FieldAttachOtherTest.php (3 hits)
	Line  91:     $display->removeComponent($this->fieldTestData->field_name);
	Line 285:         $display->removeComponent($name);
	Line 379:         $display->removeComponent($name);
  D:\wamp64\www\drupal10\core\modules\field_ui\src\Form\EntityDisplayFormBase.php (3 hits)
	Line 310:       $this->entity->removeComponent($field_name);
	Line 610:         $entity->removeComponent($field_name);
	Line 638:         $entity->removeComponent($name);
  D:\wamp64\www\drupal10\core\modules\field_ui\tests\src\Functional\ManageFieldsFunctionalTest.php (1 hit)
	Line 106:       ->removeComponent($field_name)
  D:\wamp64\www\drupal10\core\modules\field_ui\tests\src\Kernel\EntityDisplayTest.php (3 hits)
	Line 108:     $display->removeComponent('component_3');
	Line 192:     $display->removeComponent('display_extra_field');
	Line 221:     $display->removeComponent('display_extra_field');
  D:\wamp64\www\drupal10\core\modules\field_ui\tests\src\Kernel\EntityFormDisplayTest.php (1 hit)
	Line 306:     $form_display->removeComponent('langcode');
  D:\wamp64\www\drupal10\core\modules\image\tests\src\Functional\ImageAdminStylesTest.php (1 hit)
	Line 501:       ->removeComponent($field_name)
  D:\wamp64\www\drupal10\core\modules\layout_builder\src\Controller\MoveBlockController.php (1 hit)
	Line 69:     $section->removeComponent($block_uuid);
  D:\wamp64\www\drupal10\core\modules\layout_builder\src\Entity\LayoutBuilderEntityViewDisplay.php (1 hit)
	Line 412:             $section->removeComponent($uuid);
  D:\wamp64\www\drupal10\core\modules\layout_builder\src\Form\MoveBlockForm.php (1 hit)
	Line 258:       $original_section->removeComponent($this->uuid);
  D:\wamp64\www\drupal10\core\modules\layout_builder\src\Form\RemoveBlockForm.php (1 hit)
	Line 70:     $section_storage->getSection($this->delta)->removeComponent($this->uuid);
  D:\wamp64\www\drupal10\core\modules\layout_builder\src\Section.php (1 hit)
	Line 223:   public function removeComponent($uuid) {
  D:\wamp64\www\drupal10\core\modules\layout_builder\tests\src\Unit\SectionTest.php (3 hits)
	Line  83:    * @covers ::removeComponent
	Line  86:   public function testRemoveComponent(): void {
	Line  92:     $this->section->removeComponent('10000000-0000-1000-a000-000000000000');
  D:\wamp64\www\drupal10\core\modules\media\src\MediaSourceInterface.php (4 hits)
	Line 150:    * \Drupal\Core\Entity\Display\EntityDisplayInterface::removeComponent() to
	Line 159:    * @see \Drupal\Core\Entity\Display\EntityDisplayInterface::removeComponent()
	Line 168:    * \Drupal\Core\Entity\Display\EntityDisplayInterface::removeComponent() to
	Line 177:    * @see \Drupal\Core\Entity\Display\EntityDisplayInterface::removeComponent()
  D:\wamp64\www\drupal10\core\modules\media\src\MediaTypeForm.php (1 hit)
	Line 377:           $display->removeComponent($name);
  D:\wamp64\www\drupal10\core\modules\media\src\Plugin\media\Source\OEmbed.php (1 hit)
	Line 539:     $display->removeComponent('name');
  D:\wamp64\www\drupal10\core\modules\media\tests\modules\media_test_source\src\Plugin\media\Source\TestWithHiddenSourceField.php (2 hits)
	Line 26:     $display->removeComponent($this->getSourceFieldDefinition($type)->getName());
	Line 33:     $display->removeComponent($this->getSourceFieldDefinition($type)->getName());
  D:\wamp64\www\drupal10\core\modules\media\tests\src\Functional\FieldFormatter\OEmbedFormatterTest.php (1 hit)
	Line 209:     ])->removeComponent('thumbnail')
  D:\wamp64\www\drupal10\core\modules\media\tests\src\FunctionalJavascript\MediaSourceTestBase.php (1 hit)
	Line 105:       $entity_form_display->removeComponent($field_name)->save();
  D:\wamp64\www\drupal10\core\modules\media\tests\src\Kernel\MediaEmbedFilterTestBase.php (3 hits)
	Line 114:     ])->removeComponent('thumbnail')
	Line 115:       ->removeComponent('created')
	Line 116:       ->removeComponent('uid')
  D:\wamp64\www\drupal10\core\modules\media_library\media_library.module (2 hits)
	Line 412:     $display->removeComponent($name);
	Line 459:     $display->removeComponent($name);
  D:\wamp64\www\drupal10\core\modules\migrate\src\Plugin\migrate\destination\ComponentEntityDisplayBase.php (1 hit)
	Line  79:       $entity->removeComponent($values['field_name']);
  D:\wamp64\www\drupal10\core\modules\node\tests\src\Functional\NodeEditFormTest.php (1 hit)
	Line 215:     $form_display->removeComponent('uid')->save();
  D:\wamp64\www\drupal10\core\modules\node\tests\src\Functional\NodeLinksTest.php (1 hit)
	Line 45:       ->removeComponent('links')
  D:\wamp64\www\drupal10\core\modules\node\tests\src\Functional\PagePreviewTest.php (1 hit)
	Line 238:       ->removeComponent('body')
  D:\wamp64\www\drupal10\core\modules\node\tests\src\Functional\Views\NodeFieldFilterTest.php (1 hit)
	Line 109:       ->removeComponent('links')
  D:\wamp64\www\drupal10\core\modules\path\tests\src\Functional\PathMediaFormTest.php (1 hit)
	Line 63:       ->removeComponent('path')
  D:\wamp64\www\drupal10\core\modules\path\tests\src\Functional\PathNodeFormTest.php (1 hit)
	Line 54:       ->removeComponent('path')
  D:\wamp64\www\drupal10\core\modules\system\tests\src\Functional\Entity\EntityFormTest.php (1 hit)
	Line  93:     ])->removeComponent('field_test_text')->save();
  D:\wamp64\www\drupal10\core\modules\taxonomy\tests\src\Functional\Views\TermDisplayConfigurableTest.php (1 hit)
	Line 79:     $display->removeComponent('name')->save();
  D:\wamp64\www\drupal10\core\modules\views\tests\src\Kernel\Handler\FieldRenderedEntityTest.php (1 hit)
	Line 121:     $display->removeComponent('test_field')
  D:\wamp64\www\drupal10\core\tests\Drupal\KernelTests\Core\Entity\EntityDisplayFormBaseTest.php (2 hits)
	Line  41:     $entity->removeComponent('new_field_mismatch_type_visible')
	Line  80:     $entity->removeComponent('field_start_visible_change_region')
  D:\wamp64\www\drupal10\core\tests\Drupal\KernelTests\Core\Entity\FieldWidgetConstraintValidatorTest.php (1 hit)
	Line  84:       $display->removeComponent($hidden_field);

I have also checked with the Drupal 10.3.1 version; no issue was found as stated above.

It would be helpful if you could share Text formats and editor configurations.

Thanks

MR! 1 created for this issue,

Kindly review,

Thanks

amanmansuri72 → made their first commit to this issue’s fork.

Removing duplication of regex with a variable

amanmansuri72 → made their first commit to this issue’s fork.

amanmansuri72 → made their first commit to this issue’s fork.

Re-viewed the changes in the recent MR, Looks good.

Moving to RTBC+1

Needs some more clarification on this issue.

Any update will be helpful.

Thanks

amanmansuri72 → made their first commit to this issue’s fork.

amanmansuri72 → created an issue.

amanmansuri72 → created an issue.

amanmansuri72 → created an issue.

amanmansuri72 → created an issue.

amanmansuri72 → created an issue.

I reviewed MR 1.

All Good

Moving to RTBC+1

amanmansuri72 → created an issue.

No error found.

All Good

Moving to RTBC+1

amanmansuri72 → made their first commit to this issue’s fork.

amanmansuri72 → created an issue.

returns error needs work

The module is not working.

amanmansuri72 → created an issue.

amanmansuri72 → created an issue.

Reviewed MR 1 and found one error below.

Kindly fix the remaining issue.

Thanks

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml .

FILE: D:\wamp64\www\drupal10\modules\custom\doissues\madness-3462328\madness.info.yml
-------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------
 1 | WARNING | "core_version_requirement" property is missing in the info.yml file
-------------------------------------------------------------------------------------

Time: 621ms; Memory: 10MB

amanmansuri72 → created an issue.

amanmansuri72 → created an issue.

amanmansuri72 → created an issue.

MR created kindly review the MR 3

Thanks

I have checked with the windows it shows the above fixes for phpcs, also the phpcbf solves all changes but not showing any changes to push to create MR.

Thanks

amanmansuri72 → created an issue.

Reviewed the MR !1.

Looks Good.

moving to RTBC

Thanks

amanmansuri72 → created an issue.

amanmansuri72 → created an issue.

amanmansuri72 → created an issue.

amanmansuri72 → created an issue.

:( At least we can close the issue with a fixed with good luck ahead.

Thanks

amanmansuri72 → created an issue.

MR4 Looks good.

So moving to RTBC+

I added redirection to the Available block type "Add Block Content" page.

For Example:

If the "Basic" block type is available in the block types list then the URL will look like "/block/add/basic"

If the "Test" block type is available in the block types list then the URL will look like "/block/add/test"

Kindly review

Thanks

Kindly review the MR2 Updated the readme.md file.

Thanks

@rloos289 I have tracked the issue it was throwing an error due to the installation of the "Mailchimp : ^2.2" module. Under that Mailchimp Events was causing the error. You can have a try with the module installation while I have also removed the gitlab-ci file.

Kindly take a look on MR update.

Thanks

amanmansuri72 → made their first commit to this issue’s fork.

amanmansuri72 → created an issue.

The Readme.md file was missing so added and committed under MR 2. kindly review

Thanks

amanmansuri72 → made their first commit to this issue’s fork.

resolved issue on the entity tracer settings page.

kindly review the MR.

Thanks

The Help page is added, and MR is created for the change.

Kindly review the MR.

Thanks.

amanmansuri72 → created an issue.

amanmansuri72 → created an issue.

Replace the version from ^8 to ^8.8 on the release page.

attaching the screenshot for reference

Thanks

Mini pager styled, kindly review

amanmansuri72 → made their first commit to this issue’s fork.

fixed remaining issues

Reviewed the MR 3 Still found some errors

$ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml .

FILE: D:\wamp64\www\drupal10\modules\custom\doissues\gmv-3358798\gmv.module
--------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
3 | ERROR | Missing short description in doc comment
10 | ERROR | Doc comment short description must end with a full stop
12 | ERROR | The array declaration extends to column 150 (the limit is 120).
| | The array content should be split up over multiple lines
12 | ERROR | The array declaration extends to column 149 (the limit is 120).
| | The array content should be split up over multiple lines
12 | ERROR | The array declaration extends to column 148 (the limit is 120).
| | The array content should be split up over multiple lines
--------------------------------------------------------------------------------

FILE: D:\wamp64\www\drupal10\modules\custom\doissues\gmv-3358798\README.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------
3 | WARNING | Line exceeds 80 characters; contains 87 characters
4 | WARNING | Line exceeds 80 characters; contains 107 characters
7 | WARNING | Line exceeds 80 characters; contains 132 characters
--------------------------------------------------------------------------

FILE: ...v-3358798\src\Plugin\Field\FieldFormatter\ThreeDeeObjectFieldFormatter.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------------
62 | WARNING | File::load calls should be avoided in classes, use dependency
| | injection instead
67 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
72 | WARNING | File::load calls should be avoided in classes, use dependency
| | injection instead
73 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
--------------------------------------------------------------------------------

Time: 852ms; Memory: 12MB

Reviewed the MR and found some errors by PHPCBF resolve it automatically, so nothing to do with it. All good.

Moving to RTBC.

Thanks

As per the "Problem/Motivation," I have resolved the issues as suggested for the 10.3.x version Merge request !8739 created for the same.

Kindly review

Thanks

amanmansuri72 → made their first commit to this issue’s fork.

Fixed remaining issues from the previous MR kindly review MR9.

Thanks

amanmansuri72 → made their first commit to this issue’s fork.

I have reviewed the MR27 the star size in CSS is set to 16px, also while reviewing and selecting Drupal as an output on the manage display Star GIF was not visible so I have made recent changes to the same MR.

kindly review the same

Thanks

Kindly recheck the MR 2 I have rechecked and pushed the changes.

Thanks

Reviewed and tested MR-5 no error was found, so moving it forward to RTBC.

Thanks

Review is done and tested, attached screenshot for reference.

Moved to RTBC

Thanks

Reviewed and Tested the MR-1, js name change reflects correctly so moving forward to #RTBC

Attached screenshot for reference.

Thanks.

@apatel0325 I have changed the targeted branch to 1.0x kindly review.

Thanks

amanmansuri72 → created an issue.

amanmansuri72 → created an issue.

Fixed php issues, Needs review for the same.

amanmansuri72 → changed the visibility of the branch 3444066-Fix-the-phpcs to hidden.

amanmansuri72 → created an issue.

The patch is working fine, but it has one more issue not working on devel URL.

Please find the screenshot for further reference.

amanmansuri72 → made their first commit to this issue’s fork.

Fixed remaining JS issues Please review