Fix the issues reported by phpcs

Created on 29 April 2024, 2 months ago

Problem/Motivation

There is a files that need to fixed with coding standards.
Here is the command: -
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,css,theme,info,txt,md,yml,twig,js web/modules/contrib/juxtapose/

Result :-

FILE: D:\wamp64\www\drupal10\modules\contrib\juxtapose\js\juxtapose.js
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 1 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
 4 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: D:\wamp64\www\drupal10\modules\contrib\juxtapose\juxtapose.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by
   |         | drupal.org packaging automatically
--------------------------------------------------------------------------------


FILE: D:\wamp64\www\drupal10\modules\contrib\juxtapose\juxtapose.module
-----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------
 5 | WARNING | Line exceeds 80 characters; contains 81 characters
-----------------------------------------------------------------------


FILE: ...trib\juxtapose\src\Plugin\Field\FieldFormatter\JuxtaposeImageFormatter.php
--------------------------------------------------------------------------------
FOUND 22 ERRORS AND 7 WARNINGS AFFECTING 16 LINES
--------------------------------------------------------------------------------
  96 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency
     |         |     injection instead
 158 | WARNING | [x] The variable name should be defined after the type
 163 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency
     |         |     injection instead
 225 | ERROR   | [ ] Doc comment short description must be on a single line,
     |         |     further text should be a separate paragraph
 227 | ERROR   | [ ] Missing parameter type
 233 | ERROR   | [x] Visibility must be declared on method
     |         |     "parseKeyValueString"
 234 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks,
     |         |     question marks, colons, or closing parentheses
 234 | ERROR   | [x] Comments may not appear after statements
 235 | WARNING | [ ] There must be no blank line following an inline comment
 235 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks,
     |         |     question marks, colons, or closing parentheses
 235 | ERROR   | [x] Comments may not appear after statements
 238 | ERROR   | [x] There should be no white space after an opening "{"
 238 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks,
     |         |     question marks, colons, or closing parentheses
 238 | ERROR   | [x] Comments may not appear after statements
 239 | WARNING | [ ] Line exceeds 80 characters; contains 100 characters
 239 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks,
     |         |     question marks, colons, or closing parentheses
 239 | ERROR   | [x] Comments may not appear after statements
 240 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks,
     |         |     question marks, colons, or closing parentheses
 240 | ERROR   | [x] Comments may not appear after statements
 241 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
 241 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks,
     |         |     question marks, colons, or closing parentheses
 241 | ERROR   | [x] Comments may not appear after statements
 243 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters
 243 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks,
     |         |     question marks, colons, or closing parentheses
 243 | ERROR   | [x] Comments may not appear after statements
 248 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks,
     |         |     question marks, colons, or closing parentheses
 248 | ERROR   | [x] Comments may not appear after statements
 249 | ERROR   | [x] Expected 1 blank line after function; 0 found
 250 | ERROR   | [x] The closing brace for the class must have an empty line
     |         |     before it
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 21 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 1.54 secs; Memory: 12MB

Steps to reproduce

Run PHPCS on juxtapose module.

Proposed resolution

Fixed the coding standards.

Remaining tasks

Submit the patch either MR .

📌 Task
Status

Closed: outdated

Version

1.0

Component

Code

Created by

🇮🇳India amanmansuri72

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.69.0 2024