- Issue created by @quietone
- Status changed to Needs review
5 months ago 9:35am 7 August 2024 - Status changed to RTBC
5 months ago 12:46pm 7 August 2024 - ๐ฎ๐ณIndia amanbtr72
spellcheck tested in the core folder for the above 9 words which were not found and resolved.
Looks Good.
Below is the report generated by spellcheck on my local machine.
Issues found: drupalci corepack Validatable validatable drush Drush SIMPLETEST simpletest lullabot langcode umami Langcodes Langcode dblog tempstore langcodes Umami olivero LANGCODE Olivero Simpletest Bartik dependees Dependees Dependee dependee dependee's bartik druplicon Dblog DBLOG Druplicon DRUPLICON Tempstore Olivero's UMAMI CSpell: Files checked: 15264, Issues found: 7385 in 2685 files.
Moving the issue with RTBC+1
- ๐ฆ๐บAustralia mstrelan
Not sure about changing webassert, that is the name of a class in a dependency. If we have tests related to it then they should refer to it by its name, it makes it easier to find all references when needed.
- Status changed to Needs review
5 months ago 8:19am 8 August 2024 - ๐ณ๐ฟNew Zealand quietone
@amanbtr72, thanks for testing this change. These changes also change comments and code so a review needs to include reading the MR and confirming the change make sense. Sometimes a review will reject the proposed change and the 'misspelling' will be kept. For example, we allow the words dependee, dependee's, and dependees even though they are not valid words by cspell or American English dictionaries.
@mstrelan, can you point out the instances you think should not be changed?
- ๐บ๐ธUnited States smustgrave
Should webassert be moved to Drupal dictionary?
- ๐ฆ๐บAustralia mstrelan
I would be on board with webassert being in the Drupal dictionary.
- Status changed to Needs work
5 months ago 1:41pm 9 August 2024 - Status changed to Needs review
5 months ago 6:12am 10 August 2024 - ๐ณ๐ฟNew Zealand quietone
Since this is about JsWebAssert, I think that is the word to put in the drupal dictionary. Trying that now. What do you think?
- Status changed to RTBC
5 months ago 12:56pm 10 August 2024 - Status changed to Needs work
5 months ago 12:18am 17 August 2024 - Status changed to RTBC
5 months ago 1:06am 17 August 2024 - ๐ณ๐ฟNew Zealand quietone
There were no conflicts with the rebase so I am restoring the RTBC.
- ๐ฌ๐งUnited Kingdom catch
Oh I probably could have tried
/rebase
on the MR, will try to remember that next time.Committed/pushed to 11.x, thanks!
- Status changed to Fixed
5 months ago 1:25am 17 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.