Fix 9 spelling words in tests

Created on 7 August 2024, 5 months ago
Updated 31 August 2024, 4 months ago

Problem/Motivation

More words that only appear in tests.

Steps to reproduce

Proposed resolution

  1. isinstallable
  2. notexisting
  3. permissionless
  4. renderered
  5. sameline
  6. samename
  7. specialchars
  8. userref
  9. webassert

Rename 'js_webassert' to 'jswebassert', which is the class name, and put 'jswebassrt' in the drupal dictionary.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

๐Ÿ“Œ Task
Status

Fixed

Version

11.0 ๐Ÿ”ฅ

Component
Otherย  โ†’

Last updated 24 minutes ago

Created by

๐Ÿ‡ณ๐Ÿ‡ฟNew Zealand quietone

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @quietone
  • Merge request !9112Resolve #3466503 "Fix some spelling" โ†’ (Closed) created by quietone
  • Status changed to Needs review 5 months ago
  • ๐Ÿ‡ณ๐Ÿ‡ฟNew Zealand quietone
  • Status changed to RTBC 5 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia amanbtr72

    spellcheck tested in the core folder for the above 9 words which were not found and resolved.

    Looks Good.

    Below is the report generated by spellcheck on my local machine.

    Issues found:
    drupalci
    corepack
    Validatable
    validatable
    drush
    Drush
    SIMPLETEST
    simpletest
    lullabot
    langcode
    umami
    Langcodes
    Langcode
    dblog
    tempstore
    langcodes
    Umami
    olivero
    LANGCODE
    Olivero
    Simpletest
    Bartik
    dependees
    Dependees
    Dependee
    dependee
    dependee's
    bartik
    druplicon
    Dblog
    DBLOG
    Druplicon
    DRUPLICON
    Tempstore
    Olivero's
    UMAMI
    CSpell: Files checked: 15264, Issues found: 7385 in 2685 files.
    

    Moving the issue with RTBC+1

  • ๐Ÿ‡ฆ๐Ÿ‡บAustralia mstrelan

    Not sure about changing webassert, that is the name of a class in a dependency. If we have tests related to it then they should refer to it by its name, it makes it easier to find all references when needed.

  • Status changed to Needs review 5 months ago
  • ๐Ÿ‡ณ๐Ÿ‡ฟNew Zealand quietone

    @amanbtr72, thanks for testing this change. These changes also change comments and code so a review needs to include reading the MR and confirming the change make sense. Sometimes a review will reject the proposed change and the 'misspelling' will be kept. For example, we allow the words dependee, dependee's, and dependees even though they are not valid words by cspell or American English dictionaries.

    @mstrelan, can you point out the instances you think should not be changed?

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States smustgrave

    Should webassert be moved to Drupal dictionary?

  • ๐Ÿ‡ฆ๐Ÿ‡บAustralia mstrelan

    I would be on board with webassert being in the Drupal dictionary.

  • Status changed to Needs work 5 months ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States smustgrave

    @quietone mind generating that please?

  • Status changed to Needs review 5 months ago
  • ๐Ÿ‡ณ๐Ÿ‡ฟNew Zealand quietone

    Since this is about JsWebAssert, I think that is the word to put in the drupal dictionary. Trying that now. What do you think?

  • Status changed to RTBC 5 months ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States smustgrave

    Think thatโ€™s a good compromise

  • Status changed to Needs work 5 months ago
  • ๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom catch

    This all makes sense but needs a rebase.

  • Status changed to RTBC 5 months ago
  • ๐Ÿ‡ณ๐Ÿ‡ฟNew Zealand quietone

    There were no conflicts with the rebase so I am restoring the RTBC.

  • Pipeline finished with Success
    5 months ago
    Total: 558s
    #256391
    • catch โ†’ committed c2089ac4 on 11.x
      Issue #3466503 by quietone, smustgrave, mstrelan: Fix 9 spelling words...
  • ๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom catch

    Oh I probably could have tried /rebase on the MR, will try to remember that next time.

    Committed/pushed to 11.x, thanks!

  • Status changed to Fixed 5 months ago
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024